62679 2011-06-14 16:51:17 -0700 Add notify handler to trigger MemoryPressureHandler in all builds 2011-06-19 05:55:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 420854 0 msaboff 2011-06-14 16:51:17 -0700 Remove the #ifndef NDEBUG around the installation of the SIGUSR2 dispatch for triggering MemoryPressureHandler::respondToMemoryPressure(). 421399 1 97314 msaboff 2011-06-15 09:59:19 -0700 Created attachment 97314 Proposed patch 421569 2 97314 ggaren 2011-06-15 14:17:48 -0700 Comment on attachment 97314 Proposed patch r=me 423156 3 97703 msaboff 2011-06-18 12:09:09 -0700 Created attachment 97703 Updated patch using notify 423158 4 97703 darin 2011-06-18 12:11:18 -0700 Comment on attachment 97703 Updated patch using notify View in context: https://bugs.webkit.org/attachment.cgi?id=97703&action=review > Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:55 > +static int notifyToken; This can go inside the function where it’s used instead of at the file level. > Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:72 > + notify_register_dispatch("com.apple.WebKit.lowMemory", &notifyToken, > + dispatch_get_main_queue(), ^(int) { memoryPressureHandler().respondToMemoryPressure();}); This is not WebKit project style indentation. We don't line up things with parentheses on the line before I suggest "org.WebKit.lowMemory" instead of "com.apple.WebKit.lowMemory". 423227 5 97314 eric 2011-06-18 13:33:04 -0700 Comment on attachment 97314 Proposed patch Cleared Geoffrey Garen's review+ from obsolete attachment 97314 so that this bug does not appear in http://webkit.org/pending-commit. 423359 6 msaboff 2011-06-19 05:55:49 -0700 Committed r89214: <http://trac.webkit.org/changeset/89214> 97314 2011-06-15 09:59:19 -0700 2011-06-18 13:33:04 -0700 Proposed patch 62679.patch text/plain 2029 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4OTQ4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMTUgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBERUJVRyBvbmx5IFNJR1VTUjIgTWVtb3J5UHJlc3N1 cmVIYW5kbGVyIGF2YWlsYWJsZSBpbiByZWxlYXNlIGJ1aWxkcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI2NzkKKworICAgICAgICBNYWRlIFNJR1VT UjIgYW5vdGhlciB3YXkgdG8gdHJpZ2dlciB0aGUgbWVtb3J5IHByZXNzdXJlIGhhbmRsZXIgaW4K KyAgICAgICAgYWxsIGJ1aWxkcy4gIFRoaXMgd2FzIGRvbmUgdG8gYWxsb3cgZm9yIGdyZWF0ZXIg dGVzdGluZyBvZiB0aGUgCisgICAgICAgIG1lbW9yeSB1c2FnZSBpbXByb3ZlbWVudHMgd2hlbiBy dW4gaW4gcHJvZHVjdGlvbiBjb2RlLgorCisgICAgICAgIENoYW5nZWQgY29tcGlsYXRpb24gZmxh Z3MgYW5kIG5vdCBvdmVyYWxsIGZ1bmN0aW9uYWxpdHkgdGhlcmVmb3JlIAorICAgICAgICBubyBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVy TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5UHJlc3N1cmVIYW5kbGVyOjppbnN0YWxs KTogRW5hYmxlZCB0aGUKKyAgICAgICAgU0lHVVNSMiBoYW5kbGVyIGZvciBhbGwgYnVpbGRzLgor CiAyMDExLTA2LTE1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9NZW1vcnlQcmVzc3VyZUhhbmRsZXJNYWMubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbQkocmV2aXNp b24gODg4NzEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVI YW5kbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MSw5ICs1MSw3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChC VUlMRElOR19PTl9TTk9XX0xFT1BBUkQpCiAKIHN0YXRpYyBkaXNwYXRjaF9zb3VyY2VfdCBfY2Fj aGVfZXZlbnRfc291cmNlID0gMDsKLSNpZm5kZWYgTkRFQlVHCiBzdGF0aWMgZGlzcGF0Y2hfc291 cmNlX3QgX2NhY2hlX2V2ZW50X3NvdXJjZTIgPSAwOwotI2VuZGlmCiAKIHZvaWQgTWVtb3J5UHJl c3N1cmVIYW5kbGVyOjppbnN0YWxsKCkKIHsKQEAgLTY5LDcgKzY3LDYgQEAgdm9pZCBNZW1vcnlQ cmVzc3VyZUhhbmRsZXI6Omluc3RhbGwoKQogICAgICAgICB9CiAgICAgfSk7CiAKLSNpZm5kZWYg TkRFQlVHCiAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgXnsK ICAgICAgICAgX2NhY2hlX2V2ZW50X3NvdXJjZTIgPSBkaXNwYXRjaF9zb3VyY2VfY3JlYXRlKERJ U1BBVENIX1NPVVJDRV9UWVBFX1NJR05BTCwgU0lHVVNSMiwgMCwgZGlzcGF0Y2hfZ2V0X21haW5f cXVldWUoKSk7CiAgICAgICAgIGlmIChfY2FjaGVfZXZlbnRfc291cmNlMikgewpAQCAtNzksNyAr NzYsNiBAQCB2b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6aW5zdGFsbCgpCiAgICAgICAgICAg ICBzaWduYWwoKGludClTSUdVU1IyLCBTSUdfSUdOKTsKICAgICAgICAgfQogICAgIH0pOwotI2Vu ZGlmCiAKICAgICBtX2luc3RhbGxlZCA9IHRydWU7CiB9Cg== 97703 2011-06-18 12:09:09 -0700 2011-06-18 12:11:18 -0700 Updated patch using notify 62679-2.patch text/plain 2527 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTkzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTggIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIG5vdGlmeSBoYW5kbGVyIHRvIHRyaWdnZXIgTWVtb3J5 UHJlc3N1cmVIYW5kbGVyIGluIGFsbCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNjc5CisKKyAgICAgICAgUmVtb3ZlZCBTSUdVU1IyIHRy aWdnZXIgYW5kIGFkZGVkIGEgbm90aWZ5IHRyaWdnZXIgZm9yIHRoZQorICAgICAgICBNZW1vcnlQ cmVzc3VyZUhhbmRsZXIuICBUaGUgbm90aWZ5IHRyaWdnZXIgaXMgZW5hYmxlZCBmb3IgYWxsIGJ1 aWxkcy4KKworICAgICAgICBObyB0ZXN0IGFkZGVkIGFzIG9ubHkgYWRkZWQgbmV3IG1lbW9yeSBw cmVzc3VyZSB0cmlnZ2VyLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJl SGFuZGxlck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeVByZXNzdXJlSGFuZGxlcjo6 aW5zdGFsbCk6CisKIDIwMTEtMDYtMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RA Z21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4OTE1NC4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVzc3VyZUhhbmRsZXJNYWMu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNz dXJlSGFuZGxlck1hYy5tbQkocmV2aXNpb24gODkxODcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0z NCw2ICszNCw3IEBACiAKICNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVm aW5lZChCVUlMRElOR19PTl9TTk9XX0xFT1BBUkQpCiAjaW1wb3J0IDxkaXNwYXRjaC9kaXNwYXRj aC5oPgorI2ltcG9ydCA8bm90aWZ5Lmg+CiAKICNpZm5kZWYgRElTUEFUQ0hfU09VUkNFX1RZUEVf Vk0KICNkZWZpbmUgRElTUEFUQ0hfU09VUkNFX1RZUEVfVk0gKCZfZGlzcGF0Y2hfc291cmNlX3R5 cGVfdm0pCkBAIC01MSw5ICs1Miw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICNpZiAhZGVmaW5l ZChCVUlMRElOR19PTl9MRU9QQVJEKSAmJiAhZGVmaW5lZChCVUlMRElOR19PTl9TTk9XX0xFT1BB UkQpCiAKIHN0YXRpYyBkaXNwYXRjaF9zb3VyY2VfdCBfY2FjaGVfZXZlbnRfc291cmNlID0gMDsK LSNpZm5kZWYgTkRFQlVHCi1zdGF0aWMgZGlzcGF0Y2hfc291cmNlX3QgX2NhY2hlX2V2ZW50X3Nv dXJjZTIgPSAwOwotI2VuZGlmCitzdGF0aWMgaW50IG5vdGlmeVRva2VuOwogCiB2b2lkIE1lbW9y eVByZXNzdXJlSGFuZGxlcjo6aW5zdGFsbCgpCiB7CkBAIC02OSwxNyArNjgsOCBAQCB2b2lkIE1l bW9yeVByZXNzdXJlSGFuZGxlcjo6aW5zdGFsbCgpCiAgICAgICAgIH0KICAgICB9KTsKIAotI2lm bmRlZiBOREVCVUcKLSAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgp LCBeewotICAgICAgICBfY2FjaGVfZXZlbnRfc291cmNlMiA9IGRpc3BhdGNoX3NvdXJjZV9jcmVh dGUoRElTUEFUQ0hfU09VUkNFX1RZUEVfU0lHTkFMLCBTSUdVU1IyLCAwLCBkaXNwYXRjaF9nZXRf bWFpbl9xdWV1ZSgpKTsKLSAgICAgICAgaWYgKF9jYWNoZV9ldmVudF9zb3VyY2UyKSB7Ci0gICAg ICAgICAgICBkaXNwYXRjaF9zZXRfY29udGV4dChfY2FjaGVfZXZlbnRfc291cmNlMiwgdGhpcyk7 Ci0gICAgICAgICAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hhbmRsZXIoX2NhY2hlX2V2 ZW50X3NvdXJjZTIsIF57IG1lbW9yeVByZXNzdXJlSGFuZGxlcigpLnJlc3BvbmRUb01lbW9yeVBy ZXNzdXJlKCk7fSk7Ci0gICAgICAgICAgICBkaXNwYXRjaF9yZXN1bWUoX2NhY2hlX2V2ZW50X3Nv dXJjZTIpOwotICAgICAgICAgICAgc2lnbmFsKChpbnQpU0lHVVNSMiwgU0lHX0lHTik7Ci0gICAg ICAgIH0KLSAgICB9KTsKLSNlbmRpZgorICAgIG5vdGlmeV9yZWdpc3Rlcl9kaXNwYXRjaCgiY29t LmFwcGxlLldlYktpdC5sb3dNZW1vcnkiLCAmbm90aWZ5VG9rZW4sCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIF4oaW50KSB7IG1lbW9yeVBy ZXNzdXJlSGFuZGxlcigpLnJlc3BvbmRUb01lbW9yeVByZXNzdXJlKCk7fSk7CiAKICAgICBtX2lu c3RhbGxlZCA9IHRydWU7CiB9Cg==