62678 2011-06-14 16:47:00 -0700 When the window is small enough, the scrollbars are misplaced with painting artifacts, after changing the scrollbar appearance 2011-06-14 17:09:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 420849 0 bdakin 2011-06-14 16:47:00 -0700 If you make a window small enough so that webkit.org has a horizontal and vertical scrollbar, and then you change the scrollbar appearance preference on the Mac, the layout gets totally messed up. <rdar://problem/9414015> Patch forthcoming. 420856 1 97196 bdakin 2011-06-14 16:58:04 -0700 Created attachment 97196 Patch 420857 2 97196 mitz 2011-06-14 17:02:38 -0700 Comment on attachment 97196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97196&action=review > Source/WebCore/ChangeLog:11 > + Get rid of the FrameView implementation of scrollbarStyleChanged() it's approach Typ'o: it's 420863 3 bdakin 2011-06-14 17:09:21 -0700 Changed committed with revision 88877. 97196 2011-06-14 16:58:04 -0700 2011-06-14 17:02:38 -0700 Patch for-review.txt text/plain 5106 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4ODc2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDYtMTQgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MjY3OAorICAgICAgICBXaGVuIHRoZSB3aW5kb3cgaXMgc21hbGwgZW5vdWdoLCB0aGUgc2Nyb2xs YmFycyBhcmUgbWlzcGxhY2VkIHdpdGggcGFpbnRpbmcgCisgICAgICAgIGFydGlmYWN0cywgYWZ0 ZXIgY2hhbmdpbmcgdGhlIHNjcm9sbGJhciBhcHBlYXJhbmNlCisgICAgICAgIC1hbmQgY29ycmVz cG9uZGluZy0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk0MTQwMTU+CisKKyAgICAgICAgR2V0 IHJpZCBvZiB0aGUgRnJhbWVWaWV3IGltcGxlbWVudGF0aW9uIG9mIHNjcm9sbGJhclN0eWxlQ2hh bmdlZCgpIGl0J3MgYXBwcm9hY2ggCisgICAgICAgIGlzIGp1c3Qgbm90IGdvb2QuCisgICAgICAg ICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisKKyAg ICAgICAgSW1wbGVtZW50IHNjcm9sbGJhclN0eWxlQ2hhbmdlZCgpIG9uIFNjcm9sbFZpZXcgaW5z dGVhZC4gQW5kIGp1c3QgY2FsbCAKKyAgICAgICAgdXBkYXRlZFNjcm9sbGJhcnMoKS4KKyAgICAg ICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZp ZXc6OnNjcm9sbGJhclN0eWxlQ2hhbmdlZCk6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmll dy5oOgorCisgICAgICAgIEludmFsaWRhdGUgdGhlIG9sZCBzY3JvbGxiYXIgYmVmb3JlIGNoYW5n aW5nIGl0IHRvIHRoZSBuZXcgc2Nyb2xsYmFyLiBUaGlzIHdheSAKKyAgICAgICAgd2hlbiB0aGUg c2Nyb2xsYmFyIGdldHMgc21hbGxlciwgdGhlIG9sZGVyLCBsYXJnZXIgcGllY2VzIHN0aWxsIHJl cGFpbnQgcHJvcGVybHkuCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JNYWM6OnVwZGF0ZVNjcm9sbGVy U3R5bGUpOgorCiAyMDExLTA2LTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDg4ODM1KQorKysgU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjE2LDE0ICsyMjE2LDYgQEAgdm9p ZCBGcmFtZVZpZXc6OmRpZENvbXBsZXRlQW5pbWF0ZWRTY3JvbAogICAgIHJldHVybiBwYWdlLT5j aHJvbWUoKS0+Y2xpZW50KCktPmRpZENvbXBsZXRlQW5pbWF0ZWRTY3JvbGwoKTsKIH0KIAotdm9p ZCBGcmFtZVZpZXc6OnNjcm9sbGJhclN0eWxlQ2hhbmdlZCgpCi17Ci0gICAgUGFnZSogcGFnZSA9 IG1fZnJhbWUtPnBhZ2UoKTsKLSAgICBpZiAoIXBhZ2UpCi0gICAgICAgIHJldHVybjsKLSAgICBw YWdlLT5zZXROZWVkc1JlY2FsY1N0eWxlSW5BbGxGcmFtZXMoKTsKLX0KLQogdm9pZCBGcmFtZVZp ZXc6OnNldFZpc2libGVTY3JvbGxlclRodW1iUmVjdChjb25zdCBJbnRSZWN0JiBzY3JvbGxlclRo dW1iKQogewogICAgIFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLT5wYWdlKCk7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmgJKHJldmlzaW9uIDg4ODM1KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAtMzI3LDcgKzMyNyw2IEBAIHByaXZhdGU6CiAg ICAgdmlydHVhbCB2b2lkIGRpZENvbXBsZXRlUnViYmVyQmFuZChjb25zdCBJbnRTaXplJikgY29u c3Q7CiAgICAgdmlydHVhbCB2b2lkIGRpZFN0YXJ0QW5pbWF0ZWRTY3JvbGwoKSBjb25zdDsKICAg ICB2aXJ0dWFsIHZvaWQgZGlkQ29tcGxldGVBbmltYXRlZFNjcm9sbCgpIGNvbnN0OwotICAgIHZp cnR1YWwgdm9pZCBzY3JvbGxiYXJTdHlsZUNoYW5nZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0 VmlzaWJsZVNjcm9sbGVyVGh1bWJSZWN0KGNvbnN0IEludFJlY3QmKTsKICNpZiBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCBHcmFwaGljc0xheWVyKiBsYXllckZvckhv cml6b250YWxTY3JvbGxiYXIoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbFZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbFZpZXcuY3BwCShyZXZpc2lvbiA4ODgzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbFZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MzgsNiArOTM4LDExIEBAIGJvb2wg U2Nyb2xsVmlldzo6aXNTY3JvbGxDb3JuZXJWaXNpYmxlKCkKICAgICByZXR1cm4gIXNjcm9sbENv cm5lclJlY3QoKS5pc0VtcHR5KCk7CiB9CiAKK3ZvaWQgU2Nyb2xsVmlldzo6c2Nyb2xsYmFyU3R5 bGVDaGFuZ2VkKCkKK3sKKyAgICB1cGRhdGVTY3JvbGxiYXJzKHNjcm9sbE9mZnNldCgpKTsKK30K Kwogdm9pZCBTY3JvbGxWaWV3Ojp1cGRhdGVTY3JvbGxDb3JuZXIoKQogewogfQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaAkocmV2aXNpb24gODg4MzUpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDYgKzU5 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRDb21wbGV0ZVJ1YmJlckJhbmQoY29u c3QgSW50U2l6ZSYpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCBub3RpZnlQYWdlVGhhdENvbnRl bnRBcmVhV2lsbFBhaW50KCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzU2Nyb2xsQ29ybmVy VmlzaWJsZSgpIGNvbnN0OworICAgIHZpcnR1YWwgdm9pZCBzY3JvbGxiYXJTdHlsZUNoYW5nZWQo KTsKIAogICAgIC8vIE5PVEU6IFRoaXMgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGJ5IHRoZSBvdmVy cmlkZW4gc2V0U2Nyb2xsT2Zmc2V0IGZyb20gU2Nyb2xsYWJsZUFyZWEuCiAgICAgdmlydHVhbCB2 b2lkIHNjcm9sbFRvKGNvbnN0IEludFNpemUmIG5ld09mZnNldCk7CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCShyZXZpc2lvbiA4 ODgzNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5t bQkod29ya2luZyBjb3B5KQpAQCAtMTIzOCw2ICsxMjM4LDggQEAgdm9pZCBTY3JvbGxBbmltYXRv ck1hYzo6dXBkYXRlU2Nyb2xsZXJTdAogICAgIGludCBuZXdTdHlsZSA9IHdrU2Nyb2xsYmFyUGFp bnRlckNvbnRyb2xsZXJTdHlsZShtX3Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyLmdldCgpKTsK IAogICAgIGlmIChTY3JvbGxiYXIqIHZlcnRpY2FsU2Nyb2xsYmFyID0gc2Nyb2xsYWJsZUFyZWEo KS0+dmVydGljYWxTY3JvbGxiYXIoKSkgeworICAgICAgICB2ZXJ0aWNhbFNjcm9sbGJhci0+aW52 YWxpZGF0ZSgpOworCiAgICAgICAgIFdLU2Nyb2xsYmFyUGFpbnRlclJlZiBvbGRWZXJ0aWNhbFBh aW50ZXIgPSB3a1ZlcnRpY2FsU2Nyb2xsYmFyUGFpbnRlckZvckNvbnRyb2xsZXIobV9zY3JvbGxi YXJQYWludGVyQ29udHJvbGxlci5nZXQoKSk7CiAgICAgICAgIFdLU2Nyb2xsYmFyUGFpbnRlclJl ZiBuZXdWZXJ0aWNhbFBhaW50ZXIgPSB3a01ha2VTY3JvbGxiYXJSZXBsYWNlbWVudFBhaW50ZXIo b2xkVmVydGljYWxQYWludGVyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5ld1N0eWxl LApAQCAtMTI1NCw2ICsxMjU2LDggQEAgdm9pZCBTY3JvbGxBbmltYXRvck1hYzo6dXBkYXRlU2Ny b2xsZXJTdAogICAgIH0KIAogICAgIGlmIChTY3JvbGxiYXIqIGhvcml6b250YWxTY3JvbGxiYXIg PSBzY3JvbGxhYmxlQXJlYSgpLT5ob3Jpem9udGFsU2Nyb2xsYmFyKCkpIHsKKyAgICAgICAgaG9y aXpvbnRhbFNjcm9sbGJhci0+aW52YWxpZGF0ZSgpOworCiAgICAgICAgIFdLU2Nyb2xsYmFyUGFp bnRlclJlZiBvbGRIb3Jpem9udGFsUGFpbnRlciA9IHdrSG9yaXpvbnRhbFNjcm9sbGJhclBhaW50 ZXJGb3JDb250cm9sbGVyKG1fc2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIuZ2V0KCkpOwogICAg ICAgICBXS1Njcm9sbGJhclBhaW50ZXJSZWYgbmV3SG9yaXpvbnRhbFBhaW50ZXIgPSB3a01ha2VT Y3JvbGxiYXJSZXBsYWNlbWVudFBhaW50ZXIob2xkSG9yaXpvbnRhbFBhaW50ZXIsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBuZXdTdHlsZSwK