6267 2005-12-27 20:26:00 -0800 Fix Number.prototype.toFixed/toExponential(undefined) 2005-12-29 03:49:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Other Linux RESOLVED FIXED P2 Normal --- 1 maksim webkit-unassigned oldest_to_newest 26911 0 maksim 2005-12-27 20:26:00 -0800 The attached fixes the two functions to properly handle being passed undefined as per spec, and not to exception. toFixed is supposed to handle it as 0; while toExponential has special handling; that was implemented, but was prevented from running by a wrong range check. This is tested by KJS's Number.js 26912 1 5323 maksim 2005-12-27 20:26:52 -0800 Created attachment 5323 patch 26915 2 5323 ggaren 2005-12-27 21:29:43 -0800 Comment on attachment 5323 patch r=me The second throwError message needs the verb "be" before this lands. 27033 3 darin 2005-12-28 10:35:04 -0800 We need to land the Number.js test too with this patch -- can't land a patch without a test. 27039 4 maksim 2005-12-28 10:41:46 -0800 Maciej landed the entire KJS testsuite. 27121 5 ggaren 2005-12-29 03:49:09 -0800 Landed. 5323 2005-12-27 20:26:52 -0800 2005-12-27 21:29:43 -0800 patch undef.diff text/plain 1001 maksim SW5kZXg6IG51bWJlcl9vYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG51bWJlcl9vYmplY3QuY3Bw CShyZXZpc2lvbiA0OTE2NzUpCisrKyBudW1iZXJfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTYwLDYgKzE5Miw4IEBAIFZhbHVlSW1wICpOdW1iZXJQcm90b0Z1bmNJbXA6OmNhbGxBc0Z1 bmMKICAgewogICAgICAgVmFsdWVJbXAgKmZyYWN0aW9uRGlnaXRzID0gYXJnc1swXTsKICAgICAg IGRvdWJsZSBkZiA9IGZyYWN0aW9uRGlnaXRzLT50b0ludGVnZXIoZXhlYyk7CisgICAgICBpZiAo ZnJhY3Rpb25EaWdpdHMtPmlzVW5kZWZpbmVkKCkpCisgICAgICAgICAgICBkZiA9IDA7CiAgICAg ICBpZiAoIShkZiA+PSAwICYmIGRmIDw9IDIwKSkgLy8gdHJ1ZSBmb3IgTmFOCiAgICAgICAgICAg cmV0dXJuIHRocm93RXJyb3IoZXhlYywgUmFuZ2VFcnJvciwgInRvRml4ZWQoKSBkaWdpdHMgYXJn dW1lbnQgbXVzdCBiZSBiZXR3ZWVuIDAgYW5kIDIwIik7CiAgICAgICBpbnQgZiA9IChpbnQpZGY7 CkBAIC0yMDUsNyArMjM5LDcgQEAgVmFsdWVJbXAgKk51bWJlclByb3RvRnVuY0ltcDo6Y2FsbEFz RnVuYwogICAgICAgCiAgICAgICBWYWx1ZUltcCAqZnJhY3Rpb25EaWdpdHMgPSBhcmdzWzBdOwog ICAgICAgZG91YmxlIGRmID0gZnJhY3Rpb25EaWdpdHMtPnRvSW50ZWdlcihleGVjKTsKLSAgICAg IGlmICghKGRmID49IDAgJiYgZGYgPD0gMjApKSAvLyB0cnVlIGZvciBOYU4KKyAgICAgIGlmICgh ZnJhY3Rpb25EaWdpdHMtPmlzVW5kZWZpbmVkKCkgJiYgIShkZiA+PSAwICYmIGRmIDw9IDIwKSkg Ly8gdHJ1ZSBmb3IgTmFOCiAgICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywgUmFuZ2VF cnJvciwgInRvRXhwb25lbnRpYWwoKSBhcmd1bWVudCBtdXN0IGJldHdlZW4gMCBhbmQgMjAiKTsK ICAgICAgIGludCBmID0gKGludClkZjsKICAgICAgIAo=