62668 2011-06-14 15:35:18 -0700 Webkit allows disabled option as value of "required" select 2011-06-20 20:00:33 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zajec5 webkit-unassigned ap dmikurube tkent webkit.review.bot oldest_to_newest 420774 0 zajec5 2011-06-14 15:35:18 -0700 "required" attribute tells browser value has to be entered for a given input/select. AFAIK choosing disabled option with no value should generate form validation error. 420777 1 97175 zajec5 2011-06-14 15:35:55 -0700 Created attachment 97175 Testcase for the bug 421647 2 tkent 2011-06-15 17:12:12 -0700 HTMLSelectElement::hasPlaceHolderLabelOption() checks option->disabled(), but the current specification doesn't ask to check 'disabled' for placeholder label option. I don't remember why we added the option->disabled() check. The specification might have been updated. 421795 3 dmikurube 2011-06-15 23:22:34 -0700 Yes, the specification looks like updated. http://www.w3.org/TR/2010/WD-html5-20101019/the-button-element.html#placeholder-label-option says: > If a ... is the empty string, and that option is not disabled, and, finally, that option element's parent node .... http://www.w3.org/TR/2011/WD-html5-20110525/the-button-element.html#placeholder-label-option says: > If a ... is the empty string, and that option element's parent node .... I'll try fixing it. 421812 4 97409 dmikurube 2011-06-15 23:58:46 -0700 Created attachment 97409 Patch 421814 5 dmikurube 2011-06-16 00:03:51 -0700 Ah, I uploaded the patch from dmikurube@google.com. It's me, dmikurube@chromium.org. 424186 6 97409 tkent 2011-06-20 19:20:12 -0700 Comment on attachment 97409 Patch ok 424201 7 97409 webkit.review.bot 2011-06-20 20:00:28 -0700 Comment on attachment 97409 Patch Clearing flags on attachment: 97409 Committed r89332: <http://trac.webkit.org/changeset/89332> 424202 8 webkit.review.bot 2011-06-20 20:00:33 -0700 All reviewed patches have been landed. Closing bug. 97175 2011-06-14 15:35:55 -0700 2011-06-14 15:35:55 -0700 Testcase for the bug select.required.option.disabled.html text/html 590 zajec5 PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KCTxoZWFkPgoJCTxtZXRhIGNoYXJzZXQ9 InV0Zi04IiAvPgoJCTx0aXRsZT5UZXN0Y2FzZTogV2Via2l0IGFsbG93cyBkaXNhYmxlZCBvcHRp b24gYXMgdmFsdWUgb2YgInJlcXVpcmVkIiBzZWxlY3Q8L3RpdGxlPgoJPC9oZWFkPgoJPGJvZHk+ CgkJPHA+U3VibWl0dGluZyBmb3JtIHdpdGggPHE+Q2hvb3NlIGFuc3dlcjwvcT4gc2VsZWN0ZWQg c2hvdWxkIGJlIGZvcmJpZGRlbiBieSBicm93c2VyLjwvcD4KCQk8cD5DbGlja2luZyBzdWJtaXQg YnV0dG9uIGluIFdlYmtpdCBkb2VzIG5vdCBnZW5lcmF0ZSBmb3JtIHZhbGlkYXRpb24gZXJyb3Iu PC9wPgoJCTxmb3JtIGFjdGlvbj0iIyI+CgkJCTxzZWxlY3QgcmVxdWlyZWQ+CgkJCQk8b3B0aW9u IHZhbHVlPSIiIGRpc2FibGVkPkNob29zZSBhbnN3ZXI8L29wdGlvbj4KCQkJCTxvcHRpb24gdmFs dWU9IjAiPkFuc3dlciAjMTwvb3B0aW9uPgoJCQkJPG9wdGlvbiB2YWx1ZT0iMSI+QW5zd2VyICMy PC9vcHRpb24+CgkJCTwvc2VsZWN0PgoJCQk8aW5wdXQgdHlwZT0ic3VibWl0IiAvPgoJCTwvZm9y bT4KCTwvYm9keT4KPC9odG1sPgo= 97409 2011-06-15 23:58:46 -0700 2011-06-20 20:00:28 -0700 Patch bug-62668-20110616155844.patch text/plain 3808 dmikurube U3VidmVyc2lvbiBSZXZpc2lvbjogODg5ODgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmZGU4ZWQ1MWYzZTk0NjJkZTBhZDkw ZjdmYmJiMzEwYjY4YTllOWFiLi5hMWRiNDU2NDUyZGJkYzY3YjY3NGZmZWUwNGNjZWE3ZDJmZTAx NGNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMTUgIERhaSBNaWt1cnViZSAgPGRt aWt1cnViZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2Via2l0IGFsbG93cyBkaXNhYmxlZCBvcHRpb24gYXMgdmFsdWUgb2Yg InJlcXVpcmVkIiBzZWxlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYyNjY4CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL1ZhbGlkaXR5U3RhdGUtdmFs dWVNaXNzaW5nLTAwMS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9mb3Jtcy9WYWxpZGl0 eVN0YXRlLXZhbHVlTWlzc2luZy0wMDEuaHRtbDogQ2hhbmdlZCB0byBnZW5lcmF0ZSBmb3JtIHZh bGlkYXRpb24gZXJyb3IgZm9yIGRpc2FibGVkIHBsYWNlaG9sZGVyIGxhYmVsIG9wdGlvbi4KKwog MjAxMS0wNi0xNSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9WYWxpZGl0eVN0YXRlLXZhbHVlTWlzc2luZy0wMDEtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9WYWxpZGl0eVN0YXRlLXZhbHVlTWlzc2luZy0wMDEtZXhw ZWN0ZWQudHh0CmluZGV4IDExZjQ1YWY5ZmM5M2MwZGM3YjVjYjVjNDZlNzMxMmRjNTljMWQyYjAu LjFjYzZjNDQ1ZjIzOTk3NjkxNzEzN2ZlMjBlYTYxNjkwYmRlYmY0YjMgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvVmFsaWRpdHlTdGF0ZS12YWx1ZU1pc3NpbmctMDAxLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL1ZhbGlkaXR5U3RhdGUtdmFsdWVN aXNzaW5nLTAwMS1leHBlY3RlZC50eHQKQEAgLTE3LDcgKzE3LDcgQEAgUEFTUyB2YWx1ZU1pc3Np bmdGb3IoInNlbGVjdC1ub25lLXNlbGVjdGVkLXNpemUyLW11bHRpcGxlIikgaXMgdHJ1ZQogUEFT UyB2YWx1ZU1pc3NpbmdGb3IoInNlbGVjdC1mYWtlLXBsYWNlaG9sZGVyLXNlbGVjdGVkLXNpemUy LW11bHRpcGxlIikgaXMgZmFsc2UKIFBBU1MgdmFsdWVNaXNzaW5nRm9yKCJzZWxlY3Qtd2l0aG91 dC1mYWtlLXBsYWNlaG9sZGVyLXNpemUyLW11bHRpcGxlIikgaXMgZmFsc2UKIFBBU1MgdmFsdWVN aXNzaW5nRm9yKCJzZWxlY3Qtb3B0Z3JvdXAiKSBpcyBmYWxzZQotUEFTUyB2YWx1ZU1pc3NpbmdG b3IoInNlbGVjdC1kaXNhYmxlZC1vcHRpb24iKSBpcyBmYWxzZQorUEFTUyB2YWx1ZU1pc3NpbmdG b3IoInNlbGVjdC1kaXNhYmxlZC1vcHRpb24iKSBpcyB0cnVlCiBQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvVmFsaWRpdHlTdGF0ZS12YWx1ZU1pc3NpbmctMDAxLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL1ZhbGlkaXR5U3RhdGUtdmFsdWVNaXNzaW5nLTAwMS5odG1sCmluZGV4IDYw OGM4OWU2ZjIyM2I0ZjM5Yzc4NzQyM2M0NTRjZWZhZTg2MDg2MzcuLjFjYTZhM2MxMDI1ZjJkZWZm NDNiMmMwZWExNTgzZjZkMTJlYjA5OGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvVmFsaWRpdHlTdGF0ZS12YWx1ZU1pc3NpbmctMDAxLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9WYWxpZGl0eVN0YXRlLXZhbHVlTWlzc2luZy0wMDEuaHRtbApAQCAtODUsNyAr ODUsNyBAQAogICAgIHNob3VsZEJlRmFsc2UoJ3ZhbHVlTWlzc2luZ0Zvcigic2VsZWN0LWZha2Ut cGxhY2Vob2xkZXItc2VsZWN0ZWQtc2l6ZTItbXVsdGlwbGUiKScpOwogICAgIHNob3VsZEJlRmFs c2UoJ3ZhbHVlTWlzc2luZ0Zvcigic2VsZWN0LXdpdGhvdXQtZmFrZS1wbGFjZWhvbGRlci1zaXpl Mi1tdWx0aXBsZSIpJyk7CiAgICAgc2hvdWxkQmVGYWxzZSgndmFsdWVNaXNzaW5nRm9yKCJzZWxl Y3Qtb3B0Z3JvdXAiKScpOwotICAgIHNob3VsZEJlRmFsc2UoJ3ZhbHVlTWlzc2luZ0Zvcigic2Vs ZWN0LWRpc2FibGVkLW9wdGlvbiIpJyk7CisgICAgc2hvdWxkQmVUcnVlKCd2YWx1ZU1pc3NpbmdG b3IoInNlbGVjdC1kaXNhYmxlZC1vcHRpb24iKScpOwogCiAgICAgdmFyIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IHRydWU7CiA8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDE4NDUwZDJmODk0NmYyZjQz NzgwMWJiMjU3YjhhZGRmNTM2Y2E0Li4xNzM4OGZlYzcwYjhkMWNiZDgxNzY2MDE2MjljMWNiNmZm YWI3MzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMTUgIERhaSBNaWt1 cnViZSAgPGRtaWt1cnViZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Via2l0IGFsbG93cyBkaXNhYmxlZCBvcHRpb24gYXMg dmFsdWUgb2YgInJlcXVpcmVkIiBzZWxlY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYyNjY4CisKKyAgICAgICAgKiBodG1sL0hUTUxTZWxlY3RFbGVt ZW50LmNwcDogUmVtb3ZlZCAiZGlzYWJsZWQiIGNoZWNraW5nIGR1ZSB0byBzcGVjIGNoYW5nZS4K KyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50OjpoYXNQbGFjZWhvbGRlckxhYmVs T3B0aW9uKToKKwogMjAxMS0wNi0xNSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAppbmRleCBjMjAxOGZlMGYwODkxOGNlMDc1NzJl MDFlOWE5Y2ZhODc5ODI4MjI0Li44N2FjNjRmNDBiZGMwNWY4NWZmM2RmNWVmZGZmYjUyNGQwYWFh MGNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApAQCAtMTI5 LDcgKzEyOSw3IEBAIGJvb2wgSFRNTFNlbGVjdEVsZW1lbnQ6Omhhc1BsYWNlaG9sZGVyTGFiZWxP cHRpb24oKSBjb25zdAogICAgIGlmIChsaXN0SW5kZXggPCAwKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgSFRNTE9wdGlvbkVsZW1lbnQqIG9wdGlvbiA9IHN0YXRpY19jYXN0PEhUTUxPcHRp b25FbGVtZW50Kj4obGlzdEl0ZW1zKClbbGlzdEluZGV4XSk7Ci0gICAgcmV0dXJuICFvcHRpb24t PmRpc2FibGVkKCkgJiYgIWxpc3RJbmRleCAmJiBvcHRpb24tPnZhbHVlKCkuaXNFbXB0eSgpOwor ICAgIHJldHVybiAhbGlzdEluZGV4ICYmIG9wdGlvbi0+dmFsdWUoKS5pc0VtcHR5KCk7CiB9CiAK IGJvb2wgSFRNTFNlbGVjdEVsZW1lbnQ6OnZhbHVlTWlzc2luZygpIGNvbnN0Cg==