62655 2011-06-14 11:20:32 -0700 REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation) 2011-06-14 13:35:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.craftymind.com/factory/html5video/CanvasVideo.html InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson oldest_to_newest 420593 0 jer.noble 2011-06-14 11:20:32 -0700 REGRESSION: Drawing video into canvas gets about one frame every 5 seconds (AVFoundation) 420599 1 jer.noble 2011-06-14 11:25:12 -0700 http://www.craftymind.com/factory/html5video/CanvasVideo.html has terrible performance on Lion. On SL, it's pretty smooth, but on Lion the animation is really choppy. Sampling shows lots of time in -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:] (attached. 420600 2 jer.noble 2011-06-14 11:25:26 -0700 <rdar://problem/9569220> 420601 3 97143 jer.noble 2011-06-14 11:26:38 -0700 Created attachment 97143 Patch 420602 4 eric.carlson 2011-06-14 11:27:59 -0700 Note that frequency of new frames is directly related to the key frame frequency in the video file because we are not resetting AVFoundation's default of snapping the time value to the nearest key frame time. This makes the title is slightly misleading, as we could get one frame every five seconds, one frame every minute, ten frames per second, etc. 420604 5 97143 eric.carlson 2011-06-14 11:28:47 -0700 Comment on attachment 97143 Patch Nice simple fix! 420697 6 jer.noble 2011-06-14 13:35:25 -0700 Committed r88847: <http://trac.webkit.org/changeset/88847> 97143 2011-06-14 11:26:38 -0700 2011-06-14 11:28:47 -0700 Patch bug-62655-20110614112637.patch text/plain 2096 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODg2NTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkODBhMTlmOGEzNzI1ZGUy MjNjMjdhMjJlNzBkYWYwMzk0NjUzODA5Li4zZTg3Yzg1YTA2YzBlYzMzMjNlOWFmZDMzMTc5ZWVi OGVkOGVlMzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMTQgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogRHJhd2luZyB2aWRlbyBpbnRvIGNhbnZh cyBnZXRzIGFib3V0IG9uZSBmcmFtZSBldmVyeSA1IHNlY29uZHMgKEFWRm91bmRhdGlvbikKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNjU1CisKKyAg ICAgICAgTm8gbmV3IHRlc3RzOyB3ZSBkb24ndCBoYXZlIGFueSBtZWRpYS1lbmdpbmUgc3BlY2lm aWMgdGVzdHMuCisKKyAgICAgICAgQVZBc3NldEltYWdlR2VuZXJhdG9yIHdpbGwsIGJ5IGRlZmF1 bHQsIHJldHVybiB0aGUgbmVhcmVzdCBrZXlmcmFtZS4gIFRvIGdldCB0aGUgZ2VuZXJhdG9yIHRv IHJldHVybgorICAgICAgICB0aGUgaW1hZ2UgZnJvbSB0aGUgY3VycmVudCB0aW1lIGluc3RlYWQg b2YgdGhlIG5lYXJlc3Qga2V5ZnJhbWUsIHNldCB0aGUgcmVxdWVzdGVkIHRpbWUgdG9sZXJhbmNl IHRvIAorICAgICAgICB6ZXJvICh3aGljaCBkZWZhdWx0cyB0byBpbmZpbml0eSkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbk9iakM6OmNyZWF0ZUNvbnRleHRWaWRlb1JlbmRlcmVyKToKKwogMjAxMS0wNi0x MSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCmluZGV4IDBlZWM5MzNmMjUwOGZiYmI4YmQy ODc1ZjBjZTVlM2YzNTM5Yjc2MzMuLjVhMDNjNzY5YmI3MjNmN2ExZTI4OTkzNjhlMTFiYmRhMzZm OWJjODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDLm1tCkBAIC0yMDEsNiArMjAxLDggQEAgdm9pZCBNZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpjcmVhdGVDb250ZXh0VmlkZW9SZW5kZXJlcigpCiAK ICAgICBbbV9pbWFnZUdlbmVyYXRvci5nZXQoKSBzZXRBcGVydHVyZU1vZGU6QVZBc3NldEltYWdl R2VuZXJhdG9yQXBlcnR1cmVNb2RlQ2xlYW5BcGVydHVyZV07CiAgICAgW21faW1hZ2VHZW5lcmF0 b3IuZ2V0KCkgc2V0QXBwbGllc1ByZWZlcnJlZFRyYWNrVHJhbnNmb3JtOllFU107CisgICAgW21f aW1hZ2VHZW5lcmF0b3IuZ2V0KCkgc2V0UmVxdWVzdGVkVGltZVRvbGVyYW5jZUJlZm9yZTprQ01U aW1lWmVyb107CisgICAgW21faW1hZ2VHZW5lcmF0b3IuZ2V0KCkgc2V0UmVxdWVzdGVkVGltZVRv bGVyYW5jZUFmdGVyOmtDTVRpbWVaZXJvXTsKIAogICAgIExPRyhNZWRpYSwgIk1lZGlhUGxheWVy UHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OmNyZWF0ZUltYWdlR2VuZXJhdG9yKCVwKSAtIHJldHVy bmluZyAlcCIsIHRoaXMsIG1faW1hZ2VHZW5lcmF0b3IuZ2V0KCkpOwogfQo=