62649 2011-06-14 10:32:59 -0700 Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE 2011-06-14 16:30:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62652 1 msaboff msaboff aestes joepeck oldest_to_newest 420540 0 msaboff 2011-06-14 10:32:59 -0700 The #ifdef DISPATCH_VM_PRESSURE on line 43 of MemoryPressureHandlerMac.mm should actually be #ifndef. 420565 1 97140 msaboff 2011-06-14 10:49:56 -0700 Created attachment 97140 Proposed patch 420567 2 97140 joepeck 2011-06-14 10:51:12 -0700 Comment on attachment 97140 Proposed patch Thanks! 420571 3 msaboff 2011-06-14 10:55:12 -0700 Committed r88823: <http://trac.webkit.org/changeset/88823> 420595 4 aestes 2011-06-14 11:21:44 -0700 DISPATCH_VM_PRESSURE is an enum, not a macro, so this check doesn't actually work and ends up breaking the build on machines that do have the system header. 420663 5 aestes 2011-06-14 12:46:50 -0700 http://trac.webkit.org/changeset/88829 rolled this out. Reopening. 420775 6 97173 msaboff 2011-06-14 15:35:33 -0700 Created attachment 97173 Updated patch 420779 7 97176 msaboff 2011-06-14 15:38:14 -0700 Created attachment 97176 Right updated patch 420781 8 97176 joepeck 2011-06-14 15:39:28 -0700 Comment on attachment 97176 Right updated patch Thanks again. 420831 9 msaboff 2011-06-14 16:30:42 -0700 Committed r88871: <http://trac.webkit.org/changeset/88871> 97140 2011-06-14 10:49:56 -0700 2011-06-14 15:35:33 -0700 Proposed patch 62649.patch text/plain 1328 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4ODIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTQgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW5jb3JyZWN0ICNpZltuXWRlZiBmb3IgYnVpbGRpbmcgd2l0 aG91dCBESVNQQVRDSF9WTV9QUkVTU1VSRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjI2NDkKKworICAgICAgICBUaGUgI2lmZGVmIERJU1BBVENIX1ZN X1BSRVNTVVJFIGFjdHVhbGx5IG5lZWRzIHRvIGJlICNpZm5kZWYKKyAgICAgICAgdG8gaGFuZGxl IHdoZW4gRElTUEFUQ0hfVk1fUFJFU1NVUkUgaXMgTk9UIGRlZmluZWQgaW4gdGhlCisgICAgICAg IHN5c3RlbSBoZWFkZXIgZmlsZXMuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLCBm aXhpbmcgYnVpbGQgaXNzdWUgdGhlcmVmb3JlIG5vIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbToKKwogMjAxMS0wNi0xNCAgVmlhdGNo ZXNsYXYgT3N0YXBlbmtvICA8b3N0YXBlbmtvLnZpYXRjaGVzbGF2QG5va2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1tCShyZXZp c2lvbiA4ODgyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVzc3Vy ZUhhbmRsZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDcgQEAKIERJU1BBVENI X0VYUE9SVCBjb25zdCBzdHJ1Y3QgZGlzcGF0Y2hfc291cmNlX3R5cGVfcyBfZGlzcGF0Y2hfc291 cmNlX3R5cGVfdm07CiAjZW5kaWYKIAotI2lmZGVmIERJU1BBVENIX1ZNX1BSRVNTVVJFCisjaWZu ZGVmIERJU1BBVENIX1ZNX1BSRVNTVVJFCiBlbnVtIHsKICBESVNQQVRDSF9WTV9QUkVTU1VSRSA9 IDB4ODAwMDAwMDAsCiB9Owo= 97173 2011-06-14 15:35:33 -0700 2011-06-14 15:38:14 -0700 Updated patch 62649.patch text/plain 1328 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4ODIxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTQgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW5jb3JyZWN0ICNpZltuXWRlZiBmb3IgYnVpbGRpbmcgd2l0 aG91dCBESVNQQVRDSF9WTV9QUkVTU1VSRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjI2NDkKKworICAgICAgICBUaGUgI2lmZGVmIERJU1BBVENIX1ZN X1BSRVNTVVJFIGFjdHVhbGx5IG5lZWRzIHRvIGJlICNpZm5kZWYKKyAgICAgICAgdG8gaGFuZGxl IHdoZW4gRElTUEFUQ0hfVk1fUFJFU1NVUkUgaXMgTk9UIGRlZmluZWQgaW4gdGhlCisgICAgICAg IHN5c3RlbSBoZWFkZXIgZmlsZXMuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLCBm aXhpbmcgYnVpbGQgaXNzdWUgdGhlcmVmb3JlIG5vIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbToKKwogMjAxMS0wNi0xNCAgVmlhdGNo ZXNsYXYgT3N0YXBlbmtvICA8b3N0YXBlbmtvLnZpYXRjaGVzbGF2QG5va2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1tCShyZXZp c2lvbiA4ODgyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVzc3Vy ZUhhbmRsZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDcgQEAKIERJU1BBVENI X0VYUE9SVCBjb25zdCBzdHJ1Y3QgZGlzcGF0Y2hfc291cmNlX3R5cGVfcyBfZGlzcGF0Y2hfc291 cmNlX3R5cGVfdm07CiAjZW5kaWYKIAotI2lmZGVmIERJU1BBVENIX1ZNX1BSRVNTVVJFCisjaWZu ZGVmIERJU1BBVENIX1ZNX1BSRVNTVVJFCiBlbnVtIHsKICBESVNQQVRDSF9WTV9QUkVTU1VSRSA9 IDB4ODAwMDAwMDAsCiB9Owo= 97176 2011-06-14 15:38:14 -0700 2011-06-14 15:39:28 -0700 Right updated patch 62649-2.patch text/plain 1366 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4ODU3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTQgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW5jb3JyZWN0ICNpZltuXWRlZiBmb3IgYnVpbGRpbmcgd2l0 aG91dCBESVNQQVRDSF9WTV9QUkVTU1VSRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjI2NDkKKworICAgICAgICBUYWtlIDIuCisgICAgICAgIFRoZSAj aWZkZWYgRElTUEFUQ0hfVk1fUFJFU1NVUkUgZG9lc24ndCB3b3JrLiAgQ29tYmluZWQgdGhlIGNv ZGUKKyAgICAgICAgaW5zaWRlIHRoaXMgI2lmZGVmIHdpdGggdGhlIHByaW9yICNpZm5kZWYgRElT UEFUQ0hfU09VUkNFX1RZUEVfVk0uCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbCBjaGFuZ2VzLCBm aXhpbmcgYnVpbGQgaXNzdWUgdGhlcmVmb3JlIG5vIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbToKKwogMjAxMS0wNi0xNCAgSmVmZnJl eSBQZmF1ICA8anBmYXVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEh5 YXR0LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFu ZGxlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTWVt b3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1tCShyZXZpc2lvbiA4ODgyMykKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9NZW1vcnlQcmVzc3VyZUhhbmRsZXJNYWMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTM4LDkgKzM4LDcgQEAKICNpZm5kZWYgRElTUEFUQ0hfU09VUkNFX1RZUEVfVk0KICNk ZWZpbmUgRElTUEFUQ0hfU09VUkNFX1RZUEVfVk0gKCZfZGlzcGF0Y2hfc291cmNlX3R5cGVfdm0p CiBESVNQQVRDSF9FWFBPUlQgY29uc3Qgc3RydWN0IGRpc3BhdGNoX3NvdXJjZV90eXBlX3MgX2Rp c3BhdGNoX3NvdXJjZV90eXBlX3ZtOwotI2VuZGlmCiAKLSNpZm5kZWYgRElTUEFUQ0hfVk1fUFJF U1NVUkUKIGVudW0gewogIERJU1BBVENIX1ZNX1BSRVNTVVJFID0gMHg4MDAwMDAwMCwKIH07Cg==