62638 2011-06-14 08:24:37 -0700 IndexedDB: Use fileExists() first when checking if SQLite db exists 2011-06-15 06:57:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hans hans dgrogan tonyg oldest_to_newest 420426 0 hans 2011-06-14 08:24:37 -0700 IndexedDB: Use fileExists() first when checking if SQLite db exists 420430 1 97123 hans 2011-06-14 08:27:25 -0700 Created attachment 97123 Patch 420435 2 97123 eric 2011-06-14 08:42:26 -0700 Comment on attachment 97123 Patch So this is a redundant check? We were already checking this at a lower layer, but this is a nicer place to check? I'm confused. what happens if you call db.open() with a non-existant path? 420443 3 hans 2011-06-14 08:47:56 -0700 (In reply to comment #2) > (From update of attachment 97123 [details]) > So this is a redundant check? We were already checking this at a lower layer, but this is a nicer place to check? I'm confused. what happens if you call db.open() with a non-existant path? It does a LOG_ERROR about failing to open the file, and returns false. It's not a big deal, but I'd like to get those errors removed from my console. 420736 4 dgrogan 2011-06-14 14:44:47 -0700 LGTM 421237 5 hans 2011-06-15 06:57:36 -0700 Committed r88925: <http://trac.webkit.org/changeset/88925> 97123 2011-06-14 08:27:25 -0700 2011-06-15 06:46:06 -0700 Patch bug-62638-20110614162723.patch text/plain 1809 hans U3VidmVyc2lvbiBSZXZpc2lvbjogODg3ODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ODVjZmQyYTk3N2RhOTRl NjRhNDg2OWQ2MTYwMmMyYjZlYzE0N2RkLi5hNDc1ZDU5OTc2YWE3NmM5MDM5MmNkNzQzZmFkN2Y3 NDc0YzAzOWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMTQgIEhhbnMg V2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbmRleGVkREI6IFVzZSBmaWxlRXhpc3RzKCkgZmlyc3Qg d2hlbiBjaGVja2luZyBpZiBTUUxpdGUgZGIgZXhpc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjYzOAorCisgICAgICAgIEluIElEQlNRTGl0ZUJh Y2tpbmdTdG9yZTo6YmFja2luZ1N0b3JlRXhpc3RzKCksIHdoaWNoIGlzIHVzZWQgdG8gY2hlY2sK KyAgICAgICAgaWYgYSBTUUxpdGUgZGF0YWJhc2UgZXhpc3RzIGFuZCBzaG91bGQgYmUgY29uc2lk ZXJlZCBmb3IgbWlncmF0aW9uLAorICAgICAgICBjaGVjayBpZiB0aGUgZmlsZSBleGlzdHMgZmly c3QuCisKKyAgICAgICAgVHJ5aW5nIHRvIG9wZW4gYSBTUUxpdGUgZGF0YWJhc2UgZm9yIGEgbm9u LWV4aXN0aW5nIGZpbGUgcHJpbnRzIGEKKyAgICAgICAgbm9pc3kgZXJyb3IgbWVzc2FnZSBpbiBk ZWJ1ZyBidWlsZHMuCisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHksIG5vIG5ldyB0ZXN0 cy4KKworICAgICAgICAqIHN0b3JhZ2UvSURCU1FMaXRlQmFja2luZ1N0b3JlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OklEQlNRTGl0ZUJhY2tpbmdTdG9yZTo6YmFja2luZ1N0b3JlRXhpc3RzKToK KwogMjAxMS0wNi0xMyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW0VGTF0gVGhlIHNlY29uZCB0cnkgdG8gZml4IGEgYnVpbGQgYnJlYWsuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9zdG9yYWdlL0lEQlNRTGl0ZUJhY2tpbmdTdG9yZS5jcHAKaW5kZXggZjg2YzMx NjA4MGUxZWQwOTMyMmEzNDhjNjEzMTZiNzY1Y2RmMzJlZi4uMmM0OGYwZWFhY2I4NTYwYTQ2MzQ5 NWJhODRmMWExZmVlZjU0MDNhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9J REJTUUxpdGVCYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURC U1FMaXRlQmFja2luZ1N0b3JlLmNwcApAQCAtOTk0LDYgKzk5NCw4IEBAIFBhc3NSZWZQdHI8SURC QmFja2luZ1N0b3JlOjpDdXJzb3I+IElEQlNRTGl0ZUJhY2tpbmdTdG9yZTo6b3BlbkluZGV4Q3Vy c29yKGludDY0CiBib29sIElEQlNRTGl0ZUJhY2tpbmdTdG9yZTo6YmFja2luZ1N0b3JlRXhpc3Rz KFNlY3VyaXR5T3JpZ2luKiBzZWN1cml0eU9yaWdpbiwgY29uc3QgU3RyaW5nJiBwYXRoQmFzZSkK IHsKICAgICBTdHJpbmcgcGF0aCA9IHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChwYXRoQmFzZSwg c2VjdXJpdHlPcmlnaW4tPmRhdGFiYXNlSWRlbnRpZmllcigpICsgIi5pbmRleGVkZGIiKTsKKyAg ICBpZiAoIWZpbGVFeGlzdHMocGF0aCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIFNR TGl0ZURhdGFiYXNlIGRiOwogICAgIGlmICghZGIub3BlbihwYXRoKSkK