62635 2011-06-14 07:44:08 -0700 KeywordLookupGenerator's Trie does not work with Python 3 2011-06-14 09:25:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P5 Enhancement --- 1 benjamin benjamin dpranke eric kling levin mihaip ojan oliver webkit.review.bot oldest_to_newest 420405 0 benjamin 2011-06-14 07:44:08 -0700 In Python 3, the dictionary's items() function returns an iterator instead of a list of tuple. dict.items()[0] cannot work. Fix that when you have 5 minutes :) 420429 1 97122 benjamin 2011-06-14 08:27:00 -0700 Created attachment 97122 Patch 420439 2 97122 eric 2011-06-14 08:45:58 -0700 Comment on attachment 97122 Patch Odd that there isn't a nicer way to do this. 420442 3 97122 oliver 2011-06-14 08:47:01 -0700 Comment on attachment 97122 Patch Yay for languages that randomly break existing content. 420444 4 benjamin 2011-06-14 08:48:29 -0700 (In reply to comment #2) > (From update of attachment 97122 [details]) > Odd that there isn't a nicer way to do this. When we drop support for Python 2.5, we can use the global function next(). 420451 5 eric 2011-06-14 08:52:17 -0700 I see, that wasn't clear to me from your comment for some reason. 420483 6 97122 webkit.review.bot 2011-06-14 09:25:16 -0700 Comment on attachment 97122 Patch Clearing flags on attachment: 97122 Committed r88807: <http://trac.webkit.org/changeset/88807> 420485 7 webkit.review.bot 2011-06-14 09:25:21 -0700 All reviewed patches have been landed. Closing bug. 97122 2011-06-14 08:27:00 -0700 2011-06-14 09:25:16 -0700 Patch 62635.diff text/plain 1723 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVkMDhkNWMuLmUyZmE1MDkzNiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTQgIEJlbmphbWluIFBv dWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEtleXdvcmRMb29rdXBHZW5lcmF0b3IncyBUcmllIGRvZXMg bm90IHdvcmsgd2l0aCBQeXRob24gMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjI2MzUKKworICAgICAgICBXaXRoIFB5dGhvbiAzLCBkaWN0Lml0ZW1z KCkgcmV0dXJuIGFuIGl0ZXJhdG9yLiBTaW5jZSB0aGUgaXRlcmF0b3IKKyAgICAgICAgcHJvdG9j b2wgY2hhbmdlZCBiZXR3ZWVuIFB5dGhvbiAyIGFuZCAzLCB0aGUgZWFzaWVzdCB3YXkgdG8gZ2V0 IHRoZQorICAgICAgICB2YWx1ZXMgaXMgdG8gaGF2ZSBzb21ldGhpbmcgdGhhdCB1c2UgdGhlIGl0 ZXJhdG9yIGltcGxpY2l0ZWx5LCBsaWtlIGEKKyAgICAgICAgZm9yKCkgbG9vcC4KKworICAgICAg ICAqIEtleXdvcmRMb29rdXBHZW5lcmF0b3IucHk6CisKIDIwMTEtMDYtMTMgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNs b3VnaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9LZXl3b3JkTG9va3VwR2Vu ZXJhdG9yLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0tleXdvcmRMb29rdXBHZW5lcmF0b3Iu cHkKaW5kZXggODlhY2I1YS4uNDlkYTRjNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0tleXdvcmRMb29rdXBHZW5lcmF0b3IucHkKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0tleXdvcmRMb29rdXBHZW5lcmF0b3IucHkKQEAgLTEwMywxMSArMTAzLDEyIEBAIGNsYXNzIFRy aWU6CiAgICAgICAgICAgICByZXR1cm4gc2VsZgogICAgICAgICBpZiBsZW4oc2VsZi5rZXlzKSAh PSAxOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYKLSAgICAgICAgKHByZWZpeCwgc3VmZml4KSA9 IHNlbGYua2V5cy5pdGVtcygpWzBdCi0gICAgICAgIHJlcyA9IFRyaWUoc2VsZi5wcmVmaXggKyBw cmVmaXgpCi0gICAgICAgIHJlcy52YWx1ZSA9IHN1ZmZpeC52YWx1ZQotICAgICAgICByZXMua2V5 cyA9IHN1ZmZpeC5rZXlzCi0gICAgICAgIHJldHVybiByZXMKKyAgICAgICAgIyBQeXRob24gMzog Zm9yKCkgbG9vcCBmb3IgY29tcGF0aWJpbGl0eS4gVXNlIG5leHQoKSB3aGVuIFB5dGhvbiAyLjYg aXMgdGhlIGJhc2VsaW5lLgorICAgICAgICBmb3IgKHByZWZpeCwgc3VmZml4KSBpbiBzZWxmLmtl eXMuaXRlbXMoKToKKyAgICAgICAgICAgIHJlcyA9IFRyaWUoc2VsZi5wcmVmaXggKyBwcmVmaXgp CisgICAgICAgICAgICByZXMudmFsdWUgPSBzdWZmaXgudmFsdWUKKyAgICAgICAgICAgIHJlcy5r ZXlzID0gc3VmZml4LmtleXMKKyAgICAgICAgICAgIHJldHVybiByZXMKIAogICAgIGRlZiBmaWxs T3V0KHNlbGYsIHByZWZpeD0iIik6CiAgICAgICAgIHNlbGYuZnVsbFByZWZpeCA9IHByZWZpeCAr IHNlbGYucHJlZml4Cg==