62632 2011-06-14 06:35:29 -0700 [Qt] Don't include convenience "QWebFoo" headers in WebKit code. 2011-06-14 09:25:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling ademar webkit.review.bot oldest_to_newest 420368 0 kling 2011-06-14 06:35:29 -0700 We shouldn't make assumptions about these headers being available and pointing to the right qwebfoo.h 420370 1 97107 kling 2011-06-14 06:37:21 -0700 Created attachment 97107 Proposed patch 420371 2 webkit.review.bot 2011-06-14 06:38:38 -0700 Attachment 97107 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 420382 3 kling 2011-06-14 06:54:21 -0700 Committed r88795: <http://trac.webkit.org/changeset/88795> 420484 4 ademar 2011-06-14 09:25:20 -0700 Revision r88795 cherry-picked into qtwebkit-2.2 with commit ceea7a3 <http://gitorious.org/webkit/qtwebkit/commit/ceea7a3> 97107 2011-06-14 06:37:21 -0700 2011-06-14 06:38:25 -0700 Proposed patch bug-62632.diff text/plain 1038 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYmE2NTEwOS4uOTIwNmI3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMS0wNi0xNCAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBE b24ndCBpbmNsdWRlIGNvbnZlbmllbmNlICJRV2ViRm9vIiBoZWFkZXJzIGluIFdlYktpdCBjb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI2MzIK KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRRdC5jcHA6 CisKIDIwMTEtMDYtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0UXQuY3BwIGIvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0UXQuY3Bw CmluZGV4IDUwMmE0MTguLjNkZDhkOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFF0LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRRdC5jcHAKQEAgLTIz LDggKzIzLDggQEAKIAogI2luY2x1ZGUgPFFOZXR3b3JrQWNjZXNzTWFuYWdlcj4KICNpbmNsdWRl IDxRT2JqZWN0PgotI2luY2x1ZGUgPFFXZWJGcmFtZT4KLSNpbmNsdWRlIDxRV2ViUGFnZT4KKyNp bmNsdWRlICJxd2ViZnJhbWUuaCIKKyNpbmNsdWRlICJxd2VicGFnZS5oIgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAK