6261 2005-12-27 14:17:40 -0800 Misc. array object fixes from KJS 2006-01-13 12:15:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Other Linux RESOLVED FIXED P2 Normal --- 1 maksim webkit-unassigned oldest_to_newest 26813 0 maksim 2005-12-27 14:17:40 -0800 Fixes: 1. Make sure that accesses to arrays with index 2^32-1 via the int path does not screw things up. 2^32-1 is never a real array index property. (Kind of icky, I agree) 2. Throw exception on trying to set invalid array length (As per 15.4.5.1, steps 12 and 13) 3. Do not use a separator argument when doing toString/toLocalString Mostly merging work by Peter Kelly #1 and #2 are covered by KJS testcases. For #3: var a = new Array; a[0] = 5; a[1] = 3; //Shouldn't use argument for toString shouldBe("a.toString('!')", "'5,3'"); 26814 1 5311 maksim 2005-12-27 14:18:04 -0800 Created attachment 5311 patch 27100 2 5311 mjs 2005-12-29 00:27:12 -0800 Comment on attachment 5311 patch r=me, the ad-hoc test for toString needs to be converted to a proper layout test. 27108 3 5311 mjs 2005-12-29 01:16:57 -0800 Comment on attachment 5311 patch r=me 5311 2005-12-27 14:18:04 -0800 2005-12-29 00:27:12 -0800 patch array_obj.diff text/plain 3140 maksim SW5kZXg6IGFycmF5X29iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGFycmF5X29iamVjdC5oCShyZXZp c2lvbiA0OTE2NzUpCisrKyBhcnJheV9vYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiAr NTAsOCBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICBpbnQgaWQ7CiAgIH07CiAKKyAgY29uc3QgdW5z aWduZWQgTUFYX0FSUkFZX0lOREVYID0gMHhGRkZGRkZGRXU7CisKICAgY2xhc3MgQXJyYXlPYmpl Y3RJbXAgOiBwdWJsaWMgSW50ZXJuYWxGdW5jdGlvbkltcCB7CiAgIHB1YmxpYzoKICAgICBBcnJh eU9iamVjdEltcChFeGVjU3RhdGUgKmV4ZWMsCkluZGV4OiBhcnJheV9vYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIGFycmF5X29iamVjdC5jcHAJKHJldmlzaW9uIDQ5MTY3NSkKKysrIGFycmF5X29i amVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMsNiArMyw3IEBACiAgKiAgVGhpcyBmaWxlIGlz IHBhcnQgb2YgdGhlIEtERSBsaWJyYXJpZXMKICAqICBDb3B5cmlnaHQgKEMpIDE5OTktMjAwMCBI YXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENvcHlyaWdodCAoQykgMjAwMyBBcHBs ZSBDb21wdXRlciwgSW5jLgorICogIENvcHlyaWdodCAoQykgMjAwMyBQZXRlciBLZWxseSAocG1r QHBvc3QuY29tKQogICoKICAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNh biByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBv ZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYwpAQCAtMTA0LDYgKzEwNSw5IEBAIGJvb2wg QXJyYXlJbnN0YW5jZUltcDo6Z2V0T3duUHJvcGVydHlTbG8KIAogYm9vbCBBcnJheUluc3RhbmNl SW1wOjpnZXRPd25Qcm9wZXJ0eVNsb3QoRXhlY1N0YXRlICpleGVjLCB1bnNpZ25lZCBpbmRleCwg UHJvcGVydHlTbG90JiBzbG90KQogeworICBpZiAoaW5kZXggPiBNQVhfQVJSQVlfSU5ERVgpCisg ICAgcmV0dXJuIGdldE93blByb3BlcnR5U2xvdChleGVjLCBJZGVudGlmaWVyOjpmcm9tKGluZGV4 KSwgc2xvdCk7CisKICAgaWYgKGluZGV4ID49IGxlbmd0aCkKICAgICByZXR1cm4gZmFsc2U7CiAg IGlmIChpbmRleCA8IHN0b3JhZ2VMZW5ndGgpIHsKQEAgLTEyMSw3ICsxMjUsMTIgQEAgYm9vbCBB cnJheUluc3RhbmNlSW1wOjpnZXRPd25Qcm9wZXJ0eVNsbwogdm9pZCBBcnJheUluc3RhbmNlSW1w OjpwdXQoRXhlY1N0YXRlICpleGVjLCBjb25zdCBJZGVudGlmaWVyICZwcm9wZXJ0eU5hbWUsIFZh bHVlSW1wICp2YWx1ZSwgaW50IGF0dHIpCiB7CiAgIGlmIChwcm9wZXJ0eU5hbWUgPT0gbGVuZ3Ro UHJvcGVydHlOYW1lKSB7Ci0gICAgc2V0TGVuZ3RoKHZhbHVlLT50b1VJbnQzMihleGVjKSwgZXhl Yyk7CisgICAgdW5zaWduZWQgaW50IG5ld0xlbiA9IHZhbHVlLT50b1VJbnQzMihleGVjKTsKKyAg ICBpZiAodmFsdWUtPnRvTnVtYmVyKGV4ZWMpICE9IGRvdWJsZShuZXdMZW4pKSB7CisgICAgICB0 aHJvd0Vycm9yKGV4ZWMsIFJhbmdlRXJyb3IsICJJbnZhbGlkIGFycmF5IGxlbmd0aC4iKTsKKyAg ICAgIHJldHVybjsKKyAgICB9CisgICAgc2V0TGVuZ3RoKG5ld0xlbiwgZXhlYyk7CiAgICAgcmV0 dXJuOwogICB9CiAgIApAQCAtMTM3LDYgKzE0NiwxMyBAQCB2b2lkIEFycmF5SW5zdGFuY2VJbXA6 OnB1dChFeGVjU3RhdGUgKmV4CiAKIHZvaWQgQXJyYXlJbnN0YW5jZUltcDo6cHV0KEV4ZWNTdGF0 ZSAqZXhlYywgdW5zaWduZWQgaW5kZXgsIFZhbHVlSW1wICp2YWx1ZSwgaW50IGF0dHIpCiB7Cisg IC8vMHhGRkZGIEZGRkYgaXMgYSBiaXQgd2VpcmQgLS0tIGl0IHNob3VsZCBiZSB0cmVhdGVkIGFz IGEgbm9uLWFycmF5IGluZGV4LCBldmVuIHdoZW4KKyAgLy9pdCdzIGEgc3RyaW5nIAorICBpZiAo aW5kZXggPiBNQVhfQVJSQVlfSU5ERVgpIHsKKyAgICBwdXQoZXhlYywgSWRlbnRpZmllcjo6ZnJv bShpbmRleCksIHZhbHVlLCBhdHRyKTsKKyAgICByZXR1cm47CisgIH0KKwogICBpZiAoaW5kZXgg PCBzcGFyc2VBcnJheUN1dG9mZiAmJiBpbmRleCA+PSBzdG9yYWdlTGVuZ3RoKSB7CiAgICAgcmVz aXplU3RvcmFnZShpbmRleCArIDEpOwogICB9CkBAIC0xNzUsNiArMTkxLDkgQEAgYm9vbCBBcnJh eUluc3RhbmNlSW1wOjpkZWxldGVQcm9wZXJ0eShFeAogCiBib29sIEFycmF5SW5zdGFuY2VJbXA6 OmRlbGV0ZVByb3BlcnR5KEV4ZWNTdGF0ZSAqZXhlYywgdW5zaWduZWQgaW5kZXgpCiB7CisgIGlm IChpbmRleCA+IE1BWF9BUlJBWV9JTkRFWCkKKyAgICByZXR1cm4gZGVsZXRlUHJvcGVydHkoZXhl YywgSWRlbnRpZmllcjo6ZnJvbShpbmRleCkpOworCiAgIGlmIChpbmRleCA+PSBsZW5ndGgpCiAg ICAgcmV0dXJuIHRydWU7CiAgIGlmIChpbmRleCA8IHN0b3JhZ2VMZW5ndGgpIHsKQEAgLTE5Miw2 ICsyMTEsNyBAQCBSZWZlcmVuY2VMaXN0IEFycmF5SW5zdGFuY2VJbXA6OnByb3BMaXN0CiAgIC8v IGF2b2lkIGZldGNoaW5nIHRoaXMgZXZlcnkgdGltZSB0aHJvdWdoIHRoZSBsb29wCiAgIFZhbHVl SW1wICp1bmRlZmluZWQgPSBqc1VuZGVmaW5lZCgpOwogCisgIC8vIyMjIEZJWE1FOiBzaG91bGQg YXZvaWQgZHVwbGljYXRlcyB3aXRoIHByb3RvdHlwZQogICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgc3RvcmFnZUxlbmd0aDsgKytpKSB7CiAgICAgVmFsdWVJbXAgKmltcCA9IHN0b3JhZ2VbaV07 CiAgICAgaWYgKGltcCAmJiBpbXAgIT0gdW5kZWZpbmVkKSB7CkBAIC00NDksNyArNDY5LDcgQEAg VmFsdWVJbXAgKkFycmF5UHJvdG9GdW5jSW1wOjpjYWxsQXNGdW5jdAogICAgIFVTdHJpbmcgc2Vw YXJhdG9yID0gIiwiOwogICAgIFVTdHJpbmcgc3RyID0gIiI7CiAKLSAgICBpZiAoIWFyZ3NbMF0t PmlzVW5kZWZpbmVkKCkpCisgICAgaWYgKGlkID09IEpvaW4gJiYgIWFyZ3NbMF0tPmlzVW5kZWZp bmVkKCkpCiAgICAgICBzZXBhcmF0b3IgPSBhcmdzWzBdLT50b1N0cmluZyhleGVjKTsKICAgICBm b3IgKHVuc2lnbmVkIGludCBrID0gMDsgayA8IGxlbmd0aDsgaysrKSB7CiAgICAgICBpZiAoayA+ PSAxKQo=