62609 2011-06-13 16:55:05 -0700 fast/workers/worker-close.html is flaky on slower machines. 2011-06-13 18:15:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin ap dimich dslomov webkit.review.bot oldest_to_newest 420053 0 levin 2011-06-13 16:55:05 -0700 For example, http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20(1)/builds/8391/steps/ui_tests/logs/stdio 420060 1 97036 levin 2011-06-13 16:57:52 -0700 Created attachment 97036 Patch 420068 2 97036 dimich 2011-06-13 17:05:13 -0700 Comment on attachment 97036 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review > LayoutTests/fast/workers/worker-close.html:46 > + timeout = setTimeout(testErrorAfterClose, 1000); Do we need a 1000ms delay now? 420079 3 levin 2011-06-13 17:11:17 -0700 (In reply to comment #2) > (From update of attachment 97036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review > > > LayoutTests/fast/workers/worker-close.html:46 > > + timeout = setTimeout(testErrorAfterClose, 1000); > > Do we need a 1000ms delay now? The delay wasn't about waiting for this response. It was about waiting to see if it got back a response to the "worker.postMessage("ping");" message. 420098 4 97036 dimich 2011-06-13 17:33:54 -0700 Comment on attachment 97036 Patch Thanks! 420135 5 97036 webkit.review.bot 2011-06-13 18:15:39 -0700 Comment on attachment 97036 Patch Clearing flags on attachment: 97036 Committed r88746: <http://trac.webkit.org/changeset/88746> 420136 6 webkit.review.bot 2011-06-13 18:15:43 -0700 All reviewed patches have been landed. Closing bug. 97036 2011-06-13 16:57:52 -0700 2011-06-13 18:15:38 -0700 Patch bug-62609-20110613165751.patch text/plain 1800 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODg2ODgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzYzcyZDQ0M2U0MzdlYmVmZGMxNDM3 OGI5OTA3NjI0OGU4OTg4YjE5Li5iM2JhY2FjMmFjNmU5MTQ5ZTdhZDMzZDczZWM5OWZjNGYzNzY0 NTliIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMDYtMTMgIERhdmlkIExldmluICA8bGV2 aW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGZhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UuaHRtbCBpcyBmbGFreSBvbiBzbG93 ZXIgbWFjaGluZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MjYwOQorCisgICAgICAgICogZmFzdC93b3JrZXJzL3dvcmtlci1jbG9zZS5odG1sOiBN b3ZlIGEgc2V0VGltZW91dCB0byBzdGFydCBhZnRlcgorICAgICAgICB0aGUgcmVzcG9uc2UgbWVz c2FnZSBpcyByZWNlaXZlZCB0byBtYWtlIHRoZSBvcmRlcmluZyBvZiBtZXNzYWdlcworICAgICAg ICBkZXRlcm1pbmlzdGljLgorCisyMDExLTA2LTEzICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBUZXN0IGZpeCBmb3IgV2luZG93cy4KIAogICAgICAgICBbV2lu ZG93c10gV2ViIFdvcmtlciB0ZXN0IGNhdXNlcyBzY3JpcHQgZXJyb3Igb24gV2luZG93cyBwbGF0 Zm9ybSBhbG9uZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXIt Y2xvc2UuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UuaHRtbApp bmRleCA2ZjZhMzJmZTFkM2JhMzg5NjNmZDMyMTNjMGVlYzk5NmYyN2JiNGVhLi44ZTA2ZjQxMjJm ZDVhY2FkNThiZTk1MzRlNTA0YjRmNTM2OWUzNjcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L3dvcmtlcnMvd29ya2VyLWNsb3NlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3Jr ZXJzL3dvcmtlci1jbG9zZS5odG1sCkBAIC00MSwxNCArNDEsMTQgQEAgZnVuY3Rpb24gdGVzdE1l c3NhZ2VBZnRlckNsb3NlKGV2dCkgewogICAgIHdvcmtlci5wb3N0TWVzc2FnZSgiY2xvc2UiKTsK ICAgICB3b3JrZXIucG9zdE1lc3NhZ2UoInBpbmciKTsKICAgICB3b3JrZXIub25tZXNzYWdlID0g ZnVuY3Rpb24oZXZ0KSB7Ci0gICAgICAgIGlmIChldnQuZGF0YSAhPSAicG9uZyIpCisgICAgICAg IGlmIChldnQuZGF0YSAhPSAicG9uZyIpIHsKICAgICAgICAgICAgIGxvZygiUEFTUzogUmVjZWl2 ZWQgbWVzc2FnZSBwb3N0ZWQgcmlnaHQgYWZ0ZXIgY2xvc2UoKSB3YXMgaW52b2tlZDogIiArIGV2 dC5kYXRhKTsKLSAgICAgICAgZWxzZSB7CisgICAgICAgICAgICB0aW1lb3V0ID0gc2V0VGltZW91 dCh0ZXN0RXJyb3JBZnRlckNsb3NlLCAxMDAwKTsKKyAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgIGxvZygiRkFJTDogUmVjZWl2ZWQgYSBtZXNzYWdlIG9yaWdpbmF0ZWQgZnJvbSBhIGhhbmRs ZXIgaW4gdGhlIHdvcmtlciBhZnRlciB0aGUgSlMgZnJhZ21lbnQgd2l0aCBjbG9zZSgpIGV4aXRl ZCIgKyBldnQuZGF0YSk7CiAgICAgICAgICAgICBkb25lKCk7CiAgICAgICAgIH0KICAgICB9Owot ICAgIHRpbWVvdXQgPSBzZXRUaW1lb3V0KHRlc3RFcnJvckFmdGVyQ2xvc2UsIDEwMDApOwogfQog CiBmdW5jdGlvbiB0ZXN0RXJyb3JBZnRlckNsb3NlKCkK