62604 2011-06-13 15:15:33 -0700 [CMAKE] Add ENABLE_TOUCH_ICON_LOADING feature. 2011-06-14 09:29:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned gyuyoung.kim ljaehun.lim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 419937 0 ryuan.choi 2011-06-13 15:15:33 -0700 Patch will be updated. 419951 1 97016 ryuan.choi 2011-06-13 15:22:16 -0700 Created attachment 97016 Patch 420161 2 97016 lucas.de.marchi 2011-06-13 19:36:04 -0700 Comment on attachment 97016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review Isn't there any additional files that need to be compiled? Otherwise looks good. > ChangeLog:8 > + Add feature to enable or disable ENABLE_TOUCH_ICON which support supports > Source/cmakeconfig.h.cmake:39 > +#cmakedefine01 ENABLE_TOUCH_ICO_LOADING ICON 420210 3 97066 ryuan.choi 2011-06-13 22:05:38 -0700 Created attachment 97066 Patch 420215 4 ryuan.choi 2011-06-13 22:10:18 -0700 (In reply to comment #2) > (From update of attachment 97016 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review > > Isn't there any additional files that need to be compiled? Otherwise looks good. Compiling is fine without any additional files, but we need to investigate move for using those icon. > > > ChangeLog:8 > > + Add feature to enable or disable ENABLE_TOUCH_ICON which support > > supports > > > Source/cmakeconfig.h.cmake:39 > > +#cmakedefine01 ENABLE_TOUCH_ICO_LOADING > > ICON Thanks, done. 420349 5 lucas.de.marchi 2011-06-14 05:51:09 -0700 (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 97016 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review > > > > Isn't there any additional files that need to be compiled? Otherwise looks good. > Compiling is fine without any additional files, but we need to investigate move for using those icon. If there are any file that is not specific to EFL or another port, It should be added on this patch as well. You can easily checking this by investigating the build system of other ports that enable this feature (removing the platform/PORT/* and xxxxxPORT.[c|h] files) 420445 6 97066 eric 2011-06-14 08:48:54 -0700 Comment on attachment 97066 Patch OK. 420491 7 97066 webkit.review.bot 2011-06-14 09:29:28 -0700 Comment on attachment 97066 Patch Clearing flags on attachment: 97066 Committed r88809: <http://trac.webkit.org/changeset/88809> 420492 8 webkit.review.bot 2011-06-14 09:29:33 -0700 All reviewed patches have been landed. Closing bug. 97016 2011-06-13 15:22:16 -0700 2011-06-13 22:05:31 -0700 Patch bug-62604-20110614072214.patch text/plain 2069 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODg2OTkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAxZGMwZWRmYmNjM2M5NmI4ZjYyYzI1MmUzZDNlMDU5YjkyZmIxNmE3Li40Y2Uw ZDg0MGJiOGFmODYwZDI2NWQ3YWU2NTYxMmE1MDk4NjQ4NjczIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMTMgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gQWRkIEVOQUJMRV9UT1VDSF9JQ09OX0xPQURJ TkcgZmVhdHVyZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyNjA0CisKKyAgICAgICAgQWRkIGZlYXR1cmUgdG8gZW5hYmxlIG9yIGRpc2FibGUgRU5B QkxFX1RPVUNIX0lDT04gd2hpY2ggc3VwcG9ydAorICAgICAgICBhcHBsZS10b3VjaC1pY29uIGFu ZCBhcHBsZS10b3VjaC1pY29uLXByZWNvbXBvc2VkIGluIGxpbmsgdGFnLgorCisgICAgICAgICog U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlY29u ZmlnLmguY21ha2U6CisKIDIwMTEtMDYtMTAgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFy Y2hpQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2Ug Yi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCAzZDkyNGExMTA1NzcyZDc1ODMz YTQxMDBiNTEyM2RhNmJiZTczMzg4Li4xOTYzYWJkODQzMmIwMzQ2YjhmMGQ1ZDE0MmQ1MjMwNTU4 ZWM5MWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9T b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtOTEsNiArOTEsNyBAQCBXRUJLSVRfRkVB VFVSRShFTkFCTEVfU1ZHX0ZPTlRTICJFbmFibGUgU1ZHIGZvbnRzIiBERUZBVUxUIE9OIFNWRykK IFdFQktJVF9GRUFUVVJFKEVOQUJMRV9TVkdfRk9SRUlHTl9PQkpFQ1QgIkVuYWJsZSBTVkcgZm9y ZWlnbiBvYmplY3QiIERFRkFVTFQgT04gU1ZHKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1NWR19V U0UgIkVuYWJsZSBTVkcgdXNlIiBERUZBVUxUIE9OIFNWRykKIFdFQktJVF9GRUFUVVJFKEVOQUJM RV9UT1VDSF9FVkVOVFMgIkVuYWJsZSBUb3VjaCBFdmVudHMiIERFRkFVTFQgT0ZGKQorV0VCS0lU X0ZFQVRVUkUoRU5BQkxFX1RPVUNIX0lDT05fTE9BRElORyAiRW5hYmxlIFRvdWNoIEljb24gTG9h ZGluZyIgREVGQVVMVCBPRkYpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfVklERU8gIkVuYWJsZSB2 aWRlbyIgREVGQVVMVCBPTiBIVE1MKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1dFQl9TT0NLRVRT ICJFbmFibGUgd2ViIHNvY2tldHMiIERFRkFVTFQgT0ZGKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxF X1dPUktFUlMgIkVuYWJsZSB3b3JrZXJzIiBERUZBVUxUIE9OKQpkaWZmIC0tZ2l0IGEvU291cmNl L2NtYWtlY29uZmlnLmguY21ha2UgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRleCA5 YWM2ZTI2N2Q0NWEyNTExODczNzY0YjkzZmQzYWM5NzAyNmUyYjVlLi4xODE3Mjg2N2E1YjUwZTc1 YmIxODVmNDA4ZjI3YTU5ZDgwMzBmMjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Vjb25maWcu aC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQpAQCAtMzYsNiArMzYsNyBA QAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVAogI2NtYWtlZGVmaW5l MDEgRU5BQkxFX1NWR19VU0UKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9UT1VDSF9FVkVOVFMKKyNj bWFrZWRlZmluZTAxIEVOQUJMRV9UT1VDSF9JQ09fTE9BRElORwogI2NtYWtlZGVmaW5lMDEgRU5B QkxFX1ZJREVPCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfV0VCR0wKICNjbWFrZWRlZmluZTAxIEVO QUJMRV9XRUJfU09DS0VUUwo= 97066 2011-06-13 22:05:38 -0700 2011-06-14 09:29:28 -0700 Patch bug-62604-20110614140535.patch text/plain 2050 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODg3NDIKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCA1ZTQyNmE2MDZiMmNkODJiOGI3NDBiNDQ4NzlmNTEzMzJlMzk2ODMyLi5iMWE5 NTk1OTc3ZDBiOGM1MzNkYzBkMzNmZDgxN2I3NzkwMmM0YzQzIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMTMgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gQWRkIEVOQUJMRV9UT1VDSF9JQ09OX0xPQURJ TkcgZmVhdHVyZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyNjA0CisKKyAgICAgICAgQWRkIGZlYXR1cmUgdG8gZW5hYmxlIG9yIGRpc2FibGUgRU5B QkxFX1RPVUNIX0lDT04gd2hpY2ggc3VwcG9ydHMKKyAgICAgICAgYXBwbGUtdG91Y2gtaWNvbiBh bmQgYXBwbGUtdG91Y2gtaWNvbi1wcmVjb21wb3NlZCBpbiBsaW5rIHRhZy4KKworICAgICAgICAq IFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZWNv bmZpZy5oLmNtYWtlOgorCiAyMDExLTA2LTEzICBKb29uZSBIdXIgIDxqb29uZS5odXJAY29sbGFi b3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlv bnNFZmwuY21ha2UKaW5kZXggM2Q5MjRhMTEwNTc3MmQ3NTgzM2E0MTAwYjUxMjNkYTZiYmU3MzM4 OC4uMTk2M2FiZDg0MzJiMDM0NmI4ZjBkNWQxNDJkNTIzMDU1OGVjOTFmNiAxMDA2NDQKLS0tIGEv U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNF ZmwuY21ha2UKQEAgLTkxLDYgKzkxLDcgQEAgV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1NWR19GT05U UyAiRW5hYmxlIFNWRyBmb250cyIgREVGQVVMVCBPTiBTVkcpCiBXRUJLSVRfRkVBVFVSRShFTkFC TEVfU1ZHX0ZPUkVJR05fT0JKRUNUICJFbmFibGUgU1ZHIGZvcmVpZ24gb2JqZWN0IiBERUZBVUxU IE9OIFNWRykKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9TVkdfVVNFICJFbmFibGUgU1ZHIHVzZSIg REVGQVVMVCBPTiBTVkcpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfVE9VQ0hfRVZFTlRTICJFbmFi bGUgVG91Y2ggRXZlbnRzIiBERUZBVUxUIE9GRikKK1dFQktJVF9GRUFUVVJFKEVOQUJMRV9UT1VD SF9JQ09OX0xPQURJTkcgIkVuYWJsZSBUb3VjaCBJY29uIExvYWRpbmciIERFRkFVTFQgT0ZGKQog V0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1ZJREVPICJFbmFibGUgdmlkZW8iIERFRkFVTFQgT04gSFRN TCkKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9XRUJfU09DS0VUUyAiRW5hYmxlIHdlYiBzb2NrZXRz IiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9XT1JLRVJTICJFbmFibGUgd29y a2VycyIgREVGQVVMVCBPTikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtl IGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKaW5kZXggNWNiZWJhYzQ2NWQ2YTYyNjgzNmJm ZDhjNzliZGVhZDE2NGMyOWUyOS4uZWJhNGFjMGUyMjI1YWU4ZWI0MmNkMTA0YWZjYWM1MzcxZDQ4 NmEzZCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKKysrIGIvU291cmNl L2NtYWtlY29uZmlnLmguY21ha2UKQEAgLTM3LDYgKzM3LDcgQEAKICNjbWFrZWRlZmluZTAxIEVO QUJMRV9TVkdfRk9SRUlHTl9PQkpFQ1QKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9TVkdfVVNFCiAj Y21ha2VkZWZpbmUwMSBFTkFCTEVfVE9VQ0hfRVZFTlRTCisjY21ha2VkZWZpbmUwMSBFTkFCTEVf VE9VQ0hfSUNPTl9MT0FESU5HCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfVklERU8KICNjbWFrZWRl ZmluZTAxIEVOQUJMRV9XRUJHTAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1dFQl9TT0NLRVRTCg==