<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>62603</bug_id>
          
          <creation_ts>2011-06-13 15:06:18 -0700</creation_ts>
          <short_desc>Run run-api-tests on bots in debug mode</short_desc>
          <delta_ts>2011-06-17 17:23:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>57513</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Dmitry Lomov">dslomov</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aroben</cc>
    
    <cc>dbates</cc>
    
    <cc>dslomov</cc>
    
    <cc>levin</cc>
    
    <cc>rniwa</cc>
    
    <cc>slewis</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>419919</commentid>
    <comment_count>0</comment_count>
    <who name="Dmitry Lomov">dslomov</who>
    <bug_when>2011-06-13 15:06:18 -0700</bug_when>
    <thetext>Make sure TestWebKitAPI runs on bots in debug mode at least. (61812 prevents us from running in release mode yet)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419933</commentid>
    <comment_count>1</comment_count>
      <attachid>97015</attachid>
    <who name="Dmitry Lomov">dslomov</who>
    <bug_when>2011-06-13 15:14:29 -0700</bug_when>
    <thetext>Created attachment 97015
Proposed fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419942</commentid>
    <comment_count>2</comment_count>
      <attachid>97015</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-06-13 15:17:52 -0700</bug_when>
    <thetext>Comment on attachment 97015
Proposed fix

Why only debug mode?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419945</commentid>
    <comment_count>3</comment_count>
      <attachid>97015</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-06-13 15:18:29 -0700</bug_when>
    <thetext>Comment on attachment 97015
Proposed fix

I see.  We should add a comment pointing to the bug which blocks running them in release mode.  Otherwise this looks OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419961</commentid>
    <comment_count>4</comment_count>
      <attachid>97017</attachid>
    <who name="Dmitry Lomov">dslomov</who>
    <bug_when>2011-06-13 15:25:48 -0700</bug_when>
    <thetext>Created attachment 97017
Added comment explaining why debug mode only</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421649</commentid>
    <comment_count>5</comment_count>
      <attachid>97017</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-06-15 17:23:01 -0700</bug_when>
    <thetext>Comment on attachment 97017
Added comment explaining why debug mode only 

This looks good to me. If no one else has objections, I&apos;ll r+ it tomorrow.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421653</commentid>
    <comment_count>6</comment_count>
      <attachid>97017</attachid>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2011-06-15 17:30:08 -0700</bug_when>
    <thetext>Comment on attachment 97017
Added comment explaining why debug mode only 

View in context: https://bugs.webkit.org/attachment.cgi?id=97017&amp;action=review

Jus the one question, otherwise r=me

&gt; Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:556
&gt; +        self.addStep(RunUnitTests)

How come we don&apos;t need to check for debug here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421654</commentid>
    <comment_count>7</comment_count>
      <attachid>97017</attachid>
    <who name="Dmitry Lomov">dslomov</who>
    <bug_when>2011-06-15 17:32:13 -0700</bug_when>
    <thetext>Comment on attachment 97017
Added comment explaining why debug mode only 

View in context: https://bugs.webkit.org/attachment.cgi?id=97017&amp;action=review

&gt;&gt; Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:556
&gt;&gt; +        self.addStep(RunUnitTests)
&gt; 
&gt; How come we don&apos;t need to check for debug here?

Oh right - good catch! Do we have bots that both build and test?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421658</commentid>
    <comment_count>8</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2011-06-15 17:38:05 -0700</bug_when>
    <thetext>Yes. SnowLeopard Leaks, some QT and GTK bots, and some of the Chromium new-run-webkit-tests bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421668</commentid>
    <comment_count>9</comment_count>
      <attachid>97378</attachid>
    <who name="Dmitry Lomov">dslomov</who>
    <bug_when>2011-06-15 17:47:17 -0700</bug_when>
    <thetext>Created attachment 97378
BuildAndTestFactory fixed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421706</commentid>
    <comment_count>10</comment_count>
      <attachid>97378</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2011-06-15 19:22:41 -0700</bug_when>
    <thetext>Comment on attachment 97378
BuildAndTestFactory fixed

Something must be wrong. There is no change between this patch and the previous one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422000</commentid>
    <comment_count>11</comment_count>
      <attachid>97453</attachid>
    <who name="Dmitry Lomov">dslomov</who>
    <bug_when>2011-06-16 09:44:34 -0700</bug_when>
    <thetext>Created attachment 97453
Uploading correct patch this time

Ugh - sorry for the noise - I do not know what happened.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422118</commentid>
    <comment_count>12</comment_count>
      <attachid>97453</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-06-16 11:46:55 -0700</bug_when>
    <thetext>Comment on attachment 97453
Uploading correct patch this time

Clearing flags on attachment: 97453

Committed r89054: &lt;http://trac.webkit.org/changeset/89054&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422119</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-06-16 11:47:00 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422959</commentid>
    <comment_count>14</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-06-17 17:09:42 -0700</bug_when>
    <thetext>api tests are failing on SL debug tests after this patch was landed:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/723</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422968</commentid>
    <comment_count>15</comment_count>
      <attachid>97453</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-06-17 17:22:02 -0700</bug_when>
    <thetext>Comment on attachment 97453
Uploading correct patch this time

View in context: https://bugs.webkit.org/attachment.cgi?id=97453&amp;action=review

&gt; Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:316
&gt; +    command = [&quot;perl&quot;, &quot;./Tools/Scripts/run-api-tests&quot;]

We should pass the configuration (i.e. Debug/Release) to run-api-tests so that it can call build-api-tests with this configuration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>422969</commentid>
    <comment_count>16</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-06-17 17:23:04 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; We should pass the configuration (i.e. Debug/Release) to run-api-tests so that it can call build-api-tests with this configuration.

Dmitry Lomov filed bug #62918 with regards to this issue.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97015</attachid>
            <date>2011-06-13 15:14:29 -0700</date>
            <delta_ts>2011-06-13 15:25:48 -0700</delta_ts>
            <desc>Proposed fix</desc>
            <filename>62603.patch</filename>
            <type>text/plain</type>
            <size>2132</size>
            <attacher name="Dmitry Lomov">dslomov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u
ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn
LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGU3NzhjOTUuLmM4OWY3Y2YgMTAwNjQ0Ci0tLSBhL1Rv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK
KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz
dGVyLmNmZwpAQCAtMzA5LDYgKzMwOSwxMiBAQCBjbGFzcyBOZXdSdW5XZWJLaXRUZXN0cyhSdW5X
ZWJLaXRUZXN0cyk6CiAKICAgICAgICAgcmV0dXJuIHJlc3VsdAogCitjbGFzcyBSdW5Vbml0VGVz
dHMoc2hlbGwuVGVzdCk6CisgICAgbmFtZSA9ICJydW4tYXBpLXRlc3RzIgorICAgIGRlc2NyaXB0
aW9uID0gWyJ1bml0IHRlc3RzIHJ1bm5pbmciXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsidW5p
dC10ZXN0cyJdCisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLWFw
aS10ZXN0cyJdCisKIGNsYXNzIFJ1blB5dGhvblRlc3RzKHNoZWxsLlRlc3QpOgogICAgIG5hbWUg
PSAid2Via2l0cHktdGVzdCIKICAgICBkZXNjcmlwdGlvbiA9IFsicHl0aG9uLXRlc3RzIHJ1bm5p
bmciXQpAQCAtNTIxLDYgKzUyNyw4IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAg
ICAgICBzZWxmLmFkZFN0ZXAoRXh0cmFjdEJ1aWx0UHJvZHVjdCkKICAgICAgICAgc2VsZi5hZGRT
dGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMsIHNraXBCdWlsZD1UcnVlKQogICAgICAgICBzZWxm
LmFkZFN0ZXAoc2VsZi5UZXN0Q2xhc3MsIHNraXBCdWlsZD0ocGxhdGZvcm0gPT0gJ3dpbicpKQor
ICAgICAgICBpZiBjb25maWd1cmF0aW9uID09ICJkZWJ1ZyI6CisgICAgICAgICAgICBzZWxmLmFk
ZFN0ZXAoUnVuVW5pdFRlc3RzKQogICAgICAgICAjIFRpZ2VyJ3MgUHl0aG9uIDIuMyBpcyB0b28g
b2xkLiAgV2ViS2l0IFB5dGhvbiByZXF1aXJlcyAyLjUrLgogICAgICAgICAjIFNhZGx5IHdlIGhh
dmUgbm8gd2F5IHRvIGRldGVjdCB0aGUgdmVyc2lvbiBvbiB0aGUgc2xhdmUgZnJvbSBoZXJlLgog
ICAgICAgICBpZiBwbGF0Zm9ybSAhPSAibWFjLXRpZ2VyIjoKQEAgLTU0Myw2ICs1NTEsNyBAQCBj
bGFzcyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBpZiBwbGF0Zm9ybS5z
dGFydHN3aXRoKCJjaHJvbWl1bSIpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkNocm9t
aXVtV2ViS2l0VW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5UZXN0Q2xhc3Mp
CisgICAgICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0VGVzdHMpCiAgICAgICAgICMgVGlnZXIncyBQ
eXRob24gMi4zIGlzIHRvbyBvbGQuICBXZWJLaXQgUHl0aG9uIHJlcXVpcmVzIDIuNSsuCiAgICAg
ICAgICMgU2FkbHkgd2UgaGF2ZSBubyB3YXkgdG8gZGV0ZWN0IHRoZSB2ZXJzaW9uIG9uIHRoZSBz
bGF2ZSBmcm9tIGhlcmUuCiAgICAgICAgICMgQ2hyb21pdW0gV2luIHJ1bnMgaW4gbm9uLUN5Z3dp
biBlbnZpcm9ubWVudCwgd2hpY2ggaXMgbm90IHlldCBmaXQKZGlmZiAtLWdpdCBhL1Rvb2xzL0No
YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OTJlM2YxLi5iYTA4MTEzIDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTEtMDYtMTMgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI2MDMKKyAgICAgICAgUnVuIHJ1bi1hcGktdGVz
dHMgb24gYm90cyBpbiBkZWJ1ZyBtb2RlLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQv
YnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwogMjAxMS0wNi0xMyAgU2hlcmlm
ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl
ZCwgcm9sbGluZyBvdXQgcjg4NjcxLgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97017</attachid>
            <date>2011-06-13 15:25:48 -0700</date>
            <delta_ts>2011-06-15 17:47:17 -0700</delta_ts>
            <desc>Added comment explaining why debug mode only </desc>
            <filename>62603.patch</filename>
            <type>text/plain</type>
            <size>2321</size>
            <attacher name="Dmitry Lomov">dslomov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u
ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn
LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGU3NzhjOTUuLjk4NGE4ZGYgMTAwNjQ0Ci0tLSBhL1Rv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK
KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz
dGVyLmNmZwpAQCAtMzA5LDYgKzMwOSwxMiBAQCBjbGFzcyBOZXdSdW5XZWJLaXRUZXN0cyhSdW5X
ZWJLaXRUZXN0cyk6CiAKICAgICAgICAgcmV0dXJuIHJlc3VsdAogCitjbGFzcyBSdW5Vbml0VGVz
dHMoc2hlbGwuVGVzdCk6CisgICAgbmFtZSA9ICJydW4tYXBpLXRlc3RzIgorICAgIGRlc2NyaXB0
aW9uID0gWyJ1bml0IHRlc3RzIHJ1bm5pbmciXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsidW5p
dC10ZXN0cyJdCisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLWFw
aS10ZXN0cyJdCisKIGNsYXNzIFJ1blB5dGhvblRlc3RzKHNoZWxsLlRlc3QpOgogICAgIG5hbWUg
PSAid2Via2l0cHktdGVzdCIKICAgICBkZXNjcmlwdGlvbiA9IFsicHl0aG9uLXRlc3RzIHJ1bm5p
bmciXQpAQCAtNTIxLDYgKzUyNywxMCBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAg
ICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFByb2R1Y3QpCiAgICAgICAgIHNlbGYuYWRk
U3RlcChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBza2lwQnVpbGQ9VHJ1ZSkKICAgICAgICAgc2Vs
Zi5hZGRTdGVwKHNlbGYuVGVzdENsYXNzLCBza2lwQnVpbGQ9KHBsYXRmb3JtID09ICd3aW4nKSkK
KworICAgICAgICAjIEZJWE1FOiBPbmx5IHJ1bm5pbmcgaW4gZGVidWcgbW9kZSBkdWUgdG8gaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODEyCisgICAgICAgIGlmIGNv
bmZpZ3VyYXRpb24gPT0gImRlYnVnIjoKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0
VGVzdHMpCiAgICAgICAgICMgVGlnZXIncyBQeXRob24gMi4zIGlzIHRvbyBvbGQuICBXZWJLaXQg
UHl0aG9uIHJlcXVpcmVzIDIuNSsuCiAgICAgICAgICMgU2FkbHkgd2UgaGF2ZSBubyB3YXkgdG8g
ZGV0ZWN0IHRoZSB2ZXJzaW9uIG9uIHRoZSBzbGF2ZSBmcm9tIGhlcmUuCiAgICAgICAgIGlmIHBs
YXRmb3JtICE9ICJtYWMtdGlnZXIiOgpAQCAtNTQzLDYgKzU1Myw3IEBAIGNsYXNzIEJ1aWxkQW5k
VGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoImNo
cm9taXVtIik6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQ2hyb21pdW1XZWJLaXRVbml0
VGVzdHMpCiAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxmLlRlc3RDbGFzcykKKyAgICAgICAgc2Vs
Zi5hZGRTdGVwKFJ1blVuaXRUZXN0cykKICAgICAgICAgIyBUaWdlcidzIFB5dGhvbiAyLjMgaXMg
dG9vIG9sZC4gIFdlYktpdCBQeXRob24gcmVxdWlyZXMgMi41Ky4KICAgICAgICAgIyBTYWRseSB3
ZSBoYXZlIG5vIHdheSB0byBkZXRlY3QgdGhlIHZlcnNpb24gb24gdGhlIHNsYXZlIGZyb20gaGVy
ZS4KICAgICAgICAgIyBDaHJvbWl1bSBXaW4gcnVucyBpbiBub24tQ3lnd2luIGVudmlyb25tZW50
LCB3aGljaCBpcyBub3QgeWV0IGZpdApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v
bHMvQ2hhbmdlTG9nCmluZGV4IDg5MmUzZjEuLjI5M2I2YmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No
YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNi0x
MyAgRG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD02MjYwMworICAgICAgICBSdW4gcnVuLWFwaS10ZXN0cyBvbiBib3RzIGlu
IGRlYnVnIG1vZGUuCisgICAgICAgIFJlbGVhc2UgbW9kZSBpcyBkaXNhYmxlZCBkdWUgdG8gaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODEyLgorCisgICAgICAgICog
QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwog
MjAxMS0wNi0xMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK
ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg4NjcxLgo=
</data>
<flag name="review"
          id="90842"
          type_id="1"
          status="+"
          setter="slewis"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97378</attachid>
            <date>2011-06-15 17:47:17 -0700</date>
            <delta_ts>2011-06-16 09:44:34 -0700</delta_ts>
            <desc>BuildAndTestFactory fixed</desc>
            <filename>62603.patch</filename>
            <type>text/plain</type>
            <size>2321</size>
            <attacher name="Dmitry Lomov">dslomov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u
ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn
LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGU3NzhjOTUuLjk4NGE4ZGYgMTAwNjQ0Ci0tLSBhL1Rv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK
KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz
dGVyLmNmZwpAQCAtMzA5LDYgKzMwOSwxMiBAQCBjbGFzcyBOZXdSdW5XZWJLaXRUZXN0cyhSdW5X
ZWJLaXRUZXN0cyk6CiAKICAgICAgICAgcmV0dXJuIHJlc3VsdAogCitjbGFzcyBSdW5Vbml0VGVz
dHMoc2hlbGwuVGVzdCk6CisgICAgbmFtZSA9ICJydW4tYXBpLXRlc3RzIgorICAgIGRlc2NyaXB0
aW9uID0gWyJ1bml0IHRlc3RzIHJ1bm5pbmciXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsidW5p
dC10ZXN0cyJdCisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLWFw
aS10ZXN0cyJdCisKIGNsYXNzIFJ1blB5dGhvblRlc3RzKHNoZWxsLlRlc3QpOgogICAgIG5hbWUg
PSAid2Via2l0cHktdGVzdCIKICAgICBkZXNjcmlwdGlvbiA9IFsicHl0aG9uLXRlc3RzIHJ1bm5p
bmciXQpAQCAtNTIxLDYgKzUyNywxMCBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAg
ICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFByb2R1Y3QpCiAgICAgICAgIHNlbGYuYWRk
U3RlcChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBza2lwQnVpbGQ9VHJ1ZSkKICAgICAgICAgc2Vs
Zi5hZGRTdGVwKHNlbGYuVGVzdENsYXNzLCBza2lwQnVpbGQ9KHBsYXRmb3JtID09ICd3aW4nKSkK
KworICAgICAgICAjIEZJWE1FOiBPbmx5IHJ1bm5pbmcgaW4gZGVidWcgbW9kZSBkdWUgdG8gaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODEyCisgICAgICAgIGlmIGNv
bmZpZ3VyYXRpb24gPT0gImRlYnVnIjoKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0
VGVzdHMpCiAgICAgICAgICMgVGlnZXIncyBQeXRob24gMi4zIGlzIHRvbyBvbGQuICBXZWJLaXQg
UHl0aG9uIHJlcXVpcmVzIDIuNSsuCiAgICAgICAgICMgU2FkbHkgd2UgaGF2ZSBubyB3YXkgdG8g
ZGV0ZWN0IHRoZSB2ZXJzaW9uIG9uIHRoZSBzbGF2ZSBmcm9tIGhlcmUuCiAgICAgICAgIGlmIHBs
YXRmb3JtICE9ICJtYWMtdGlnZXIiOgpAQCAtNTQzLDYgKzU1Myw3IEBAIGNsYXNzIEJ1aWxkQW5k
VGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoImNo
cm9taXVtIik6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQ2hyb21pdW1XZWJLaXRVbml0
VGVzdHMpCiAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxmLlRlc3RDbGFzcykKKyAgICAgICAgc2Vs
Zi5hZGRTdGVwKFJ1blVuaXRUZXN0cykKICAgICAgICAgIyBUaWdlcidzIFB5dGhvbiAyLjMgaXMg
dG9vIG9sZC4gIFdlYktpdCBQeXRob24gcmVxdWlyZXMgMi41Ky4KICAgICAgICAgIyBTYWRseSB3
ZSBoYXZlIG5vIHdheSB0byBkZXRlY3QgdGhlIHZlcnNpb24gb24gdGhlIHNsYXZlIGZyb20gaGVy
ZS4KICAgICAgICAgIyBDaHJvbWl1bSBXaW4gcnVucyBpbiBub24tQ3lnd2luIGVudmlyb25tZW50
LCB3aGljaCBpcyBub3QgeWV0IGZpdApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v
bHMvQ2hhbmdlTG9nCmluZGV4IDg5MmUzZjEuLjI5M2I2YmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No
YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNi0x
MyAgRG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD02MjYwMworICAgICAgICBSdW4gcnVuLWFwaS10ZXN0cyBvbiBib3RzIGlu
IGRlYnVnIG1vZGUuCisgICAgICAgIFJlbGVhc2UgbW9kZSBpcyBkaXNhYmxlZCBkdWUgdG8gaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODEyLgorCisgICAgICAgICog
QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwog
MjAxMS0wNi0xMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK
ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg4NjcxLgo=
</data>
<flag name="review"
          id="91307"
          type_id="1"
          status="-"
          setter="levin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97453</attachid>
            <date>2011-06-16 09:44:34 -0700</date>
            <delta_ts>2011-06-17 17:22:02 -0700</delta_ts>
            <desc>Uploading correct patch this time</desc>
            <filename>62603.patch</filename>
            <type>text/plain</type>
            <size>2451</size>
            <attacher name="Dmitry Lomov">dslomov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u
ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn
LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGU3NzhjOTUuLmU2NmE4YzAgMTAwNjQ0Ci0tLSBhL1Rv
b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK
KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz
dGVyLmNmZwpAQCAtMzA5LDYgKzMwOSwxMiBAQCBjbGFzcyBOZXdSdW5XZWJLaXRUZXN0cyhSdW5X
ZWJLaXRUZXN0cyk6CiAKICAgICAgICAgcmV0dXJuIHJlc3VsdAogCitjbGFzcyBSdW5Vbml0VGVz
dHMoc2hlbGwuVGVzdCk6CisgICAgbmFtZSA9ICJydW4tYXBpLXRlc3RzIgorICAgIGRlc2NyaXB0
aW9uID0gWyJ1bml0IHRlc3RzIHJ1bm5pbmciXQorICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsidW5p
dC10ZXN0cyJdCisgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLWFw
aS10ZXN0cyJdCisKIGNsYXNzIFJ1blB5dGhvblRlc3RzKHNoZWxsLlRlc3QpOgogICAgIG5hbWUg
PSAid2Via2l0cHktdGVzdCIKICAgICBkZXNjcmlwdGlvbiA9IFsicHl0aG9uLXRlc3RzIHJ1bm5p
bmciXQpAQCAtNTIxLDYgKzUyNywxMCBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAg
ICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFByb2R1Y3QpCiAgICAgICAgIHNlbGYuYWRk
U3RlcChSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBza2lwQnVpbGQ9VHJ1ZSkKICAgICAgICAgc2Vs
Zi5hZGRTdGVwKHNlbGYuVGVzdENsYXNzLCBza2lwQnVpbGQ9KHBsYXRmb3JtID09ICd3aW4nKSkK
KworICAgICAgICAjIEZJWE1FOiBPbmx5IHJ1bm5pbmcgaW4gZGVidWcgbW9kZSBkdWUgdG8gaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxODEyCisgICAgICAgIGlmIGNv
bmZpZ3VyYXRpb24gPT0gImRlYnVnIjoKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0
VGVzdHMpCiAgICAgICAgICMgVGlnZXIncyBQeXRob24gMi4zIGlzIHRvbyBvbGQuICBXZWJLaXQg
UHl0aG9uIHJlcXVpcmVzIDIuNSsuCiAgICAgICAgICMgU2FkbHkgd2UgaGF2ZSBubyB3YXkgdG8g
ZGV0ZWN0IHRoZSB2ZXJzaW9uIG9uIHRoZSBzbGF2ZSBmcm9tIGhlcmUuCiAgICAgICAgIGlmIHBs
YXRmb3JtICE9ICJtYWMtdGlnZXIiOgpAQCAtNTQzLDYgKzU1Myw5IEBAIGNsYXNzIEJ1aWxkQW5k
VGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoImNo
cm9taXVtIik6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQ2hyb21pdW1XZWJLaXRVbml0
VGVzdHMpCiAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxmLlRlc3RDbGFzcykKKyAgICAgICAgIyBG
SVhNRTogT25seSBydW5uaW5nIGluIGRlYnVnIG1vZGUgZHVlIHRvIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTgxMgorICAgICAgICBpZiBjb25maWd1cmF0aW9uID09
ICJkZWJ1ZyI6CisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuVW5pdFRlc3RzKQogICAgICAg
ICAjIFRpZ2VyJ3MgUHl0aG9uIDIuMyBpcyB0b28gb2xkLiAgV2ViS2l0IFB5dGhvbiByZXF1aXJl
cyAyLjUrLgogICAgICAgICAjIFNhZGx5IHdlIGhhdmUgbm8gd2F5IHRvIGRldGVjdCB0aGUgdmVy
c2lvbiBvbiB0aGUgc2xhdmUgZnJvbSBoZXJlLgogICAgICAgICAjIENocm9taXVtIFdpbiBydW5z
IGluIG5vbi1DeWd3aW4gZW52aXJvbm1lbnQsIHdoaWNoIGlzIG5vdCB5ZXQgZml0CmRpZmYgLS1n
aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQwYmRhNC4uNjlk
MzQ4NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDEzIEBACisyMDExLTA2LTEzICBEbWl0cnkgTG9tb3YgIDxkc2xvbW92QGdvb2ds
ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNjAzCisgICAgICAgIFJ1
biBydW4tYXBpLXRlc3RzIG9uIGJvdHMgaW4gZGVidWcgbW9kZS4KKyAgICAgICAgUmVsZWFzZSBt
b2RlIGlzIGRpc2FibGVkIGR1ZSB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9NjE4MTIuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu
b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorCiAyMDExLTA2LTE1ICBKZXJlbXkgT3Jsb3cgIDxqb3Js
b3dAd2Via2l0Lm9yZz4KIAogICAgICAgICBDaGFuZ2UgbXkgZW1haWwgdG8gQHdlYmtpdC5vcmcK
</data>

          </attachment>
      

    </bug>

</bugzilla>