62600 2011-06-13 14:39:03 -0700 Make it possible to inline the common case of identifier parsing 2011-06-13 15:48:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 419881 0 oliver 2011-06-13 14:39:03 -0700 Make it possible to inline the common case of identifier parsing 419888 1 97011 oliver 2011-06-13 14:44:28 -0700 Created attachment 97011 Patch 419978 2 97011 barraclough 2011-06-13 15:33:06 -0700 Comment on attachment 97011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97011&action=review > Source/JavaScriptCore/parser/Lexer.h:92 > + JSTokenType lexExpectIdentifier(JSTokenData* lvalp, JSTokenInfo* llocp, unsigned, bool strictMode); lvalp, llocp (1) These are not necessary in the header. (2) Say 20 Hail Marys, and please to be making these variables to have the better names. 97011 2011-06-13 14:44:28 -0700 2011-06-13 15:33:06 -0700 Patch bug-62600-20110613144427.patch text/plain 6228 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODg2OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFi OThkMjNlMzM4MDExMWMzYWJjNDk0OTEyZDEyZWFkOGQ1ZTQ5ZGYuLjIwODgwNjAwMjE0YTE0ZGMx YjA5MTQwMWJkYTI2YzI4NTYzMjQ1N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI0IEBACisyMDExLTA2LTEzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBpdCBw b3NzaWJsZSB0byBpbmxpbmUgdGhlIGNvbW1vbiBjYXNlIG9mIGlkZW50aWZpZXIgbGV4aW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjYwMAorCisg ICAgICAgIEFkZCBhIGxleGluZyBmdW5jdGlvbiB0aGF0IGV4cGVjdHMgdG8gbGV4IGFuICJub3Jt YWwiIGFscGhhIG51bWVyaWMKKyAgICAgICAgaWRlbnRpZmllciAodGhhdCBpZ25vcmVzIGtleXdv cmRzKSBzbyBpdCdzIHBvc3NpYmxlIHRvIGlubGluZSB0aGUKKyAgICAgICAgY29tbW9uIHBhcnNp bmcgY2FzZXMuICBUaGlzIGNvbWVzIG91dCBhcyBhIHJlYXNvbmFibGUgcGFyc2luZyBzcGVlZAor ICAgICAgICBib29zdC4KKworICAgICAgICAqIHBhcnNlci9KU1BhcnNlci5jcHA6CisgICAgICAg IChKU0M6OkpTUGFyc2VyOjpuZXh0RXhwZWN0SWRlbnRpZmllcik6CisgICAgICAgIChKU0M6OkpT UGFyc2VyOjpwYXJzZVByb3BlcnR5KToKKyAgICAgICAgKEpTQzo6SlNQYXJzZXI6OnBhcnNlTWVt YmVyRXhwcmVzc2lvbik6CisgICAgICAgICogcGFyc2VyL0xleGVyLmNwcDoKKyAgICAgICAgKiBw YXJzZXIvTGV4ZXIuaDoKKyAgICAgICAgKEpTQzo6TGV4ZXI6Om1ha2VJZGVudGlmaWVyKToKKyAg ICAgICAgKEpTQzo6TGV4ZXI6OmxleEV4cGVjdElkZW50aWZpZXIpOgorCiAyMDExLTA2LTEzICBY YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0 aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0pT UGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCmlu ZGV4IGEzZWE0NGRhZWYzMzZiZjU4MDg3NDdjMzA3Mjk3M2IyYmQ0ODBjNGMuLmQ1NjE1NWJkNDc5 NDg2MzMyZjRiYjY3MmJiN2Q0Njg4ZTk4ZDE0MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvSlNQYXJzZXIuY3BwCkBAIC0xMDcsNiArMTA3LDE0IEBAIHByaXZhdGU6CiAgICAgICAg IG1fdG9rZW4ubV90eXBlID0gbV9sZXhlci0+bGV4KCZtX3Rva2VuLm1fZGF0YSwgJm1fdG9rZW4u bV9pbmZvLCBsZXhUeXBlLCBzdHJpY3RNb2RlKCkpOwogICAgIH0KICAgICAKKyAgICBBTFdBWVNf SU5MSU5FIHZvaWQgbmV4dEV4cGVjdElkZW50aWZpZXIodW5zaWduZWQgbGV4VHlwZSA9IDApCisg ICAgeworICAgICAgICBtX2xhc3RMaW5lID0gbV90b2tlbi5tX2luZm8ubGluZTsKKyAgICAgICAg bV9sYXN0VG9rZW5FbmQgPSBtX3Rva2VuLm1faW5mby5lbmRPZmZzZXQ7CisgICAgICAgIG1fbGV4 ZXItPnNldExhc3RMaW5lTnVtYmVyKG1fbGFzdExpbmUpOworICAgICAgICBtX3Rva2VuLm1fdHlw ZSA9IG1fbGV4ZXItPmxleEV4cGVjdElkZW50aWZpZXIoJm1fdG9rZW4ubV9kYXRhLCAmbV90b2tl bi5tX2luZm8sIGxleFR5cGUsIHN0cmljdE1vZGUoKSk7CisgICAgfQorICAgIAogICAgIEFMV0FZ U19JTkxJTkUgYm9vbCBuZXh0VG9rZW5Jc0NvbG9uKCkKICAgICB7CiAgICAgICAgIHJldHVybiBt X2xleGVyLT5uZXh0VG9rZW5Jc0NvbG9uKCk7CkBAIC0xNzA3LDkgKzE3MTUsOSBAQCB0ZW1wbGF0 ZSA8Ym9vbCBjb21wbGV0ZSwgY2xhc3MgVHJlZUJ1aWxkZXI+IFRyZWVQcm9wZXJ0eSBKU1BhcnNl cjo6cGFyc2VQcm9wZXJ0eQogICAgIGNhc2UgU1RSSU5HOiB7CiAgICAgICAgIGNvbnN0IElkZW50 aWZpZXIqIGlkZW50ID0gbV90b2tlbi5tX2RhdGEuaWRlbnQ7CiAgICAgICAgIGlmIChjb21wbGV0 ZSB8fCAod2FzSWRlbnQgJiYgKCppZGVudCA9PSBtX2dsb2JhbERhdGEtPnByb3BlcnR5TmFtZXMt PmdldCB8fCAqaWRlbnQgPT0gbV9nbG9iYWxEYXRhLT5wcm9wZXJ0eU5hbWVzLT5zZXQpKSkKLSAg ICAgICAgICAgIG5leHQoTGV4ZXI6Oklnbm9yZVJlc2VydmVkV29yZHMpOworICAgICAgICAgICAg bmV4dEV4cGVjdElkZW50aWZpZXIoTGV4ZXI6Oklnbm9yZVJlc2VydmVkV29yZHMpOwogICAgICAg ICBlbHNlCi0gICAgICAgICAgICBuZXh0KExleGVyOjpJZ25vcmVSZXNlcnZlZFdvcmRzIHwgVHJl ZUJ1aWxkZXI6OkRvbnRCdWlsZEtleXdvcmRzKTsKKyAgICAgICAgICAgIG5leHRFeHBlY3RJZGVu dGlmaWVyKExleGVyOjpJZ25vcmVSZXNlcnZlZFdvcmRzIHwgVHJlZUJ1aWxkZXI6OkRvbnRCdWls ZEtleXdvcmRzKTsKIAogICAgICAgICBpZiAobWF0Y2goQ09MT04pKSB7CiAgICAgICAgICAgICBu ZXh0KCk7CkBAIC0yMDM4LDcgKzIwNDYsNyBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxkZXI+ IFRyZWVFeHByZXNzaW9uIEpTUGFyc2VyOjpwYXJzZU1lbWJlckV4cHJlc3Npb24oVHJlZQogICAg ICAgICBjYXNlIERPVDogewogICAgICAgICAgICAgbV9ub25Ucml2aWFsRXhwcmVzc2lvbkNvdW50 Kys7CiAgICAgICAgICAgICBpbnQgZXhwcmVzc2lvbkVuZCA9IGxhc3RUb2tlbkVuZCgpOwotICAg ICAgICAgICAgbmV4dChMZXhlcjo6SWdub3JlUmVzZXJ2ZWRXb3JkcyB8IFRyZWVCdWlsZGVyOjpE b250QnVpbGRLZXl3b3Jkcyk7CisgICAgICAgICAgICBuZXh0RXhwZWN0SWRlbnRpZmllcihMZXhl cjo6SWdub3JlUmVzZXJ2ZWRXb3JkcyB8IFRyZWVCdWlsZGVyOjpEb250QnVpbGRLZXl3b3Jkcyk7 CiAgICAgICAgICAgICBtYXRjaE9yRmFpbChJREVOVCk7CiAgICAgICAgICAgICBiYXNlID0gY29u dGV4dC5jcmVhdGVEb3RBY2Nlc3MoYmFzZSwgbV90b2tlbi5tX2RhdGEuaWRlbnQsIGV4cHJlc3Np b25TdGFydCwgZXhwcmVzc2lvbkVuZCwgdG9rZW5FbmQoKSk7CiAgICAgICAgICAgICBuZXh0KCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCmluZGV4IDY0YWUyNjRkNWI4NzFl NzQ3MjVkZmIwMTFjZjNjMGQ1NzY2MDc0MDMuLmIyNzA0NTVjOTI3MGZhNWI4OTY4MDhhY2FkODE5 N2ZkMWYxMTA0YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4 ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCkBAIC0z MzEsMTEgKzMzMSw2IEBAIHZvaWQgTGV4ZXI6OnNoaWZ0TGluZVRlcm1pbmF0b3IoKQogICAgICsr bV9saW5lTnVtYmVyOwogfQogCi1BTFdBWVNfSU5MSU5FIGNvbnN0IElkZW50aWZpZXIqIExleGVy OjptYWtlSWRlbnRpZmllcihjb25zdCBVQ2hhciogY2hhcmFjdGVycywgc2l6ZV90IGxlbmd0aCkK LXsKLSAgICByZXR1cm4gJm1fYXJlbmEtPm1ha2VJZGVudGlmaWVyKG1fZ2xvYmFsRGF0YSwgY2hh cmFjdGVycywgbGVuZ3RoKTsKLX0KLQogQUxXQVlTX0lOTElORSBib29sIExleGVyOjpsYXN0VG9r ZW5XYXNSZXN0cktleXdvcmQoKSBjb25zdAogewogICAgIHJldHVybiBtX2xhc3RUb2tlbiA9PSBD T05USU5VRSB8fCBtX2xhc3RUb2tlbiA9PSBCUkVBSyB8fCBtX2xhc3RUb2tlbiA9PSBSRVRVUk4g fHwgbV9sYXN0VG9rZW4gPT0gVEhST1c7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL0xleGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmgK aW5kZXggZWUwYTA4OTE5ZmQ5N2VkYzNjMzMyODdiNWZlNDRiNjViYzgxYmMxYi4uYmQ5NjkwYWI5 Zjc3NjA5NjJiMDcxODg0MTI5NDUwMjdjNDc2NjkyZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9MZXhlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJz ZXIvTGV4ZXIuaApAQCAtODgsNyArODgsOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgfQog CiAgICAgICAgIFNvdXJjZVByb3ZpZGVyKiBzb3VyY2VQcm92aWRlcigpIGNvbnN0IHsgcmV0dXJu IG1fc291cmNlLT5wcm92aWRlcigpOyB9Ci0KKyAgICAgICAgCisgICAgICAgIEpTVG9rZW5UeXBl IGxleEV4cGVjdElkZW50aWZpZXIoSlNUb2tlbkRhdGEqIGx2YWxwLCBKU1Rva2VuSW5mbyogbGxv Y3AsIHVuc2lnbmVkLCBib29sIHN0cmljdE1vZGUpOworICAgICAgICAKICAgICBwcml2YXRlOgog ICAgICAgICBmcmllbmQgY2xhc3MgSlNHbG9iYWxEYXRhOwogCkBAIC0xNzMsNiArMTc1LDU1IEBA IG5hbWVzcGFjZSBKU0MgewogICAgIHsKICAgICAgICAgcmV0dXJuIChjb252ZXJ0SGV4KGMxLCBj MikgPDwgOCkgfCBjb252ZXJ0SGV4KGMzLCBjNCk7CiAgICAgfQorICAgIAorICAgIEFMV0FZU19J TkxJTkUgY29uc3QgSWRlbnRpZmllciogTGV4ZXI6Om1ha2VJZGVudGlmaWVyKGNvbnN0IFVDaGFy KiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoKQorICAgIHsKKyAgICAgICAgcmV0dXJuICZtX2Fy ZW5hLT5tYWtlSWRlbnRpZmllcihtX2dsb2JhbERhdGEsIGNoYXJhY3RlcnMsIGxlbmd0aCk7Cisg ICAgfQorCisgICAgQUxXQVlTX0lOTElORSBKU1Rva2VuVHlwZSBMZXhlcjo6bGV4RXhwZWN0SWRl bnRpZmllcihKU1Rva2VuRGF0YSogbHZhbHAsIEpTVG9rZW5JbmZvKiBsbG9jcCwgdW5zaWduZWQg bGV4VHlwZSwgYm9vbCBzdHJpY3RNb2RlKQorICAgIHsKKyAgICAgICAgQVNTRVJUKChsZXhUeXBl ICYgSWdub3JlUmVzZXJ2ZWRXb3JkcykpOworICAgICAgICBjb25zdCBVQ2hhciogc3RhcnQgPSBt X2NvZGU7CisgICAgICAgIGNvbnN0IFVDaGFyKiBwdHIgPSBzdGFydDsKKyAgICAgICAgY29uc3Qg VUNoYXIqIGVuZCA9IG1fY29kZUVuZDsKKyAgICAgICAgaWYgKHB0ciA+PSBlbmQpIHsKKyAgICAg ICAgICAgIEFTU0VSVChwdHIgPT0gZW5kKTsKKyAgICAgICAgICAgIGdvdG8gc2xvd0Nhc2U7Cisg ICAgICAgIH0KKyAgICAgICAgaWYgKCFXVEY6OmlzQVNDSUlBbHBoYSgqcHRyKSkKKyAgICAgICAg ICAgIGdvdG8gc2xvd0Nhc2U7CisgICAgICAgICsrcHRyOworICAgICAgICB3aGlsZSAocHRyIDwg ZW5kKSB7CisgICAgICAgICAgICBpZiAoIVdURjo6aXNBU0NJSUFscGhhbnVtZXJpYygqcHRyKSkK KyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICsrcHRyOworICAgICAgICB9CisK KyAgICAgICAgLy8gSGVyZSdzIHRoZSBzaGlmdAorICAgICAgICBpZiAocHRyIDwgZW5kKSB7Cisg ICAgICAgICAgICBpZiAoIVdURjo6aXNBU0NJSSgqcHRyKSB8fCAoKnB0ciA9PSAnXFwnKSB8fCAo KnB0ciA9PSAnXycpKQorICAgICAgICAgICAgICAgIGdvdG8gc2xvd0Nhc2U7CisgICAgICAgICAg ICBtX2N1cnJlbnQgPSAqcHRyOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIG1fY3VycmVu dCA9IC0xOworCisgICAgICAgIG1fY29kZSA9IHB0cjsKKworICAgICAgICAvLyBDcmVhdGUgdGhl IGlkZW50aWZpZXIgaWYgbmVlZGVkCisgICAgICAgIGlmIChsZXhUeXBlICYgRG9udEJ1aWxkS2V5 d29yZHMpCisgICAgICAgICAgICBsdmFscC0+aWRlbnQgPSAwOworICAgICAgICBlbHNlCisgICAg ICAgICAgICBsdmFscC0+aWRlbnQgPSBtYWtlSWRlbnRpZmllcihzdGFydCwgcHRyIC0gc3RhcnQp OworICAgICAgICBsbG9jcC0+bGluZSA9IG1fbGluZU51bWJlcjsKKyAgICAgICAgbGxvY3AtPnN0 YXJ0T2Zmc2V0ID0gc3RhcnQgLSBtX2NvZGVTdGFydDsKKyAgICAgICAgbGxvY3AtPmVuZE9mZnNl dCA9IGN1cnJlbnRPZmZzZXQoKTsKKyAgICAgICAgbV9sYXN0VG9rZW4gPSBJREVOVDsKKyAgICAg ICAgcmV0dXJuIElERU5UOworICAgICAgICAKKyAgICBzbG93Q2FzZToKKyAgICAgICAgcmV0dXJu IGxleChsdmFscCwgbGxvY3AsIGxleFR5cGUsIHN0cmljdE1vZGUpOworICAgIH0KIAogfSAvLyBu YW1lc3BhY2UgSlNDCiAK