6259 2005-12-27 13:57:31 -0800 Handle negative, FP numbers with non-10 radix in toString 2005-12-30 00:13:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Other Linux RESOLVED FIXED P2 Normal --- 1 maksim webkit-unassigned oldest_to_newest 26797 0 maksim 2005-12-27 13:57:31 -0800 r260470 | porten | 2003-10-20 10:45:55 -0400 (Mon, 20 Oct 2003) | 2 lines This is a merge of: * number_object.cpp: rewrote Number.toString(radix) to work with negative numbers, floating point and very large numbers. As ammended by: r290299 | porten | 2004-02-22 13:32:05 -0500 (Sun, 22 Feb 2004) | 4 lines fixed crash if toString() is called on NaN or Inf with a radix != 10.) It's somewhat covered by KJS tests. 26798 1 5309 maksim 2005-12-27 13:58:10 -0800 Created attachment 5309 patch 27081 2 5309 mjs 2005-12-28 21:23:38 -0800 Comment on attachment 5309 patch I'll grant review because I think it's better to have this change than not. However: > + const double eps = 0.001; // TODO: guessed. base on radix ? That seems like a pretty high value for epsilon. > int(d) > double(radix) (in various places) - it would be better to avoid this cast syntax for numbers, I think. In some cases I think it is unnecesary, in other cases a normal c-style cast or assigning first to a variable of the appropriate type would be better. I think these improvements can be made in a separate pass though. 5309 2005-12-27 13:58:10 -0800 2005-12-28 21:23:38 -0800 patch num_obj.diff text/plain 2344 maksim SW5kZXg6IG51bWJlcl9vYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG51bWJlcl9vYmplY3QuY3Bw CShyZXZpc2lvbiA0OTE2NzUpCisrKyBudW1iZXJfb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMSw3ICsxLDcgQEAKIC8vIC0qLSBjLWJhc2ljLW9mZnNldDogMiAtKi0KIC8qCiAgKiAgVGhp cyBmaWxlIGlzIHBhcnQgb2YgdGhlIEtERSBsaWJyYXJpZXMKLSAqICBDb3B5cmlnaHQgKEMpIDE5 OTktMjAwMCBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQorICogIENvcHlyaWdodCAoQykg MTk5OS0yMDAwLDIwMDMgSGFycmkgUG9ydGVuIChwb3J0ZW5Aa2RlLm9yZykKICAqCiAgKiAgVGhp cyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v cgogICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJh bCBQdWJsaWMKQEAgLTE0MCwxNCArMTQwLDQ2IEBAIFZhbHVlSW1wICpOdW1iZXJQcm90b0Z1bmNJ bXA6OmNhbGxBc0Z1bmMKICAgICAgIGRyYWRpeCA9IGFyZ3NbMF0tPnRvSW50ZWdlcihleGVjKTsK ICAgICBpZiAoZHJhZGl4ID49IDIgJiYgZHJhZGl4IDw9IDM2ICYmIGRyYWRpeCAhPSAxMCkgeyAv LyBmYWxzZSBmb3IgTmFOCiAgICAgICBpbnQgcmFkaXggPSBzdGF0aWNfY2FzdDxpbnQ+KGRyYWRp eCk7Ci0gICAgICB1bnNpZ25lZCBpID0gdi0+dG9VSW50MzIoZXhlYyk7Ci0gICAgICBjaGFyIHNb MzNdOwotICAgICAgY2hhciAqcCA9IHMgKyBzaXplb2Yocyk7Ci0gICAgICAqLS1wID0gJ1wwJzsK KyAgICAgIGNvbnN0IGNoYXIgZGlnaXRzW10gPSAiMDEyMzQ1Njc4OWFiY2RlZmdoaWprbG1ub3Bx cnN0dXZ3eHl6IjsKKyAgICAgIC8vIElOVF9NQVggcmVzdWx0cyBpbiAxMDI0IGNoYXJhY3RlcnMg bGVmdCBvZiB0aGUgZG90IHdpdGggcmFkaXggMgorICAgICAgLy8gZ2l2ZSB0aGUgc2FtZSBzcGFj ZSBvbiB0aGUgcmlnaHQgc2lkZS4gc2FmZXR5IGNoZWNrcyBhcmUgaW4gcGxhY2UKKyAgICAgIC8v IHVubGVzcyBzb21lb25lIGZpbmRzIGEgcHJlY2lzZSBydWxlLgorICAgICAgY2hhciBzWzIwNDgg KyAzXTsKKyAgICAgIGRvdWJsZSB4ID0gdi0+dG9OdW1iZXIoZXhlYyk7CisgICAgICBpZiAoaXNO YU4oeCkgfHwgaXNJbmYoeCkpCisgICAgICAgIHJldHVybiBTdHJpbmcoVVN0cmluZzo6ZnJvbSh4 KSk7CisKKyAgICAgIC8vIGFwcGx5IGFsZ29yaXRobSBvbiBhYnNvbHV0ZSB2YWx1ZS4gYWRkIHNp Z24gbGF0ZXIuCisgICAgICBib29sIG5lZyA9IGZhbHNlOworICAgICAgaWYgKHggPCAwLjApIHsK KyAgICAgICAgbmVnID0gdHJ1ZTsKKyAgICAgICAgeCA9IC14OworICAgICAgfQorICAgICAgLy8g Y29udmVydCBpbnRlZ2VyIHBvcnRpb24KKyAgICAgIGRvdWJsZSBmID0gZmxvb3IoeCk7CisgICAg ICBkb3VibGUgZCA9IGY7CisgICAgICBjaGFyICpkb3QgPSBzICsgc2l6ZW9mKHMpIC8gMjsKKyAg ICAgIGNoYXIgKnAgPSBkb3Q7CisgICAgICAqcCA9ICdcMCc7CiAgICAgICBkbyB7Ci0gICAgICAg ICotLXAgPSAiMDEyMzQ1Njc4OWFiY2RlZmdoaWprbG1ub3BxcnN0dXZ3eHl6IltpICUgcmFkaXhd OwotICAgICAgICBpIC89IHJhZGl4OwotICAgICAgfSB3aGlsZSAoaSk7CisgICAgICAgICotLXAg PSBkaWdpdHNbaW50KGZtb2QoZCwgZG91YmxlKHJhZGl4KSkpXTsKKyAgICAgICAgZCAvPSByYWRp eDsKKyAgICAgIH0gd2hpbGUgKChkIDw9IC0xLjAgfHwgZCA+PSAxLjApICYmIHAgPiBzKTsKKyAg ICAgIC8vIGFueSBkZWNpbWFsIGZyYWN0aW9uID8KKyAgICAgIGQgPSB4IC0gZjsKKyAgICAgIGNv bnN0IGRvdWJsZSBlcHMgPSAwLjAwMTsgLy8gVE9ETzogZ3Vlc3NlZC4gYmFzZSBvbiByYWRpeCA/ CisgICAgICBpZiAoZCA8IC1lcHMgfHwgZCA+IGVwcykgeworICAgICAgICAqZG90KysgPSAnLic7 CisgICAgICAgIGRvIHsKKyAgICAgICAgICBkICo9IHJhZGl4OworICAgICAgICAgICpkb3QrKyA9 IGRpZ2l0c1tpbnQoZCldOworICAgICAgICAgIGQgLT0gaW50KGQpOworICAgICAgICB9IHdoaWxl ICgoZCA8IC1lcHMgfHwgZCA+IGVwcykgJiYgZG90IC0gcyA8IGludChzaXplb2YocykpIC0gMSk7 CisgICAgICAgICpkb3QgPSAnXDAnOworICAgICAgfQorICAgICAgLy8gYWRkIHNpZ24gaWYgbmVn YXRpdmUKKyAgICAgIGlmIChuZWcpCisgICAgICAgICotLXAgPSAnLSc7CiAgICAgICByZXR1cm4g U3RyaW5nKHApOwogICAgIH0gZWxzZQogICAgICAgcmV0dXJuIFN0cmluZyh2LT50b1N0cmluZyhl eGVjKSk7Cg==