62584 2011-06-13 11:49:15 -0700 Make it possible to inline Identifier::equal 2011-06-13 12:12:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 419738 0 oliver 2011-06-13 11:49:15 -0700 Make it possible to inline Identifier::equal 419739 1 96984 oliver 2011-06-13 11:50:16 -0700 Created attachment 96984 Patch 419750 2 96984 simon.fraser 2011-06-13 12:02:26 -0700 Comment on attachment 96984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review > Source/JavaScriptCore/runtime/Identifier.h:138 > + inline bool Identifier::equal(const StringImpl* r, const UChar* s, unsigned length) Why isn't it const? 419752 3 oliver 2011-06-13 12:05:44 -0700 (In reply to comment #2) > (From update of attachment 96984 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review > > > Source/JavaScriptCore/runtime/Identifier.h:138 > > + inline bool Identifier::equal(const StringImpl* r, const UChar* s, unsigned length) > > Why isn't it const? It's a static method, and therefore can't be :) 419758 4 oliver 2011-06-13 12:12:55 -0700 Committed r88668: <http://trac.webkit.org/changeset/88668> 96984 2011-06-13 11:50:16 -0700 2011-06-13 12:02:26 -0700 Patch bug-62584-20110613115015.patch text/plain 2368 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODg2NTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU0 NmFiMTNkOWU3YzcwNzQ3MjY4ZDIwODFmYjZmZjBjNWFhMWRmMzYuLjM2NjEzM2M0N2NiNjdjOWU4 YTAxM2IyMTgwMDE1MDkwMjI2MmQ2ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTA2LTEzICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBpdCBw b3NzaWJsZSB0byBpbmxpbmUgSWRlbnRpZmllcjo6ZXF1YWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNTg0CisKKyAgICAgICAgTW92ZSBJZGVudGlm aWVyOjplcXVhbCB0byB0aGUgSWRlbnRpZmllciBoZWFkZXIgZmlsZS4KKworICAgICAgICAqIHJ1 bnRpbWUvSWRlbnRpZmllci5jcHA6CisgICAgICAgICogcnVudGltZS9JZGVudGlmaWVyLmg6Cisg ICAgICAgIChKU0M6OklkZW50aWZpZXI6OmVxdWFsKToKKwogMjAxMS0wNi0xMyAgVG9ueSBDaGFu ZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVudGlmaWVyLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCmluZGV4IDRh OTliMTliYmVlNTMyMGQyMjRiMjZkNGQwYjA5NjUyNTZmNGE0ZjQuLmIwNzM0MWM5NWM4ZTBlNzU3 NGJjY2Q5MzEwMjg0YjFmMWM0ZmM4MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0lkZW50aWZpZXIuY3BwCkBAIC03NywxNyArNzcsNiBAQCBib29sIElkZW50aWZpZXI6OmVx dWFsKGNvbnN0IFN0cmluZ0ltcGwqIHIsIGNvbnN0IGNoYXIqIHMpCiAgICAgcmV0dXJuIHNbbGVu Z3RoXSA9PSAwOwogfQogCi1ib29sIElkZW50aWZpZXI6OmVxdWFsKGNvbnN0IFN0cmluZ0ltcGwq IHIsIGNvbnN0IFVDaGFyKiBzLCB1bnNpZ25lZCBsZW5ndGgpCi17Ci0gICAgaWYgKHItPmxlbmd0 aCgpICE9IGxlbmd0aCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGNvbnN0IFVDaGFyKiBk ID0gci0+Y2hhcmFjdGVycygpOwotICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgIT0gbGVuZ3Ro OyArK2kpCi0gICAgICAgIGlmIChkW2ldICE9IHNbaV0pCi0gICAgICAgICAgICByZXR1cm4gZmFs c2U7Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIHN0cnVjdCBJZGVudGlmaWVyQ1N0cmluZ1RyYW5z bGF0b3IgewogICAgIHN0YXRpYyB1bnNpZ25lZCBoYXNoKGNvbnN0IGNoYXIqIGMpCiAgICAgewpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5oCmluZGV4IDNhOGFlZDdh ODlhYWFiYjc0MGJjMmYwZGJlMmE5ZGVkYzRjZTA3NjEuLjM2YjMzNmVmNDkyNDFiYzkzMzE3MjRm YWNkOTNhYjRkYTc1ZDZkOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0lkZW50aWZpZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVu dGlmaWVyLmgKQEAgLTEzNSw2ICsxMzUsMTcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHJl dHVybiAhSWRlbnRpZmllcjo6ZXF1YWwoYSwgYik7CiAgICAgfQogCisgICAgaW5saW5lIGJvb2wg SWRlbnRpZmllcjo6ZXF1YWwoY29uc3QgU3RyaW5nSW1wbCogciwgY29uc3QgVUNoYXIqIHMsIHVu c2lnbmVkIGxlbmd0aCkKKyAgICB7CisgICAgICAgIGlmIChyLT5sZW5ndGgoKSAhPSBsZW5ndGgp CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGNvbnN0IFVDaGFyKiBkID0gci0+ Y2hhcmFjdGVycygpOworICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpICE9IGxlbmd0aDsg KytpKQorICAgICAgICAgICAgaWYgKGRbaV0gIT0gc1tpXSkKKyAgICAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICAKICAgICBJZGVudGlm aWVyVGFibGUqIGNyZWF0ZUlkZW50aWZpZXJUYWJsZSgpOwogICAgIHZvaWQgZGVsZXRlSWRlbnRp ZmllclRhYmxlKElkZW50aWZpZXJUYWJsZSopOwogCg==