62551 2011-06-13 10:32:52 -0700 r87539 broke HTMLMediaElement url logging 2011-06-13 11:37:52 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson abarth abarth eric webkit.review.bot oldest_to_newest 419640 0 eric.carlson 2011-06-13 10:32:52 -0700 HTMLMediaElement's urlForLogging was broken by http://trac.webkit.org/changeset/87539. With logging enabled (defaults write com.apple.Safari WebCoreLogLevel "0x01000000" on OS X), urls are never logged. 419675 1 abarth 2011-06-13 10:51:57 -0700 What happens instead? 419676 2 abarth 2011-06-13 10:53:04 -0700 Yeah, that code doesn't may any sense. It's returning a pointer to a temporary that's out of scope! Who wrote that! 419683 3 abarth 2011-06-13 10:54:44 -0700 I blame Eric. :) /me will fix. 419684 4 eric.carlson 2011-06-13 10:57:13 -0700 (In reply to comment #3) > I blame Eric. :) > Hey now, watch it with the finger pointing - you could put out an eye ;-) 419694 5 96975 abarth 2011-06-13 11:05:03 -0700 Created attachment 96975 Patch 419726 6 96975 webkit.review.bot 2011-06-13 11:37:47 -0700 Comment on attachment 96975 Patch Clearing flags on attachment: 96975 Committed r88662: <http://trac.webkit.org/changeset/88662> 419727 7 webkit.review.bot 2011-06-13 11:37:52 -0700 All reviewed patches have been landed. Closing bug. 96975 2011-06-13 11:05:03 -0700 2011-06-13 11:37:47 -0700 Patch bug-62551-20110613110501.patch text/plain 5213 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NjUzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMTMgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICByODc1MzkgYnJva2UgSFRNTE1lZGlhRWxlbWVudCB1cmwgbG9nZ2lu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI1NTEK KworICAgICAgICBSZXR1cm5pbmcgcG9pbnRlcnMgdG8gdGVtcG9yYXJpZXMgaXMgYmFkIHRpbWVz IQorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OnVybEZvckxvZ2dpbmcpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 bG9hZFJlc291cmNlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmlzU2Fm ZVRvTG9hZFVSTCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3RO ZXh0U291cmNlQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c291 cmNlV2FzQWRkZWQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c291cmNl V2lsbEJlUmVtb3ZlZCk6CisKIDIwMTEtMDYtMTAgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDg4NjI4KQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODYsMTMgKzg2LDEzIEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKICNpZiAhTE9HX0RJU0FCTEVECi1zdGF0aWMgY29uc3QgY2hhciogdXJsRm9yTG9nZ2luZyhj b25zdCBLVVJMJiB1cmwpCitzdGF0aWMgU3RyaW5nIHVybEZvckxvZ2dpbmcoY29uc3QgS1VSTCYg dXJsKQogewogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBtYXhpbXVtVVJMTGVuZ3RoRm9yTG9n Z2luZyA9IDEyODsKIAogICAgIGlmICh1cmwuc3RyaW5nKCkubGVuZ3RoKCkgPCBtYXhpbXVtVVJM TGVuZ3RoRm9yTG9nZ2luZykKLSAgICAgICAgcmV0dXJuIHVybC5zdHJpbmcoKS51dGY4KCkuZGF0 YSgpOwotICAgIHJldHVybiBTdHJpbmcodXJsLnN0cmluZygpLnN1YnN0cmluZygwLCBtYXhpbXVt VVJMTGVuZ3RoRm9yTG9nZ2luZykgKyAiLi4uIikudXRmOCgpLmRhdGEoKTsKKyAgICAgICAgcmV0 dXJuIHVybC5zdHJpbmcoKTsKKyAgICByZXR1cm4gdXJsLnN0cmluZygpLnN1YnN0cmluZygwLCBt YXhpbXVtVVJMTGVuZ3RoRm9yTG9nZ2luZykgKyAiLi4uIjsKIH0KIAogc3RhdGljIGNvbnN0IGNo YXIqIGJvb2xTdHJpbmcoYm9vbCB2YWwpCkBAIC02NzUsNyArNjc1LDcgQEAgdm9pZCBIVE1MTWVk aWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UoY29ucwogewogICAgIEFTU0VSVChpc1NhZmVUb0xvYWRV UkwoaW5pdGlhbFVSTCwgQ29tcGxhaW4pKTsKIAotICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVs ZW1lbnQ6OmxvYWRSZXNvdXJjZSglcywgJXMpIiwgdXJsRm9yTG9nZ2luZyhpbml0aWFsVVJMKSwg Y29udGVudFR5cGUucmF3KCkudXRmOCgpLmRhdGEoKSk7CisgICAgTE9HKE1lZGlhLCAiSFRNTE1l ZGlhRWxlbWVudDo6bG9hZFJlc291cmNlKCVzLCAlcykiLCB1cmxGb3JMb2dnaW5nKGluaXRpYWxV UkwpLnV0ZjgoKS5kYXRhKCksIGNvbnRlbnRUeXBlLnJhdygpLnV0ZjgoKS5kYXRhKCkpOwogCiAg ICAgRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQoKS0+ZnJhbWUoKTsKICAgICBpZiAoIWZyYW1lKQpA QCAtNjkwLDcgKzY5MCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bG9hZFJlc291cmNlKGNv bnMKIAogICAgIG1fY3VycmVudFNyYyA9IHVybDsKIAotICAgIExPRyhNZWRpYSwgIkhUTUxNZWRp YUVsZW1lbnQ6OmxvYWRSZXNvdXJjZSAtIG1fY3VycmVudFNyYyAtPiAlcyIsIHVybEZvckxvZ2dp bmcobV9jdXJyZW50U3JjKSk7CisgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6bG9h ZFJlc291cmNlIC0gbV9jdXJyZW50U3JjIC0+ICVzIiwgdXJsRm9yTG9nZ2luZyhtX2N1cnJlbnRT cmMpLnV0ZjgoKS5kYXRhKCkpOwogCiAgICAgaWYgKG1fc2VuZFByb2dyZXNzRXZlbnRzKSAKICAg ICAgICAgc3RhcnRQcm9ncmVzc0V2ZW50VGltZXIoKTsKQEAgLTcyMCw3ICs3MjAsNyBAQCB2b2lk IEhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZShjb25zCiBib29sIEhUTUxNZWRpYUVsZW1l bnQ6OmlzU2FmZVRvTG9hZFVSTChjb25zdCBLVVJMJiB1cmwsIEludmFsaWRTb3VyY2VBY3Rpb24g YWN0aW9uSWZJbnZhbGlkKQogewogICAgIGlmICghdXJsLmlzVmFsaWQoKSkgewotICAgICAgICBM T0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50Ojppc1NhZmVUb0xvYWRVUkwoJXMpIC0+IEZBTFNF IGJlY2F1c2UgdXJsIGlzIGludmFsaWQiLCB1cmxGb3JMb2dnaW5nKHVybCkpOworICAgICAgICBM T0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50Ojppc1NhZmVUb0xvYWRVUkwoJXMpIC0+IEZBTFNF IGJlY2F1c2UgdXJsIGlzIGludmFsaWQiLCB1cmxGb3JMb2dnaW5nKHVybCkudXRmOCgpLmRhdGEo KSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKQEAgLTcyOCw3ICs3MjgsNyBAQCBi b29sIEhUTUxNZWRpYUVsZW1lbnQ6OmlzU2FmZVRvTG9hZFVSTChjCiAgICAgaWYgKCFmcmFtZSB8 fCAhZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKS0+Y2FuRGlzcGxheSh1cmwpKSB7CiAgICAg ICAgIGlmIChhY3Rpb25JZkludmFsaWQgPT0gQ29tcGxhaW4pCiAgICAgICAgICAgICBGcmFtZUxv YWRlcjo6cmVwb3J0TG9jYWxMb2FkRmFpbGVkKGZyYW1lLCB1cmwuc3RyaW5nKCkpOwotICAgICAg ICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50Ojppc1NhZmVUb0xvYWRVUkwoJXMpIC0+IEZB TFNFIHJlamVjdGVkIGJ5IFNlY3VyaXR5T3JpZ2luIiwgdXJsRm9yTG9nZ2luZyh1cmwpKTsKKyAg ICAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6aXNTYWZlVG9Mb2FkVVJMKCVzKSAt PiBGQUxTRSByZWplY3RlZCBieSBTZWN1cml0eU9yaWdpbiIsIHVybEZvckxvZ2dpbmcodXJsKS51 dGY4KCkuZGF0YSgpKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApAQCAtMTczMCw3 ICsxNzMwLDcgQEAgS1VSTCBIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291cmNlQwogICAg ICAgICBtZWRpYVVSTCA9IHNvdXJjZS0+Z2V0Tm9uRW1wdHlVUkxBdHRyaWJ1dGUoc3JjQXR0cik7 CiAjaWYgIUxPR19ESVNBQkxFRAogICAgICAgICBpZiAoc2hvdWxkTG9nKQotICAgICAgICAgICAg TE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6c2VsZWN0TmV4dFNvdXJjZUNoaWxkIC0gJ3Ny YycgaXMgJXMiLCB1cmxGb3JMb2dnaW5nKG1lZGlhVVJMKSk7CisgICAgICAgICAgICBMT0coTWVk aWEsICJIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291cmNlQ2hpbGQgLSAnc3JjJyBpcyAl cyIsIHVybEZvckxvZ2dpbmcobWVkaWFVUkwpLnV0ZjgoKS5kYXRhKCkpOwogI2VuZGlmCiAgICAg ICAgIGlmIChtZWRpYVVSTC5pc0VtcHR5KCkpCiAgICAgICAgICAgICBnb3RvIGNoZWNrX2FnYWlu OwpAQCAtMTc4MSw3ICsxNzgxLDcgQEAgY2hlY2tfYWdhaW46CiAKICNpZiAhTE9HX0RJU0FCTEVE CiAgICAgaWYgKHNob3VsZExvZykKLSAgICAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVu dDo6c2VsZWN0TmV4dFNvdXJjZUNoaWxkIC0+ICVwLCAlcyIsIG1fY3VycmVudFNvdXJjZU5vZGUs IGNhblVzZSA/IHVybEZvckxvZ2dpbmcobWVkaWFVUkwpIDogIiIpOworICAgICAgICBMT0coTWVk aWEsICJIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3ROZXh0U291cmNlQ2hpbGQgLT4gJXAsICVzIiwg bV9jdXJyZW50U291cmNlTm9kZSwgY2FuVXNlID8gdXJsRm9yTG9nZ2luZyhtZWRpYVVSTCkudXRm OCgpLmRhdGEoKSA6ICIiKTsKICNlbmRpZgogICAgIHJldHVybiBjYW5Vc2UgPyBtZWRpYVVSTCA6 IEtVUkwoKTsKIH0KQEAgLTE3OTMsNyArMTc5Myw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6 c291cmNlV2FzQWRkZWQoSFQKICNpZiAhTE9HX0RJU0FCTEVECiAgICAgaWYgKHNvdXJjZS0+aGFz VGFnTmFtZShzb3VyY2VUYWcpKSB7CiAgICAgICAgIEtVUkwgdXJsID0gc291cmNlLT5nZXROb25F bXB0eVVSTEF0dHJpYnV0ZShzcmNBdHRyKTsKLSAgICAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlh RWxlbWVudDo6c291cmNlV2FzQWRkZWQgLSAnc3JjJyBpcyAlcyIsIHVybEZvckxvZ2dpbmcodXJs KSk7CisgICAgICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OnNvdXJjZVdhc0FkZGVk IC0gJ3NyYycgaXMgJXMiLCB1cmxGb3JMb2dnaW5nKHVybCkudXRmOCgpLmRhdGEoKSk7CiAgICAg fQogI2VuZGlmCiAgICAgCkBAIC0xODQwLDcgKzE4NDAsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1l bnQ6OnNvdXJjZVdpbGxCZVJlbW92CiAjaWYgIUxPR19ESVNBQkxFRAogICAgIGlmIChzb3VyY2Ut Pmhhc1RhZ05hbWUoc291cmNlVGFnKSkgewogICAgICAgICBLVVJMIHVybCA9IHNvdXJjZS0+Z2V0 Tm9uRW1wdHlVUkxBdHRyaWJ1dGUoc3JjQXR0cik7Ci0gICAgICAgIExPRyhNZWRpYSwgIkhUTUxN ZWRpYUVsZW1lbnQ6OnNvdXJjZVdpbGxCZVJlbW92ZWQgLSAnc3JjJyBpcyAlcyIsIHVybEZvckxv Z2dpbmcodXJsKSk7CisgICAgICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OnNvdXJj ZVdpbGxCZVJlbW92ZWQgLSAnc3JjJyBpcyAlcyIsIHVybEZvckxvZ2dpbmcodXJsKS51dGY4KCku ZGF0YSgpKTsKICAgICB9CiAjZW5kaWYKIAo=