62544 2011-06-13 09:19:44 -0700 REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input 2011-06-13 14:01:17 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED data:text/html,%3Cinput%20type=file%3E InRadar, Regression P1 Normal --- 1 mitz rniwa adele darin dglazkov enrica rniwa tkent oldest_to_newest 419594 0 mitz 2011-06-13 09:19:44 -0700 <radar://problem/9544885> To reproduce: open the URL, move the mouse cursor over the Choose File button and press Command-Control-D (the default Dictionary panel shortcut). Results: crash with this backtrace: 0 com.apple.WebCore 0x00007fff89bb9585 WebCore::makeRange(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&) + 277 1 com.apple.WebCore 0x00007fff89f8d4ff WebCore::Frame::rangeForPoint(WebCore::IntPoint const&) + 243 2 com.apple.WebKit2 0x00007fff88509ad1 WebKit::WebPage::performDictionaryLookupAtLocation(WebCore::FloatPoint const&) + 249 In a debug build, an assertion failure occurs in positionInParentAfterNode(), since nonShadowBoundaryParentNode() returns 0 (the parent of the button is a shadow root). 419608 1 mitz 2011-06-13 09:52:18 -0700 While the details of the crash in its current incarnation have to do with r87067, the crash itself probably predates that revision. 419697 2 mitz 2011-06-13 11:06:10 -0700 Caused by <http://trac.webkit.org/changeset/81518> 419732 3 rniwa 2011-06-13 11:43:37 -0700 Do you know how I can open up dictionary panel in DRT? Or is that even supported? 419740 4 mitz 2011-06-13 11:50:31 -0700 I don’t think you can open the dictionary panel, but the TextInputController characterIndexForPoint function may trigger the same code path. 419751 5 96986 rniwa 2011-06-13 12:05:33 -0700 Created attachment 96986 fixes the crash 419827 6 rniwa 2011-06-13 13:46:30 -0700 Committed r88685: <http://trac.webkit.org/changeset/88685> 419832 7 mitz 2011-06-13 13:50:44 -0700 Thanks! 419846 8 rniwa 2011-06-13 14:01:17 -0700 (In reply to comment #7) > Thanks! Nope. Thanks for the timely review! 96986 2011-06-13 12:05:33 -0700 2011-06-13 13:04:01 -0700 fixes the crash bug-62544-20110613120532.patch text/plain 3014 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NjY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMTMgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAocjgxNTE4KTogQ3Jhc2ggaW4gbWFrZVJhbmdl KCkgd2hlbiBpbnZva2luZyB0aGUgZGljdGlvbmFyeSBwYW5lbCBvdmVyIGEgZmlsZSBpbnB1dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI1NDQKKwor ICAgICAgICBGaXhlZCB0aGUgY3Jhc2ggYnkgYWRkaW5nIG51bGwgcG9pbnRlciBjaGVja3MuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoZXJlJ3Mgbm8gd2F5IHRvIG9wZW4gZGljdGlv bmFyeSBwYW5lbC4KKworICAgICAgICAqIGRvbS9Qb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQb3NpdGlvbjo6cGFyZW50QW5jaG9yZWRFcXVpdmFsZW50KToKKyAgICAgICAgKiBlZGl0 aW5nL1Zpc2libGVQb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjptYWtlUmFuZ2UpOgor ICAgICAgICAqIHBhZ2UvRnJhbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OnJhbmdl Rm9yUG9pbnQpOgorCiAyMDExLTA2LTEzICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9k b20vUG9zaXRpb24uY3BwCShyZXZpc2lvbiA4ODY1OSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Q b3NpdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3NCw3ICsxNzQsOCBAQCBQb3NpdGlvbiBQ b3NpdGlvbjo6cGFyZW50QW5jaG9yZWRFcXVpdmFsCiAgICAgICAgIHJldHVybiBmaXJzdFBvc2l0 aW9uSW5PckJlZm9yZU5vZGUobV9hbmNob3JOb2RlLmdldCgpKTsKICAgICB9CiAgICAgaWYgKCFt X2FuY2hvck5vZGUtPm9mZnNldEluQ2hhcmFjdGVycygpICYmIChtX2FuY2hvclR5cGUgPT0gUG9z aXRpb25Jc0FmdGVyQW5jaG9yIHx8IHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX29mZnNldCkgPT0g bV9hbmNob3JOb2RlLT5jaGlsZE5vZGVDb3VudCgpKQotICAgICAgICAmJiAoZWRpdGluZ0lnbm9y ZXNDb250ZW50KG1fYW5jaG9yTm9kZS5nZXQoKSkgfHwgaXNUYWJsZUVsZW1lbnQobV9hbmNob3JO b2RlLmdldCgpKSkpIHsKKyAgICAgICAgJiYgKGVkaXRpbmdJZ25vcmVzQ29udGVudChtX2FuY2hv ck5vZGUuZ2V0KCkpIHx8IGlzVGFibGVFbGVtZW50KG1fYW5jaG9yTm9kZS5nZXQoKSkpCisgICAg ICAgICYmIGNvbnRhaW5lck5vZGUoKSkgewogICAgICAgICByZXR1cm4gcG9zaXRpb25JblBhcmVu dEFmdGVyTm9kZShtX2FuY2hvck5vZGUuZ2V0KCkpOwogICAgIH0KIApJbmRleDogU291cmNlL1dl YkNvcmUvZWRpdGluZy9WaXNpYmxlUG9zaXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVBvc2l0aW9uLmNwcAkocmV2aXNpb24gODg2NTkpCisrKyBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Zpc2libGVQb3NpdGlvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTYzMiw2ICs2MzIsOSBAQCBQYXNzUmVmUHRyPFJhbmdlPiBtYWtlUmFuZ2UoY29uc3QgVmlz aWJsCiAgICAgCiAgICAgUG9zaXRpb24gcyA9IHN0YXJ0LmRlZXBFcXVpdmFsZW50KCkucGFyZW50 QW5jaG9yZWRFcXVpdmFsZW50KCk7CiAgICAgUG9zaXRpb24gZSA9IGVuZC5kZWVwRXF1aXZhbGVu dCgpLnBhcmVudEFuY2hvcmVkRXF1aXZhbGVudCgpOworICAgIGlmIChzLmlzTnVsbCgpIHx8IGUu aXNOdWxsKCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAgcmV0dXJuIFJhbmdlOjpjcmVhdGUo cy5jb250YWluZXJOb2RlKCktPmRvY3VtZW50KCksIHMuY29udGFpbmVyTm9kZSgpLCBzLm9mZnNl dEluQ29udGFpbmVyTm9kZSgpLCBlLmNvbnRhaW5lck5vZGUoKSwgZS5vZmZzZXRJbkNvbnRhaW5l ck5vZGUoKSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lvbiA4ODY1OSkK KysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OTgs OCArODk4LDcgQEAgUGFzc1JlZlB0cjxSYW5nZT4gRnJhbWU6OnJhbmdlRm9yUG9pbnQoYwogICAg IH0KIAogICAgIFZpc2libGVQb3NpdGlvbiBuZXh0ID0gcG9zaXRpb24ubmV4dCgpOwotICAgIGlm IChuZXh0LmlzTm90TnVsbCgpKSB7Ci0gICAgICAgIFJlZlB0cjxSYW5nZT4gbmV4dENoYXJhY3Rl clJhbmdlID0gbWFrZVJhbmdlKHBvc2l0aW9uLCBuZXh0KTsKKyAgICBpZiAoUmVmUHRyPFJhbmdl PiBuZXh0Q2hhcmFjdGVyUmFuZ2UgPSBtYWtlUmFuZ2UocG9zaXRpb24sIG5leHQpKSB7CiAgICAg ICAgIEludFJlY3QgcmVjdCA9IGVkaXRvcigpLT5maXJzdFJlY3RGb3JSYW5nZShuZXh0Q2hhcmFj dGVyUmFuZ2UuZ2V0KCkpOwogICAgICAgICBpZiAocmVjdC5jb250YWlucyhmcmFtZVBvaW50KSkK ICAgICAgICAgICAgIHJldHVybiBuZXh0Q2hhcmFjdGVyUmFuZ2UucmVsZWFzZSgpOwo=