62541 2011-06-13 05:55:57 -0700 [GTK] Fix a crash when drawing area has been deleted 2011-06-13 10:14:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 419516 0 cgarcia 2011-06-13 05:55:57 -0700 We should check whether WebPageProxy::drawingArea() returns a valid pointer before using it, it might be null, for example, when the web process crashes. 419517 1 96949 cgarcia 2011-06-13 05:57:58 -0700 Created attachment 96949 Patch 419622 2 cgarcia 2011-06-13 10:14:53 -0700 Committed r88646: <http://trac.webkit.org/changeset/88646> 96949 2011-06-13 05:57:58 -0700 2011-06-13 09:30:45 -0700 Patch wk2-drawing-area-crash.diff text/plain 2027 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4Njc1MThiLi40NjhmMWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDYtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEZpeCBhIGNyYXNoIHdoZW4gZHJhd2luZyBhcmVhIGhhcyBiZWVuIGRlbGV0ZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNTQxCisKKyAgICAgICAg Q2hlY2sgd2hldGhlciBXZWJQYWdlUHJveHk6OmRyYXdpbmdBcmVhKCkgcmV0dXJucyBhIHZhbGlk IHBvaW50ZXIKKyAgICAgICAgYmVmb3JlIHVzaW5nIGl0LCBpdCBtaWdodCBiZSBudWxsLCBmb3Ig ZXhhbXBsZSwgd2hlbiB0aGUgd2ViCisgICAgICAgIHByb2Nlc3MgY3Jhc2hlcy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAgKGNh bGxEcmF3aW5nQXJlYVBhaW50TWV0aG9kKToKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlU2l6 ZUFsbG9jYXRlKToKKworMjAxMS0wNi0xMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgogCiAg ICAgICAgIFtHVEtdIEFkZCBjb250ZXh0IG1lbnUgc3VwcG9ydCBmb3IgV2Via2l0MgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2Uu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2Uu Y3BwCmluZGV4IDBhYzZhYTUuLjgzNTNiNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTE1Myw2ICsxNTMs OSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfYmFzZV9pbml0KFdlYktpdFdlYlZpZXdC YXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKIAogc3RhdGljIHZvaWQgY2FsbERyYXdpbmdBcmVhUGFp bnRNZXRob2QoRHJhd2luZ0FyZWFQcm94eSogZHJhd2luZ0FyZWEsIGNhaXJvX3QqIGNvbnRleHQs IGNvbnN0IEludFJlY3QmIGFyZWEpCiB7CisgICAgaWYgKCFkcmF3aW5nQXJlYSkKKyAgICAgICAg cmV0dXJuOworCiAgICAgV2ViS2l0OjpSZWdpb24gdW5wYWludGVkUmVnaW9uOyAvLyBUaGlzIGlz IHNpbXBseSB1bnVzZWQuCiAgICAgc3RhdGljX2Nhc3Q8RHJhd2luZ0FyZWFQcm94eUltcGwqPihk cmF3aW5nQXJlYSktPnBhaW50KGNvbnRleHQsIGFyZWEsIHVucGFpbnRlZFJlZ2lvbik7CiB9CkBA IC0xODQsNiArMTg3LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTaXplQWxsb2Nh dGUoR3RrV2lkZ2V0KiB3aWRnZXQsIEd0a0FsbG9jYXRpb24qIGFsbG8KICAgICBXZWJLaXRXZWJW aWV3QmFzZSogd2ViVmlld0Jhc2UgPSBXRUJLSVRfV0VCX1ZJRVdfQkFTRSh3aWRnZXQpOwogICAg IFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OwogCisg ICAgaWYgKCFwcml2LT5wYWdlUHJveHktPmRyYXdpbmdBcmVhKCkpCisgICAgICAgIHJldHVybjsK KwogICAgIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X2Jhc2VfcGFyZW50X2NsYXNz KS0+c2l6ZV9hbGxvY2F0ZSh3aWRnZXQsIGFsbG9jYXRpb24pOwogICAgIHByaXYtPnBhZ2VQcm94 eS0+ZHJhd2luZ0FyZWEoKS0+c2V0U2l6ZShJbnRTaXplKGFsbG9jYXRpb24tPndpZHRoLCBhbGxv Y2F0aW9uLT5oZWlnaHQpLCBJbnRTaXplKCkpOwogfQo=