62539 2011-06-13 05:29:23 -0700 [EFL] Input method hints not updated while clicking non-input field editable area 2011-06-13 15:47:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED http://24ways.org/examples/have-a-field-day-with-html5-forms/24ways-form.html P3 Normal --- 0 mpakulavelrutka webkit-unassigned antognolli+webkit gustavo.noronha gustavo gyuyoung.kim leandro lucas.de.marchi rakuco webkit.review.bot xan.lopez oldest_to_newest 419507 0 mpakulavelrutka 2011-06-13 05:29:23 -0700 Overview: On some pages input method hints are not updated while focus is changed from editable area with input tags to other which are does not have input tag i.e. textarea When input method hints are set by ewk_view_input_method_state_set current input method priv->imh is being reset after an if condition. One of its conditions is that a focused node has to have tag name input. There may be editable areas i.e. textarea are which does not have input tag, and hints remain unchanged. Steps to reproduce: Go to http://24ways.org/examples/have-a-field-day-with-html5-forms/24ways-form.html, click on the one of input fields - input method hints should change respectively of an input type. Then click on Address area. Actual result: Input method hint remains unchanged Expected result: Input method hint should be reset to 0. 419568 1 96956 mpakulavelrutka 2011-06-13 08:13:20 -0700 Created attachment 96956 patch 419576 2 96956 gustavo.noronha 2011-06-13 08:29:14 -0700 Comment on attachment 96956 patch Attachment 96956 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8831805 419770 3 96956 leandro 2011-06-13 12:22:58 -0700 Comment on attachment 96956 patch LGTM. (Also, cq? again, as this isn't touching any GTK-related file.) 419879 4 96956 eric 2011-06-13 14:37:16 -0700 Comment on attachment 96956 patch I don't know how to review this. I don't think there are any EFL reviewers. I'm happy to rs=me. The gtk error looks bogus. 420006 5 96956 webkit.review.bot 2011-06-13 15:47:48 -0700 Comment on attachment 96956 patch Clearing flags on attachment: 96956 Committed r88725: <http://trac.webkit.org/changeset/88725> 420007 6 webkit.review.bot 2011-06-13 15:47:53 -0700 All reviewed patches have been landed. Closing bug. 96956 2011-06-13 08:13:20 -0700 2011-06-13 15:47:48 -0700 patch Input_method_hints.diff text/plain 1768 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAxODU5NWZiLi40M2NmYTkwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTMgIE1pY2hhbCBQYWt1bGEgdmVsIFJ1dGthICA8bS5w YWt1bGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0VGTF0gSW5wdXQgbWV0aG9kIGhpbnRzIG5vdCB1cGRhdGVkIHdoaWxlIGNs aWNraW5nIG5vbi1pbnB1dCBmaWVsZCBlZGl0YWJsZSBhcmVhCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjUzOQorCisgICAgICAgIFRoaXMgZml4ZXMg YSBtaW5vciBidWcgd2hlbiBpbnB1dCBtZXRob2QgaGludHMgYXJlIG5vdCB1cGRhdGVkIHdoaWxl IGZvY3VzIGlzIAorICAgICAgICBjaGFuZ2VkIGZyb20gZWRpdGFibGUgYXJlYSB3aXRoIGlucHV0 IHRhZ3MgdG8gb3RoZXIgd2hpY2ggYXJlIGRvZXMgbm90IGhhdmUgaW5wdXQgCisgICAgICAgIHRh ZyBpLmUuIHRleHRhcmVhLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAg KGV3a192aWV3X2lucHV0X21ldGhvZF9zdGF0ZV9zZXQpOgorCiAyMDExLTA2LTEwICBLd2FuZ0h5 dWsgS2ltICA8aHl1a2kua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtl bm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5k ZXggM2UzZTc5Ni4uYmRlYTg0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0z NDQxLDYgKzM0NDEsNyBAQCB2b2lkIGV3a192aWV3X2lucHV0X21ldGhvZF9zdGF0ZV9zZXQoRXZh c19PYmplY3QqIG8sIEVpbmFfQm9vbCBhY3RpdmUpCiAgICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2Qs IHByaXYpOwogICAgIFdlYkNvcmU6OkZyYW1lKiBmb2N1c2VkRnJhbWUgPSBwcml2LT5wYWdlLT5m b2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCk7CiAKKyAgICBwcml2LT5pbWgg PSAwOwogICAgIGlmIChmb2N1c2VkRnJhbWUKICAgICAgICAgJiYgZm9jdXNlZEZyYW1lLT5kb2N1 bWVudCgpCiAgICAgICAgICYmIGZvY3VzZWRGcmFtZS0+ZG9jdW1lbnQoKS0+Zm9jdXNlZE5vZGUo KQpAQCAtMzQ0OSw3ICszNDUwLDYgQEAgdm9pZCBld2tfdmlld19pbnB1dF9tZXRob2Rfc3RhdGVf c2V0KEV2YXNfT2JqZWN0KiBvLCBFaW5hX0Jvb2wgYWN0aXZlKQogCiAgICAgICAgIGlucHV0RWxl bWVudCA9IHN0YXRpY19jYXN0PFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQqPihmb2N1c2VkRnJh bWUtPmRvY3VtZW50KCktPmZvY3VzZWROb2RlKCkpOwogICAgICAgICBpZiAoaW5wdXRFbGVtZW50 KSB7Ci0gICAgICAgICAgICBwcml2LT5pbWggPSAwOwogICAgICAgICAgICAgLy8gZm9yIHBhc3N3 b3JkIGZpZWxkcywgYWN0aXZlID09IGZhbHNlCiAgICAgICAgICAgICBpZiAoIWFjdGl2ZSkgewog ICAgICAgICAgICAgICAgIGFjdGl2ZSA9IGlucHV0RWxlbWVudC0+aXNQYXNzd29yZEZpZWxkKCk7 Cg==