62515 2011-06-12 11:39:59 -0700 [Qt] Fix http/tests/xmlhttprequest/cache-override.html 2014-02-03 03:17:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 62929 1 robert webkit-unassigned cmarcelo eric kenneth luiz robert yael oldest_to_newest 419313 0 robert 2011-06-12 11:39:59 -0700 [Qt] Fix http/tests/xmlhttprequest/cache-override.html 419315 1 96885 robert 2011-06-12 11:56:18 -0700 Created attachment 96885 Patch 420587 2 96885 luiz 2011-06-14 11:14:20 -0700 Comment on attachment 96885 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96885&action=review > Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:424 > if (httpStatusCode == 401 || httpStatusCode == 407) > return true; This if became useless after this change. > Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:427 > - if (receivedData && (httpStatusCode >= 400 && httpStatusCode < 600)) > + if (httpStatusCode >= 400 && httpStatusCode < 600) > return true; The idea here is to show to the user the content sent by the server, if some content was sent by the server. If the server did not send any content then we do not ignore the error and we may provide a special page with some information to the user instead of a blank screen. Most of the browsers do it. When the error is not ignored ResourceHandleClient::didFail() is called. Isn't ResourceHandleClient responsible for handling the error? 420634 3 robert 2011-06-14 11:59:12 -0700 (In reply to comment #2) > > Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:424 > > if (httpStatusCode == 401 || httpStatusCode == 407) > > return true; > > This if became useless after this change. Good point! > The idea here is to show to the user the content sent by the server, if some content was sent by the server. > If the server did not send any content then we do not ignore the error and we may provide a special page with some information to the user instead of a blank screen. Most of the browsers do it. How is the client receiving notice of the error? Won't he get it anyway from the unsupportedContent() signal ? From what I can tell in other ports, didFail() is only used when there has been a transport error of some sort. 422139 4 luiz 2011-06-16 12:36:14 -0700 (In reply to comment #3) > (In reply to comment #2) > > > The idea here is to show to the user the content sent by the server, if some content was sent by the server. > > If the server did not send any content then we do not ignore the error and we may provide a special page with some information to the user instead of a blank screen. Most of the browsers do it. > > How is the client receiving notice of the error? Won't he get it anyway from the unsupportedContent() signal ? From what I can tell in other ports, didFail() is only used when there has been a transport error of some sort. Look at FrameLoaderClientQt::callErrorPageExtension. By default QtTestBrowser will show a page containing the http error string and title 'Failed loading page' when it receives a message that has no content. No, unsupportedContent will probably not help. 446096 5 96885 robert 2011-08-03 14:43:41 -0700 Comment on attachment 96885 Patch Clearing review for now. 975232 6 jturcotte 2014-02-03 03:17:56 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 96885 2011-06-12 11:56:18 -0700 2011-08-03 14:43:41 -0700 Patch bug-62515-20110612195613.patch text/plain 5833 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODg2MTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2ZGE1YTM2NDEyZjc4OWYxOGIxMzI4 ZDJhY2MxNTZhOWNjOWZjYWVkLi4yNzFkZjFlZTUxNTNkODY1NDdlMTJmNGMyZDNjODczMjk4YzQ0 YzNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYtMTIgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gRml4IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvY2FjaGUtb3ZlcnJp ZGUuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjI1MTUKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6IFVuc2tpcCBodHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L2NhY2hlLW92ZXJyaWRlLmh0bWwKKwogMjAxMS0wNi0xMiAgTWFoZXNo IEt1bGthcm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggNDU2MDE3OTQ1 OTkyNTEyYTJhNDc5NzgwNTllYzg5OWFhOTg3NmJjNi4uZjllNDgxYzdmMzg0M2JiZjJkZGU3N2Fl OTQ0YTUxNDQ1ZWRhNDk5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp cHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC0zNjQsNyArMzY0 LDYgQEAgaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9mYWlsZWQtYXV0aC5odG1sCiBodHRwL3Rl c3RzL3htbGh0dHByZXF1ZXN0L2Nyb3NzLW9yaWdpbi1jb29raWUtc3RvcmFnZS5odG1sCiAKICMg U3RpbGwgZmFpbCB3aXRoIFF0IDQuNy4xCi1odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2NhY2hl LW92ZXJyaWRlLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvY3Jvc3Mtb3JpZ2luLWF1 dGhvcml6YXRpb24uaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jcm9zcy1vcmlnaW4t bm8tYXV0aG9yaXphdGlvbi5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlZGlyZWN0 LWNyb3NzLW9yaWdpbi10cmlwbWluZS5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU3ZmM1NjVjM2Y4NWFh ODRlNzI4OGExNjBkOWMwZGQ2NmFhN2QwNi4uMGU2ZGMyOTRkNTVkYzNiMTAyYmFlNGYyMzgxNTQ4 OTg2ZDg4MzdiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDExLTA2LTEyICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L2NhY2hlLW92ZXJyaWRlLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNTE1CisKKyAgICAgICAgVGhlcmUgaXNuJ3QgYSBnb29kIHJlYXNvbiB0 byBvbmx5IGlnbm9yZSBIVFRQIHN0YXR1cyBjb2RlcyBiZXR3ZWVuIDQwMCBhbmQgNjAwCisgICAg ICAgIGlmIHRoZSByZXNwb25zZSBjb250YWlucyBkYXRhLiBJbiB0aGUgY2FzZSBvZiBYTUxIVFRQ UmVxdWVzdHMgZmlyaW5nIGFuIGVycm9yCisgICAgICAgIGZvciB0aGVtIHdpbGwgY2xlYXIgdGhl IHJlc3BvbnNlIGRhdGEsIGFuZCB0aGUgWE1MSFRUUFJlcXVlc3Qgd2lsbCByZXR1cm4gYSBzdGF0 dXMgb2YgMC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhh bmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UU5ldHdvcmtSZXBseVdyYXBwZXI6OlFOZXR3 b3JrUmVwbHlXcmFwcGVyKTogUmVtb3ZlIG1fcmVzcG9uc2VDb250YWluc0RhdGEKKyAgICAgICAg KFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlXcmFwcGVyOjplbWl0TWV0YURhdGFDaGFuZ2VkKTogUmVt b3ZlIG1fcmVzcG9uc2VDb250YWluc0RhdGEKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVw bHlXcmFwcGVyOjpkaWRSZWNlaXZlUmVhZHlSZWFkKTpSZW1vdmUgbV9yZXNwb25zZUNvbnRhaW5z RGF0YQorICAgICAgICAoV2ViQ29yZTo6c2hvdWxkSWdub3JlSHR0cEVycm9yKToKKyAgICAgICAg KFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpmaW5pc2gpOgorICAgICAgICAqIHBsYXRm b3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuaDoKKwogMjAxMS0wNi0xMiAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9R TmV0d29ya1JlcGx5SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAppbmRleCA5ZTFiODFkMWMxYTIyNDcyZGZlODAz YzgzNzZkMGRkODBhYWE5OTQ2Li44M2E2YWE4MzgyMjM4NzViYTI3YjFkN2E4ZTM2YzE1ZDc3MTVk YWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3 b3JrUmVwbHlIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcApAQCAtMjA5LDcgKzIwOSw2IEBAIFFOZXR3b3Jr UmVwbHlXcmFwcGVyOjpRTmV0d29ya1JlcGx5V3JhcHBlcihRTmV0d29ya1JlcGx5SGFuZGxlckNh bGxRdWV1ZSogcXVldWUsCiAgICAgOiBRT2JqZWN0KHBhcmVudCkKICAgICAsIG1fcmVwbHkocmVw bHkpCiAgICAgLCBtX3F1ZXVlKHF1ZXVlKQotICAgICwgbV9yZXNwb25zZUNvbnRhaW5zRGF0YShm YWxzZSkKICAgICAsIG1fc25pZmZNSU1FVHlwZXMoc25pZmZNSU1FVHlwZXMpCiB7CiAgICAgUV9B U1NFUlQobV9yZXBseSk7CkBAIC0zMjAsMTAgKzMxOSw4IEBAIHZvaWQgUU5ldHdvcmtSZXBseVdy YXBwZXI6OmVtaXRNZXRhRGF0YUNoYW5nZWQoKQogICAgIFF1ZXVlTG9ja2VyIGxvY2sobV9xdWV1 ZSk7CiAgICAgbV9xdWV1ZS0+cHVzaCgmUU5ldHdvcmtSZXBseUhhbmRsZXI6OnNlbmRSZXNwb25z ZUlmTmVlZGVkKTsKIAotICAgIGlmIChtX3JlcGx5LT5ieXRlc0F2YWlsYWJsZSgpKSB7Ci0gICAg ICAgIG1fcmVzcG9uc2VDb250YWluc0RhdGEgPSB0cnVlOworICAgIGlmIChtX3JlcGx5LT5ieXRl c0F2YWlsYWJsZSgpKQogICAgICAgICBtX3F1ZXVlLT5wdXNoKCZRTmV0d29ya1JlcGx5SGFuZGxl cjo6Zm9yd2FyZERhdGEpOwotICAgIH0KIAogICAgIGlmIChpc0ZpbmlzaGVkKCkpIHsKICAgICAg ICAgbV9xdWV1ZS0+cHVzaCgmUU5ldHdvcmtSZXBseUhhbmRsZXI6OmZpbmlzaCk7CkBAIC0zMzcs OCArMzM0LDYgQEAgdm9pZCBRTmV0d29ya1JlcGx5V3JhcHBlcjo6ZW1pdE1ldGFEYXRhQ2hhbmdl ZCgpCiAKIHZvaWQgUU5ldHdvcmtSZXBseVdyYXBwZXI6OmRpZFJlY2VpdmVSZWFkeVJlYWQoKQog ewotICAgIGlmIChtX3JlcGx5LT5ieXRlc0F2YWlsYWJsZSgpKQotICAgICAgICBtX3Jlc3BvbnNl Q29udGFpbnNEYXRhID0gdHJ1ZTsKICAgICBtX3F1ZXVlLT5wdXNoKCZRTmV0d29ya1JlcGx5SGFu ZGxlcjo6Zm9yd2FyZERhdGEpOwogfQogCkBAIC00MjEsMTQgKzQxNiwxNCBAQCBRTmV0d29ya1Jl cGx5KiBRTmV0d29ya1JlcGx5SGFuZGxlcjo6cmVsZWFzZSgpCiAgICAgcmV0dXJuIHJlcGx5Owog fQogCi1zdGF0aWMgYm9vbCBzaG91bGRJZ25vcmVIdHRwRXJyb3IoUU5ldHdvcmtSZXBseSogcmVw bHksIGJvb2wgcmVjZWl2ZWREYXRhKQorc3RhdGljIGJvb2wgc2hvdWxkSWdub3JlSHR0cEVycm9y KFFOZXR3b3JrUmVwbHkqIHJlcGx5KQogewogICAgIGludCBodHRwU3RhdHVzQ29kZSA9IHJlcGx5 LT5hdHRyaWJ1dGUoUU5ldHdvcmtSZXF1ZXN0OjpIdHRwU3RhdHVzQ29kZUF0dHJpYnV0ZSkudG9J bnQoKTsKIAogICAgIGlmIChodHRwU3RhdHVzQ29kZSA9PSA0MDEgfHwgaHR0cFN0YXR1c0NvZGUg PT0gNDA3KQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIGlmIChyZWNlaXZlZERhdGEgJiYg KGh0dHBTdGF0dXNDb2RlID49IDQwMCAmJiBodHRwU3RhdHVzQ29kZSA8IDYwMCkpCisgICAgaWYg KGh0dHBTdGF0dXNDb2RlID49IDQwMCAmJiBodHRwU3RhdHVzQ29kZSA8IDYwMCkKICAgICAgICAg cmV0dXJuIHRydWU7CiAKICAgICByZXR1cm4gZmFsc2U7CkBAIC00NTAsNyArNDQ1LDcgQEAgdm9p ZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6ZmluaXNoKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0K IAotICAgIGlmICghbV9yZXBseVdyYXBwZXItPnJlcGx5KCktPmVycm9yKCkgfHwgc2hvdWxkSWdu b3JlSHR0cEVycm9yKG1fcmVwbHlXcmFwcGVyLT5yZXBseSgpLCBtX3JlcGx5V3JhcHBlci0+cmVz cG9uc2VDb250YWluc0RhdGEoKSkpCisgICAgaWYgKCFtX3JlcGx5V3JhcHBlci0+cmVwbHkoKS0+ ZXJyb3IoKSB8fCBzaG91bGRJZ25vcmVIdHRwRXJyb3IobV9yZXBseVdyYXBwZXItPnJlcGx5KCkp KQogICAgICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRpbmcobV9yZXNvdXJjZUhhbmRsZSwgMCk7 CiAgICAgZWxzZSB7CiAgICAgICAgIFFVcmwgdXJsID0gbV9yZXBseVdyYXBwZXItPnJlcGx5KCkt PnVybCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9R TmV0d29ya1JlcGx5SGFuZGxlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x dC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCmluZGV4IDYxNTAxMjBiNzM1OTFkNTk0MGZkYTAyMjM5 OTJkN2MyZTFhYjk0OTQuLjgwZDVhNmNlMWY1YTg5NTdhOGUzYmEyZmQyMjQxMzU4ZDA3NmI1YjMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtS ZXBseUhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FO ZXR3b3JrUmVwbHlIYW5kbGVyLmgKQEAgLTc5LDcgKzc5LDYgQEAgcHVibGljOgogICAgIFFTdHJp bmcgYWR2ZXJ0aXNlZE1JTUVUeXBlKCkgY29uc3QgeyByZXR1cm4gbV9hZHZlcnRpc2VkTUlNRVR5 cGU7IH0KICAgICBRU3RyaW5nIG1pbWVUeXBlKCkgY29uc3QgeyByZXR1cm4gbV9zbmlmZmVkTUlN RVR5cGUuaXNFbXB0eSgpID8gbV9hZHZlcnRpc2VkTUlNRVR5cGUgOiBtX3NuaWZmZWRNSU1FVHlw ZTsgfQogCi0gICAgYm9vbCByZXNwb25zZUNvbnRhaW5zRGF0YSgpIGNvbnN0IHsgcmV0dXJuIG1f cmVzcG9uc2VDb250YWluc0RhdGE7IH0KICAgICBib29sIHdhc1JlZGlyZWN0ZWQoKSBjb25zdCB7 IHJldHVybiBtX3JlZGlyZWN0aW9uVGFyZ2V0VXJsLmlzVmFsaWQoKTsgfQogCiAgICAgLy8gU2Vl IHNldEZpbmlzaGVkKCkuCkBAIC0xMDEsNyArMTAwLDYgQEAgcHJpdmF0ZToKIAogICAgIFFTdHJp bmcgbV9lbmNvZGluZzsKICAgICBRTmV0d29ya1JlcGx5SGFuZGxlckNhbGxRdWV1ZSogbV9xdWV1 ZTsKLSAgICBib29sIG1fcmVzcG9uc2VDb250YWluc0RhdGE7CiAKICAgICBRU3RyaW5nIG1fYWR2 ZXJ0aXNlZE1JTUVUeXBlOwogCg==