62514 2011-06-12 10:30:48 -0700 [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078 2011-06-19 03:53:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62926 62929 1 robert robert ap kling ossy rniwa webkit.review.bot oldest_to_newest 419307 0 robert 2011-06-12 10:30:48 -0700 [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078 419308 1 96882 robert 2011-06-12 10:38:23 -0700 Created attachment 96882 Patch 422814 2 robert 2011-06-17 12:10:44 -0700 Committed r89154: <http://trac.webkit.org/changeset/89154> 422951 3 rniwa 2011-06-17 16:39:15 -0700 It seems like this patch caused Qt Windows build failure: http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/24074/steps/compile-webkit/logs/stdio 423004 4 robert 2011-06-17 18:34:32 -0700 Whoops.i'll take a look in the morning. 423086 5 ossy 2011-06-18 01:43:22 -0700 Robert, you should have watch the bots after landing instead of waiting if somebody kick in your ass. :) Please respect contributing rules and try to keep the tree green: http://www.webkit.org/coding/contributing.html "Your change must at least compile on all platforms." I had to roll it out to make the bots green again: http://trac.webkit.org/changeset/89191 423094 6 97695 robert 2011-06-18 03:33:57 -0700 Created attachment 97695 Patch 423121 7 97695 ap 2011-06-18 09:34:52 -0700 Comment on attachment 97695 Patch ok 423350 8 97695 webkit.review.bot 2011-06-19 03:53:16 -0700 Comment on attachment 97695 Patch Clearing flags on attachment: 97695 Committed r89213: <http://trac.webkit.org/changeset/89213> 423351 9 webkit.review.bot 2011-06-19 03:53:21 -0700 All reviewed patches have been landed. Closing bug. 96882 2011-06-12 10:38:23 -0700 2011-06-18 01:43:34 -0700 Patch bug-62514-20110612183819.patch text/plain 3570 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODg2MTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMWQzYjUyMmVmYWExYjRjMDFhMTY5 YmJhZmRlYTgxNDJiYmE5Nzc1Li4wNmZkY2Q3MDkyNzAwMTgxMDExNWU0NjZmYjMxYWFkMWE5YTgy NjMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDYtMTIgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gUXQgQ291bnRlcnBhcnQgZm9yIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0LzQyMDc4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MjUxNAorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDogVW5za2lwIGh0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVkaXJlY3QtY3Jvc3Mtb3JpZ2luLXRyaXBtaW5lLmh0 bWwKKworMjAxMS0wNi0xMiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KIAogICAgICAgICBbUXRdIEZpeCBtZXRo b2RzLmh0bWwgYW5kIG1ldGhvZHMtbG93ZXItY2FzZS5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZAppbmRleCBhNzMxNTdhMTk0NDg0MjViYjk2NDg4Y2UxYTI5MWFkODUzNTI1MmVhLi5jOWEwYTc5 Y2I0ODI1ODBmNDA4Yjk0MjliOTg3NGYzMTNiN2JlMGQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKQEAgLTM2Nyw3ICszNjcsNiBAQCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2Nyb3NzLW9y aWdpbi1jb29raWUtc3RvcmFnZS5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2NhY2hl LW92ZXJyaWRlLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvY3Jvc3Mtb3JpZ2luLWF1 dGhvcml6YXRpb24uaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jcm9zcy1vcmlnaW4t bm8tYXV0aG9yaXphdGlvbi5odG1sCi1odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlZGlyZWN0 LWNyb3NzLW9yaWdpbi10cmlwbWluZS5odG1sCiAKICMgPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKICMg ICAgICAgRmFpbGluZyBpbnNlcnRpbmcgdGVzdHMuICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZmRhYWQxMTQ2ZDM1YzZkY2E2NGUy OTY3YzU5NWQ5N2ZlMGEyNTRhLi40NDkzYjc5ZTFhZTMxNmFjZmZjOGZmOGRmMGQwMTY0MTIxOTU0 MDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMDYtMTIgIFJvYmVydCBIb2dh biAgPHJvYmVydEB3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtRdF0gUXQgQ291bnRlcnBhcnQgZm9yIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzQyMDc4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MjUxNAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9SZXNv dXJjZUhhbmRsZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkNvcmVTeW5jaHJvbm91c0xv YWRlcjo6d2lsbFNlbmRSZXF1ZXN0KToKKworMjAxMS0wNi0xMiAgUm9iZXJ0IEhvZ2FuICA8cm9i ZXJ0QHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KIAog ICAgICAgICBbUXRdIEZpeCBtZXRob2RzLmh0bWwgYW5kIG1ldGhvZHMtbG93ZXItY2FzZS5odG1s CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNl SGFuZGxlUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJj ZUhhbmRsZVF0LmNwcAppbmRleCA2NDJkMGE2MDQxYWI2M2QyNGMyZTFjMGVlYTNhMzkzZGE0ZGQx ZDNiLi45YTFhMGUxYzllN2QyYjI2OTJkNDVlMDQwZGQzN2MzODVjNTQzZDk5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VIYW5kbGVR dC5jcHAKQEAgLTU5LDYgKzU5LDcgQEAgcHVibGljOgogICAgICAgICAsIG1fZGF0YShkYXRhKQog ICAgIHt9CiAKKyAgICB2aXJ0dWFsIHZvaWQgd2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlSGFuZGxl KiwgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwogICAgIHZpcnR1 YWwgdm9pZCBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBSZXNvdXJj ZVJlc3BvbnNlJiByZXNwb25zZSkgeyBtX3Jlc3BvbnNlID0gcmVzcG9uc2U7IH0KICAgICB2aXJ0 dWFsIHZvaWQgZGlkUmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBjaGFyKiBkYXRh LCBpbnQgbGVuZ3RoLCBpbnQpIHsgbV9kYXRhLmFwcGVuZChkYXRhLCBsZW5ndGgpOyB9CiAgICAg dmlydHVhbCB2b2lkIGRpZEZpbmlzaExvYWRpbmcoUmVzb3VyY2VIYW5kbGUqLCBkb3VibGUgLypm aW5pc2hUaW1lKi8pIHt9CkBAIC02OSw2ICs3MCwxNyBAQCBwcml2YXRlOgogICAgIFZlY3Rvcjxj aGFyPiYgbV9kYXRhOwogfTsKIAordm9pZCBXZWJDb3JlU3luY2hyb25vdXNMb2FkZXI6OndpbGxT ZW5kUmVxdWVzdChSZXNvdXJjZUhhbmRsZSogaGFuZGxlLCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIC8qcmVkaXJlY3RSZXNwb25zZSovKQoreworICAg IC8vIEZJWE1FOiBUaGlzIG5lZWRzIHRvIGJlIGZpeGVkIHRvIGZvbGxvdyB0aGUgcmVkaXJlY3Qg Y29ycmVjdGx5IGV2ZW4gZm9yIGNyb3NzLWRvbWFpbiByZXF1ZXN0cy4KKyAgICBpZiAoIXByb3Rv Y29sSG9zdEFuZFBvcnRBcmVFcXVhbChoYW5kbGUtPmZpcnN0UmVxdWVzdCgpLnVybCgpLCByZXF1 ZXN0LnVybCgpKSkgeworICAgICAgICBBU1NFUlQoIW1fZXJyb3IpOworICAgICAgICBtX2Vycm9y LnNldElzQ2FuY2VsbGF0aW9uKHRydWUpOworICAgICAgICByZXF1ZXN0ID0gUmVzb3VyY2VSZXF1 ZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9Cit9CisKIFJlc291cmNlSGFuZGxlSW50ZXJu YWw6On5SZXNvdXJjZUhhbmRsZUludGVybmFsKCkKIHsKIH0K 97695 2011-06-18 03:33:57 -0700 2011-06-19 03:53:16 -0700 Patch bug-62514-20110618113355.patch text/plain 3487 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODkxOTMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhZWRmZDMwOTM4MWVmZDA3Y2E3M2I2 ZTM5MjQ4YjIxNWVkMzliYmQ3Li5iOTYzYmU3ZjRlODFiYmZmYmZiOWM1MjI5ODExODA3MzI0NTNj YjMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDYtMTIgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFr b3YuCisKKyAgICAgICAgW1F0XSBRdCBDb3VudGVycGFydCBmb3IgaHR0cDovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvNDIwNzgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNTE0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOiBVbnNr aXAgaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZWRpcmVjdC1jcm9zcy1vcmlnaW4tdHJpcG1p bmUuaHRtbAorCiAyMDExLTA2LTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CiAKICAgICAgICAgW1F0XVtNYWNdIFNraXAgZmFpbGluZyB0ZXN0cy4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9Ta2lwcGVkCmluZGV4IDlhNjkyMmU1ZDA4NGI0MjFkYTYyYjQxN2I5NTkxMTVkNDliNjc1ZDIu LmIyMzc0ODc2YjZiZGFkMDRjY2ZkOTkwNjE3NjY1OTAwZTk5YmQ5NzggMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZApAQCAtMzY3LDcgKzM2Nyw2IEBAIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv Y3Jvc3Mtb3JpZ2luLWNvb2tpZS1zdG9yYWdlLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QvY2FjaGUtb3ZlcnJpZGUuaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jcm9zcy1v cmlnaW4tYXV0aG9yaXphdGlvbi5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2Nyb3Nz LW9yaWdpbi1uby1hdXRob3JpemF0aW9uLmh0bWwKLWh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv cmVkaXJlY3QtY3Jvc3Mtb3JpZ2luLXRyaXBtaW5lLmh0bWwKIAogIyA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0gIwogIyAgICAgICBGYWlsaW5nIGluc2VydGluZyB0ZXN0cy4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDJlNTM2MzVhYWQzNzdj NDY3ODg1ZmMyY2U1ODI5YmI5YTE2OGZmNzcuLjFkNmI3MjNhM2Y1Njc5MTU2YWYwZTcyNGU5NTk3 YWY3ODAyMDA3MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNi0xMiAgUm9i ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxl eGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBbUXRdIFF0IENvdW50ZXJwYXJ0IGZvciBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC80MjA3OAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI1MTQKKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvcXQvUmVzb3VyY2VIYW5kbGVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJDb3Jl U3luY2hyb25vdXNMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCk6CisKIDIwMTEtMDYtMTggIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI4OTE1NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvcXQvUmVzb3VyY2VIYW5kbGVRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlSGFuZGxlUXQuY3BwCmluZGV4IDY0MmQwYTYwNDFhYjYz ZDI0YzJlMWMwZWVhM2EzOTNkYTRkZDFkM2IuLjMwOGVmODFhNjkyNWY0NjVhYzA4MWMxNzgwY2Jk MjdjN2YwYzQ1ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv cXQvUmVzb3VyY2VIYW5kbGVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9xdC9SZXNvdXJjZUhhbmRsZVF0LmNwcApAQCAtNTksNiArNTksNyBAQCBwdWJsaWM6CiAg ICAgICAgICwgbV9kYXRhKGRhdGEpCiAgICAge30KIAorICAgIHZpcnR1YWwgdm9pZCB3aWxsU2Vu ZFJlcXVlc3QoUmVzb3VyY2VIYW5kbGUqLCBSZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBSZXNvdXJj ZVJlc3BvbnNlJik7CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVSZXNwb25zZShSZXNvdXJj ZUhhbmRsZSosIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKSB7IG1fcmVzcG9uc2Ug PSByZXNwb25zZTsgfQogICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlRGF0YShSZXNvdXJjZUhh bmRsZSosIGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgsIGludCkgeyBtX2RhdGEuYXBwZW5k KGRhdGEsIGxlbmd0aCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlkRmluaXNoTG9hZGluZyhSZXNv dXJjZUhhbmRsZSosIGRvdWJsZSAvKmZpbmlzaFRpbWUqLykge30KQEAgLTY5LDYgKzcwLDE3IEBA IHByaXZhdGU6CiAgICAgVmVjdG9yPGNoYXI+JiBtX2RhdGE7CiB9OwogCit2b2lkIFdlYkNvcmVT eW5jaHJvbm91c0xvYWRlcjo6d2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlSGFuZGxlKiBoYW5kbGUs IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgLypyZWRp cmVjdFJlc3BvbnNlKi8pCit7CisgICAgLy8gRklYTUU6IFRoaXMgbmVlZHMgdG8gYmUgZml4ZWQg dG8gZm9sbG93IHRoZSByZWRpcmVjdCBjb3JyZWN0bHkgZXZlbiBmb3IgY3Jvc3MtZG9tYWluIHJl cXVlc3RzLgorICAgIGlmICghcHJvdG9jb2xIb3N0QW5kUG9ydEFyZUVxdWFsKGhhbmRsZS0+Zmly c3RSZXF1ZXN0KCkudXJsKCksIHJlcXVlc3QudXJsKCkpKSB7CisgICAgICAgIEFTU0VSVChtX2Vy cm9yLmlzTnVsbCgpKTsKKyAgICAgICAgbV9lcnJvci5zZXRJc0NhbmNlbGxhdGlvbih0cnVlKTsK KyAgICAgICAgcmVxdWVzdCA9IFJlc291cmNlUmVxdWVzdCgpOworICAgICAgICByZXR1cm47Cisg ICAgfQorfQorCiBSZXNvdXJjZUhhbmRsZUludGVybmFsOjp+UmVzb3VyY2VIYW5kbGVJbnRlcm5h bCgpCiB7CiB9Cg==