62512 2011-06-12 09:05:47 -0700 [GTK] Remove webkit_web_view_get_selected_text 2011-06-12 16:36:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez xan.lopez christian kling mrobinson xan.lopez oldest_to_newest 419297 0 xan.lopez 2011-06-12 09:05:47 -0700 It's unused *and* private *and* can what it does can be done with the DOM bindings, so we can just nuke it. 419298 1 96881 xan.lopez 2011-06-12 09:10:02 -0700 Created attachment 96881 Patch 419300 2 96881 kling 2011-06-12 09:19:19 -0700 Comment on attachment 96881 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96881&action=review I'm not qualified to make decisions about the Gtk API, but it looks like a reasonable change to me. Note that the Midori browser currently uses this API, so it would be nice of you to let them know it's being removed. :) > Source/WebKit/gtk/ChangeLog:8 > + It's no longer used and is a privated method, so it can be Typo, private. 419347 3 mrobinson 2011-06-12 15:50:32 -0700 :/ I guess if Midori is using it we should make it deprecated with a note to use the DOM APIs and then remove it in some future release. 419352 4 xan.lopez 2011-06-12 16:10:22 -0700 (In reply to comment #3) > :/ I guess if Midori is using it we should make it deprecated with a note to use the DOM APIs and then remove it in some future release. Maybe it was not clear in the first comment, but this method is *private*. It's not exported in any public header, so whoever is using it does it at his own risk. 419353 5 mrobinson 2011-06-12 16:17:45 -0700 (In reply to comment #4) > (In reply to comment #3) > > :/ I guess if Midori is using it we should make it deprecated with a note to use the DOM APIs and then remove it in some future release. > > Maybe it was not clear in the first comment, but this method is *private*. It's not exported in any public header, so whoever is using it does it at his own risk. Apologies, I was thrown off momentarily because it had gtkdoc and Midori and claws are using it. I thought perhaps you had made a mistake in thinking it private. I don't see it on the documentation site though, so I believe that you are correct that it is safe to remove. I feel that we should not use gtkdoc for private methods. It seems too easy for them slip into the public documentation and sends the wrong message downstream. CCing Christian so that he has some advance warning. 419354 6 xan.lopez 2011-06-12 16:23:21 -0700 (In reply to comment #5) > Apologies, I was thrown off momentarily because it had gtkdoc and Midori and claws are using it. I thought perhaps you had made a mistake in thinking it private. I don't see it on the documentation site though, so I believe that you are correct that it is safe to remove. Maybe this is because it was used at some point in DRT (and that's the reason why it's in a header and marked with WEBKIT_API too). > > I feel that we should not use gtkdoc for private methods. It seems too easy for them slip into the public documentation and sends the wrong message downstream. CCing Christian so that he has some advance warning. Right. FWIW, we just cannot remove public methods. What you suggested (deprecate + remove later) is what has to happen, it's not really up to debate. With private methods, of course, we can do whatever we want. 419356 7 xan.lopez 2011-06-12 16:36:11 -0700 Landed in r88621, closing. 96881 2011-06-12 09:10:02 -0700 2011-06-12 16:17:51 -0700 Patch bug-62512-20110612180954.patch text/plain 2408 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogODg2MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBjMDA0OTQ0NDU2 MWM5ZjM3OGY0ZjU4MjJjNWJhNDczN2ZjNzUwNTc5Li43NmFkYThkYjdhNTI3ZjAwYTRmOTQ2ODI2 ODE0MWE4ZWY1ODA0MmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDYtMTIgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFJlbW92ZSB3ZWJraXRfd2ViX3Zp ZXdfZ2V0X3NlbGVjdGVkX3RleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNTEyCisKKyAgICAgICAgSXQncyBubyBsb25nZXIgdXNlZCBhbmQgaXMg YSBwcml2YXRlZCBtZXRob2QsIHNvIGl0IGNhbiBiZQorICAgICAgICByZW1vdmVkLgorCisgICAg ICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOiBraWxsIGl0LgorICAgICAgICAqIHdlYmtp dC93ZWJraXR3ZWJ2aWV3cHJpdmF0ZS5oOiBkaXR0by4KKwogMjAxMS0wNi0wOSAgTWFydGluIFJv Ymluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi dmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5k ZXggZWE2OWIwMmQ4MDhmMmQ1YTQ4ZTAzM2MxMjVmMWQ0ZmYwNWJhYzQ1NC4uYzYyMzk0MGRiZWZj NGQ5ZmVhMzQwMjI0ZmZlMDRjNjdjNGY0MWM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNDIxOCwyMiArNDIxOCw2IEBAIGdib29sZWFuIHdlYmtp dF93ZWJfdmlld19oYXNfc2VsZWN0aW9uKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB9CiAKIC8q KgotICogd2Via2l0X3dlYl92aWV3X2dldF9zZWxlY3RlZF90ZXh0OgotICogQHdlYlZpZXc6IGEg I1dlYktpdFdlYlZpZXcKLSAqCi0gKiBSZXRyaWV2ZXMgdGhlIHNlbGVjdGVkIHRleHQgaWYgYW55 LgotICoKLSAqIFJldHVybiB2YWx1ZTogYSBuZXdseSBhbGxvY2F0ZWQgc3RyaW5nIHdpdGggdGhl IHNlbGVjdGlvbiBvciAlTlVMTAotICovCi1nY2hhciogd2Via2l0X3dlYl92aWV3X2dldF9zZWxl Y3RlZF90ZXh0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCi17Ci0gICAgZ19yZXR1cm5fdmFsX2lm X2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVXKHdlYlZpZXcpLCAwKTsKLQotICAgIEZyYW1lKiBmcmFt ZSA9IGNvcmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUo KTsKLSAgICByZXR1cm4gZ19zdHJkdXAoZnJhbWUtPmVkaXRvcigpLT5zZWxlY3RlZFRleHQoKS51 dGY4KCkuZGF0YSgpKTsKLX0KLQotLyoqCiAgKiB3ZWJraXRfd2ViX3ZpZXdfc2VsZWN0X2FsbDoK ICAqIEB3ZWJWaWV3OiBhICNXZWJLaXRXZWJWaWV3CiAgKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXdwcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2Vidmlld3ByaXZhdGUuaAppbmRleCA0OGFmODJhMTBmNTlhOTc1MmY5 MzZhMGIwYTVkZWIxNTc1NTQyNzFhLi5lNjRiNTYwYTc3MDAzZTFiZGE3MzllM2I0YTg1ZTc3MjE5 Y2RhM2M1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmll d3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlld3By aXZhdGUuaApAQCAtMTE5LDggKzExOSw2IEBAIEdMaXN0KiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3N1 YnJlc291cmNlcyhXZWJLaXRXZWJWaWV3Kik7CiB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfdG9v bHRpcF90ZXh0KFdlYktpdFdlYlZpZXcqLCBjb25zdCBjaGFyKik7CiBHdGtNZW51KiB3ZWJraXRf d2ViX3ZpZXdfZ2V0X2NvbnRleHRfbWVudShXZWJLaXRXZWJWaWV3Kik7CiAKLVdFQktJVF9BUEkg Z2NoYXIqIHdlYmtpdF93ZWJfdmlld19nZXRfc2VsZWN0ZWRfdGV4dChXZWJLaXRXZWJWaWV3Kik7 Ci0KIHZvaWQgd2ViVmlld0VudGVyRnVsbHNjcmVlbihXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBX ZWJDb3JlOjpOb2RlKik7CiB2b2lkIHdlYlZpZXdFeGl0RnVsbHNjcmVlbihXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3KTsKIAo=