62508 2011-06-12 01:01:55 -0700 DocumentParser::appendBytes should use size_t for length instead of int 2011-06-12 19:05:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth darin webkit.review.bot oldest_to_newest 419273 0 abarth 2011-06-12 01:01:55 -0700 DocumentParser::appendBytes should use size_t for length instead of int 419274 1 96871 abarth 2011-06-12 01:03:10 -0700 Created attachment 96871 Patch 419371 2 96871 darin 2011-06-12 18:27:46 -0700 Comment on attachment 96871 Patch Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness. 419373 3 abarth 2011-06-12 18:30:42 -0700 (In reply to comment #2) > (From update of attachment 96871 [details]) > Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness. Yep! 419383 4 96871 webkit.review.bot 2011-06-12 19:05:40 -0700 Comment on attachment 96871 Patch Clearing flags on attachment: 96871 Committed r88623: <http://trac.webkit.org/changeset/88623> 419384 5 webkit.review.bot 2011-06-12 19:05:44 -0700 All reviewed patches have been landed. Closing bug. 96871 2011-06-12 01:03:10 -0700 2011-06-12 19:05:40 -0700 Patch bug-62508-20110612010309.patch text/plain 5885 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NjExKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDYtMTIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEb2N1bWVudFBhcnNlcjo6YXBwZW5kQnl0ZXMgc2hvdWxkIHVzZSBz aXplX3QgZm9yIGxlbmd0aCBpbnN0ZWFkIG9mIGludAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI1MDgKKworICAgICAgICBzaXplX3QgaXMgdGhlIHBy b3BlciB0eXBlIGZvciBkaXN0YW5jZXMgaW4gbWVtb3J5LCBlc3BlY2lhbGx5IG9uIDY0IGJpdAor ICAgICAgICBtYWNoaW5lcy4KKworICAgICAgICAqIGRvbS9EZWNvZGVkRGF0YURvY3VtZW50UGFy c2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRlY29kZWREYXRhRG9jdW1lbnRQYXJzZXI6OmFw cGVuZEJ5dGVzKToKKyAgICAgICAgKiBkb20vRGVjb2RlZERhdGFEb2N1bWVudFBhcnNlci5oOgor ICAgICAgICAqIGRvbS9Eb2N1bWVudFBhcnNlci5oOgorICAgICAgICAqIGh0bWwvSW1hZ2VEb2N1 bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZURvY3VtZW50UGFyc2VyOjphcHBlbmRC eXRlcyk6CisgICAgICAgICogaHRtbC9NZWRpYURvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhRG9jdW1lbnRQYXJzZXI6OmFwcGVuZEJ5dGVzKToKKyAgICAgICAgKiBodG1sL1Bs dWdpbkRvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpbkRvY3VtZW50UGFyc2Vy OjphcHBlbmRCeXRlcyk6CisgICAgICAgICogbG9hZGVyL1NpbmtEb2N1bWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTaW5rRG9jdW1lbnRQYXJzZXI6OmFwcGVuZEJ5dGVzKToKKwogMjAxMS0w Ni0xMSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9EZWNvZGVk RGF0YURvY3VtZW50UGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v RGVjb2RlZERhdGFEb2N1bWVudFBhcnNlci5jcHAJKHJldmlzaW9uIDg4NjEwKQorKysgU291cmNl L1dlYkNvcmUvZG9tL0RlY29kZWREYXRhRG9jdW1lbnRQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNyw3ICszNyw3IEBAIERlY29kZWREYXRhRG9jdW1lbnRQYXJzZXI6OkRlY29kZWREYXRh RG8KIHsKIH0KIAotdm9pZCBEZWNvZGVkRGF0YURvY3VtZW50UGFyc2VyOjphcHBlbmRCeXRlcyhE b2N1bWVudFdyaXRlciogd3JpdGVyLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuZ3RoKQordm9p ZCBEZWNvZGVkRGF0YURvY3VtZW50UGFyc2VyOjphcHBlbmRCeXRlcyhEb2N1bWVudFdyaXRlciog d3JpdGVyLCBjb25zdCBjaGFyKiBkYXRhLCBzaXplX3QgbGVuZ3RoKQogewogICAgIGlmICghbGVu Z3RoKQogICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRGVjb2RlZERh dGFEb2N1bWVudFBhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9EZWNv ZGVkRGF0YURvY3VtZW50UGFyc2VyLmgJKHJldmlzaW9uIDg4NjEwKQorKysgU291cmNlL1dlYkNv cmUvZG9tL0RlY29kZWREYXRhRG9jdW1lbnRQYXJzZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNDQs NyArNDQsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBhcHBlbmQoY29uc3QgU2VnbWVu dGVkU3RyaW5nJikgPSAwOwogCiAgICAgLy8gYXBwZW5kQnl0ZXMgYW5kIGZsdXNoIGFyZSB1c2Vk IGJ5IERvY3VtZW50V3JpdGVyICh0aGUgbG9hZGVyKS4KLSAgICB2aXJ0dWFsIHZvaWQgYXBwZW5k Qnl0ZXMoRG9jdW1lbnRXcml0ZXIqLCBjb25zdCBjaGFyKiBieXRlcywgaW50IGxlbmd0aCk7Cisg ICAgdmlydHVhbCB2b2lkIGFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29uc3QgY2hhciog Ynl0ZXMsIHNpemVfdCBsZW5ndGgpOwogICAgIHZpcnR1YWwgdm9pZCBmbHVzaChEb2N1bWVudFdy aXRlciopOwogfTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmgJKHJldmlz aW9uIDg4NjEwKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmgJKHdvcmtp bmcgY29weSkKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBpbnNl cnQoY29uc3QgU2VnbWVudGVkU3RyaW5nJikgPSAwOwogCiAgICAgLy8gYXBwZW5kQnl0ZXMgYW5k IGZsdXNoIGFyZSB1c2VkIGJ5IERvY3VtZW50V3JpdGVyICh0aGUgbG9hZGVyKS4KLSAgICB2aXJ0 dWFsIHZvaWQgYXBwZW5kQnl0ZXMoRG9jdW1lbnRXcml0ZXIqLCBjb25zdCBjaGFyKiBieXRlcywg aW50IGxlbmd0aCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBhcHBlbmRCeXRlcyhEb2N1bWVudFdy aXRlciosIGNvbnN0IGNoYXIqIGJ5dGVzLCBzaXplX3QgbGVuZ3RoKSA9IDA7CiAgICAgdmlydHVh bCB2b2lkIGZsdXNoKERvY3VtZW50V3JpdGVyKikgPSAwOwogCiAgICAgLy8gRklYTUU6IGFwcGVu ZCgpIHNob3VsZCBiZSBwcml2YXRlLCBidXQgRG9jdW1lbnRXcml0ZXI6OnJlcGxhY2VEb2N1bWVu dApJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZURvY3VtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlRG9jdW1lbnQuY3BwCShyZXZpc2lvbiA4ODYx MCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VEb2N1bWVudC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTkwLDcgKzkwLDcgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgfQogCi0gICAgdmlydHVh bCB2b2lkIGFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29uc3QgY2hhciosIGludCk7Cisg ICAgdmlydHVhbCB2b2lkIGFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29uc3QgY2hhcios IHNpemVfdCk7CiAgICAgdmlydHVhbCB2b2lkIGZpbmlzaCgpOwogfTsKIApAQCAtMTI0LDcgKzEy NCw3IEBAIHN0YXRpYyBmbG9hdCBwYWdlWm9vbUZhY3Rvcihjb25zdCBEb2N1bWUKICAgICByZXR1 cm4gZnJhbWUgPyBmcmFtZS0+cGFnZVpvb21GYWN0b3IoKSA6IDE7CiB9CiAKLXZvaWQgSW1hZ2VE b2N1bWVudFBhcnNlcjo6YXBwZW5kQnl0ZXMoRG9jdW1lbnRXcml0ZXIqLCBjb25zdCBjaGFyKiwg aW50KQordm9pZCBJbWFnZURvY3VtZW50UGFyc2VyOjphcHBlbmRCeXRlcyhEb2N1bWVudFdyaXRl ciosIGNvbnN0IGNoYXIqLCBzaXplX3QpCiB7CiAgICAgRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQo KS0+ZnJhbWUoKTsKICAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSBmcmFtZS0+c2V0dGluZ3MoKTsK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFEb2N1bWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYURvY3VtZW50LmNwcAkocmV2aXNpb24gODg2MTAp CisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02MCw3ICs2MCw3IEBAIHByaXZhdGU6CiAgICAgewogICAgIH0KIAotICAgIHZpcnR1YWwg dm9pZCBhcHBlbmRCeXRlcyhEb2N1bWVudFdyaXRlciosIGNvbnN0IGNoYXIqLCBpbnQpOworICAg IHZpcnR1YWwgdm9pZCBhcHBlbmRCeXRlcyhEb2N1bWVudFdyaXRlciosIGNvbnN0IGNoYXIqLCBz aXplX3QpOwogCiAgICAgdm9pZCBjcmVhdGVEb2N1bWVudFN0cnVjdHVyZSgpOwogCkBAIC0xMDMs NyArMTAzLDcgQEAgdm9pZCBNZWRpYURvY3VtZW50UGFyc2VyOjpjcmVhdGVEb2N1bWVudAogICAg IGZyYW1lLT5sb2FkZXIoKS0+YWN0aXZlRG9jdW1lbnRMb2FkZXIoKS0+bWFpblJlc291cmNlTG9h ZGVyKCktPnNldFNob3VsZEJ1ZmZlckRhdGEoZmFsc2UpOwogfQogCi12b2lkIE1lZGlhRG9jdW1l bnRQYXJzZXI6OmFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29uc3QgY2hhciosIGludCkK K3ZvaWQgTWVkaWFEb2N1bWVudFBhcnNlcjo6YXBwZW5kQnl0ZXMoRG9jdW1lbnRXcml0ZXIqLCBj b25zdCBjaGFyKiwgc2l6ZV90KQogewogICAgIGlmIChtX21lZGlhRWxlbWVudCkKICAgICAgICAg cmV0dXJuOwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9QbHVnaW5Eb2N1bWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9QbHVnaW5Eb2N1bWVudC5jcHAJKHJldmlz aW9uIDg4NjEwKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9QbHVnaW5Eb2N1bWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU4LDcgKzU4LDcgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgfQogCi0g ICAgdmlydHVhbCB2b2lkIGFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29uc3QgY2hhcios IGludCk7CisgICAgdmlydHVhbCB2b2lkIGFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29u c3QgY2hhciosIHNpemVfdCk7CiAKICAgICB2b2lkIGNyZWF0ZURvY3VtZW50U3RydWN0dXJlKCk7 CiAKQEAgLTEwMyw3ICsxMDMsNyBAQCB2b2lkIFBsdWdpbkRvY3VtZW50UGFyc2VyOjpjcmVhdGVE b2N1bWVuCiAgICAgYm9keS0+YXBwZW5kQ2hpbGQoZW1iZWRFbGVtZW50LCBlYyk7ICAgIAogfQog Ci12b2lkIFBsdWdpbkRvY3VtZW50UGFyc2VyOjphcHBlbmRCeXRlcyhEb2N1bWVudFdyaXRlcios IGNvbnN0IGNoYXIqLCBpbnQpCit2b2lkIFBsdWdpbkRvY3VtZW50UGFyc2VyOjphcHBlbmRCeXRl cyhEb2N1bWVudFdyaXRlciosIGNvbnN0IGNoYXIqLCBzaXplX3QpCiB7CiAgICAgaWYgKG1fZW1i ZWRFbGVtZW50KQogICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv U2lua0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU2lu a0RvY3VtZW50LmNwcAkocmV2aXNpb24gODg2MTApCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv U2lua0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQsNyArNDQsNyBAQCBwcml2YXRl OgogICAgIH0KIAogICAgIC8vIElnbm9yZSBhbGwgZGF0YS4KLSAgICB2aXJ0dWFsIHZvaWQgYXBw ZW5kQnl0ZXMoRG9jdW1lbnRXcml0ZXIqLCBjb25zdCBjaGFyKiwgaW50KSB7IH0KKyAgICB2aXJ0 dWFsIHZvaWQgYXBwZW5kQnl0ZXMoRG9jdW1lbnRXcml0ZXIqLCBjb25zdCBjaGFyKiwgc2l6ZV90 KSB7IH0KIH07CiAKIFNpbmtEb2N1bWVudDo6U2lua0RvY3VtZW50KEZyYW1lKiBmcmFtZSwgY29u c3QgS1VSTCYgdXJsKQo=