62505 2011-06-11 19:02:42 -0700 Remove unnecessary strlen from DocumentWriter 2011-06-11 22:09:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth darin webkit.review.bot oldest_to_newest 419260 0 abarth 2011-06-11 19:02:42 -0700 Remove unnecessary strlen from DocumentWriter 419261 1 96869 abarth 2011-06-11 19:04:40 -0700 Created attachment 96869 Patch 419262 2 96869 darin 2011-06-11 20:42:11 -0700 Comment on attachment 96869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96869&action=review > Source/WebCore/loader/DocumentWriter.cpp:204 > -void DocumentWriter::addData(const char* bytes, int length) > +void DocumentWriter::addData(const char* bytes, size_t length) > { > - if (length == -1) > - length = strlen(bytes); > - > m_parser->appendBytes(this, bytes, length); > } This function now truncates a passed-in size_t to an int by passing it to appendBytes. It would be possible to instead write a loop that does up to INT_MAX characters at once. Or to make a more extensive change so we use size_t in the signature of the appendBytes function too. 419264 3 96869 webkit.review.bot 2011-06-11 21:19:51 -0700 Comment on attachment 96869 Patch Clearing flags on attachment: 96869 Committed r88610: <http://trac.webkit.org/changeset/88610> 419265 4 webkit.review.bot 2011-06-11 21:19:55 -0700 All reviewed patches have been landed. Closing bug. 419266 5 abarth 2011-06-11 22:09:06 -0700 > It would be possible to instead write a loop that does up to INT_MAX characters at once. Or to make a more extensive change so we use size_t in the signature of the appendBytes function too. It seems like we should just use size_t everywhere for the length of the buffer. There's a bunch of code sites that need to change. I'll study it. 96869 2011-06-11 19:04:40 -0700 2011-06-11 21:19:51 -0700 Patch bug-62505-20110611190439.patch text/plain 4017 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NjA5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMTEgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkgc3RybGVuIGZyb20gRG9jdW1lbnRX cml0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYy NTA1CisKKyAgICAgICAgVGhpcyB1Z2x5IHBpZWNlIG9mIGNvZGUgYXBwZWFycyBub3QgdG8gYmUg bmVlZGVkLiAgUmVqb2ljZS4KKworICAgICAgICAqIFdlYkNvcmUuZXhwLmluOgorICAgICAgICAq IGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExv YWRlcjo6Y29tbWl0RGF0YSk6CisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmg6Cisg ICAgICAgICogbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRv Y3VtZW50V3JpdGVyOjphZGREYXRhKToKKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRXcml0ZXIu aDoKKwogMjAxMS0wNi0xMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5leHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJl dmlzaW9uIDg4NjA5KQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTMzMiw3ICszMzIsNyBAQCBfX1pON1dlYkNvcmUxM3RvSlNET01XaW5kb3dFTjNK U0M3SlNWYWx1CiBfX1pON1dlYkNvcmUxNENhY2hlZFJlc291cmNlMTJyZW1vdmVDbGllbnRFUE5T XzIwQ2FjaGVkUmVzb3VyY2VDbGllbnRFCiBfX1pON1dlYkNvcmUxNENhY2hlZFJlc291cmNlMTZ1 bnJlZ2lzdGVySGFuZGxlRVBOU18yNENhY2hlZFJlc291cmNlSGFuZGxlQmFzZUUKIF9fWk43V2Vi Q29yZTE0Q2FjaGVkUmVzb3VyY2U5YWRkQ2xpZW50RVBOU18yMENhY2hlZFJlc291cmNlQ2xpZW50 RQotX19aTjdXZWJDb3JlMTREb2N1bWVudExvYWRlcjEwY29tbWl0RGF0YUVQS2NpCitfX1pON1dl YkNvcmUxNERvY3VtZW50TG9hZGVyMTBjb21taXREYXRhRVBLY20KIF9fWk43V2ViQ29yZTE0RG9j dW1lbnRMb2FkZXIxM2F0dGFjaFRvRnJhbWVFdgogX19aTjdXZWJDb3JlMTREb2N1bWVudExvYWRl cjE1ZGV0YWNoRnJvbUZyYW1lRXYKIF9fWk43V2ViQ29yZTE0RG9jdW1lbnRMb2FkZXIxOGFkZEFy Y2hpdmVSZXNvdXJjZUVOM1dURjEwUGFzc1JlZlB0cklOU18xNUFyY2hpdmVSZXNvdXJjZUVFRQpJ bmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCShyZXZpc2lvbiA4 ODYwOSkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMwNyw3ICszMDcsNyBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjb21taXRM b2FkKGNvbnN0IGNoCiAgICAgZnJhbWVMb2FkZXItPmNsaWVudCgpLT5jb21taXR0ZWRMb2FkKHRo aXMsIGRhdGEsIGxlbmd0aCk7CiB9CiAKLXZvaWQgRG9jdW1lbnRMb2FkZXI6OmNvbW1pdERhdGEo Y29uc3QgY2hhciogYnl0ZXMsIGludCBsZW5ndGgpCit2b2lkIERvY3VtZW50TG9hZGVyOjpjb21t aXREYXRhKGNvbnN0IGNoYXIqIGJ5dGVzLCBzaXplX3QgbGVuZ3RoKQogewogICAgIC8vIFNldCB0 aGUgdGV4dCBlbmNvZGluZy4gIFRoaXMgaXMgc2FmZSB0byBjYWxsIG11bHRpcGxlIHRpbWVzLgog ICAgIGJvb2wgdXNlckNob3NlbiA9IHRydWU7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv RG9jdW1lbnRMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRMb2FkZXIuaAkocmV2aXNpb24gODg2MDkpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv RG9jdW1lbnRMb2FkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjM4LDcgKzIzOCw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogICAgICAgICAvLyBUaGUgV2ViS2l0IGxheWVyIGNhbGxzIHRoaXMg ZnVuY3Rpb24gd2hlbiBpdCdzIHJlYWR5IGZvciB0aGUgZGF0YSB0bwogICAgICAgICAvLyBhY3R1 YWxseSBiZSBhZGRlZCB0byB0aGUgZG9jdW1lbnQuCi0gICAgICAgIHZvaWQgY29tbWl0RGF0YShj b25zdCBjaGFyKiBieXRlcywgaW50IGxlbmd0aCk7CisgICAgICAgIHZvaWQgY29tbWl0RGF0YShj b25zdCBjaGFyKiBieXRlcywgc2l6ZV90IGxlbmd0aCk7CiAKICNpZiBFTkFCTEUoT0ZGTElORV9X RUJfQVBQTElDQVRJT05TKQogICAgICAgICBBcHBsaWNhdGlvbkNhY2hlSG9zdCogYXBwbGljYXRp b25DYWNoZUhvc3QoKSBjb25zdCB7IHJldHVybiBtX2FwcGxpY2F0aW9uQ2FjaGVIb3N0LmdldCgp OyB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5jcHAJKHJldmlz aW9uIDg4NjA5KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTk4LDExICsxOTgsOCBAQCB2b2lkIERvY3VtZW50V3JpdGVyOjpy ZXBvcnREYXRhUmVjZWl2ZWQoCiAgICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+cmVjYWxjU3R5bGUo Tm9kZTo6Rm9yY2UpOwogfQogCi12b2lkIERvY3VtZW50V3JpdGVyOjphZGREYXRhKGNvbnN0IGNo YXIqIGJ5dGVzLCBpbnQgbGVuZ3RoKQordm9pZCBEb2N1bWVudFdyaXRlcjo6YWRkRGF0YShjb25z dCBjaGFyKiBieXRlcywgc2l6ZV90IGxlbmd0aCkKIHsKLSAgICBpZiAobGVuZ3RoID09IC0xKQot ICAgICAgICBsZW5ndGggPSBzdHJsZW4oYnl0ZXMpOwotCiAgICAgbV9wYXJzZXItPmFwcGVuZEJ5 dGVzKHRoaXMsIGJ5dGVzLCBsZW5ndGgpOwogfQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRXcml0ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv RG9jdW1lbnRXcml0ZXIuaAkocmV2aXNpb24gODg2MDkpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRXcml0ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNyArNTEsNyBAQCBwdWJs aWM6CiAKICAgICB2b2lkIGJlZ2luKCk7CiAgICAgdm9pZCBiZWdpbihjb25zdCBLVVJMJiwgYm9v bCBkaXNwYXRjaFdpbmRvd09iamVjdEF2YWlsYWJsZSA9IHRydWUsIFNlY3VyaXR5T3JpZ2luKiBm b3JjZWRTZWN1cml0eU9yaWdpbiA9IDApOwotICAgIHZvaWQgYWRkRGF0YShjb25zdCBjaGFyKiBi eXRlcywgaW50IGxlbmd0aCA9IC0xKTsKKyAgICB2b2lkIGFkZERhdGEoY29uc3QgY2hhciogYnl0 ZXMsIHNpemVfdCBsZW5ndGgpOwogICAgIHZvaWQgZW5kKCk7CiAgICAgdm9pZCBlbmRJZk5vdExv YWRpbmdNYWluUmVzb3VyY2UoKTsKICAgICAK