62496 2011-06-10 19:00:05 -0700 REGRESSION (WebKit2): window.showModalDialog() broken 2011-06-10 19:04:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 419114 0 andersca 2011-06-10 19:00:05 -0700 REGRESSION (WebKit2): window.showModalDialog() broken 419117 1 96834 andersca 2011-06-10 19:02:17 -0700 Created attachment 96834 Patch 419119 2 andersca 2011-06-10 19:04:36 -0700 Committed r88588: <http://trac.webkit.org/changeset/88588> 96834 2011-06-10 19:02:17 -0700 2011-06-10 19:04:19 -0700 Patch bug-62496-20110610190215.patch text/plain 3462 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NTg2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMTAgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChXZWJLaXQyKTogd2luZG93LnNob3dN b2RhbERpYWxvZygpIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjI0OTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk1ODE0OTI+CisKKyAg ICAgICAgSWYgZGlzcGF0Y2hpbmcgYSBtZXNzYWdlIGVuZHMgdXAgY3JlYXRpbmcgYSBuZXN0ZWQg cnVuIGxvb3AsIHNvbWUgaW5jb21pbmcgbWVzc2FnZXMgY2FuIGVuZCB1cCBub3QgYmVpbmcKKyAg ICAgICAgZGVsaXZlcmVkIHVudGlsIHdlIGV4aXQgZnJvbSB0aGUgcnVuIGxvb3AuCisKKyAgICAg ICAgRml4IHRoaXMgYnkgdXNpbmcgYSBEZXF1ZSBpbnN0ZWFkIG9mIGEgVmVjdG9yIGZvciBpbmNv bWluZyBtZXNzYWdlcywgYW5kIGdldCBvbmUgbWVzc2FnZSBhdCBhIHRpbWUgYW5kIHRoZW4KKyAg ICAgICAgZGlzcGF0Y2ggaXQuIFRoYXQgcHJldmVudHMgdXMgZnJvbSBoYXZpbmcgYW55IGxpbmdl cmluZyBtZXNzYWdlcyBseWluZyBhcm91bmQgaW4gc3RhY2sgYWxsb2NhdGVkIHNwYWNlLgorCisg ICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKENvcmVJ UEM6OkNvbm5lY3Rpb246OndhaXRGb3JNZXNzYWdlKToKKyAgICAgICAgKENvcmVJUEM6OkNvbm5l Y3Rpb246OmRpc3BhdGNoTWVzc2FnZXMpOgorICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29u bmVjdGlvbi5oOgorCiAyMDExLTA2LTEwICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDogU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCShyZXZpc2lvbiA4ODU0NikK KysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMyNiwxNCArMzI2LDEzIEBAIFBhc3NPd25QdHI8QXJndW1lbnREZWNvZGVy PiBDb25uZWN0aW9uOjoKICAgICB7CiAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2luY29t aW5nTWVzc2FnZXNMb2NrKTsKIAotICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1faW5j b21pbmdNZXNzYWdlcy5zaXplKCk7ICsraSkgewotICAgICAgICAgICAgSW5jb21pbmdNZXNzYWdl JiBtZXNzYWdlID0gbV9pbmNvbWluZ01lc3NhZ2VzW2ldOworICAgICAgICBmb3IgKERlcXVlPElu Y29taW5nTWVzc2FnZT46Oml0ZXJhdG9yIGl0ID0gbV9pbmNvbWluZ01lc3NhZ2VzLmJlZ2luKCks IGVuZCA9IG1faW5jb21pbmdNZXNzYWdlcy5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KSB7CisgICAg ICAgICAgICBJbmNvbWluZ01lc3NhZ2UmIG1lc3NhZ2UgPSAqaXQ7CiAKICAgICAgICAgICAgIGlm IChtZXNzYWdlLm1lc3NhZ2VJRCgpID09IG1lc3NhZ2VJRCAmJiBtZXNzYWdlLmFyZ3VtZW50cygp LT5kZXN0aW5hdGlvbklEKCkgPT0gZGVzdGluYXRpb25JRCkgewogICAgICAgICAgICAgICAgIE93 blB0cjxBcmd1bWVudERlY29kZXI+IGFyZ3VtZW50cyA9IG1lc3NhZ2UucmVsZWFzZUFyZ3VtZW50 cygpOwogCi0gICAgICAgICAgICAgICAgLy8gRXJhc2UgdGhlIGluY29taW5nIG1lc3NhZ2UuCi0g ICAgICAgICAgICAgICAgbV9pbmNvbWluZ01lc3NhZ2VzLnJlbW92ZShpKTsKKyAgICAgICAgICAg ICAgICBtX2luY29taW5nTWVzc2FnZXMucmVtb3ZlKGl0KTsKICAgICAgICAgICAgICAgICByZXR1 cm4gYXJndW1lbnRzLnJlbGVhc2UoKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQpAQCAtNjg5 LDE1ICs2ODgsMTkgQEAgdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaE1lc3NhZ2UoSW5jb21pbgog CiB2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoTWVzc2FnZXMoKQogewotICAgIFZlY3RvcjxJbmNv bWluZ01lc3NhZ2U+IGluY29taW5nTWVzc2FnZXM7Ci0gICAgCi0gICAgewotICAgICAgICBNdXRl eExvY2tlciBsb2NrZXIobV9pbmNvbWluZ01lc3NhZ2VzTG9jayk7Ci0gICAgICAgIG1faW5jb21p bmdNZXNzYWdlcy5zd2FwKGluY29taW5nTWVzc2FnZXMpOwotICAgIH0KKyAgICB3aGlsZSAodHJ1 ZSkgeworICAgICAgICBJbmNvbWluZ01lc3NhZ2UgaW5jb21pbmdNZXNzYWdlOwogCi0gICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBpbmNvbWluZ01lc3NhZ2VzLnNpemUoKTsgKytpKQotICAgICAg ICBkaXNwYXRjaE1lc3NhZ2UoaW5jb21pbmdNZXNzYWdlc1tpXSk7CisgICAgICAgIHsKKyAgICAg ICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2luY29taW5nTWVzc2FnZXNMb2NrKTsKKyAgICAg ICAgICAgIGlmIChtX2luY29taW5nTWVzc2FnZXMuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAg IGJyZWFrOworCisgICAgICAgICAgICBpbmNvbWluZ01lc3NhZ2UgPSBtX2luY29taW5nTWVzc2Fn ZXMudGFrZUZpcnN0KCk7CisgICAgICAgIH0KKworICAgICAgICBkaXNwYXRjaE1lc3NhZ2UoaW5j b21pbmdNZXNzYWdlKTsKKyAgICB9CiB9CiAKIH0gLy8gbmFtZXNwYWNlIENvcmVJUEMKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCShyZXZpc2lv biA4ODU0NikKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5o CSh3b3JraW5nIGNvcHkpCkBAIC0yNTcsNyArMjU3LDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIElu Y29taW5nIG1lc3NhZ2VzLgogICAgIE11dGV4IG1faW5jb21pbmdNZXNzYWdlc0xvY2s7Ci0gICAg VmVjdG9yPEluY29taW5nTWVzc2FnZT4gbV9pbmNvbWluZ01lc3NhZ2VzOworICAgIERlcXVlPElu Y29taW5nTWVzc2FnZT4gbV9pbmNvbWluZ01lc3NhZ2VzOwogCiAgICAgLy8gT3V0Z29pbmcgbWVz c2FnZXMuCiAgICAgTXV0ZXggbV9vdXRnb2luZ01lc3NhZ2VzTG9jazsK