62460 2011-06-10 08:45:37 -0700 REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges 2011-06-12 18:35:01 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59693 1 webkit.review.bot morrita bfulgham dglazkov hbono oldest_to_newest 418714 0 webkit.review.bot 2011-06-10 08:45:37 -0700 REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges Requested by dglazkov on #webkit. 418717 1 dglazkov 2011-06-10 08:48:58 -0700 The problem is fairly obvious from looking at the stack trace. Please fix. ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) Backtrace: [0x01555675+133] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\javascriptcore\wtf\hashtable.h:467) [0x0155498F+47] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\javascriptcore\wtf\hashtable.h:483) WTF::HashMap<WTF::RefPtr<WebCore::Node>,WTF::Vector<WebCore::RenderedDocumentMarker,0> *,WTF::PtrHash<WTF::RefPtr<WebCore::Node> >,WTF::HashTraits<WTF::RefPtr<WebCore::Node> >,WTF::HashTraits<WTF::Vector<WebCore::RenderedDocumentMarker,0> *> >::inlineGet [0x01553C73+35] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\javascriptcore\wtf\refptrhashmap.h:274) WTF::HashMap<WTF::RefPtr<WebCore::Node>,WTF::Vector<WebCore::RenderedDocumentMarker,0> *,WTF::PtrHash<WTF::RefPtr<WebCore::Node> >,WTF::HashTraits<WTF::RefPtr<WebCore::Node> >,WTF::HashTraits<WTF::Vector<WebCore::RenderedDocumentMarker,0> *> >::get [0x01551CCA+26] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\javascriptcore\wtf\refptrhashmap.h:285) WebCore::DocumentMarkerController::userSpellingMarkersForNode [0x0155077E+78] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\dom\documentmarkercontroller.cpp:663) WebCore::HTMLInputElement::spellcheckRanges [0x0217D66C+44] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\html\htmlinputelement.cpp:1849) WebCore::HTMLInputElementInternal::spellcheckRangesAttrGetter [0x0214FE61+65] (e:\b\build\slave\webkit_win__dbg__1_\build\src\webkit\debug\obj\global_intermediate\webcore\bindings\v8htmlinputelement.cpp:638) v8::internal::Object::GetPropertyWithCallback [0x0051D1F5+421] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\objects.cc:204) v8::internal::Object::GetProperty [0x0051E938+744] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\objects.cc:576) v8::internal::Object::GetPropertyWithReceiver [0x0051CFE9+89] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\objects.cc:165) v8::internal::Object::GetProperty [0x0046DD6E+46] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\objects-inl.h:847) v8::internal::Runtime::GetObjectProperty [0x005F28A2+466] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\runtime.cc:3752) v8::internal::Runtime_KeyedGetProperty [0x005F2E39+969] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\runtime.cc:3834) (No symbol) [0x260600B6] (No symbol) [0x2607D739] (No symbol) [0x25250A21] (No symbol) [0x25259932] (No symbol) [0x2607311A] (No symbol) [0x26063D6B] v8::internal::Invoke [0x004DDA3C+412] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\execution.cc:122) v8::internal::Execution::Call [0x004DD82C+140] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\execution.cc:158) v8::Script::Run [0x0046BBEC+524] (e:\b\build\slave\webkit_win__dbg__1_\build\src\v8\src\api.cc:1552) WebCore::V8Proxy::runScript [0x013CEFD7+391] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\bindings\v8\v8proxy.cpp:435) WebCore::V8Proxy::evaluate [0x013CEA71+497] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\bindings\v8\v8proxy.cpp:389) WebCore::ScriptController::evaluate [0x014F9346+214] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\bindings\v8\scriptcontroller.cpp:243) WebCore::ScriptElement::executeScript [0x01895E6E+318] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\dom\scriptelement.cpp:277) WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent [0x022489AE+286] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\html\parser\htmlscriptrunner.cpp:140) WebCore::HTMLScriptRunner::executeParsingBlockingScript [0x022485F0+256] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\html\parser\htmlscriptrunner.cpp:119) WebCore::HTMLScriptRunner::executeParsingBlockingScripts [0x02248DEF+63] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\html\parser\htmlscriptrunner.cpp:196) WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad [0x02248EEB+219] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\html\parser\htmlscriptrunner.cpp:207) WebCore::HTMLDocumentParser::notifyFinished [0x021DA2BC+300] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\html\parser\htmldocumentparser.cpp:521) WebCore::CachedResource::checkNotify [0x015160CE+110] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\loader\cache\cachedresource.cpp:152) WebCore::CachedScript::data [0x0188773C+140] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\loader\cache\cachedscript.cpp:105) WebCore::CachedResourceRequest::didFinishLoading [0x017B20A5+341] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\loader\cache\cachedresourcerequest.cpp:163) WebCore::SubresourceLoader::didFinishLoading [0x018CF671+161] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\loader\subresourceloader.cpp:197) WebCore::ResourceLoader::didFinishLoading [0x017C2887+39] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webcore\loader\resourceloader.cpp:449) WebCore::ResourceHandleInternal::didFinishLoading [0x0228B4B0+144] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\source\webkit\chromium\src\resourcehandle.cpp:190) webkit_glue::WebURLLoaderImpl::Context::OnCompletedRequest [0x00B443BB+523] (e:\b\build\slave\webkit_win__dbg__1_\build\src\webkit\glue\weburlloader_impl.cc:662) `anonymous namespace'::RequestProxy::NotifyCompletedRequest [0x00AC4019+57] (e:\b\build\slave\webkit_win__dbg__1_\build\src\webkit\tools\test_shell\simple_resource_loader_bridge.cc:274) [0x00ACB641+33] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\tuple.h:564) [0x00AC9D65+53] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\task.h:338) `anonymous namespace'::TaskClosureAdapter::Run [0x01E03A02+50] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:102) base::internal::Invoker1<0,base::internal::InvokerStorage1<void (__thiscall `anonymous namespace'::TaskClosureAdapter::*)(void),A0x17a47d7c::TaskClosureAdapter *>,void (__thiscall `anonymous namespace'::TaskClosureAdapter::*)(void)>::DoInvoke [0x01E0EAAD+45] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\bind_internal.h:547) base::Callback<void __cdecl(void)>::Run [0x01E0636F+47] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\callback.h:261) MessageLoop::RunTask [0x01E050C5+293] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:484) MessageLoop::DeferOrRunPendingTask [0x01E05213+51] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:503) MessageLoop::DoWork [0x01E05BED+221] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:691) base::MessagePumpForUI::DoRunLoop [0x01E67154+84] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_pump_win.cc:203) base::MessagePumpWin::RunWithDispatcher [0x01E66A22+130] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_pump_win.cc:51) base::MessagePumpWin::Run [0x01E66C8C+28] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_pump_win.h:80) MessageLoop::RunInternal [0x01E04DE7+247] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:449) MessageLoop::RunHandler [0x01E04BBE+46] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:423) MessageLoop::Run [0x01E044CA+58] (e:\b\build\slave\webkit_win__dbg__1_\build\src\base\message_loop.cc:347) webkit_support::RunMessageLoop [0x008D812F+15] (e:\b\build\slave\webkit_win__dbg__1_\build\src\webkit\support\webkit_support.cc:376) TestShell::waitTestFinished [0x0042C4ED+141] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\tools\dumprendertree\chromium\testshellwin.cpp:106) TestShell::runFileTest [0x0044637F+479] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\tools\dumprendertree\chromium\testshell.cpp:225) runTest [0x0041B23D+733] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\tools\dumprendertree\chromium\dumprendertree.cpp:125) main [0x0041AA38+2232] (e:\b\build\slave\webkit_win__dbg__1_\build\src\third_party\webkit\tools\dumprendertree\chromium\dumprendertree.cpp:248) __tmainCRTStartup [0x00A69B37+279] (f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:266) mainCRTStartup [0x00A69A0F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crt0.c:182) RegisterWaitForInputIdle [0x7C817077+73] 418758 2 96754 dglazkov 2011-06-10 10:15:05 -0700 Created attachment 96754 Patch 418786 3 96754 webkit.review.bot 2011-06-10 10:57:04 -0700 Comment on attachment 96754 Patch Clearing flags on attachment: 96754 Committed r88551: <http://trac.webkit.org/changeset/88551> 418787 4 webkit.review.bot 2011-06-10 10:57:08 -0700 All reviewed patches have been landed. Closing bug. 419374 5 hbono 2011-06-12 18:35:01 -0700 Greetings Dimitri, Apologies for my bonehead mistake and thank you so much for fixing it. Regards, Hironori Bono 96754 2011-06-10 10:15:05 -0700 2011-06-10 10:57:04 -0700 Patch bug-62460-20110610101504.patch text/plain 1556 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogODg1NDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhYmM3YjYyOTk1MjRjNDM0 ZmNkNTNiYjVlZjcyZWI0ZjU5NzQzYzE4Li43MzRjYWUyZDNjZTQ0NDA4ZTQxMjk0NTNiNGZlZTcz Yzk4ZDgzODFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMTAgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChyODgzMzIpOiBwcm90b3R5 cGUtaW5oZXJpdGFuY2UtMiBBU1NFUlRTIGF0dGVtcHRpbmcgdG8gZW51bWVyYXRlIHNwZWxsQ2hl Y2tSYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYyNDYwCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLTIu aHRtbAorCisgICAgICAgICogZG9tL0RvY3VtZW50TWFya2VyQ29udHJvbGxlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudE1hcmtlckNvbnRyb2xsZXI6OnVzZXJTcGVsbGluZ01hcmtl cnNGb3JOb2RlKTogQWRkZWQgYW4gZXh0cmEgMC1jaGVjay4KKwogMjAxMS0wNi0xMCAgRGFyaW4g QWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJs c29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50TWFya2VyQ29udHJv bGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmNw cAppbmRleCA3MzRhN2ZhMjVjMmNhOWM2NDExOTMzOTU4YzY2MDQyODE5MWIxOGYyLi5kNTM0YTgw MGE2N2M2MjBjZjBjMjI2YzcyZWJmNDJlYzgxNzY0Mzc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmNwcApAQCAtNjYwLDcgKzY2MCwxMSBAQCBQ YXNzUmVmUHRyPFNwZWxsY2hlY2tSYW5nZUxpc3Q+IERvY3VtZW50TWFya2VyQ29udHJvbGxlcjo6 dXNlclNwZWxsaW5nTWFya2Vyc0ZvcgogewogICAgIFJlZlB0cjxTcGVsbGNoZWNrUmFuZ2VMaXN0 PiByZXN1bHQgPSBTcGVsbGNoZWNrUmFuZ2VMaXN0OjpjcmVhdGUoKTsKIAotICAgIE1hcmtlckxp c3QqIGxpc3QgPSBtX21hcmtlcnMuZ2V0KHVzZXJTcGVsbGluZ05vZGUobm9kZSkpOworICAgIE5v ZGUqIHNwZWxsaW5nTm9kZSA9IHVzZXJTcGVsbGluZ05vZGUobm9kZSk7CisgICAgaWYgKCFzcGVs bGluZ05vZGUpCisgICAgICAgIHJldHVybiByZXN1bHQ7CisKKyAgICBNYXJrZXJMaXN0KiBsaXN0 ID0gbV9tYXJrZXJzLmdldChzcGVsbGluZ05vZGUpOwogICAgIGlmICghbGlzdCkKICAgICAgICAg cmV0dXJuIHJlc3VsdDsKIAo=