62454 2011-06-10 05:46:50 -0700 [GTK] Add support for non-ASCII filenames in Content-Disposition header 2011-06-10 09:08:12 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar oldest_to_newest 418678 0 svillar 2011-06-10 05:46:50 -0700 RFC 2045 restricts parameter values (and hence Content-Disposition filenames) to US-ASCII. As we know standards are created to be broken :-), and that's why it's not rare to find filenames using non ASCII encodings. See https://bugzilla.gnome.org/show_bug.cgi?id=649305 418690 1 96742 svillar 2011-06-10 06:21:38 -0700 Created attachment 96742 Patch 418694 2 96742 gustavo 2011-06-10 06:57:30 -0700 Comment on attachment 96742 Patch LGTM! 418720 3 svillar 2011-06-10 09:08:12 -0700 Committed r88543: <http://trac.webkit.org/changeset/88543> 96742 2011-06-10 06:21:38 -0700 2011-06-10 06:57:30 -0700 Patch bug-62454-20110610152135.patch text/plain 1911 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogODg1MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NWY1ZGRkNzAzMzBiOWY0 YmE2NzdmNDNmNTExZjI5MDRkZjI4ZWIzLi44MjFiOGQ5ZTgzNTFhZTY5ODc3NjhiN2E1OGU5OWE5 MmJmYTc2OWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMTAgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9yIG5vbi1B U0NJSSBmaWxlbmFtZXMgaW4gQ29udGVudC1EaXNwb3NpdGlvbiBoZWFkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNDU0CisKKyAgICAgICAgVHJ5 IGxhdGluMSBhcyBmYWxsYmFjayBmb3IgaGVhZGVyIHBhcmFtZXRlciB2YWx1ZXMgYXMgc29tZSBz ZXJ2ZXJzCisgICAgICAgIGRvIG5vdCBmb2xsb3cgUkZDIDIwNDUgZm9yIGV4YW1wbGUgd2l0aCBm aWxlbmFtZSBwYXJhbWV0ZXIgaW4KKyAgICAgICAgQ29udGVudC1EaXNwb3NpdGlvbi4KKworICAg ICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQgYXMgbm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2VkLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2U6OnVwZGF0ZUZyb21Tb3VwTWVz c2FnZSk6CisKIDIwMTEtMDYtMTAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4ODUzMC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3Bv bnNlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3Vy Y2VSZXNwb25zZVNvdXAuY3BwCmluZGV4IDJjMjRlNmQwZWRmYzRlMjk0MWVmZjYyNGEyMTE3ZTky YjFkZDlhMDEuLjdiNTgzMjU2YTZhZDM3ZjIzMDM3NGExYWU1ZmUyZWQ0NmUwYmIyZGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3Bv bnNlU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl c291cmNlUmVzcG9uc2VTb3VwLmNwcApAQCAtNjcsNyArNjcsOCBAQCB2b2lkIFJlc291cmNlUmVz cG9uc2U6OnVwZGF0ZUZyb21Tb3VwTWVzc2FnZShTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UpCiAK ICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19pdGVyX2luaXQoJmhlYWRlcnNJdGVyLCBzb3VwTWVz c2FnZS0+cmVzcG9uc2VfaGVhZGVycyk7CiAgICAgd2hpbGUgKHNvdXBfbWVzc2FnZV9oZWFkZXJz X2l0ZXJfbmV4dCgmaGVhZGVyc0l0ZXIsICZoZWFkZXJOYW1lLCAmaGVhZGVyVmFsdWUpKQotICAg ICAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KFN0cmluZzo6ZnJvbVVURjgoaGVhZGVyTmFtZSks IFN0cmluZzo6ZnJvbVVURjgoaGVhZGVyVmFsdWUpKTsKKyAgICAgICAgbV9odHRwSGVhZGVyRmll bGRzLnNldChTdHJpbmc6OmZyb21VVEY4KGhlYWRlck5hbWUpLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFN0cmluZzo6ZnJvbVVURjhXaXRoTGF0aW4xRmFsbGJhY2soaGVhZGVyVmFs dWUsIHN0cmxlbihoZWFkZXJWYWx1ZSkpKTsKIAogICAgIG1fc291cEZsYWdzID0gc291cF9tZXNz YWdlX2dldF9mbGFncyhzb3VwTWVzc2FnZSk7CiAK