62446 2011-06-10 03:28:53 -0700 [Chromium] Worker object may be garbage collected if it doesn't send any messages 2011-06-15 01:30:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys ap caseq dimich dslomov jianli levin pfeldman oldest_to_newest 418618 0 96722 yurys 2011-06-10 03:28:53 -0700 Created attachment 96722 Test case If there are no references to a dedicated worker object and no messages are sent to its worker context(which would increment unconfirmed messages counter which in turn would protect worker from being collected) then it may be garbage collected before a first message from worker context arrives. See attached page where messages from the worker context never reaches worker object. This works fine on other ports that use in-process workers. 418634 1 96729 yurys 2011-06-10 04:07:15 -0700 Created attachment 96729 Patch 418805 2 dimich 2011-06-10 11:21:32 -0700 Did you mean r? it or is it still in the works? 420340 3 yurys 2011-06-14 05:36:55 -0700 (In reply to comment #2) > Did you mean r? it or is it still in the works? I wanted to run the test on Chromium to make sure that it passes there. Now the patch is ready for review. 420569 4 96729 dimich 2011-06-14 10:51:57 -0700 Comment on attachment 96729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96729&action=review r=me I wonder if it improves flakiness of worker tests run in Chromium. > Source/WebKit/chromium/ChangeLog:11 > + "from it context" -> "from its context" 421106 5 yurys 2011-06-15 01:26:51 -0700 Committed r88914: <http://trac.webkit.org/changeset/88914> 421108 6 yurys 2011-06-15 01:30:34 -0700 (In reply to comment #4) > (From update of attachment 96729 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96729&action=review > > r=me > I wonder if it improves flakiness of worker tests run in Chromium. > > > Source/WebKit/chromium/ChangeLog:11 > > + > > "from it context" -> "from its context" Done. 96722 2011-06-10 03:28:53 -0700 2011-06-10 03:28:53 -0700 Test case worker-init.zip application/zip 807 yurys UEsDBBQAAAAIAGpwyj7rJuihbQEAAAcDAAAQABwAd29ya2VyLWluaXQuaHRtbFVUCQAD6OvxTSjs 8U11eAsAAQQkdwAABIgTAABlUsFuwjAMvU/aP1g5BbG1cB0FaUPT4LDzDtMOWWPasDatkrQMTfz7 3KYtBXxJYj8/PzuOUpdnq/s7gOi7kEe6tXepalByyQzaKnNsFYXk6YM2Nqp0kAmdVCLBJduLWngn a6kAdpWOnSo0yCovucNfN4E/H2qsFgZym8ASZBFXOWoXxAaFw9cMmxdnVI5NFucMQgcNzbrQjgCU 2bxGgIEoQdexvBy3kvctTAJRlqjlOlWZ5ETXs5/8caXbOmHcR2F+0HB1o/3QBkiExgN0KOadj0or F+xtq/6c5YNBoXO0loZGuX0tjjWJvagBfm7svQMbjFHVKJ+AwRRafCCFE+MJnfp+hrrjHuZnOUOP zqgkQfO25jcNpijkiHtXGOCNX5Hu2YKOCOYzMrpOp1fSPQNNZkMk3YyejRFH3qSMJTfW4T5nXwS9 KttYOpBsLoOni++z6La0GaYWGR/6eoBZ33YU+gX1qx52ux6F3fr/A1BLAwQUAAAACAB7cMo+tpXg /GgAAACAAAAADgAcAHdvcmtlci1pbml0LmpzVVQJAAMJ7PFND+zxTXV4CwABBCR3AAAEiBMAAFWM sQqDQBAF+4P7h8XqBMGzzjfYhEBq0acsibviriAJ+ffELrYzw4yb9M4qZJDhCltUDKmkdwxEi5q3 MOsmpOKu6wMr9SqO3YmFnbsnvzAU5SWGTwznxY/VtcFvPEM3T/+2oibnfCRfUEsBAh4DFAAAAAgA anDKPusm6KFtAQAABwMAABAAGAAAAAAAAQAAAKSBAAAAAHdvcmtlci1pbml0Lmh0bWxVVAUAA+jr 8U11eAsAAQQkdwAABIgTAABQSwECHgMUAAAACAB7cMo+tpXg/GgAAACAAAAADgAYAAAAAAABAAAA pIG3AQAAd29ya2VyLWluaXQuanNVVAUAAwns8U11eAsAAQQkdwAABIgTAABQSwUGAAAAAAIAAgCq AAAAZwIAAAAA 96729 2011-06-10 04:07:15 -0700 2011-06-14 10:51:57 -0700 Patch worker-message-confirm.patch text/plain 5800 yurys ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MzcxMTg4Li5mNWFhNzA0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYt MTAgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBXb3JrZXIgb2Jq ZWN0IG1heSBiZSBnYXJiYWdlIGNvbGxlY3RlZCBpZiBpdCBkb2Vzbid0IHNlbmQgYW55IG1lc3Nh Z2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjQ0 NgorCisgICAgICAgICogZmFzdC93b3JrZXJzL3Jlc291cmNlcy93b3JrZXItaW5pdC5qczogQWRk ZWQuCisgICAgICAgICogZmFzdC93b3JrZXJzL3dvcmtlci1pbml0LWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC93b3JrZXJzL3dvcmtlci1pbml0Lmh0bWw6IEFkZGVkLgorCiAy MDExLTA2LTEwICBNYWhlc2ggS3Vsa2FybmkgIDxtYWhlc2gua3Vsa2FybmlAbm9raWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L3dvcmtlcnMvcmVzb3VyY2VzL3dvcmtlci1pbml0LmpzIGIvTGF5b3V0VGVzdHMv ZmFzdC93b3JrZXJzL3Jlc291cmNlcy93b3JrZXItaW5pdC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi5iNWMyNjI4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC93b3JrZXJzL3Jlc291cmNlcy93b3JrZXItaW5pdC5qcwpAQCAtMCwwICsxLDIgQEAKK3Bv c3RNZXNzYWdlKCJTVUNDRVNTOiBXb3JrZXIgY29udGV4dCBpbml0aWFsaXplZCIpOworCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLWluaXQtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1pbml0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi40NDE0ZmU1Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1pbml0LWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDQgQEAKK1Rlc3QgdGhhdCB3b3JrZXIgb2JqZWN0IGlzIG5vdCBnYXJiYWdlIGNvbGxl Y3RlZCBpZiB0aGVyZSBpcyBhIG1lc3NhZ2UgZnJvbSB3b3JrZXIgY29udGV4dC4gU2hvdWxkIHBy aW50ICJTVUNDRVNTIi4gQnVnIDYyNDQ2CisKK1NVQ0NFU1M6IFdvcmtlciBjb250ZXh0IGluaXRp YWxpemVkCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItaW5p dC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1pbml0Lmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWIzYmNkZAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItaW5pdC5odG1sCkBAIC0wLDAgKzEsNDMg QEAKKzxib2R5PgorPHA+VGVzdCB0aGF0IHdvcmtlciBvYmplY3QgaXMgbm90IGdhcmJhZ2UgY29s bGVjdGVkIGlmIHRoZXJlIGlzIGEgbWVzc2FnZSBmcm9tCit3b3JrZXIgY29udGV4dC4gU2hvdWxk IHByaW50ICJTVUNDRVNTIi4KKzxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02MjQ0NiI+QnVnIDYyNDQ2PC9hPjwvcD4KKzxkaXYgaWQ9cmVzdWx0PjwvZGl2 PgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgKz0gbWVzc2FnZSArICI8YnI+IjsKK30KKwor ZnVuY3Rpb24gZ2MoKQoreworICAgIGlmICh3aW5kb3cuR0NDb250cm9sbGVyKQorICAgICAgICBy ZXR1cm4gR0NDb250cm9sbGVyLmNvbGxlY3QoKTsKKworICAgIHZhciBoZWFkOworICAgIGZvciAo dmFyIGkgPSAwOyBpIDwgMTAwMDA7IGkrKykgeworICAgICAgICB2YXIgbmV3SGVhZCA9IG5ldyBB cnJheSgxMDAwKTsKKyAgICAgICAgbmV3SGVhZFswXSA9IGhlYWQ7CisgICAgICAgIGhlYWQgPSBu ZXdIZWFkOworICAgIH0KK30KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CisKK3ZhciBpbnRlcnZhbCA9IHNldEludGVydmFs KGdjLCAwKTsKKwordmFyIHdvcmtlciA9IG5ldyBXb3JrZXIoJ3Jlc291cmNlcy93b3JrZXItaW5p dC5qcycpOword29ya2VyLm9ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2dCkgeworICAgIGxvZyhldnQu ZGF0YSk7CisgICAgY2xlYXJJbnRlcnZhbChpbnRlcnZhbCk7CisgICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u ZSgpOworfQord29ya2VyID0gMDsKK2djKCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMGM5MTkwYi4uYjYzM2VmZCAxMDA3NTUKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMS0wNi0xMCAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIFdvcmtlciBvYmplY3QgbWF5IGJlIGdh cmJhZ2UgY29sbGVjdGVkIGlmIGl0IGRvZXNuJ3Qgc2VuZCBhbnkgbWVzc2FnZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNDQ2CisKKyAgICAgICAg QXNzdW1lIHRoYXQgV29ya2VyQ29udGV4dCBoYXMgcGVuZGluZyBhY3Rpdml0eSBiZWZvcmUgZXhw bGljaXQgbm90aWZpY2F0aW9uCisgICAgICAgIGlzIHJlY2VpdmVkIGZyb20gaXQuIEl0IHByZXZl bnRzIHdvcmtlciBvYmplY3QgZnJvbSBiZWluZyBjb2xsZWN0ZWQgYmVmb3JlCisgICAgICAgIHRo ZSBmaXJzdCBtZXNzYWdlIGZyb20gaXQgY29udGV4dCBpcyByZWNlaXZlZC4KKworICAgICAgICAq IHNyYy9XZWJXb3JrZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViV29ya2Vy Q2xpZW50SW1wbDo6c3RhcnRXb3JrZXJDb250ZXh0KToKKyAgICAgICAgKFdlYktpdDo6V2ViV29y a2VyQ2xpZW50SW1wbDo6c3RhcnRXb3JrZXJDb250ZXh0SW50ZXJuYWwpOgorICAgICAgICAoV2Vi S2l0OjpXZWJXb3JrZXJDbGllbnRJbXBsOjpzdGFydFdvcmtlckNvbnRleHRUYXNrKToKKyAgICAg ICAgKiBzcmMvV2ViV29ya2VyQ2xpZW50SW1wbC5oOgorCiAyMDExLTA2LTA5ICBZdXJ5IFNlbWlr aGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRy eSBUaXRvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYldvcmtl ckNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViV29ya2VyQ2xp ZW50SW1wbC5jcHAKaW5kZXggNDJjNTMxNy4uYzE5OGNjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViV29ya2VyQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViV29ya2VyQ2xpZW50SW1wbC5jcHAKQEAgLTE1MCw3ICsxNTAs MTMgQEAgdm9pZCBXZWJXb3JrZXJDbGllbnRJbXBsOjpzdGFydFdvcmtlckNvbnRleHQoY29uc3Qg S1VSTCYgc2NyaXB0VVJMLAogICAgICAgICAgICAgc291cmNlQ29kZSkpOwogICAgICAgICByZXR1 cm47CiAgICAgfQorICAgIHN0YXJ0V29ya2VyQ29udGV4dEludGVybmFsKHNjcmlwdFVSTCwgdXNl ckFnZW50LCBzb3VyY2VDb2RlKTsKK30KKwordm9pZCBXZWJXb3JrZXJDbGllbnRJbXBsOjpzdGFy dFdvcmtlckNvbnRleHRJbnRlcm5hbChjb25zdCBLVVJMJiBzY3JpcHRVUkwsIGNvbnN0IFdURjo6 U3RyaW5nJiB1c2VyQWdlbnQsIGNvbnN0IFdURjo6U3RyaW5nJiBzb3VyY2VDb2RlKQorewogICAg IG1fd2ViV29ya2VyLT5zdGFydFdvcmtlckNvbnRleHQoc2NyaXB0VVJMLCB1c2VyQWdlbnQsIHNv dXJjZUNvZGUpOworICAgIG1fd29ya2VyQ29udGV4dEhhZFBlbmRpbmdBY3Rpdml0eSA9IHRydWU7 IC8vIFdvcmtlciBpbml0aWFsaXphdGlvbiBtZWFucyBhIHBlbmRpbmcgYWN0aXZpdHkuCiB9CiAK IHZvaWQgV2ViV29ya2VyQ2xpZW50SW1wbDo6dGVybWluYXRlV29ya2VyQ29udGV4dCgpCkBAIC0z NTEsOCArMzU3LDcgQEAgdm9pZCBXZWJXb3JrZXJDbGllbnRJbXBsOjpzdGFydFdvcmtlckNvbnRl eHRUYXNrKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBTdHJpbmcmIHVzZXJBZ2VudCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBT dHJpbmcmIHNvdXJjZUNvZGUpCiB7Ci0gICAgdGhpc1B0ci0+bV93ZWJXb3JrZXItPnN0YXJ0V29y a2VyQ29udGV4dChLVVJMKFBhcnNlZFVSTFN0cmluZywgc2NyaXB0VVJMKSwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVzZXJBZ2VudCwgc291cmNlQ29kZSk7 CisgICAgdGhpc1B0ci0+c3RhcnRXb3JrZXJDb250ZXh0SW50ZXJuYWwoS1VSTChQYXJzZWRVUkxT dHJpbmcsIHNjcmlwdFVSTCksIHVzZXJBZ2VudCwgc291cmNlQ29kZSk7CiB9CiAKIHZvaWQgV2Vi V29ya2VyQ2xpZW50SW1wbDo6dGVybWluYXRlV29ya2VyQ29udGV4dFRhc2soU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCogY29udGV4dCwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYldvcmtlckNsaWVudEltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YldvcmtlckNsaWVudEltcGwuaAppbmRleCA2NThiZjVhLi5jMjcwZmZjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJXb3JrZXJDbGllbnRJbXBsLmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViV29ya2VyQ2xpZW50SW1wbC5oCkBAIC0xNTksNiAr MTU5LDggQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFdlYldvcmtlckNsaWVudEltcGwqIHRoaXNQdHIsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBib29sIGhhc1BlbmRpbmdBY3Rpdml0eSk7CiAKKyAgICB2b2lk IHN0YXJ0V29ya2VyQ29udGV4dEludGVybmFsKGNvbnN0IFdlYkNvcmU6OktVUkwmIHNjcmlwdFVS TCwgY29uc3QgV1RGOjpTdHJpbmcmIHVzZXJBZ2VudCwgY29uc3QgV1RGOjpTdHJpbmcmIHNvdXJj ZUNvZGUpOworCiAgICAgLy8gR3VhcmQgYWdhaW5zdCBjb250ZXh0IGZyb20gYmVpbmcgZGVzdHJv eWVkIGJlZm9yZSBhIHdvcmtlciBleGl0cy4KICAgICBSZWZQdHI8V2ViQ29yZTo6U2NyaXB0RXhl Y3V0aW9uQ29udGV4dD4gbV9zY3JpcHRFeGVjdXRpb25Db250ZXh0OwogCg==