62443 2011-06-10 02:16:38 -0700 Make dynamic annotations weak symbols and prevent identical code folding by the linker 2011-07-06 11:59:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 63252 1 timurrrr dvyukov barraclough dvyukov eric ggaren jamesr levin oliver timurrrr webkit.review.bot yurys oldest_to_newest 418601 0 timurrrr 2011-06-10 02:16:38 -0700 Make dynamic annotations weak symbols and prevent identical code folding by the linker 418602 1 96716 timurrrr 2011-06-10 02:18:00 -0700 Created attachment 96716 Patch 418605 2 timurrrr 2011-06-10 02:23:15 -0700 Hi David, James, Can you please review this small patch for me? Or can you recommend someone else to review it for me? FYI, all the changes done only affect anything when USE_DYNAMIC_ANNOTATIONS is defined => should only affect Chromium and only in the Debug- or Valgrind- build set up. Thanks, Timur 419911 3 eric 2011-06-13 15:01:47 -0700 I CC'd folks who know things about code generation. :) However, reading the bug I now see this is chromium-only. I'm still not sure who is particularly good for reviewing this. 419913 4 eric 2011-06-13 15:01:58 -0700 What happens w/o this change? 420268 5 dvyukov 2011-06-14 01:25:25 -0700 Hi Eric, > What happens w/o this change? As for __attribute__((weak)), our tools define strong symbols with the same names, so if WebKit annotations are not weak symbols we either get linker errors or our symbols do not trump WebKit symbols. As for Identical Code Folding and strange function bodies, linkers can fold symbols with identical bodies (as you may guess it especially affects empty functions because there are a lot of them). Then some tools (in particular, Valgrind) are unable to intercept such functions. It's possible to suppress such behavior with linker-specific flags, but (1) the problem is hard to debug (so it will make harm before people guess they need additional flags), (2) it can significantly increase binary size (especially crucial for ARM devices), (3) libraries have loose control over linker flags and (4) it's better to provide a solution that works either way anyway. 420410 6 eric 2011-06-14 07:53:32 -0700 So these functions are specifically added to WTF to provide hook-points for Valgrind, is that correct? Where are these functions called? (All over the place, I assume?) 420415 7 dvyukov 2011-06-14 08:01:10 -0700 > So these functions are specifically added to WTF to provide hook-points for Valgrind, is that correct? Yes. These are annotations for dynamic tools like Valgrind. > Where are these functions called? (All over the place, I assume?) Currently we added them only to thread-safe reference counters (wtf/ThreadSafeRefCounted.h) and strings (wtf/text/StringStatics.cpp, in order to deal with shared string bodies). 426027 8 dvyukov 2011-06-23 01:55:37 -0700 Ping 426033 9 96716 levin 2011-06-23 02:00:08 -0700 Comment on attachment 96716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96716&action=review Looks ok. > Source/JavaScriptCore/wtf/DynamicAnnotations.h:80 > +# define WTF_DYNAMIC_ANNOTATIONS_ATTRIBUTE_WEAK This # define style isn't used elsewhere in WebKit as far as I know. 426037 10 dvyukov 2011-06-23 02:03:09 -0700 Should we fix that define? If not, what should we do to land it? 426038 11 levin 2011-06-23 02:05:34 -0700 (In reply to comment #10) > Should we fix that define? > If not, what should we do to land it? Ideally if you'd like me to cq+ it or you can get someone else to land it who has commit permission. Or you can upload with the fix and put in "Reviewed by David Levin." in place of the oops since I gave you an r+. Then you only need to set cq? (and leave the r blank). Any WK committer can then change that to cq+. 426041 12 98327 dvyukov 2011-06-23 02:14:35 -0700 Created attachment 98327 Proposed patch 426042 13 96716 levin 2011-06-23 02:16:10 -0700 Comment on attachment 96716 Patch Please obsolete the old patch when uploading a new one. 426050 14 98327 webkit.review.bot 2011-06-23 02:55:51 -0700 Comment on attachment 98327 Proposed patch Clearing flags on attachment: 98327 Committed r89547: <http://trac.webkit.org/changeset/89547> 426051 15 webkit.review.bot 2011-06-23 02:55:56 -0700 All reviewed patches have been landed. Closing bug. 426144 16 yurys 2011-06-23 07:12:08 -0700 The patch was rolled out in http://trac.webkit.org/changeset/89566 since it caused Chromium Linux Debug to crash during startup. Debug bots also crashed: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29%281%29/builds/7586/steps/webkit_tests/logs/stdio 426865 17 98490 dvyukov 2011-06-24 06:52:57 -0700 Created attachment 98490 Proposed patch 426866 18 dvyukov 2011-06-24 06:53:23 -0700 Another take that does not use weak symbols. PTAL 426867 19 webkit.review.bot 2011-06-24 06:54:30 -0700 Attachment 98490 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/DynamicAnnotations.cpp:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/JavaScriptCore/wtf/DynamicAnnotations.cpp:38: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/DynamicAnnotations.cpp:41: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/JavaScriptCore/wtf/DynamicAnnotations.cpp:41: More than one command on the same line [whitespace/newline] [4] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 427887 20 98712 dvyukov 2011-06-27 06:27:05 -0700 Created attachment 98712 Proposed patch 427888 21 dvyukov 2011-06-27 06:27:42 -0700 PTAL 432917 22 98712 webkit.review.bot 2011-07-06 11:59:03 -0700 Comment on attachment 98712 Proposed patch Clearing flags on attachment: 98712 Committed r90477: <http://trac.webkit.org/changeset/90477> 432918 23 webkit.review.bot 2011-07-06 11:59:09 -0700 All reviewed patches have been landed. Closing bug. 96716 2011-06-10 02:18:00 -0700 2011-06-23 02:16:10 -0700 Patch bug-62443-20110610131756.patch text/plain 3971 timurrrr SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODg1MzMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDYtMTAgIFRpbXVyIElza2hvZHpoYW5vdiAgPHRpbXVycnJyQGdvb2dsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBkeW5h bWljIGFubm90YXRpb25zIHdlYWsgc3ltYm9scyBhbmQgcHJldmVudCBpZGVudGljYWwgY29kZSBm b2xkaW5nIGJ5IHRoZSBsaW5rZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNDQzCisKKyAgICAgICAgKiB3dGYvRHluYW1pY0Fubm90YXRpb25zLmNw cDoKKyAgICAgICAgKFdURkFubm90YXRlQmVuaWduUmFjZVNpemVkKToKKyAgICAgICAgKFdURkFu bm90YXRlSGFwcGVuc0JlZm9yZSk6CisgICAgICAgIChXVEZBbm5vdGF0ZUhhcHBlbnNBZnRlcik6 CisgICAgICAgICogd3RmL0R5bmFtaWNBbm5vdGF0aW9ucy5oOgorCiAyMDExLTA2LTA5ICBHZW9m ZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4OiBDb3Jy ZWN0ZWQgaGVhZGVyIHNwZWxsaW5nLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9E eW5hbWljQW5ub3RhdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvRHluYW1pY0Fubm90YXRpb25zLmNwcAkocmV2aXNpb24gODg0ODkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL0R5bmFtaWNBbm5vdGF0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI5LDcgKzI5LDIyIEBACiAjaW5jbHVkZSAiRHluYW1pY0Fubm90YXRpb25zLmgiCiAKICNp ZiBVU0UoRFlOQU1JQ19BTk5PVEFUSU9OUykKLXZvaWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6 ZWQoY29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUgdm9pZCosIGxvbmcsIGNvbnN0IGNo YXIqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQmVmb3JlKGNvbnN0IGNoYXIqLCBpbnQs IGNvbnN0IHZvbGF0aWxlIHZvaWQqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQWZ0ZXIo Y29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUgdm9pZCopIHsgfQorCisvKiBJZGVudGlj YWwgY29kZSBmb2xkaW5nKC1XbCwtLWljZj1hbGwpIGNvdW50ZXJtZWFzdXJlcy4KKyAqIFRoaXMg bWFrZXMgYWxsIEFubm90YXRlKiBmdW5jdGlvbnMgZGlmZmVyZW50LCB3aGljaCBwcmV2ZW50cyB0 aGUgbGlua2VyIGZyb20gZm9sZGluZyB0aGVtLgorICovCisjaWZkZWYgX19DT1VOVEVSX18KKyNk ZWZpbmUgRFlOQU1JQ19BTk5PVEFUSU9OU19JTVBMIFwKKyAgICB2b2xhdGlsZSBzaG9ydCBsaW5l bm8gPSAoX19MSU5FX18gPDwgOCkgKyBfX0NPVU5URVJfXzsgXAorICAgICh2b2lkKWxpbmVubzsK KyNlbHNlCisjZGVmaW5lIERZTkFNSUNfQU5OT1RBVElPTlNfSU1QTCBcCisgICAgdm9sYXRpbGUg c2hvcnQgbGluZW5vID0gKF9fTElORV9fIDw8IDgpOyBcCisgICAgKHZvaWQpbGluZW5vOworI2Vu ZGlmCisKK3ZvaWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciosIGludCwg Y29uc3Qgdm9sYXRpbGUgdm9pZCosIGxvbmcsIGNvbnN0IGNoYXIqKSB7IERZTkFNSUNfQU5OT1RB VElPTlNfSU1QTCB9Cit2b2lkIFdURkFubm90YXRlSGFwcGVuc0JlZm9yZShjb25zdCBjaGFyKiwg aW50LCBjb25zdCB2b2xhdGlsZSB2b2lkKikgeyBEWU5BTUlDX0FOTk9UQVRJT05TX0lNUEwgfQor dm9pZCBXVEZBbm5vdGF0ZUhhcHBlbnNBZnRlcihjb25zdCBjaGFyKiwgaW50LCBjb25zdCB2b2xh dGlsZSB2b2lkKikgeyBEWU5BTUlDX0FOTk9UQVRJT05TX0lNUEwgfQogI2VuZGlmIC8vIFVTRShE WU5BTUlDX0FOTk9UQVRJT05TKQorCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0R5 bmFtaWNBbm5vdGF0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvRHluYW1pY0Fubm90YXRpb25zLmgJKHJldmlzaW9uIDg4NDg5KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9EeW5hbWljQW5ub3RhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtNzMs MTcgKzczLDI2IEBACiAjZGVmaW5lIFdURl9BTk5PVEFURV9IQVBQRU5TX0JFRk9SRShhZGRyZXNz KSBXVEZBbm5vdGF0ZUhhcHBlbnNCZWZvcmUoX19GSUxFX18sIF9fTElORV9fLCBhZGRyZXNzKQog I2RlZmluZSBXVEZfQU5OT1RBVEVfSEFQUEVOU19BRlRFUihhZGRyZXNzKSBXVEZBbm5vdGF0ZUhh cHBlbnNBZnRlcihfX0ZJTEVfXywgX19MSU5FX18sIGFkZHJlc3MpCiAKKy8qIFRoZSBkeW5hbWlj IGFubm90YXRpb25zIG11c3QgYmUgd2VhayBzeW1ib2xzIHRvIGJlIGludGVyY2VwdGFibGUgYnkg YSBsaW5rZXIuICovCisjaWYgZGVmaW5lZChfX0dOVUNfXykKKyMgICBkZWZpbmUgV1RGX0RZTkFN SUNfQU5OT1RBVElPTlNfQVRUUklCVVRFX1dFQUsgX19hdHRyaWJ1dGVfXygod2VhaykpCisjZWxz ZQorIyAgIGRlZmluZSBXVEZfRFlOQU1JQ19BTk5PVEFUSU9OU19BVFRSSUJVVEVfV0VBSworI2Vu ZGlmCisKICNpZmRlZiBfX2NwbHVzcGx1cwogZXh0ZXJuICJDIiB7CiAjZW5kaWYKIC8qIERvbid0 IHVzZSB0aGVzZSBkaXJlY3RseSwgdXNlIHRoZSBhYm92ZSBtYWNyb3MgaW5zdGVhZC4gKi8KLXZv aWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUs IGNvbnN0IHZvbGF0aWxlIHZvaWQqIG1lbW9yeSwgbG9uZyBzaXplLCBjb25zdCBjaGFyKiBkZXNj cmlwdGlvbik7Ci12b2lkIFdURkFubm90YXRlSGFwcGVuc0JlZm9yZShjb25zdCBjaGFyKiBmaWxl LCBpbnQgbGluZSwgY29uc3Qgdm9sYXRpbGUgdm9pZCogYWRkcmVzcyk7Ci12b2lkIFdURkFubm90 YXRlSGFwcGVuc0FmdGVyKGNvbnN0IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCB2b2xhdGls ZSB2b2lkKiBhZGRyZXNzKTsKK3ZvaWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3Qg Y2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IHZvbGF0aWxlIHZvaWQqIG1lbW9yeSwgbG9uZyBz aXplLCBjb25zdCBjaGFyKiBkZXNjcmlwdGlvbikgV1RGX0RZTkFNSUNfQU5OT1RBVElPTlNfQVRU UklCVVRFX1dFQUs7Cit2b2lkIFdURkFubm90YXRlSGFwcGVuc0JlZm9yZShjb25zdCBjaGFyKiBm aWxlLCBpbnQgbGluZSwgY29uc3Qgdm9sYXRpbGUgdm9pZCogYWRkcmVzcykgV1RGX0RZTkFNSUNf QU5OT1RBVElPTlNfQVRUUklCVVRFX1dFQUs7Cit2b2lkIFdURkFubm90YXRlSGFwcGVuc0FmdGVy KGNvbnN0IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCB2b2xhdGlsZSB2b2lkKiBhZGRyZXNz KSBXVEZfRFlOQU1JQ19BTk5PVEFUSU9OU19BVFRSSUJVVEVfV0VBSzsKICNpZmRlZiBfX2NwbHVz cGx1cwogfSAvLyBleHRlcm4gIkMiCiAjZW5kaWYKIAorI3VuZGVmIFdURl9EWU5BTUlDX0FOTk9U QVRJT05TX0FUVFJJQlVURV9XRUFLCisKICNlbHNlIC8vIFVTRShEWU5BTUlDX0FOTk9UQVRJT05T KQogLyogVGhlc2UgbWFjcm9zIGFyZSBlbXB0eSB3aGVuIGR5bmFtaWMgYW5ub3RhdGlvbnMgYXJl IG5vdCBlbmFibGVkIHNvIHlvdSBjYW4KICAqIHVzZSB0aGVtIHdpdGhvdXQgYWZmZWN0aW5nIHRo ZSBwZXJmb3JtYW5jZSBvZiByZWxlYXNlIGJpbmFyaWVzLiAqLwo= 98327 2011-06-23 02:14:35 -0700 2011-06-24 06:52:57 -0700 Proposed patch bug-62443-20110610131756.patch text/plain 3965 dvyukov SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODg1MzMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDYtMTAgIFRpbXVyIElza2hvZHpoYW5vdiAgPHRpbXVycnJyQGdvb2dsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBkeW5h bWljIGFubm90YXRpb25zIHdlYWsgc3ltYm9scyBhbmQgcHJldmVudCBpZGVudGljYWwgY29kZSBm b2xkaW5nIGJ5IHRoZSBsaW5rZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNDQzCisKKyAgICAgICAgKiB3dGYvRHluYW1pY0Fubm90YXRpb25zLmNw cDoKKyAgICAgICAgKFdURkFubm90YXRlQmVuaWduUmFjZVNpemVkKToKKyAgICAgICAgKFdURkFu bm90YXRlSGFwcGVuc0JlZm9yZSk6CisgICAgICAgIChXVEZBbm5vdGF0ZUhhcHBlbnNBZnRlcik6 CisgICAgICAgICogd3RmL0R5bmFtaWNBbm5vdGF0aW9ucy5oOgorCiAyMDExLTA2LTA5ICBHZW9m ZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4OiBDb3Jy ZWN0ZWQgaGVhZGVyIHNwZWxsaW5nLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9E eW5hbWljQW5ub3RhdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvRHluYW1pY0Fubm90YXRpb25zLmNwcAkocmV2aXNpb24gODg0ODkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL0R5bmFtaWNBbm5vdGF0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI5LDcgKzI5LDIyIEBACiAjaW5jbHVkZSAiRHluYW1pY0Fubm90YXRpb25zLmgiCiAKICNp ZiBVU0UoRFlOQU1JQ19BTk5PVEFUSU9OUykKLXZvaWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6 ZWQoY29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUgdm9pZCosIGxvbmcsIGNvbnN0IGNo YXIqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQmVmb3JlKGNvbnN0IGNoYXIqLCBpbnQs IGNvbnN0IHZvbGF0aWxlIHZvaWQqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQWZ0ZXIo Y29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUgdm9pZCopIHsgfQorCisvKiBJZGVudGlj YWwgY29kZSBmb2xkaW5nKC1XbCwtLWljZj1hbGwpIGNvdW50ZXJtZWFzdXJlcy4KKyAqIFRoaXMg bWFrZXMgYWxsIEFubm90YXRlKiBmdW5jdGlvbnMgZGlmZmVyZW50LCB3aGljaCBwcmV2ZW50cyB0 aGUgbGlua2VyIGZyb20gZm9sZGluZyB0aGVtLgorICovCisjaWZkZWYgX19DT1VOVEVSX18KKyNk ZWZpbmUgRFlOQU1JQ19BTk5PVEFUSU9OU19JTVBMIFwKKyAgICB2b2xhdGlsZSBzaG9ydCBsaW5l bm8gPSAoX19MSU5FX18gPDwgOCkgKyBfX0NPVU5URVJfXzsgXAorICAgICh2b2lkKWxpbmVubzsK KyNlbHNlCisjZGVmaW5lIERZTkFNSUNfQU5OT1RBVElPTlNfSU1QTCBcCisgICAgdm9sYXRpbGUg c2hvcnQgbGluZW5vID0gKF9fTElORV9fIDw8IDgpOyBcCisgICAgKHZvaWQpbGluZW5vOworI2Vu ZGlmCisKK3ZvaWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciosIGludCwg Y29uc3Qgdm9sYXRpbGUgdm9pZCosIGxvbmcsIGNvbnN0IGNoYXIqKSB7IERZTkFNSUNfQU5OT1RB VElPTlNfSU1QTCB9Cit2b2lkIFdURkFubm90YXRlSGFwcGVuc0JlZm9yZShjb25zdCBjaGFyKiwg aW50LCBjb25zdCB2b2xhdGlsZSB2b2lkKikgeyBEWU5BTUlDX0FOTk9UQVRJT05TX0lNUEwgfQor dm9pZCBXVEZBbm5vdGF0ZUhhcHBlbnNBZnRlcihjb25zdCBjaGFyKiwgaW50LCBjb25zdCB2b2xh dGlsZSB2b2lkKikgeyBEWU5BTUlDX0FOTk9UQVRJT05TX0lNUEwgfQogI2VuZGlmIC8vIFVTRShE WU5BTUlDX0FOTk9UQVRJT05TKQorCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0R5 bmFtaWNBbm5vdGF0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvRHluYW1pY0Fubm90YXRpb25zLmgJKHJldmlzaW9uIDg4NDg5KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9EeW5hbWljQW5ub3RhdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtNzMs MTcgKzczLDI2IEBACiAjZGVmaW5lIFdURl9BTk5PVEFURV9IQVBQRU5TX0JFRk9SRShhZGRyZXNz KSBXVEZBbm5vdGF0ZUhhcHBlbnNCZWZvcmUoX19GSUxFX18sIF9fTElORV9fLCBhZGRyZXNzKQog I2RlZmluZSBXVEZfQU5OT1RBVEVfSEFQUEVOU19BRlRFUihhZGRyZXNzKSBXVEZBbm5vdGF0ZUhh cHBlbnNBZnRlcihfX0ZJTEVfXywgX19MSU5FX18sIGFkZHJlc3MpCiAKKy8qIFRoZSBkeW5hbWlj IGFubm90YXRpb25zIG11c3QgYmUgd2VhayBzeW1ib2xzIHRvIGJlIGludGVyY2VwdGFibGUgYnkg YSBsaW5rZXIuICovCisjaWYgZGVmaW5lZChfX0dOVUNfXykKKyNkZWZpbmUgV1RGX0RZTkFNSUNf QU5OT1RBVElPTlNfQVRUUklCVVRFX1dFQUsgX19hdHRyaWJ1dGVfXygod2VhaykpCisjZWxzZQor I2RlZmluZSBXVEZfRFlOQU1JQ19BTk5PVEFUSU9OU19BVFRSSUJVVEVfV0VBSworI2VuZGlmCisK ICNpZmRlZiBfX2NwbHVzcGx1cwogZXh0ZXJuICJDIiB7CiAjZW5kaWYKIC8qIERvbid0IHVzZSB0 aGVzZSBkaXJlY3RseSwgdXNlIHRoZSBhYm92ZSBtYWNyb3MgaW5zdGVhZC4gKi8KLXZvaWQgV1RG QW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0 IHZvbGF0aWxlIHZvaWQqIG1lbW9yeSwgbG9uZyBzaXplLCBjb25zdCBjaGFyKiBkZXNjcmlwdGlv bik7Ci12b2lkIFdURkFubm90YXRlSGFwcGVuc0JlZm9yZShjb25zdCBjaGFyKiBmaWxlLCBpbnQg bGluZSwgY29uc3Qgdm9sYXRpbGUgdm9pZCogYWRkcmVzcyk7Ci12b2lkIFdURkFubm90YXRlSGFw cGVuc0FmdGVyKGNvbnN0IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCB2b2xhdGlsZSB2b2lk KiBhZGRyZXNzKTsKK3ZvaWQgV1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciog ZmlsZSwgaW50IGxpbmUsIGNvbnN0IHZvbGF0aWxlIHZvaWQqIG1lbW9yeSwgbG9uZyBzaXplLCBj b25zdCBjaGFyKiBkZXNjcmlwdGlvbikgV1RGX0RZTkFNSUNfQU5OT1RBVElPTlNfQVRUUklCVVRF X1dFQUs7Cit2b2lkIFdURkFubm90YXRlSGFwcGVuc0JlZm9yZShjb25zdCBjaGFyKiBmaWxlLCBp bnQgbGluZSwgY29uc3Qgdm9sYXRpbGUgdm9pZCogYWRkcmVzcykgV1RGX0RZTkFNSUNfQU5OT1RB VElPTlNfQVRUUklCVVRFX1dFQUs7Cit2b2lkIFdURkFubm90YXRlSGFwcGVuc0FmdGVyKGNvbnN0 IGNoYXIqIGZpbGUsIGludCBsaW5lLCBjb25zdCB2b2xhdGlsZSB2b2lkKiBhZGRyZXNzKSBXVEZf RFlOQU1JQ19BTk5PVEFUSU9OU19BVFRSSUJVVEVfV0VBSzsKICNpZmRlZiBfX2NwbHVzcGx1cwog fSAvLyBleHRlcm4gIkMiCiAjZW5kaWYKIAorI3VuZGVmIFdURl9EWU5BTUlDX0FOTk9UQVRJT05T X0FUVFJJQlVURV9XRUFLCisKICNlbHNlIC8vIFVTRShEWU5BTUlDX0FOTk9UQVRJT05TKQogLyog VGhlc2UgbWFjcm9zIGFyZSBlbXB0eSB3aGVuIGR5bmFtaWMgYW5ub3RhdGlvbnMgYXJlIG5vdCBl bmFibGVkIHNvIHlvdSBjYW4KICAqIHVzZSB0aGVtIHdpdGhvdXQgYWZmZWN0aW5nIHRoZSBwZXJm b3JtYW5jZSBvZiByZWxlYXNlIGJpbmFyaWVzLiAqLwo= 98490 2011-06-24 06:52:57 -0700 2011-06-27 06:27:05 -0700 Proposed patch patch text/plain 2217 dvyukov SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODk2NzEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDYtMjQgIERtaXRyaXkgVnl1a292ICA8ZHZ5dWtvdkBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93IHN1YnN0aXR1 dGlvbiBvZiBkeW5hbWljIGFubm90YXRpb25zIGFuZCBwcmV2ZW50IGlkZW50aWNhbCBjb2RlIGZv bGRpbmcgYnkgdGhlIGxpbmtlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNDQzCisKKyAgICAgICAgKiB3dGYvRHluYW1pY0Fubm90YXRpb25zLmNw cDoKKyAgICAgICAgKFdURkFubm90YXRlQmVuaWduUmFjZVNpemVkKToKKyAgICAgICAgKFdURkFu bm90YXRlSGFwcGVuc0JlZm9yZSk6CisgICAgICAgIChXVEZBbm5vdGF0ZUhhcHBlbnNBZnRlcik6 CisKIDIwMTEtMDYtMjQgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4OTU5NC4KSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvRHluYW1pY0Fubm90YXRpb25zLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0R5bmFtaWNBbm5vdGF0aW9ucy5jcHAJKHJldmlz aW9uIDg5NjcxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9EeW5hbWljQW5ub3RhdGlv bnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw4ICsyOCwyMSBAQAogCiAjaW5jbHVkZSAiRHlu YW1pY0Fubm90YXRpb25zLmgiCiAKLSNpZiBVU0UoRFlOQU1JQ19BTk5PVEFUSU9OUykKLXZvaWQg V1RGQW5ub3RhdGVCZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRp bGUgdm9pZCosIGxvbmcsIGNvbnN0IGNoYXIqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVIYXBwZW5z QmVmb3JlKGNvbnN0IGNoYXIqLCBpbnQsIGNvbnN0IHZvbGF0aWxlIHZvaWQqKSB7IH0KLXZvaWQg V1RGQW5ub3RhdGVIYXBwZW5zQWZ0ZXIoY29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUg dm9pZCopIHsgfQotI2VuZGlmIC8vIFVTRShEWU5BTUlDX0FOTk9UQVRJT05TKQorI2lmIFVTRShE WU5BTUlDX0FOTk9UQVRJT05TKSAmJiAhVVNFKERZTkFNSUNfQU5OT1RBVElPTlNfTk9JTVBMKQor CisvLyBJZGVudGljYWwgY29kZSBmb2xkaW5nKC1XbCwtLWljZj1hbGwpIGNvdW50ZXJtZWFzdXJl cy4KKy8vIFRoaXMgbWFrZXMgYWxsIEFubm90YXRlKiBmdW5jdGlvbnMgZGlmZmVyZW50LCB3aGlj aCBwcmV2ZW50cyB0aGUgbGlua2VyIGZyb20KKy8vIGZvbGRpbmcgdGhlbS4KKyNpZmRlZiBfX0NP VU5URVJfXworI2RlZmluZSBEWU5BTUlDX0FOTk9UQVRJT05TX0lNUEwgXAorICB2b2xhdGlsZSBz aG9ydCBsaW5lbm8gPSAoX19MSU5FX18gPDwgOCkgKyBfX0NPVU5URVJfXzsgKHZvaWQpbGluZW5v OworI2Vsc2UKKyNkZWZpbmUgRFlOQU1JQ19BTk5PVEFUSU9OU19JTVBMIFwKKyAgdm9sYXRpbGUg c2hvcnQgbGluZW5vID0gKF9fTElORV9fIDw8IDgpOyAodm9pZClsaW5lbm87CisjZW5kaWYKKwor dm9pZCBXVEZBbm5vdGF0ZUJlbmlnblJhY2VTaXplZChjb25zdCBjaGFyKiwgaW50LCBjb25zdCB2 b2xhdGlsZSB2b2lkKiwgbG9uZywgY29uc3QgY2hhciopIHsgRFlOQU1JQ19BTk5PVEFUSU9OU19J TVBMIH0KK3ZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQmVmb3JlKGNvbnN0IGNoYXIqLCBpbnQsIGNv bnN0IHZvbGF0aWxlIHZvaWQqKSB7IERZTkFNSUNfQU5OT1RBVElPTlNfSU1QTCB9Cit2b2lkIFdU RkFubm90YXRlSGFwcGVuc0FmdGVyKGNvbnN0IGNoYXIqLCBpbnQsIGNvbnN0IHZvbGF0aWxlIHZv aWQqKSB7IERZTkFNSUNfQU5OT1RBVElPTlNfSU1QTCB9CisKKyNlbmRpZiAvLyBVU0UoRFlOQU1J Q19BTk5PVEFUSU9OUykgJiYgIVVTRShEWU5BTUlDX0FOTk9UQVRJT05TX05PSU1QTCkK 98712 2011-06-27 06:27:05 -0700 2011-07-06 11:59:03 -0700 Proposed patch patch text/plain 2248 dvyukov SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODk4MTUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDYtMjcgIERtaXRyaXkgVnl1a292ICA8ZHZ5dWtvdkBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93IHN1YnN0aXR1 dGlvbiBvZiBkeW5hbWljIGFubm90YXRpb25zIGFuZCBwcmV2ZW50IGlkZW50aWNhbCBjb2RlIGZv bGRpbmcgYnkgdGhlIGxpbmtlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYyNDQzCisKKyAgICAgICAgKiB3dGYvRHluYW1pY0Fubm90YXRpb25zLmNw cDoKKyAgICAgICAgKFdURkFubm90YXRlQmVuaWduUmFjZVNpemVkKToKKyAgICAgICAgKFdURkFu bm90YXRlSGFwcGVuc0JlZm9yZSk6CisgICAgICAgIChXVEZBbm5vdGF0ZUhhcHBlbnNBZnRlcik6 CisKIDIwMTEtMDYtMjYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvRHluYW1pY0Fubm90YXRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL0R5bmFtaWNBbm5vdGF0aW9ucy5jcHAJKHJldmlzaW9uIDg5ODE1KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9EeW5hbWljQW5ub3RhdGlvbnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOCw4ICsyOCwzNCBAQAogCiAjaW5jbHVkZSAiRHluYW1pY0Fubm90YXRp b25zLmgiCiAKLSNpZiBVU0UoRFlOQU1JQ19BTk5PVEFUSU9OUykKLXZvaWQgV1RGQW5ub3RhdGVC ZW5pZ25SYWNlU2l6ZWQoY29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUgdm9pZCosIGxv bmcsIGNvbnN0IGNoYXIqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQmVmb3JlKGNvbnN0 IGNoYXIqLCBpbnQsIGNvbnN0IHZvbGF0aWxlIHZvaWQqKSB7IH0KLXZvaWQgV1RGQW5ub3RhdGVI YXBwZW5zQWZ0ZXIoY29uc3QgY2hhciosIGludCwgY29uc3Qgdm9sYXRpbGUgdm9pZCopIHsgfQot I2VuZGlmIC8vIFVTRShEWU5BTUlDX0FOTk9UQVRJT05TKQorI2lmIFVTRShEWU5BTUlDX0FOTk9U QVRJT05TKSAmJiAhVVNFKERZTkFNSUNfQU5OT1RBVElPTlNfTk9JTVBMKQorCisvLyBJZGVudGlj YWwgY29kZSBmb2xkaW5nKC1XbCwtLWljZj1hbGwpIGNvdW50ZXJtZWFzdXJlcy4KKy8vIFRoaXMg bWFrZXMgYWxsIEFubm90YXRlKiBmdW5jdGlvbnMgZGlmZmVyZW50LCB3aGljaCBwcmV2ZW50cyB0 aGUgbGlua2VyIGZyb20KKy8vIGZvbGRpbmcgdGhlbS4KKyNpZmRlZiBfX0NPVU5URVJfXworI2Rl ZmluZSBEWU5BTUlDX0FOTk9UQVRJT05TX0lNUEwgXAorICAgIHZvbGF0aWxlIHNob3J0IGxpbmVu byA9IChfX0xJTkVfXyA8PCA4KSArIF9fQ09VTlRFUl9fOyBcCisgICAgKHZvaWQpbGluZW5vOwor I2Vsc2UKKyNkZWZpbmUgRFlOQU1JQ19BTk5PVEFUSU9OU19JTVBMIFwKKyAgICB2b2xhdGlsZSBz aG9ydCBsaW5lbm8gPSAoX19MSU5FX18gPDwgOCk7IFwKKyAgICAodm9pZClsaW5lbm87CisjZW5k aWYKKwordm9pZCBXVEZBbm5vdGF0ZUJlbmlnblJhY2VTaXplZChjb25zdCBjaGFyKiwgaW50LCBj b25zdCB2b2xhdGlsZSB2b2lkKiwgbG9uZywgY29uc3QgY2hhciopCit7CisgICAgRFlOQU1JQ19B Tk5PVEFUSU9OU19JTVBMCit9CisKK3ZvaWQgV1RGQW5ub3RhdGVIYXBwZW5zQmVmb3JlKGNvbnN0 IGNoYXIqLCBpbnQsIGNvbnN0IHZvbGF0aWxlIHZvaWQqKQoreworICAgIERZTkFNSUNfQU5OT1RB VElPTlNfSU1QTAorfQorCit2b2lkIFdURkFubm90YXRlSGFwcGVuc0FmdGVyKGNvbnN0IGNoYXIq LCBpbnQsIGNvbnN0IHZvbGF0aWxlIHZvaWQqKQoreworICAgIERZTkFNSUNfQU5OT1RBVElPTlNf SU1QTAorfQorCisjZW5kaWYgLy8gVVNFKERZTkFNSUNfQU5OT1RBVElPTlMpICYmICFVU0UoRFlO QU1JQ19BTk5PVEFUSU9OU19OT0lNUEwpCg==