62442 2011-06-10 02:14:55 -0700 [Qt] LayoutTestController needs setTextDirection implementation 2011-06-12 21:13:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED Qt P2 Normal --- 62517 1 maheshk maheshk kling laszlo.gombos rniwa tonikitoo oldest_to_newest 418600 0 maheshk 2011-06-10 02:14:55 -0700 fast/html/set-text-direction.html is failing in Qt port because LayoutTestController needs setTextDirection implementation. 418604 1 96717 maheshk 2011-06-10 02:21:43 -0700 Created attachment 96717 patch Implements setTextDirection using QWebPage actions. 419333 2 rniwa 2011-06-12 13:27:17 -0700 It seems like findString.html is failing on Qt bot after this patch is landed: http://build.webkit.org/results/Qt%20Linux%20Release/r88616%20(34105)/results.html http://build.webkit.org/results/Qt%20Linux%20Release/r88619%20(34108)/results.html 419336 3 tonikitoo 2011-06-12 14:21:21 -0700 Do you need to reset the direction value before each test execution? 419339 4 tonikitoo 2011-06-12 14:58:36 -0700 rolled out by to fix the test offline. 419408 5 maheshk 2011-06-12 20:20:03 -0700 (In reply to comment #3) > Do you need to reset the direction value before each test execution? Sorry for the confusion created, This bug fixes only > # LayoutTestController::setTextDirection is not implemented. > fast/html/set-text-direction.html I was working next on findString() and committed with below case commented. > # Missing layoutTestController.findString() http://webkit.org/b/50236 > # editing/text-iterator/findString.html I will use webkit-patch land-attachment from now on and land the patch reviewed :) 419415 6 96717 maheshk 2011-06-12 21:13:24 -0700 Comment on attachment 96717 patch Clearing flags on attachment: 96717 Committed r88626: <http://trac.webkit.org/changeset/88626> 419416 7 maheshk 2011-06-12 21:13:34 -0700 All reviewed patches have been landed. Closing bug. 96717 2011-06-10 02:21:43 -0700 2011-06-12 21:13:24 -0700 patch 62442.patch text/plain 3479 maheshk SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg4NTMzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDYtMTAgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxrYXJuaUBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBMYXlvdXRUZXN0Q29udHJvbGxlciBuZWVkcyBzZXRUZXh0RGlyZWN0aW9uIGltcGxl bWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MjQ0MgorCisgICAgICAgIEltcGxlbWVudHMgTGF5b3V0Q29udHJvbGxlci5zZXRUZXh0RGly ZWN0aW9uLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xs ZXJRdC5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0VGV4dERpcmVjdGlv bik6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5o OgorCiAyMDExLTA2LTA5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCByb2xsaW5nIG91dCByODg0NzEsIGJlY2F1c2UgaXQgYnJva2Ug cGx1Z2luIHRlc3RzIG9uIFF0LgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0 VGVzdENvbnRyb2xsZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAJKHJldmlzaW9uIDg4NTI4KQorKysgVG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTk1NCw1ICs5NTQsMTUgQEAgUVN0cmluZyBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bGF5 ZXJUcmVlQQogICAgIHJldHVybiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6bGF5ZXJUcmVlQXNU ZXh0KG1fZHJ0LT53ZWJQYWdlKCktPm1haW5GcmFtZSgpKTsKIH0KIAordm9pZCBMYXlvdXRUZXN0 Q29udHJvbGxlcjo6c2V0VGV4dERpcmVjdGlvbihjb25zdCBRU3RyaW5nJiBkaXJlY3Rpb25OYW1l KQoreworICAgIGlmIChkaXJlY3Rpb25OYW1lID09ICJhdXRvIikKKyAgICAgICAgbV9kcnQtPndl YlBhZ2UoKS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6U2V0VGV4dERpcmVjdGlvbkRlZmF1bHQp OworICAgIGVsc2UgaWYgKGRpcmVjdGlvbk5hbWUgPT0gInJ0bCIpCisgICAgICAgIG1fZHJ0LT53 ZWJQYWdlKCktPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OlNldFRleHREaXJlY3Rpb25SaWdodFRv TGVmdCk7CisgICAgZWxzZSBpZiAoZGlyZWN0aW9uTmFtZSA9PSAibHRyIikKKyAgICAgICAgbV9k cnQtPndlYlBhZ2UoKS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6U2V0VGV4dERpcmVjdGlvbkxl ZnRUb1JpZ2h0KTsKK30KKwogY29uc3QgdW5zaWduZWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1h eFZpZXdXaWR0aCA9IDgwMDsKIGNvbnN0IHVuc2lnbmVkIExheW91dFRlc3RDb250cm9sbGVyOjpt YXhWaWV3SGVpZ2h0ID0gNjAwOwpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0 VGVzdENvbnRyb2xsZXJRdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0xheW91dFRlc3RDb250cm9sbGVyUXQuaAkocmV2aXNpb24gODg1MjgpCisrKyBUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgJKHdvcmtpbmcgY29weSkKQEAg LTI3NCw2ICsyNzQsNyBAQCBwdWJsaWMgc2xvdHM6CiAgICAgdm9pZCBvYnNlcnZlU3RvcmFnZVRy YWNrZXJOb3RpZmljYXRpb25zKHVuc2lnbmVkIG51bWJlcik7CiAgICAgdm9pZCBzeW5jTG9jYWxT dG9yYWdlKCk7CiAgICAgUVN0cmluZyBsYXllclRyZWVBc1RleHQoKTsKKyAgICB2b2lkIHNldFRl eHREaXJlY3Rpb24oY29uc3QgUVN0cmluZyYgZGlyZWN0aW9uTmFtZSk7CiAKIHByaXZhdGUgc2xv dHM6CiAgICAgdm9pZCBwcm9jZXNzV29yaygpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODg1MzMpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAor MjAxMS0wNi0xMCAgTWFoZXNoIEt1bGthcm5pICA8bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIExh eW91dFRlc3RDb250cm9sbGVyIG5lZWRzIHNldFRleHREaXJlY3Rpb24gaW1wbGVtZW50YXRpb24K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNDQyCisK KyAgICAgICAgVW5za2lwcGluZyBmYXN0L2h0bWwvc2V0LXRleHQtZGlyZWN0aW9uLmh0bWwuIAor CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMS0wNi0xMCAgU2hlcmlmZiBC b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjg4NTMwLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCShyZXZpc2lv biA4ODUyOCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHdvcmtpbmcgY29w eSkKQEAgLTI1MTAsOSArMjUxMCw2IEBAIGZhc3QvZXZlbnRzL3JlbW92ZS10YXJnZXQtaW4tbW91 c2V1cC5odG0KIGZhc3QvZXZlbnRzL3NlbGVjdHN0YXJ0LWJ5LWRvdWJsZS10cmlwbGUtY2xpY2tz Lmh0bWwKIGZhc3QvZXZlbnRzL3NlbGVjdHN0YXJ0LWJ5LWRyYWcuaHRtbAogCi0jIExheW91dFRl c3RDb250cm9sbGVyOjpzZXRUZXh0RGlyZWN0aW9uIGlzIG5vdCBpbXBsZW1lbnRlZC4KLWZhc3Qv aHRtbC9zZXQtdGV4dC1kaXJlY3Rpb24uaHRtbAotCiAjIEpTQyBkb2VzIG5vdCBzdXBwb3J0IHNl dElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbiAoaHR0cDovL3dlYmtpdC5vcmcvYi82MTU0MCkK IGh0dHAvdGVzdHMvc2VjdXJpdHkvaXNvbGF0ZWRXb3JsZC9jcm9zcy1vcmlnaW4teGhyLmh0bWwK IAo=