62424 2011-06-09 19:37:29 -0700 [GTK] webkit_web_settings_copy does not copy all settings 2011-06-20 14:19:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 61972 1 mrobinson mrobinson gustavo xan.lopez oldest_to_newest 418472 0 mrobinson 2011-06-09 19:37:29 -0700 webkit_web_settings_copy copies some of the settings in WebKitWebSettings, but it appears to be out of date. It only copies a subset of the total settings that the GObject tracks. 419093 1 96831 mrobinson 2011-06-10 18:01:41 -0700 Created attachment 96831 Patch 419357 2 96831 xan.lopez 2011-06-12 16:50:19 -0700 Comment on attachment 96831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96831&action=review OK with those changes, I guess, but I feel this will bite us down the road somehow ;) > Source/WebKit/gtk/tests/testwebsettings.c:52 > + g_assert_cmpstr(defaultEncoding, ==, "utf-8"); Leaking defaultEncoding! > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1252 > + for (size_t i = 0; i < numberOfProperties; i++) { I believe to be at least a bit more correct you should check the property has a G_PARAM_CONSTRUCT flag. And uh... READWRITE? > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1253 > + GParamSpec* property = properties.get()[i]; There is no nicer way to write this? at least properties[i].get() ? > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1254 > + GParameter* parameter = parameters.get() + i; And why do you do it differently in the next line? 423939 3 mrobinson 2011-06-20 14:17:33 -0700 (In reply to comment #2) > (From update of attachment 96831 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96831&action=review Thanks for the review! > OK with those changes, I guess, but I feel this will bite us down the road somehow ;) Perhaps. :/ > > Source/WebKit/gtk/tests/testwebsettings.c:52 > > + g_assert_cmpstr(defaultEncoding, ==, "utf-8"); > Leaking defaultEncoding! Fixed. > > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1252 > > + for (size_t i = 0; i < numberOfProperties; i++) { > > I believe to be at least a bit more correct you should check the property has a G_PARAM_CONSTRUCT flag. And uh... READWRITE? Fixed. This wasn't there before since we know that all properties use the same flags in this class. I agree that it will make this code safer though. > > > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1253 > > + GParamSpec* property = properties.get()[i]; > > There is no nicer way to write this? at least properties[i].get() ? I don't think that GOwnPtr has that operator overload. > > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1254 > > + GParameter* parameter = parameters.get() + i; > And why do you do it differently in the next line? One of them is a GParamSpec** and the other is a GParameter*, but they are both 1-dimensional arrays. They are just stored in memory differently. 423940 4 mrobinson 2011-06-20 14:18:43 -0700 Committed r89288: <http://trac.webkit.org/changeset/89288> 423943 5 96831 mrobinson 2011-06-20 14:19:36 -0700 Comment on attachment 96831 Patch Clearing flags after landing. 96831 2011-06-10 18:01:41 -0700 2011-06-20 14:19:36 -0700 Patch bug-62424-20110610180141.patch text/plain 7459 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODg1NzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA0MTFkZWUxZTU0 Y2I2MTViOTAxZDhhZjI5MGJiN2EyN2U2ZDRkNzA1Li5kYmJiYzcyZGJkNDYwYmY3NzYxYzE2ZDY3 YTZmNzNkMGMzNWY4ODgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDYtMTAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHdlYmtpdF93ZWJf c2V0dGluZ3NfY29weSBkb2VzIG5vdCBjb3B5IGFsbCBzZXR0aW5ncworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI0MjQKKworICAgICAgICBJbnN0ZWFk IG9mIHRyeWluZyB0byBrZWVwIHdlYmtpdF93ZWJfc2V0dGluZ3NfY29weSB1cCB0byBkYXRlIHdp dGgKKyAgICAgICAgcHJvcGVydHkgYWRkaXRpb25zLCBjcmVhdGUgdGhlIG9iamVjdCBjb3B5IGJ5 IGR5bmFtaWNhbGx5IGluaXRpYWxpemluZworICAgICAgICBhbGwgd2Via2l0X3dlYl9zZXR0aW5n cyBwcm9wZXJ0aWVzIGF0IG9uY2UuCisKKyAgICAgICAgKiB0ZXN0cy90ZXN0d2Vic2V0dGluZ3Mu YzoKKyAgICAgICAgKHRlc3Rfd2Via2l0X3dlYl9zZXR0aW5nc19jb3B5KTogQ3JlYXRlIGEgdGVz dCBmb3Igd2Via2l0X3dlYl9zZXR0aW5ncyBjb3B5LgorICAgICAgICAobWFpbik6IFJ1biB0aGUg bmV3IHRlc3QuCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcDoKKyAgICAg ICAgKHdlYmtpdF93ZWJfc2V0dGluZ3NfY29weSk6IER5bmFtaWNhbGx5IGluaXRpYWxpemUgYWxs IHByb3BlcnRpZXMgb2YgdGhlIGNvcHkuCisKIDIwMTEtMDYtMDkgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnNldHRpbmdz LmMgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vic2V0dGluZ3MuYwppbmRleCA0ZGI5 MjlhYTdmNzA0NjhkMmMyZWQzZGY2ZGFmNmU3ZTNkOWM0ODRlLi5hZTYzMmJkZWU2MmVlMWZkYTQ0 ZWU1MjdhZTIyZmM1YzMyMTM2Y2Q3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0 cy90ZXN0d2Vic2V0dGluZ3MuYworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vi c2V0dGluZ3MuYwpAQCAtMjMsNiArMjMsMzUgQEAKIAogI2lmIEdUS19DSEVDS19WRVJTSU9OKDIs IDE0LCAwKQogCitzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF93ZWJfc2V0dGluZ3NfY29weSh2b2lk KQoreworICAgIFdlYktpdFdlYlNldHRpbmdzKiBzZXR0aW5ncyA9IHdlYmtpdF93ZWJfc2V0dGlu Z3NfbmV3KCk7CisKKyAgICAvLyBTZXQgc29tZSBub24tZGVmYXVsdCBzZXR0aW5ncyB0byB2ZXJp ZnkgdGhhdCBzZXR0aW5ncyBhcmUgcHJvcGVybHkgY29waWVkLgorICAgIGdfb2JqZWN0X3NldChz ZXR0aW5ncywKKyAgICAgICAgICAgICAgICAgImVuYWJsZS13ZWJnbCIsIFRSVUUsCisgICAgICAg ICAgICAgICAgICJlbmFibGUtZnVsbHNjcmVlbiIsIFRSVUUsCisgICAgICAgICAgICAgICAgICJh dXRvLWxvYWQtaW1hZ2VzIiwgRkFMU0UsCisgICAgICAgICAgICAgICAgICJkZWZhdWx0LWVuY29k aW5nIiwgInV0Zi04IiwgTlVMTCk7CisKKyAgICBXZWJLaXRXZWJTZXR0aW5ncyogY29weSA9IHdl YmtpdF93ZWJfc2V0dGluZ3NfY29weShzZXR0aW5ncyk7CisKKyAgICBnYm9vbGVhbiBlbmFibGVX ZWJHTCA9IEZBTFNFOworICAgIGdib29sZWFuIGVuYWJsZUZ1bGxzY3JlZW4gPSBGQUxTRTsKKyAg ICBnYm9vbGVhbiBhdXRvTG9hZEltYWdlcyA9IEZBTFNFOworICAgIGNoYXIqIGRlZmF1bHRFbmNv ZGluZyA9IE5VTEw7CisgICAgZ19vYmplY3RfZ2V0KGNvcHksCisgICAgICAgICAgICAgICAgICJl bmFibGUtZnVsbHNjcmVlbiIsICZlbmFibGVGdWxsc2NyZWVuLAorICAgICAgICAgICAgICAgICAi ZW5hYmxlLXdlYmdsIiwgJmVuYWJsZVdlYkdMLAorICAgICAgICAgICAgICAgICAiYXV0by1sb2Fk LWltYWdlcyIsICZhdXRvTG9hZEltYWdlcywKKyAgICAgICAgICAgICAgICAgImRlZmF1bHQtZW5j b2RpbmciLCAmZGVmYXVsdEVuY29kaW5nLCBOVUxMKTsKKworICAgIGdfYXNzZXJ0KGVuYWJsZVdl YkdMKTsKKyAgICBnX2Fzc2VydChlbmFibGVGdWxsc2NyZWVuKTsKKyAgICBnX2Fzc2VydCghYXV0 b0xvYWRJbWFnZXMpOworICAgIGdfYXNzZXJ0X2NtcHN0cihkZWZhdWx0RW5jb2RpbmcsID09LCAi dXRmLTgiKTsKK30KKwogc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX3NldHRpbmdzX3VzZXJf YWdlbnQodm9pZCkKIHsKICAgICBXZWJLaXRXZWJTZXR0aW5ncyogc2V0dGluZ3M7CkBAIC02OCw2 ICs5Nyw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKIAogICAgIGdfdGVzdF9i dWdfYmFzZSgiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvIik7CiAgICAgZ190ZXN0X2FkZF9mdW5j KCIvd2Via2l0L3dlYnNldHRpbmdzL3VzZXJfYWdlbnQiLCB0ZXN0X3dlYmtpdF93ZWJfc2V0dGlu Z3NfdXNlcl9hZ2VudCk7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYnNldHRpbmdz L2NvcHkiLCB0ZXN0X3dlYmtpdF93ZWJfc2V0dGluZ3NfY29weSk7CiAgICAgcmV0dXJuIGdfdGVz dF9ydW4gKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXR3ZWJzZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0 dGluZ3MuY3BwCmluZGV4IDZiYmM3Yzk4MGNkY2E1NjZkYWVlNWMyMzRmYjFmNzU3MmM1ZjhiMGMu LmM3M2UxOTQ2MGYxYzcyMGY1MDk3MjE0Y2FiNzM5MmZkN2MxZDM3ZGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApAQCAtMTI0NCw1MyArMTI0 NCwyMiBAQCBXZWJLaXRXZWJTZXR0aW5ncyogd2Via2l0X3dlYl9zZXR0aW5nc19uZXcoKQogICoq LwogV2ViS2l0V2ViU2V0dGluZ3MqIHdlYmtpdF93ZWJfc2V0dGluZ3NfY29weShXZWJLaXRXZWJT ZXR0aW5ncyogb3JpZ2luYWwpCiB7Ci0gICAgV2ViS2l0V2ViU2V0dGluZ3NQcml2YXRlKiBwcml2 ID0gb3JpZ2luYWwtPnByaXY7Ci0gICAgcmV0dXJuIFdFQktJVF9XRUJfU0VUVElOR1MoZ19vYmpl Y3RfbmV3KFdFQktJVF9UWVBFX1dFQl9TRVRUSU5HUywKLSAgICAgICAgICAgICAgICAgImRlZmF1 bHQtZW5jb2RpbmciLCBwcml2LT5kZWZhdWx0RW5jb2RpbmcuZGF0YSgpLAotICAgICAgICAgICAg ICAgICAiY3Vyc2l2ZS1mb250LWZhbWlseSIsIHByaXYtPmN1cnNpdmVGb250RmFtaWx5LmRhdGEo KSwKLSAgICAgICAgICAgICAgICAgImRlZmF1bHQtZm9udC1mYW1pbHkiLCBwcml2LT5kZWZhdWx0 Rm9udEZhbWlseS5kYXRhKCksCi0gICAgICAgICAgICAgICAgICJmYW50YXN5LWZvbnQtZmFtaWx5 IiwgcHJpdi0+ZmFudGFzeUZvbnRGYW1pbHkuZGF0YSgpLAotICAgICAgICAgICAgICAgICAibW9u b3NwYWNlLWZvbnQtZmFtaWx5IiwgcHJpdi0+bW9ub3NwYWNlRm9udEZhbWlseS5kYXRhKCksCi0g ICAgICAgICAgICAgICAgICJzYW5zLXNlcmlmLWZvbnQtZmFtaWx5IiwgcHJpdi0+c2Fuc1Nlcmlm Rm9udEZhbWlseS5kYXRhKCksCi0gICAgICAgICAgICAgICAgICJzZXJpZi1mb250LWZhbWlseSIs IHByaXYtPnNlcmlmRm9udEZhbWlseS5kYXRhKCksCi0gICAgICAgICAgICAgICAgICJkZWZhdWx0 LWZvbnQtc2l6ZSIsIHByaXYtPmRlZmF1bHRGb250U2l6ZSwKLSAgICAgICAgICAgICAgICAgImRl ZmF1bHQtbW9ub3NwYWNlLWZvbnQtc2l6ZSIsIHByaXYtPmRlZmF1bHRNb25vc3BhY2VGb250U2l6 ZSwKLSAgICAgICAgICAgICAgICAgIm1pbmltdW0tZm9udC1zaXplIiwgcHJpdi0+bWluaW11bUZv bnRTaXplLAotICAgICAgICAgICAgICAgICAibWluaW11bS1sb2dpY2FsLWZvbnQtc2l6ZSIsIHBy aXYtPm1pbmltdW1Mb2dpY2FsRm9udFNpemUsCi0gICAgICAgICAgICAgICAgICJhdXRvLWxvYWQt aW1hZ2VzIiwgcHJpdi0+YXV0b0xvYWRJbWFnZXMsCi0gICAgICAgICAgICAgICAgICJhdXRvLXNo cmluay1pbWFnZXMiLCBwcml2LT5hdXRvU2hyaW5rSW1hZ2VzLAotICAgICAgICAgICAgICAgICAi cHJpbnQtYmFja2dyb3VuZHMiLCBwcml2LT5wcmludEJhY2tncm91bmRzLAotICAgICAgICAgICAg ICAgICAiZW5hYmxlLXNjcmlwdHMiLCBwcml2LT5lbmFibGVTY3JpcHRzLAotICAgICAgICAgICAg ICAgICAiZW5hYmxlLXBsdWdpbnMiLCBwcml2LT5lbmFibGVQbHVnaW5zLAotICAgICAgICAgICAg ICAgICAicmVzaXphYmxlLXRleHQtYXJlYXMiLCBwcml2LT5yZXNpemFibGVUZXh0QXJlYXMsCi0g ICAgICAgICAgICAgICAgICJ1c2VyLXN0eWxlc2hlZXQtdXJpIiwgcHJpdi0+dXNlclN0eWxlc2hl ZXRVUkkuZGF0YSgpLAotICAgICAgICAgICAgICAgICAiem9vbS1zdGVwIiwgcHJpdi0+em9vbVN0 ZXAsCi0gICAgICAgICAgICAgICAgICJlbmFibGUtZGV2ZWxvcGVyLWV4dHJhcyIsIHByaXYtPmVu YWJsZURldmVsb3BlckV4dHJhcywKLSAgICAgICAgICAgICAgICAgInNwZWxsLWNoZWNraW5nLWxh bmd1YWdlcyIsIHByaXYtPnNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMuZGF0YSgpLAotICAgICAgICAg ICAgICAgICAiZW5hYmxlLWNhcmV0LWJyb3dzaW5nIiwgcHJpdi0+ZW5hYmxlQ2FyZXRCcm93c2lu ZywKLSAgICAgICAgICAgICAgICAgImVuYWJsZS1odG1sNS1kYXRhYmFzZSIsIHByaXYtPmVuYWJs ZUhUTUw1RGF0YWJhc2UsCi0gICAgICAgICAgICAgICAgICJlbmFibGUtaHRtbDUtbG9jYWwtc3Rv cmFnZSIsIHByaXYtPmVuYWJsZUhUTUw1TG9jYWxTdG9yYWdlLAotICAgICAgICAgICAgICAgICAi ZW5hYmxlLXhzcy1hdWRpdG9yIiwgcHJpdi0+ZW5hYmxlWFNTQXVkaXRvciwKLSAgICAgICAgICAg ICAgICAgImVuYWJsZS1zcGF0aWFsLW5hdmlnYXRpb24iLCBwcml2LT5lbmFibGVTcGF0aWFsTmF2 aWdhdGlvbiwKLSAgICAgICAgICAgICAgICAgImVuYWJsZS1mcmFtZS1mbGF0dGVuaW5nIiwgcHJp di0+ZW5hYmxlRnJhbWVGbGF0dGVuaW5nLAotICAgICAgICAgICAgICAgICAidXNlci1hZ2VudCIs IHdlYmtpdF93ZWJfc2V0dGluZ3NfZ2V0X3VzZXJfYWdlbnQob3JpZ2luYWwpLAotICAgICAgICAg ICAgICAgICAiamF2YXNjcmlwdC1jYW4tb3Blbi13aW5kb3dzLWF1dG9tYXRpY2FsbHkiLCBwcml2 LT5qYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3NBdXRvbWF0aWNhbGx5LAotICAgICAgICAgICAgICAg ICAiamF2YXNjcmlwdC1jYW4tYWNjZXNzLWNsaXBib2FyZCIsIHByaXYtPmphdmFzY3JpcHRDYW5B Y2Nlc3NDbGlwYm9hcmQsCi0gICAgICAgICAgICAgICAgICJlbmFibGUtb2ZmbGluZS13ZWItYXBw bGljYXRpb24tY2FjaGUiLCBwcml2LT5lbmFibGVPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZSwK LSAgICAgICAgICAgICAgICAgImVkaXRpbmctYmVoYXZpb3IiLCBwcml2LT5lZGl0aW5nQmVoYXZp b3IsCi0gICAgICAgICAgICAgICAgICJlbmFibGUtdW5pdmVyc2FsLWFjY2Vzcy1mcm9tLWZpbGUt dXJpcyIsIHByaXYtPmVuYWJsZVVuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJJcywKLSAgICAgICAg ICAgICAgICAgImVuYWJsZS1maWxlLWFjY2Vzcy1mcm9tLWZpbGUtdXJpcyIsIHByaXYtPmVuYWJs ZUZpbGVBY2Nlc3NGcm9tRmlsZVVSSXMsCi0gICAgICAgICAgICAgICAgICJlbmFibGUtZG9tLXBh c3RlIiwgcHJpdi0+ZW5hYmxlRE9NUGFzdGUsCi0gICAgICAgICAgICAgICAgICJ0YWIta2V5LWN5 Y2xlcy10aHJvdWdoLWVsZW1lbnRzIiwgcHJpdi0+dGFiS2V5Q3ljbGVzVGhyb3VnaEVsZW1lbnRz LAotICAgICAgICAgICAgICAgICAiZW5hYmxlLWRlZmF1bHQtY29udGV4dC1tZW51IiwgcHJpdi0+ ZW5hYmxlRGVmYXVsdENvbnRleHRNZW51LAotICAgICAgICAgICAgICAgICAiZW5hYmxlLXNpdGUt c3BlY2lmaWMtcXVpcmtzIiwgcHJpdi0+ZW5hYmxlU2l0ZVNwZWNpZmljUXVpcmtzLAotICAgICAg ICAgICAgICAgICAiZW5hYmxlLXBhZ2UtY2FjaGUiLCBwcml2LT5lbmFibGVQYWdlQ2FjaGUsCi0g ICAgICAgICAgICAgICAgICJhdXRvLXJlc2l6ZS13aW5kb3ciLCBwcml2LT5hdXRvUmVzaXplV2lu ZG93LAotICAgICAgICAgICAgICAgICAiZW5hYmxlLWphdmEtYXBwbGV0IiwgcHJpdi0+ZW5hYmxl SmF2YUFwcGxldCwKLSAgICAgICAgICAgICAgICAgImVuYWJsZS1oeXBlcmxpbmstYXVkaXRpbmci LCBwcml2LT5lbmFibGVIeXBlcmxpbmtBdWRpdGluZywKLSAgICAgICAgICAgICAgICAgImVuYWJs ZS1mdWxsc2NyZWVuIiwgcHJpdi0+ZW5hYmxlRnVsbHNjcmVlbiwKLSAgICAgICAgICAgICAgICAg ImVuYWJsZS1kbnMtcHJlZmV0Y2hpbmciLCBwcml2LT5lbmFibGVETlNQcmVmZXRjaGluZywKLSAg ICAgICAgICAgICAgICAgTlVMTCkpOworICAgIHVuc2lnbmVkIG51bWJlck9mUHJvcGVydGllcyA9 IDA7CisgICAgR093blB0cjxHUGFyYW1TcGVjKj4gcHJvcGVydGllcyhnX29iamVjdF9jbGFzc19s aXN0X3Byb3BlcnRpZXMoCisgICAgICAgIEdfT0JKRUNUX0NMQVNTKFdFQktJVF9XRUJfU0VUVElO R1NfR0VUX0NMQVNTKG9yaWdpbmFsKSksICZudW1iZXJPZlByb3BlcnRpZXMpKTsKKyAgICBHT3du UHRyPEdQYXJhbWV0ZXI+IHBhcmFtZXRlcnMoZ19uZXcwKEdQYXJhbWV0ZXIsIG51bWJlck9mUHJv cGVydGllcykpOworCisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBudW1iZXJPZlByb3BlcnRp ZXM7IGkrKykgeworICAgICAgICBHUGFyYW1TcGVjKiBwcm9wZXJ0eSA9IHByb3BlcnRpZXMuZ2V0 KClbaV07CisgICAgICAgIEdQYXJhbWV0ZXIqIHBhcmFtZXRlciA9IHBhcmFtZXRlcnMuZ2V0KCkg KyBpOworCisgICAgICAgIHBhcmFtZXRlci0+bmFtZSA9IHByb3BlcnR5LT5uYW1lOworICAgICAg ICBnX3ZhbHVlX2luaXQoJnBhcmFtZXRlci0+dmFsdWUsIHByb3BlcnR5LT52YWx1ZV90eXBlKTsK KyAgICAgICAgZ19vYmplY3RfZ2V0X3Byb3BlcnR5KEdfT0JKRUNUKG9yaWdpbmFsKSwgcHJvcGVy dHktPm5hbWUsICZwYXJhbWV0ZXItPnZhbHVlKTsKKyAgICB9CisKKyAgICByZXR1cm4gV0VCS0lU X1dFQl9TRVRUSU5HUyhnX29iamVjdF9uZXd2KFdFQktJVF9UWVBFX1dFQl9TRVRUSU5HUywgbnVt YmVyT2ZQcm9wZXJ0aWVzLCBwYXJhbWV0ZXJzLmdldCgpKSk7CisKIH0KIAogLyoqCg==