62423 2011-06-09 19:33:35 -0700 [Chromium] Add WebSettings::setShouldPrintBackgrounds() 2011-06-13 15:57:13 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thestig thestig fishd webkit.review.bot oldest_to_newest 418466 0 96688 thestig 2011-06-09 19:33:35 -0700 Created attachment 96688 Patch to add setShouldPrintBackgrounds() Hook up setShouldPrintBackgrounds for http://crbug.com/2294 418849 1 thestig 2011-06-10 12:50:05 -0700 +fishd 419166 2 96688 fishd 2011-06-10 22:34:44 -0700 Comment on attachment 96688 Patch to add setShouldPrintBackgrounds() View in context: https://bugs.webkit.org/attachment.cgi?id=96688&action=review Patch looks good except for the ChangeLog entry. > WebKit/chromium/ChangeLog:5 > + Need a short description and bug URL (OOPS!) you need to do as this says :) 419820 3 97000 thestig 2011-06-13 13:39:41 -0700 Created attachment 97000 Added comment to ChangeLog Whoops indeed. 419948 4 97000 fishd 2011-06-13 15:20:58 -0700 Comment on attachment 97000 Added comment to ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=97000&action=review You forgot to set the '?' on the patch, which meant that it didn't go into the review request queue :-( > WebKit/chromium/ChangeLog:5 > + [Chromium] Add a WebSetting to control printing backgrounds sorry to give you a hard time, but you are also supposed to include the URL of this bug report here. please take a look at how other people write ChangeLog entries. 419979 5 97020 thestig 2011-06-13 15:33:27 -0700 Created attachment 97020 Add bug url to changelog That's ok. Third time is the charm. 420017 6 97020 webkit.review.bot 2011-06-13 15:57:08 -0700 Comment on attachment 97020 Add bug url to changelog Clearing flags on attachment: 97020 Committed r88728: <http://trac.webkit.org/changeset/88728> 420018 7 webkit.review.bot 2011-06-13 15:57:13 -0700 All reviewed patches have been landed. Closing bug. 96688 2011-06-09 19:33:35 -0700 2011-06-13 15:33:27 -0700 Patch to add setShouldPrintBackgrounds() printbg.txt text/plain 2156 thestig SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODg1MTMpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMDkgIExlaSBa aGFuZyAgPHRoZXN0aWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVS TCAoT09QUyEpCisKKyAgICAgICAgKiBwdWJsaWMvV2ViU2V0dGluZ3MuaDoKKyAgICAgICAgKiBz cmMvV2ViU2V0dGluZ3NJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU2V0dGluZ3NJbXBs OjpzZXRTaG91bGRQcmludEJhY2tncm91bmRzKToKKyAgICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJ bXBsLmg6CisKIDIwMTEtMDYtMDkgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlNldHRpbmdzLmgJKHJldmlzaW9uIDg4NDU3KQorKysgV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJTZXR0aW5ncy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjMsNiArMTIzLDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRGdWxsU2NyZWVuRW5hYmxlZChib29sKSA9IDA7 CiAgICAgdmlydHVhbCB2b2lkIHNldEFsbG93RGlzcGxheU9mSW5zZWN1cmVDb250ZW50KGJvb2wp ID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dSdW5uaW5nT2ZJbnNlY3VyZUNvbnRlbnQo Ym9vbCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzZXRTaG91bGRQcmludEJhY2tncm91bmRzKGJv b2wpID0gMDsKIAogcHJvdGVjdGVkOgogICAgIH5XZWJTZXR0aW5ncygpIHsgfQpJbmRleDogV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAkocmV2aXNpb24gODg0NTcpCisrKyBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQxNyw0ICs0MTcsOSBAQCB2b2lkIFdlYlNldHRpbmdzSW1wbDo6c2V0QWxsb3dSdW5uaW5nT2ZJ CiAgICAgbV9zZXR0aW5ncy0+c2V0QWxsb3dSdW5uaW5nT2ZJbnNlY3VyZUNvbnRlbnQoZW5hYmxl ZCk7CiB9CiAKK3ZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRTaG91bGRQcmludEJhY2tncm91bmRz KGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX3NldHRpbmdzLT5zZXRTaG91bGRQcmludEJhY2tncm91 bmRzKGVuYWJsZWQpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkocmV2aXNpb24gODg0NTcpCisrKyBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNiArMTE2 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRGdWxsU2NyZWVuRW5hYmxlZChib29s KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dEaXNwbGF5T2ZJbnNlY3VyZUNvbnRlbnQoYm9v bCk7CiAgICAgdmlydHVhbCB2b2lkIHNldEFsbG93UnVubmluZ09mSW5zZWN1cmVDb250ZW50KGJv b2wpOworICAgIHZpcnR1YWwgdm9pZCBzZXRTaG91bGRQcmludEJhY2tncm91bmRzKGJvb2wpOwog CiBwcml2YXRlOgogICAgIFdlYkNvcmU6OlNldHRpbmdzKiBtX3NldHRpbmdzOwo= 97000 2011-06-13 13:39:41 -0700 2011-06-13 15:33:27 -0700 Added comment to ChangeLog printbg.txt text/plain 2173 thestig SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODg2ODEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMTMgIExlaSBa aGFuZyAgPHRoZXN0aWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQWRkIGEgV2ViU2V0dGluZyB0byBjb250 cm9sIHByaW50aW5nIGJhY2tncm91bmRzCisKKyAgICAgICAgKiBwdWJsaWMvV2ViU2V0dGluZ3Mu aDoKKyAgICAgICAgKiBzcmMvV2ViU2V0dGluZ3NJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViU2V0dGluZ3NJbXBsOjpzZXRTaG91bGRQcmludEJhY2tncm91bmRzKToKKyAgICAgICAgKiBz cmMvV2ViU2V0dGluZ3NJbXBsLmg6CisKIDIwMTEtMDYtMTIgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAkocmV2aXNpb24gODg2MzYpCisr KyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAg LTEyMyw2ICsxMjMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldEZ1bGxTY3JlZW5F bmFibGVkKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dEaXNwbGF5T2ZJbnNl Y3VyZUNvbnRlbnQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBbGxvd1J1bm5pbmdP Zkluc2VjdXJlQ29udGVudChib29sKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHNldFNob3VsZFBy aW50QmFja2dyb3VuZHMoYm9vbCkgPSAwOwogCiBwcm90ZWN0ZWQ6CiAgICAgfldlYlNldHRpbmdz KCkgeyB9CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCShyZXZp c2lvbiA4ODYzNikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNDE3LDQgKzQxNyw5IEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpz ZXRBbGxvd1J1bm5pbmdPZkkKICAgICBtX3NldHRpbmdzLT5zZXRBbGxvd1J1bm5pbmdPZkluc2Vj dXJlQ29udGVudChlbmFibGVkKTsKIH0KIAordm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFNob3Vs ZFByaW50QmFja2dyb3VuZHMoYm9vbCBlbmFibGVkKQoreworICAgIG1fc2V0dGluZ3MtPnNldFNo b3VsZFByaW50QmFja2dyb3VuZHMoZW5hYmxlZCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktp dApJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCShyZXZpc2lvbiA4ODYz NikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgJKHdvcmtpbmcgY29w eSkKQEAgLTExNiw2ICsxMTYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldEZ1bGxT Y3JlZW5FbmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBbGxvd0Rpc3BsYXlPZklu c2VjdXJlQ29udGVudChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dSdW5uaW5nT2ZJ bnNlY3VyZUNvbnRlbnQoYm9vbCk7CisgICAgdmlydHVhbCB2b2lkIHNldFNob3VsZFByaW50QmFj a2dyb3VuZHMoYm9vbCk7CiAKIHByaXZhdGU6CiAgICAgV2ViQ29yZTo6U2V0dGluZ3MqIG1fc2V0 dGluZ3M7Cg== 97020 2011-06-13 15:33:27 -0700 2011-06-13 15:57:08 -0700 Add bug url to changelog printbg.txt text/plain 2231 thestig SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODg3MTQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMTMgIExlaSBa aGFuZyAgPHRoZXN0aWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQWRkIGEgV2ViU2V0dGluZyB0byBjb250 cm9sIHByaW50aW5nIGJhY2tncm91bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MjQyMworCisgICAgICAgICogcHVibGljL1dlYlNldHRpbmdzLmg6 CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlNldHRpbmdzSW1wbDo6c2V0U2hvdWxkUHJpbnRCYWNrZ3JvdW5kcyk6CisgICAgICAgICogc3Jj L1dlYlNldHRpbmdzSW1wbC5oOgorCiAyMDExLTA2LTEzICBEb21pbmljIE1henpvbmkgIDxkbWF6 em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4K SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3MuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgJKHJldmlzaW9uIDg4NjM2KQor KysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMjMsNiArMTIzLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRGdWxsU2NyZWVu RW5hYmxlZChib29sKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNldEFsbG93RGlzcGxheU9mSW5z ZWN1cmVDb250ZW50KGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dSdW5uaW5n T2ZJbnNlY3VyZUNvbnRlbnQoYm9vbCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzZXRTaG91bGRQ cmludEJhY2tncm91bmRzKGJvb2wpID0gMDsKIAogcHJvdGVjdGVkOgogICAgIH5XZWJTZXR0aW5n cygpIHsgfQpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAkocmV2 aXNpb24gODg2MzYpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQxNyw0ICs0MTcsOSBAQCB2b2lkIFdlYlNldHRpbmdzSW1wbDo6 c2V0QWxsb3dSdW5uaW5nT2ZJCiAgICAgbV9zZXR0aW5ncy0+c2V0QWxsb3dSdW5uaW5nT2ZJbnNl Y3VyZUNvbnRlbnQoZW5hYmxlZCk7CiB9CiAKK3ZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRTaG91 bGRQcmludEJhY2tncm91bmRzKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX3NldHRpbmdzLT5zZXRT aG91bGRQcmludEJhY2tncm91bmRzKGVuYWJsZWQpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkocmV2aXNpb24gODg2 MzYpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMTYsNiArMTE2LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRGdWxs U2NyZWVuRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsb3dEaXNwbGF5T2ZJ bnNlY3VyZUNvbnRlbnQoYm9vbCk7CiAgICAgdmlydHVhbCB2b2lkIHNldEFsbG93UnVubmluZ09m SW5zZWN1cmVDb250ZW50KGJvb2wpOworICAgIHZpcnR1YWwgdm9pZCBzZXRTaG91bGRQcmludEJh Y2tncm91bmRzKGJvb2wpOwogCiBwcml2YXRlOgogICAgIFdlYkNvcmU6OlNldHRpbmdzKiBtX3Nl dHRpbmdzOwo=