62420 2011-06-09 17:56:22 -0700 [Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION 2011-06-10 06:19:24 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 laszlo.gombos webkit-unassigned ademar kenneth qi.2.zhang webkit.review.bot oldest_to_newest 418443 0 laszlo.gombos 2011-06-09 17:56:22 -0700 http://trac.webkit.org/changeset/73584 made ORIENTATION_EVENTS dependent from DEVICE_ORIENTATION, even though these features are interdependently configurable. I think we should keep them independent. 418445 1 96680 laszlo.gombos 2011-06-09 18:00:33 -0700 Created attachment 96680 proposed patch 418613 2 96680 webkit.review.bot 2011-06-10 03:06:53 -0700 Comment on attachment 96680 proposed patch Clearing flags on attachment: 96680 Committed r88534: <http://trac.webkit.org/changeset/88534> 418614 3 webkit.review.bot 2011-06-10 03:06:58 -0700 All reviewed patches have been landed. Closing bug. 418689 4 ademar 2011-06-10 06:19:24 -0700 I guess we should include this fix in 2.2, no? (even though r73584 was included in 2.1.x). 96680 2011-06-09 18:00:33 -0700 2011-06-10 03:06:53 -0700 proposed patch 62420.patch text/plain 2787 laszlo.gombos ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCmluZGV4IGNjMmVmMGQuLjczODRjNDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcApAQCAtNDQ5LDcgKzQ0OSw3IEBAIHZvaWQgUVdlYkZy YW1lUHJpdmF0ZTo6ZW1pdFVybENoYW5nZWQoKQogCiB2b2lkIFFXZWJGcmFtZVByaXZhdGU6Ol9x X29yaWVudGF0aW9uQ2hhbmdlZCgpCiB7Ci0jaWYgRU5BQkxFKE9SSUVOVEFUSU9OX0VWRU5UUykg JiYgRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKKyNpZiBFTkFCTEUoT1JJRU5UQVRJT05fRVZF TlRTKQogICAgIGludCBvcmllbnRhdGlvbjsKICAgICBXZWJDb3JlOjpGcmFtZSogZnJhbWUgPSBj b3JlKHEpOwogCkBAIC01OTIsNyArNTkyLDcgQEAgUVdlYkZyYW1lOjpRV2ViRnJhbWUoUVdlYlBh Z2UgKnBhcmVudCwgUVdlYkZyYW1lRGF0YSAqZnJhbWVEYXRhKQogICAgICAgICBXZWJDb3JlOjpS ZXNvdXJjZVJlcXVlc3QgcmVxdWVzdChmcmFtZURhdGEtPnVybCwgZnJhbWVEYXRhLT5yZWZlcnJl cik7CiAgICAgICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+bG9hZChyZXF1ZXN0LCBmcmFtZURhdGEt Pm5hbWUsIGZhbHNlKTsKICAgICB9Ci0jaWYgRU5BQkxFKE9SSUVOVEFUSU9OX0VWRU5UUykgJiYg RU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKKyNpZiBFTkFCTEUoT1JJRU5UQVRJT05fRVZFTlRT KQogICAgIGNvbm5lY3QoJmQtPm1fb3JpZW50YXRpb24sIFNJR05BTChyZWFkaW5nQ2hhbmdlZCgp KSwgdGhpcywgU0xPVChfcV9vcmllbnRhdGlvbkNoYW5nZWQoKSkpOwogICAgIGQtPm1fb3JpZW50 YXRpb24uc3RhcnQoKTsKICNlbmRpZgpAQCAtNjA0LDcgKzYwNCw3IEBAIFFXZWJGcmFtZTo6UVdl YkZyYW1lKFFXZWJGcmFtZSAqcGFyZW50LCBRV2ViRnJhbWVEYXRhICpmcmFtZURhdGEpCiB7CiAg ICAgZC0+cGFnZSA9IHBhcmVudC0+ZC0+cGFnZTsKICAgICBkLT5pbml0KHRoaXMsIGZyYW1lRGF0 YSk7Ci0jaWYgRU5BQkxFKE9SSUVOVEFUSU9OX0VWRU5UUykgJiYgRU5BQkxFKERFVklDRV9PUklF TlRBVElPTikKKyNpZiBFTkFCTEUoT1JJRU5UQVRJT05fRVZFTlRTKQogICAgIGNvbm5lY3QoJmQt Pm1fb3JpZW50YXRpb24sIFNJR05BTChyZWFkaW5nQ2hhbmdlZCgpKSwgdGhpcywgU0xPVChfcV9v cmllbnRhdGlvbkNoYW5nZWQoKSkpOwogICAgIGQtPm1fb3JpZW50YXRpb24uc3RhcnQoKTsKICNl bmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lX3AuaCBiL1Nv dXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZV9wLmgKaW5kZXggZGJkYmMzNC4uMzc2M2ZlOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lX3AuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWVfcC5oCkBAIC0yOCw3ICsyOCw3IEBACiAjaW5jbHVk ZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogI2luY2x1ZGUgIlBsYXRm b3JtU3RyaW5nLmgiCi0jaWYgRU5BQkxFKE9SSUVOVEFUSU9OX0VWRU5UUykgJiYgRU5BQkxFKERF VklDRV9PUklFTlRBVElPTikKKyNpZiBFTkFCTEUoT1JJRU5UQVRJT05fRVZFTlRTKQogI2luY2x1 ZGUgInFvcmllbnRhdGlvbnNlbnNvci5oIgogI2VuZGlmCiAjaW5jbHVkZSAicXdlYmVsZW1lbnQu aCIKQEAgLTEyNiw3ICsxMjYsNyBAQCBwdWJsaWM6CiAgICAgT3duUHRyPFdlYkNvcmU6OlRleHR1 cmVNYXBwZXI+IHRleHR1cmVNYXBwZXI7CiAjZW5kaWYKIAotI2lmIEVOQUJMRShPUklFTlRBVElP Tl9FVkVOVFMpICYmIEVOQUJMRShERVZJQ0VfT1JJRU5UQVRJT04pCisjaWYgRU5BQkxFKE9SSUVO VEFUSU9OX0VWRU5UUykKICAgICBRdE1vYmlsaXR5OjpRT3JpZW50YXRpb25TZW5zb3IgbV9vcmll bnRhdGlvbjsKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDc0Y2VhNGUuLjQxMjIyNjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv cXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMDkgIExhc3psbyBHb21ib3Mg IDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gS2VlcCBPUklFTlRBVElPTl9FVkVOVFMgaW5kZXBl bmRlbnQgZnJvbSBERVZJQ0VfT1JJRU5UQVRJT04KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNDIwCisKKyAgICAgICAgT1JJRU5UQVRJT05fRVZFTlRT IGFuZCBERVZJQ0VfT1JJRU5UQVRJT04gZmVhdHVyZXMgYXJlIHZlcnkgc2ltaWxhcgorICAgICAg ICBidXQgdGhleSBtZWFudCB0byBiZSBpbmRlcGVuZGVudC4KKworICAgICAgICAqIEFwaS9xd2Vi ZnJhbWUuY3BwOgorICAgICAgICAoUVdlYkZyYW1lUHJpdmF0ZTo6X3Ffb3JpZW50YXRpb25DaGFu Z2VkKToKKyAgICAgICAgKFFXZWJGcmFtZTo6UVdlYkZyYW1lKToKKyAgICAgICAgKiBBcGkvcXdl YmZyYW1lX3AuaDoKKwogMjAxMS0wNi0wNyAgQXJhdmluZCBBa2VsbGEgIDxhcmF2aW5kLmFrZWxs YUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4K