62411 2011-06-09 16:06:51 -0700 REGRESSION: End of apple.com video in full-screen mode leads to unusable page. 2011-06-10 20:36:38 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble darin webkit.review.bot oldest_to_newest 418372 0 jer.noble 2011-06-09 16:06:51 -0700 REGRESSION: End of apple.com video in full-screen mode leads to unusable page. 418376 1 96659 jer.noble 2011-06-09 16:18:41 -0700 Created attachment 96659 Patch 418377 2 webkit.review.bot 2011-06-09 16:19:45 -0700 Attachment 96659 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderFullScreen.cpp:49: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 418711 3 jer.noble 2011-06-10 08:07:57 -0700 <rdar://problem/9583009> 418732 4 96659 darin 2011-06-10 09:31:54 -0700 Comment on attachment 96659 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96659&action=review > Source/WebCore/rendering/RenderFullScreen.cpp:47 > + virtual ~RenderFullScreenPlaceholder() { } There’s no need for you to define this explicitly. > Source/WebCore/rendering/RenderFullScreen.cpp:48 > + virtual bool isRenderFullScreenPlaceholder() const { return true; } This could be private. >> Source/WebCore/rendering/RenderFullScreen.cpp:49 >> + virtual void destroy() { > > Place brace on its own line for function definitions. [whitespace/braces] [4] I think this could be private. I think it would be better style to not make this inline. > Source/WebCore/rendering/RenderFullScreen.cpp:53 > + RenderFullScreen* m_owner; This could be private. 418733 5 darin 2011-06-10 09:32:13 -0700 Where’s the regression test? 418742 6 jer.noble 2011-06-10 09:43:06 -0700 (In reply to comment #5) > Where’s the regression test? I'll write one up before landing. Thanks! 419139 7 jer.noble 2011-06-10 20:36:38 -0700 Committed r88591: <http://trac.webkit.org/changeset/88591> 96659 2011-06-09 16:18:41 -0700 2011-06-10 09:31:54 -0700 Patch bug-62411-20110609161840.patch text/plain 6149 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODg0NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlMzg0ZGIzNTIwMjlmNzYx OGQ4MGVjYzA4NjQwZmY1NTYxMjAyMmRmLi41MTJkNGQ4MTMyOWIxNzY0MzhhYjFmYjJkMTkxZjJj YzU1ZjlkMzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMzcgQEAKIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBSRUdSRVNTSU9OOiBFbmQgb2YgYXBwbGUu Y29tIHZpZGVvIGluIGZ1bGwtc2NyZWVuIG1vZGUgbGVhZHMgdG8gdW51c2FibGUgcGFnZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNDExCisKKyAg ICAgICAgVGhlIHBsYWNlaG9sZGVyIGZvciBSZW5kZXJGdWxsU2NyZWVuIHdhcyBiZWluZyBjcmVh dGVkIGFzIGEgbm9uLWFub255bW91cyBvYmplY3QsIHdoaWNoIGxlZAorICAgICAgICB0byB0aGUg ZG9jdW1lbnQncyByZW5kZXJlciBiZWluZyBzZXQgdG8gMCB3aGVuIHRoZSBwbGFjZWhvbGRlciB3 YXMgcmVtb3ZlZCBkdWUgdG8gaXRzIHBhcmVudAorICAgICAgICBiZWluZyByZW1vdmVkLiBTZXR0 aW5nIHRoZSBwbGFjZWhvbGRlciB0byBiZSBhbm9ueW1vdXMsIGhvd2V2ZXIsIG1lYW5zIHRoYXQg aXQgd2lsbCBiZQorICAgICAgICBjb2FsZXNjZWQgd2l0aCBzaWJsaW5nIGFub255bW91cyBibG9j a3MsIHNvIGFkZGVkIHRoZSBSZW5kZXJGdWxsU2NyZWVuUGxhY2Vob2xkZXIgdG8gdGhlCisgICAg ICAgIGxpc3Qgb2YgYW5vbnltb3VzIG9iamVjdHMgdGhhdCBhcmUgbm90IGNvbnNpZGVyZWQgYW5v bnltb3VzIGJsb2NrcywgdG8gYXZvaWQgdGhlIHBsYWNlaG9sZGVyCisgICAgICAgIGJlaW5nIHNv IGNvYWxlc2NlZC4gVG8gZG8gc28sIG1hZGUgdGhlIHBsYWNlaG9sZGVyIG9iamVjdCBhIHRydWUg c3ViY2xhc3MsIGFuZCBhZGQgYW5kCisgICAgICAgIG92ZXJyaWRlIGl0cyBkZXN0cm95KCkgZnVu Y3Rpb24gdG8gbm90aWZ5IHRoZSBSZW5kZXJGdWxsU2NyZWVuIG9iamVjdCB0aGF0IGl0IGhhcyBi ZWVuCisgICAgICAgIGRlc3Ryb3llZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGdWxs U2NyZWVuLmNwcDoKKyAgICAgICAgKFJlbmRlckZ1bGxTY3JlZW5QbGFjZWhvbGRlcjo6UmVuZGVy RnVsbFNjcmVlblBsYWNlaG9sZGVyKTogQWRkZWQuCisgICAgICAgIChSZW5kZXJGdWxsU2NyZWVu UGxhY2Vob2xkZXI6On5SZW5kZXJGdWxsU2NyZWVuUGxhY2Vob2xkZXIpOiBBZGRlZC4KKyAgICAg ICAgKFJlbmRlckZ1bGxTY3JlZW5QbGFjZWhvbGRlcjo6aXNSZW5kZXJGdWxsU2NyZWVuUGxhY2Vo b2xkZXIpOiBBZGRlZC4KKyAgICAgICAgKFJlbmRlckZ1bGxTY3JlZW5QbGFjZWhvbGRlcjo6ZGVz dHJveSk6IE5vdGlmeSB0aGUgb3duZXIgcmVuZGVyZXIgdGhhdCBpdHMgcGxhY2Vob2xkZXIKKyAg ICAgICAgICAgIGhhcyBiZWVuIGRlc3Ryb3llZC4KKyAgICAgICAgKFJlbmRlckZ1bGxTY3JlZW46 OmRlc3Ryb3kpOiBBc3NlcnQgdGhhdCB0aGUgbV9wbGFjZWhvbGRlciBpdmFyIGlzIDAgYWZ0ZXIg ZGVzdHJveWluZyBpdC4KKyAgICAgICAgKFJlbmRlckZ1bGxTY3JlZW46OnNldFBsYWNlaG9sZGVy KTogQWRkZWQuCisgICAgICAgIChSZW5kZXJGdWxsU2NyZWVuOjpjcmVhdGVQbGFjZWhvbGRlcik6 IERvIG5vdCBtYWtlIHRoZSBwbGFjZWhvbGRlciBhbm9ueW1vdXMuCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckZ1bGxTY3JlZW4uaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0 Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmlzUmVuZGVyRnVsbFNjcmVlblBs YWNlaG9sZGVyKTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmlzQW5v bnltb3VzQmxvY2spOiBBZGRlZCB0aGUgcGxhY2Vob2xkZXIgY2xhc3MgdG8gdGhlIGxpc3Qgb2YK KyAgICAgICAgICAgIG9iamVjdHMgd2hpY2ggYXJlIG5vdCBhbm9ueW1vdXMgYmxvY2tzLgorCisy MDExLTA2LTA5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFJvbGwgb3V0IHI4ODQ2OCwgYW5k IGZpeCBidWcgIzYxOTExIHdpdGhvdXQgbWFraW5nIEVsZW1lbnQ6Om9mZnNldCBmdW5jdGlvbnMg dmlydHVhbC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYyNDAwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGdWxs U2NyZWVuLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVuLmNw cAppbmRleCAwZThjODIxZGJmNzc3OTAwM2E5ZmNkOTZiNDBiYzUxMzRkNjYzYzQ2Li45NjQwYWYy NDQwMTM1ZmJmMmZkNDk2Yzk5NWYwMTY5ZGU5YWZmNDdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRnVsbFNjcmVlbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uY3BwCkBAIC0zNiw2ICszNiwyMyBAQAogCiB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAorY2xhc3MgUmVuZGVyRnVsbFNjcmVlblBsYWNlaG9sZGVy IDogcHVibGljIFJlbmRlckJsb2NrIHsKK3B1YmxpYzoKKyAgICBSZW5kZXJGdWxsU2NyZWVuUGxh Y2Vob2xkZXIoUmVuZGVyRnVsbFNjcmVlbiogb3duZXIpIAorICAgICAgICA6IFJlbmRlckJsb2Nr KG93bmVyLT5kb2N1bWVudCgpKQorICAgICAgICAsIG1fb3duZXIob3duZXIpIAorICAgIHsgCisg ICAgfQorICAgIAorICAgIHZpcnR1YWwgflJlbmRlckZ1bGxTY3JlZW5QbGFjZWhvbGRlcigpIHsg fQorICAgIHZpcnR1YWwgYm9vbCBpc1JlbmRlckZ1bGxTY3JlZW5QbGFjZWhvbGRlcigpIGNvbnN0 IHsgcmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIHZvaWQgZGVzdHJveSgpIHsKKyAgICAgICAg bV9vd25lci0+c2V0UGxhY2Vob2xkZXIoMCk7CisgICAgICAgIFJlbmRlckJsb2NrOjpkZXN0cm95 KCk7CisgICAgfQorICAgIFJlbmRlckZ1bGxTY3JlZW4qIG1fb3duZXI7Cit9OworCiBSZW5kZXJG dWxsU2NyZWVuOjpSZW5kZXJGdWxsU2NyZWVuKE5vZGUqIG5vZGUpIAogICAgIDogUmVuZGVyRmxl eGlibGVCb3gobm9kZSkgCiAgICAgLCBtX3BsYWNlaG9sZGVyKDApCkBAIC00OSw3ICs2Niw3IEBA IHZvaWQgUmVuZGVyRnVsbFNjcmVlbjo6ZGVzdHJveSgpCiAgICAgICAgIHJlbW92ZSgpOwogICAg ICAgICBpZiAoIW1fcGxhY2Vob2xkZXItPmJlaW5nRGVzdHJveWVkKCkpCiAgICAgICAgICAgICBt X3BsYWNlaG9sZGVyLT5kZXN0cm95KCk7Ci0gICAgICAgIG1fcGxhY2Vob2xkZXIgPSAwOworICAg ICAgICBBU1NFUlQoIW1fcGxhY2Vob2xkZXIpOwogICAgIH0KIAogICAgIC8vIFJlbmRlck9iamVj dHMgYXJlIHVucmV0YWluZWQsIHNvIG5vdGlmeSB0aGUgZG9jdW1lbnQgKHdoaWNoIGhvbGRzIGEg cG9pbnRlciB0byBhIFJlbmRlckZ1bGxTY3JlZW4pCkBAIC04Niw2ICsxMDMsMTEgQEAgUGFzc1Jl ZlB0cjxSZW5kZXJTdHlsZT4gUmVuZGVyRnVsbFNjcmVlbjo6Y3JlYXRlRnVsbFNjcmVlblN0eWxl KCkKICAgICByZXR1cm4gZnVsbHNjcmVlblN0eWxlLnJlbGVhc2UoKTsKIH0KIAordm9pZCBSZW5k ZXJGdWxsU2NyZWVuOjpzZXRQbGFjZWhvbGRlcihSZW5kZXJCbG9jayogcGxhY2Vob2xkZXIpCit7 CisgICAgbV9wbGFjZWhvbGRlciA9IHBsYWNlaG9sZGVyOworfQorCiB2b2lkIFJlbmRlckZ1bGxT Y3JlZW46OmNyZWF0ZVBsYWNlaG9sZGVyKFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+IHN0eWxlLCBj b25zdCBJbnRSZWN0JiBmcmFtZVJlY3QpCiB7CiAgICAgaWYgKHN0eWxlLT53aWR0aCgpLmlzQXV0 bygpKQpAQCAtOTQsOSArMTE2LDggQEAgdm9pZCBSZW5kZXJGdWxsU2NyZWVuOjpjcmVhdGVQbGFj ZWhvbGRlcihQYXNzUmVmUHRyPFJlbmRlclN0eWxlPiBzdHlsZSwgY29uc3QgSW4KICAgICAgICAg c3R5bGUtPnNldEhlaWdodChMZW5ndGgoZnJhbWVSZWN0LmhlaWdodCgpLCBGaXhlZCkpOwogCiAg ICAgaWYgKCFtX3BsYWNlaG9sZGVyKSB7Ci0gICAgICAgIG1fcGxhY2Vob2xkZXIgPSBuZXcgKGRv Y3VtZW50KCktPnJlbmRlckFyZW5hKCkpIFJlbmRlckJsb2NrKGRvY3VtZW50KCkpOworICAgICAg ICBtX3BsYWNlaG9sZGVyID0gbmV3IChkb2N1bWVudCgpLT5yZW5kZXJBcmVuYSgpKSBSZW5kZXJG dWxsU2NyZWVuUGxhY2Vob2xkZXIodGhpcyk7CiAgICAgICAgIG1fcGxhY2Vob2xkZXItPnNldFN0 eWxlKHN0eWxlKTsKLSAgICAgICAgbV9wbGFjZWhvbGRlci0+c2V0SXNBbm9ueW1vdXMoZmFsc2Up OwogICAgICAgICBpZiAocGFyZW50KCkpIHsKICAgICAgICAgICAgIHBhcmVudCgpLT5hZGRDaGls ZChtX3BsYWNlaG9sZGVyLCB0aGlzKTsKICAgICAgICAgICAgIHJlbW92ZSgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1bGxTY3JlZW4uaCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGdWxsU2NyZWVuLmgKaW5kZXggMGE4NzE4YzJhN2I2YzVm NzQxMzZiOGMzMGY1MjMyNDk1ODczZTlmMi4uZjA4NDZjNmJkMmM0MzA2ZTMyNTc4YmUyMDQzOWY2 YjkwYWFiOWUxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZ1 bGxTY3JlZW4uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnVsbFNjcmVl bi5oCkBAIC0zOCw2ICszOCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJG dWxsU2NyZWVuKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgY29uc3QgY2hh ciogcmVuZGVyTmFtZSgpIGNvbnN0IHsgcmV0dXJuICJSZW5kZXJGdWxsU2NyZWVuIjsgfQogCisg ICAgdm9pZCBzZXRQbGFjZWhvbGRlcihSZW5kZXJCbG9jayopOwogICAgIFJlbmRlckJsb2NrKiBw bGFjZWhvbGRlcigpIHsgcmV0dXJuIG1fcGxhY2Vob2xkZXI7IH0KICAgICB2b2lkIGNyZWF0ZVBs YWNlaG9sZGVyKFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+LCBjb25zdCBJbnRSZWN0JiBmcmFtZVJl Y3QpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKaW5kZXggNDE3NDQ3 NWRmYTU3MDY0MzA0ZDYyOWM5N2Y0NzkxYzQ2ZGZkNWQ3Yi4uM2RlZjEzMmI3ZWI0MjVmZTE3MDYw NzBiYzM2ZjM0ZmMzZjFkMDFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuaApAQCAtMzExLDYgKzMxMSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNDYW52 YXMoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK ICAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJGdWxsU2NyZWVuKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNSZW5kZXJGdWxsU2NyZWVuUGxhY2Vob2xkZXIoKSBj b25zdCB7IHJldHVybiBmYWxzZTsgfQogI2VuZGlmCiAKICAgICBib29sIGlzUm9vdCgpIGNvbnN0 IHsgcmV0dXJuIGRvY3VtZW50KCktPmRvY3VtZW50RWxlbWVudCgpID09IG1fbm9kZTsgfQpAQCAt NDAyLDYgKzQwMyw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1faXNBbm9ueW1vdXMgJiYg KHN0eWxlKCktPmRpc3BsYXkoKSA9PSBCTE9DSyB8fCBzdHlsZSgpLT5kaXNwbGF5KCkgPT0gQk9Y KSAmJiBzdHlsZSgpLT5zdHlsZVR5cGUoKSA9PSBOT1BTRVVETyAmJiBpc1JlbmRlckJsb2NrKCkg JiYgIWlzTGlzdE1hcmtlcigpCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogICAgICAgICAg ICAgJiYgIWlzUmVuZGVyRnVsbFNjcmVlbigpCisgICAgICAgICAgICAmJiAhaXNSZW5kZXJGdWxs U2NyZWVuUGxhY2Vob2xkZXIoKQogI2VuZGlmCiAgICAgICAgICAgICA7CiAgICAgfQo=