62400 2011-06-09 13:43:40 -0700 Roll out r88468, and fix bug #61911 without making Element::offset functions virtual. 2011-06-09 17:03:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble hyatt mjs oldest_to_newest 418242 0 jer.noble 2011-06-09 13:43:40 -0700 Hyatt doesn't like the fix in bug #61911, <http://trac.webkit.org/changeset/88468>, and suggested a different way of achieving the same effect. 418246 1 96634 jer.noble 2011-06-09 13:47:19 -0700 Created attachment 96634 Patch 418247 2 96634 hyatt 2011-06-09 13:49:22 -0700 Comment on attachment 96634 Patch r=me! Thanks for the quick turnaround! 418262 3 jer.noble 2011-06-09 14:02:52 -0700 http://jerryseinfeld.com/ content still appears fixed with this patch. No major regressions found on apple.com content, vimeo.com content, or embedded vimeo.com videos. 418263 4 jer.noble 2011-06-09 14:04:01 -0700 <rdar://problem/9582672> 418400 5 jer.noble 2011-06-09 17:03:29 -0700 Committed r88505: <http://trac.webkit.org/changeset/88505> 96634 2011-06-09 13:47:19 -0700 2011-06-09 13:49:22 -0700 Patch bug-62400-20110609134718.patch text/plain 6757 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODg0NjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MjUxZTk4ZjUwYzBlYzgw YTU0MGI0OTQ2MTdlZDkzZGYyYzRmNDBmLi40NDFkNjJlNjEzOGZjOTkxOTYxZDJhOTUzNzRmMmIz NWJjMTE5MGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDYtMDkgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUm9sbCBvdXQgcjg4NDY4LCBhbmQgZml4IGJ1ZyAjNjE5MTEg d2l0aG91dCBtYWtpbmcgRWxlbWVudDo6b2Zmc2V0IGZ1bmN0aW9ucyB2aXJ0dWFsLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI0MDAKKworICAgICAg ICBObyBuZXcgdGVzdHM7IGNvdmVyZWQgYnkgZXhpc3RpbmcgZnVsbHNjcmVlbi9mdWxsLXNjcmVl bi12aWRlby1vZmZzZXQuaHRtbCB0ZXN0LgorCisgICAgICAgICogZG9tL0VsZW1lbnQuaDogTWFr ZSB0aGUgb2Zmc2V0IGZ1bmN0aW9ucyBub24tdmlydHVhbC4KKyAgICAgICAgKiBodG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwOiBSZW1vdmUgdGhlIG9mZnNldCBmdW5jdGlvbnMuCisgICAgICAgICog aHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6IERpdHRvLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJWaWRlby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZW5kZXJlclBsYWNlaG9sZGVyKTogQWRk ZWQ7IHJldHVybnMgdGhlIHBsYWNlaG9sZGVyIGJsb2NrLCBpZiBpdCBleGlzdHMuCisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJWaWRlbzo6b2Zmc2V0TGVmdCk6IFBhc3MgdGhlIG9mZnNldCByZXF1 ZXN0IHRvIHRoZSBwbGFjZWhvbGRlciBibG9jay4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZp ZGVvOjpvZmZzZXRUb3ApOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZGVvOjpv ZmZzZXRXaWR0aCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlkZW86Om9mZnNl dEhlaWdodCk6IERpdHRvLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWRlby5oOiBBZGRl ZCB2aXJ0dWFsIG92ZXJyaWRlcyBmb3IgdGhlIG9mZnNldCBmdW5jdGlvbnMuCisKIDIwMTEtMDYt MDggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCAzMjdkYTBhNjE2Y2UwMTFh ZjUyOGZlYmZmODVjNmZhY2VmZDAzZjI0Li40NDI2MDdlNTQzNDNiYTE1NGMzMmE5ODc0OWVkNjE0 NDNjNDYxNWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTE1MiwxMCArMTUyLDEwIEBAIHB1Ymxp YzoKICAgICB2b2lkIHNjcm9sbEJ5TGluZXMoaW50IGxpbmVzKTsKICAgICB2b2lkIHNjcm9sbEJ5 UGFnZXMoaW50IHBhZ2VzKTsKIAotICAgIHZpcnR1YWwgaW50IG9mZnNldExlZnQoKTsKLSAgICB2 aXJ0dWFsIGludCBvZmZzZXRUb3AoKTsKLSAgICB2aXJ0dWFsIGludCBvZmZzZXRXaWR0aCgpOwot ICAgIHZpcnR1YWwgaW50IG9mZnNldEhlaWdodCgpOworICAgIGludCBvZmZzZXRMZWZ0KCk7Cisg ICAgaW50IG9mZnNldFRvcCgpOworICAgIGludCBvZmZzZXRXaWR0aCgpOworICAgIGludCBvZmZz ZXRIZWlnaHQoKTsKICAgICBFbGVtZW50KiBvZmZzZXRQYXJlbnQoKTsKICAgICBpbnQgY2xpZW50 TGVmdCgpOwogICAgIGludCBjbGllbnRUb3AoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCmluZGV4IDI3Yzc4OWJjZTY2ODhjNDg4MzcwZTEwNGYzNWYzZmNkN2U1MzY0 N2IuLmI3ZjIyMjhmN2M1MDkxZTRiYjY3ZjU3NWZiZjIzMzliYTEzYzNlMzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMjcxNyw0NyArMjcxNyw2IEBAIHZv aWQqIEhUTUxNZWRpYUVsZW1lbnQ6OnByZURpc3BhdGNoRXZlbnRIYW5kbGVyKEV2ZW50KiBldmVu dCkKICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIFJlbmRlckJsb2NrKiBlbGVtZW50UGxhY2Vo b2xkZXIoRWxlbWVudCogZWxlbWVudCkKLXsKLSAgICBSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0g ZWxlbWVudC0+cmVuZGVyZXIoKTsKLSAgICBSZW5kZXJPYmplY3QqIHBhcmVudCA9IHJlbmRlcmVy ID8gcmVuZGVyZXItPnBhcmVudCgpIDogMDsKLSAgICBSZW5kZXJGdWxsU2NyZWVuKiBmdWxsU2Ny ZWVuID0gcGFyZW50ICYmIHBhcmVudC0+aXNSZW5kZXJGdWxsU2NyZWVuKCkgPyB0b1JlbmRlckZ1 bGxTY3JlZW4ocGFyZW50KSA6IDA7Ci0KLSAgICByZXR1cm4gZnVsbFNjcmVlbiA/IGZ1bGxTY3Jl ZW4tPnBsYWNlaG9sZGVyKCkgOiAwOwotfQotCi1pbnQgSFRNTE1lZGlhRWxlbWVudDo6b2Zmc2V0 TGVmdCgpCi17Ci0gICAgaW50IGxlZnQgPSBFbGVtZW50OjpvZmZzZXRMZWZ0KCk7Ci0gICAgaWYg KFJlbmRlckJsb2NrKiBibG9jayA9IGVsZW1lbnRQbGFjZWhvbGRlcih0aGlzKSkKLSAgICAgICAg bGVmdCA9IEVsZW1lbnQ6OmFkanVzdEZvckxvY2FsWm9vbShibG9jay0+b2Zmc2V0TGVmdCgpLCBi bG9jayk7Ci0gICAgcmV0dXJuIGxlZnQ7Ci19Ci0KLWludCBIVE1MTWVkaWFFbGVtZW50OjpvZmZz ZXRUb3AoKQotewotICAgIGludCB0b3AgPSBFbGVtZW50OjpvZmZzZXRUb3AoKTsKLSAgICBpZiAo UmVuZGVyQmxvY2sqIGJsb2NrID0gZWxlbWVudFBsYWNlaG9sZGVyKHRoaXMpKQotICAgICAgICB0 b3AgPSBFbGVtZW50OjphZGp1c3RGb3JMb2NhbFpvb20oYmxvY2stPm9mZnNldFRvcCgpLCBibG9j ayk7Ci0gICAgcmV0dXJuIHRvcDsKLX0KLQotaW50IEhUTUxNZWRpYUVsZW1lbnQ6Om9mZnNldFdp ZHRoKCkKLXsKLSAgICBpbnQgd2lkdGggPSBFbGVtZW50OjpvZmZzZXRXaWR0aCgpOwotICAgIGlm IChSZW5kZXJCbG9jayogYmxvY2sgPSBlbGVtZW50UGxhY2Vob2xkZXIodGhpcykpCi0gICAgICAg IHdpZHRoID0gRWxlbWVudDo6YWRqdXN0Rm9yTG9jYWxab29tKGJsb2NrLT5vZmZzZXRXaWR0aCgp LCBibG9jayk7Ci0gICAgcmV0dXJuIHdpZHRoOwotfQotCi1pbnQgSFRNTE1lZGlhRWxlbWVudDo6 b2Zmc2V0SGVpZ2h0KCkKLXsKLSAgICBpbnQgaGVpZ2h0ID0gRWxlbWVudDo6b2Zmc2V0SGVpZ2h0 KCk7Ci0gICAgaWYgKFJlbmRlckJsb2NrKiBibG9jayA9IGVsZW1lbnRQbGFjZWhvbGRlcih0aGlz KSkKLSAgICAgICAgaGVpZ2h0ID0gRWxlbWVudDo6YWRqdXN0Rm9yTG9jYWxab29tKGJsb2NrLT5v ZmZzZXRIZWlnaHQoKSwgYmxvY2spOwotICAgIHJldHVybiBoZWlnaHQ7Ci19Ci0KIH0KIAogI2Vu ZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IGNmNDJkMTM3MGNj ZjBkYzI3MjBmN2QyNjA2MWU4MjZiZDdmN2M1MWUuLjI3MTYzOWVjZmZlNWI5ODQ1OTk2ZjI3NDdk ZjBiNTMwYWEwYTk2YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBA IC0yMDMsMTIgKzIwMyw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaXNQbGF5aW5nKCkgY29uc3Qg eyByZXR1cm4gbV9wbGF5aW5nOyB9CiAKLSAgICAvLyBPdmVycmlkZSBFbGVtZW50IGltcGxlbWVu dGF0aW9ucwotICAgIHZpcnR1YWwgaW50IG9mZnNldExlZnQoKTsKLSAgICB2aXJ0dWFsIGludCBv ZmZzZXRUb3AoKTsKLSAgICB2aXJ0dWFsIGludCBvZmZzZXRXaWR0aCgpOwotICAgIHZpcnR1YWwg aW50IG9mZnNldEhlaWdodCgpOwotCiBwcm90ZWN0ZWQ6CiAgICAgSFRNTE1lZGlhRWxlbWVudChj b25zdCBRdWFsaWZpZWROYW1lJiwgRG9jdW1lbnQqKTsKICAgICB2aXJ0dWFsIH5IVE1MTWVkaWFF bGVtZW50KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlk ZW8uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcAppbmRleCA0 YzFkN2M0MDI5OTUzMzNjZjg3OGJlZDk0Y2NhMGMzZTQ5MTE4MGUyLi5jOGZiNGMzNjZlZmYzMzhk OTdlMTkyOGZlMzFhYzY2ZjY0YTM0MWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVmlkZW8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWRlby5jcHAKQEAgLTM3LDYgKzM3LDEwIEBACiAjaW5jbHVkZSAiUGFpbnRJbmZvLmgiCiAj aW5jbHVkZSAiUmVuZGVyVmlldy5oIgogCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorI2lu Y2x1ZGUgIlJlbmRlckZ1bGxTY3JlZW4uaCIKKyNlbmRpZgorCiAjaWYgVVNFKEFDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HKQogI2luY2x1ZGUgIlJlbmRlckxheWVyLmgiCiAjaW5jbHVkZSAiUmVuZGVy TGF5ZXJCYWNraW5nLmgiCkBAIC0yODIsNiArMjg2LDQ5IEBAIHZvaWQgUmVuZGVyVmlkZW86OmFj Y2VsZXJhdGVkUmVuZGVyaW5nU3RhdGVDaGFuZ2VkKCkKIH0KICNlbmRpZiAgLy8gVVNFKEFDQ0VM RVJBVEVEX0NPTVBPU0lUSU5HKQogCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorc3RhdGlj IGNvbnN0IFJlbmRlckJsb2NrKiByZW5kZXJlclBsYWNlaG9sZGVyKGNvbnN0IFJlbmRlck9iamVj dCogcmVuZGVyZXIpCit7CisgICAgUmVuZGVyT2JqZWN0KiBwYXJlbnQgPSByZW5kZXJlci0+cGFy ZW50KCk7CisgICAgaWYgKCFwYXJlbnQpCisgICAgICAgIHJldHVybiAwOworICAgIAorICAgIFJl bmRlckZ1bGxTY3JlZW4qIGZ1bGxTY3JlZW4gPSBwYXJlbnQtPmlzUmVuZGVyRnVsbFNjcmVlbigp ID8gdG9SZW5kZXJGdWxsU2NyZWVuKHBhcmVudCkgOiAwOworICAgIGlmICghZnVsbFNjcmVlbikK KyAgICAgICAgcmV0dXJuIDA7CisgICAgCisgICAgcmV0dXJuIGZ1bGxTY3JlZW4tPnBsYWNlaG9s ZGVyKCk7Cit9CisKK2ludCBSZW5kZXJWaWRlbzo6b2Zmc2V0TGVmdCgpIGNvbnN0Cit7CisgICAg aWYgKGNvbnN0IFJlbmRlckJsb2NrKiBibG9jayA9IHJlbmRlcmVyUGxhY2Vob2xkZXIodGhpcykp CisgICAgICAgIHJldHVybiBibG9jay0+b2Zmc2V0TGVmdCgpOworICAgIHJldHVybiBSZW5kZXJN ZWRpYTo6b2Zmc2V0TGVmdCgpOworfQorCitpbnQgUmVuZGVyVmlkZW86Om9mZnNldFRvcCgpIGNv bnN0Cit7CisgICAgaWYgKGNvbnN0IFJlbmRlckJsb2NrKiBibG9jayA9IHJlbmRlcmVyUGxhY2Vo b2xkZXIodGhpcykpCisgICAgICAgIHJldHVybiBibG9jay0+b2Zmc2V0VG9wKCk7CisgICAgcmV0 dXJuIFJlbmRlck1lZGlhOjpvZmZzZXRUb3AoKTsKK30KKworaW50IFJlbmRlclZpZGVvOjpvZmZz ZXRXaWR0aCgpIGNvbnN0Cit7CisgICAgaWYgKGNvbnN0IFJlbmRlckJsb2NrKiBibG9jayA9IHJl bmRlcmVyUGxhY2Vob2xkZXIodGhpcykpCisgICAgICAgIHJldHVybiBibG9jay0+b2Zmc2V0V2lk dGgoKTsKKyAgICByZXR1cm4gUmVuZGVyTWVkaWE6Om9mZnNldFdpZHRoKCk7Cit9CisKK2ludCBS ZW5kZXJWaWRlbzo6b2Zmc2V0SGVpZ2h0KCkgY29uc3QKK3sKKyAgICBpZiAoY29uc3QgUmVuZGVy QmxvY2sqIGJsb2NrID0gcmVuZGVyZXJQbGFjZWhvbGRlcih0aGlzKSkKKyAgICAgICAgcmV0dXJu IGJsb2NrLT5vZmZzZXRIZWlnaHQoKTsKKyAgICByZXR1cm4gUmVuZGVyTWVkaWE6Om9mZnNldEhl aWdodCgpOworfQorI2VuZGlmCisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5oCmluZGV4IDQzNzlmNThjODdkMzQ3Y2Y0 MTE1ZTQyOWI3NzI2NTk4ZDRmZjk3OWIuLjk0ZDIzYWUyMmJiZjJkMzEwOGNhMGRjYzViZjFkN2Jk OTBlYzhkNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRl by5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5oCkBAIC03NCw2 ICs3NCwxMyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgaW50IGNvbXB1dGVSZXBsYWNlZExvZ2lj YWxIZWlnaHQoKSBjb25zdDsKICAgICB2aXJ0dWFsIGludCBtaW5pbXVtUmVwbGFjZWRIZWlnaHQo KSBjb25zdDsKIAorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICB2aXJ0dWFsIGludCBv ZmZzZXRMZWZ0KCkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQgb2Zmc2V0VG9wKCkgY29uc3Q7Cisg ICAgdmlydHVhbCBpbnQgb2Zmc2V0V2lkdGgoKSBjb25zdDsKKyAgICB2aXJ0dWFsIGludCBvZmZz ZXRIZWlnaHQoKSBjb25zdDsKKyNlbmRpZgorCiAgICAgdm9pZCB1cGRhdGVQbGF5ZXIoKTsKIAog ICAgIEludFNpemUgbV9jYWNoZWRJbWFnZVNpemU7Cg==