6240 2005-12-25 12:54:41 -0800 REGRESSION: scrollbars in overflows don't work 2006-01-31 21:20:52 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 mitz darin darin oldest_to_newest 26632 0 mitz 2005-12-25 12:54:41 -0800 Scrollbars in overflows don't respond at all. See for example attachment 4800. The regression happened sometime in these 18 minutes: WebKit-CVS-2005-12-23 21-57-59 GMT.dmg - scrollbars work WebKit-CVS-2005-12-23 22-16-19 GMT.dmg - scrollbars don't work 26634 1 mitz 2005-12-25 13:48:34 -0800 Looks like a regression from the changes to position computations in dom2_eventsimpl.cpp in the patch for bug 6177. 26635 2 mitz 2005-12-25 14:13:53 -0800 - docRenderer->layer()->hitTest(hitTestResult, m_pageX, m_pageY); + docRenderer->layer()->hitTest(hitTestResult, m_clientX, m_clientY); seems to do the trick, but I don't understand all those coordinate systems. 26636 3 mitz 2005-12-25 14:16:35 -0800 (And just to explain how this affected scrollbars: hit-testing the wrong point at the wrong time clears the RenderLayer::gScrollBar global). 26637 4 mitz 2005-12-25 14:32:35 -0800 On an unrelated note, the use of viewportToContents in MouseRelatedEventImpl::computePositions seems ood. It looks to me like m_clientX and m_clientY are already the result of applying viewportToContents to view coordinates in e.g. NodeImpl::dispatchMouseEvent(QMouseEvent *_mouse, const AtomicString &overrideType, int overrideDetail). 26689 5 darin 2005-12-26 17:52:26 -0800 You're right about that viewportToContents call being wrong. That was part of a bigger patch that should not have been landed in this broken form. 26691 6 darin 2005-12-26 17:57:12 -0800 The real issue here is that the current code can't handle clientX, clientY, pageX, and pageY without changes that are outside the event class. So the right thing to do here is to patch to restore the old (albeit broken) behavior. And file a new bug about clientX and clientY being wrong. 27610 7 darin 2006-01-03 11:05:17 -0800 <rdar://problem/4392772> REGRESSION (420+): Can't use scroll bar on DIV element that has been assigned (overflow: auto) (6240) 29393 8 joost 2006-01-22 04:56:20 -0800 Removing keyword(s) since bug is fixed. 29417 9 joost 2006-01-22 05:00:34 -0800 Removing keyword(s) since bug is fixed. 30886 10 eric 2006-01-31 21:20:52 -0800 Removing Regression keyword from bugs already fixed.