62398 2011-06-09 13:32:03 -0700 IndexedDB: indexedDB.open() name argument is required 2011-06-15 10:24:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned dglazkov dgrogan hans tony webkit.review.bot oldest_to_newest 418234 0 96629 pilgrim 2011-06-09 13:32:03 -0700 Created attachment 96629 test case http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBFactory-open-IDBRequest-DOMString-name states that the name argument to open() (for opening a database) is not optional and can not be null. This test opens a database without supplying a name argument. Expected behavior: throws IDBDatabaseException.NON_TRANSIENT_ERR Actual behavior: opens a database whose name is the 9-letter string "undefined" Test case attached. 418802 1 96763 pilgrim 2011-06-10 11:20:22 -0700 Created attachment 96763 Patch 418879 2 dgrogan 2011-06-10 13:57:09 -0700 LGTM 418932 3 96763 webkit.review.bot 2011-06-10 14:42:40 -0700 Comment on attachment 96763 Patch Clearing flags on attachment: 96763 Committed r88569: <http://trac.webkit.org/changeset/88569> 418933 4 webkit.review.bot 2011-06-10 14:42:44 -0700 All reviewed patches have been landed. Closing bug. 419235 5 dglazkov 2011-06-11 13:22:03 -0700 Reverted r88569 for reason: Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest Committed r88606: <http://trac.webkit.org/changeset/88606> 419237 6 dglazkov 2011-06-11 13:23:05 -0700 (In reply to comment #5) > Reverted r88569 for reason: > > Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest > > Committed r88606: <http://trac.webkit.org/changeset/88606> That's the one. 419238 7 dglazkov 2011-06-11 13:24:37 -0700 (In reply to comment #6) > (In reply to comment #5) > > Reverted r88569 for reason: > > > > Broke Chromium browser test: IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest > > > > Committed r88606: <http://trac.webkit.org/changeset/88606> > > That's the one. There's the test: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/test/data/indexeddb/database_callbacks_first.html&exact_package=chromium&q=database_callbacks_first.html&type=cs 421140 8 hans 2011-06-15 02:16:31 -0700 Fixed the Chromium browser test: http://src.chromium.org/viewvc/chrome?view=rev&revision=89152 We should be able to re-land this now. 421423 9 96763 webkit.review.bot 2011-06-15 10:24:43 -0700 Comment on attachment 96763 Patch Clearing flags on attachment: 96763 Committed r88954: <http://trac.webkit.org/changeset/88954> 421424 10 webkit.review.bot 2011-06-15 10:24:47 -0700 All reviewed patches have been landed. Closing bug. 96629 2011-06-09 13:32:03 -0700 2011-06-10 11:23:32 -0700 test case database-name-undefined.html text/html 1581 pilgrim PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVm PSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+CjxzY3JpcHQgc3Jj PSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CjxzY3Jp cHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QtZnVuY3Rpb24uanMi Pjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3NoYXJlZC5qcyI+PC9zY3JpcHQ+Cjwv aGVhZD4KPGJvZHk+CjxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgo8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KPHNjcmlwdD4KCmRlc2NyaXB0aW9uKCJUZXN0IEluZGV4ZWREQiB1bmRlZmluZWQgYXMg cmVjb3JkIHZhbHVlIik7CmlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CgpmdW5jdGlvbiB0ZXN0KCkKewogICAg aW5kZXhlZERCID0gZXZhbEFuZExvZygiaW5kZXhlZERCID0gd2luZG93LmluZGV4ZWREQiB8fCB3 aW5kb3cud2Via2l0SW5kZXhlZERCIHx8IHdpbmRvdy5tb3pJbmRleGVkREI7Iik7CiAgICBzaG91 bGRCZUZhbHNlKCJpbmRleGVkREIgPT0gbnVsbCIpOwogICAgSURCRGF0YWJhc2VFeGNlcHRpb24g PSBldmFsQW5kTG9nKCJJREJEYXRhYmFzZUV4Y2VwdGlvbiA9IHdpbmRvdy5JREJEYXRhYmFzZUV4 Y2VwdGlvbiB8fCB3aW5kb3cud2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb247Iik7CiAgICBzaG91 bGRCZUZhbHNlKCJJREJEYXRhYmFzZUV4Y2VwdGlvbiA9PSBudWxsIik7CiAgICBJREJDdXJzb3Ig PSBldmFsQW5kTG9nKCJJREJDdXJzb3IgPSB3aW5kb3cuSURCQ3Vyc29yIHx8IHdpbmRvdy53ZWJr aXRJREJDdXJzb3I7Iik7CiAgICBzaG91bGRCZUZhbHNlKCJJREJDdXJzb3IgPT0gbnVsbCIpOwog ICAgSURCS2V5UmFuZ2UgPSBldmFsQW5kTG9nKCJJREJLZXlSYW5nZSA9IHdpbmRvdy5JREJLZXlS YW5nZSB8fCB3aW5kb3cud2Via2l0SURCS2V5UmFuZ2U7Iik7CiAgICBzaG91bGRCZUZhbHNlKCJJ REJLZXlSYW5nZSA9PSBudWxsIik7CgogICAgZXZhbEFuZEV4cGVjdEV4Y2VwdGlvbigiaW5kZXhl ZERCLm9wZW4oKTsiLCBJREJEYXRhYmFzZUV4Y2VwdGlvbi5OT05fVFJBTlNJRU5UX0VSUik7CiAg ICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IGluZGV4ZWREQi5vcGVuKCk7Iik7CiAg ICByZXF1ZXN0Lm9uc3VjY2VzcyA9IG9wZW5TdWNjZXNzOwogICAgcmVxdWVzdC5vbmVycm9yID0g dW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7Cn0KCmZ1bmN0aW9uIG9wZW5TdWNjZXNzKCkKewogICAg ZGIgPSBldmFsQW5kTG9nKCJkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsKICAgIGRlYnVnKCJk Yi5uYW1lIGlzICIgKyBkYi5uYW1lKTsKICAgIGRlYnVnKCJkYi5uYW1lLmxlbmd0aCBpcyAiICsg ZGIubmFtZS5sZW5ndGgpOwogICAgZG9uZSgpOwp9Cgp2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsKCnRlc3QoKTsKCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 96763 2011-06-10 11:20:22 -0700 2011-06-15 10:24:43 -0700 Patch bug-62398-20110610142037.patch text/plain 4676 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NTUzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMTAgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQjogaW5kZXhlZERCLm9wZW4oKSBuYW1lIGFy Z3VtZW50IGlzIHJlcXVpcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02MjM5OAorCisgICAgICAgIFRlc3Q6IHN0b3JhZ2UvaW5kZXhlZGRiL2RhdGFi YXNlLW5hbWUtdW5kZWZpbmVkLmh0bWwKKworICAgICAgICAqIHN0b3JhZ2UvSURCRmFjdG9yeS5p ZGw6IHVzZSBhcHByb3ByaWF0ZSBJREwgbWFnaWMgdG8gZm9yY2UgdW5kZWZpbmVkIHZhbHVlcyB0 byBudWxsLCBzbyB3ZSBoYW5kbGUgbWlzc2luZyBhcmd1bWVudHMgYXMgd2VsbCBhcyBudWxsIGFy Z3VtZW50cworCiAyMDExLTA2LTEwICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9zdG9yYWdlL0lEQkZhY3RvcnkuaWRsCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3N0b3JhZ2UvSURCRmFjdG9yeS5pZGwJKHJldmlzaW9uIDg4MTgxKQorKysgU291cmNl L1dlYkNvcmUvc3RvcmFnZS9JREJGYWN0b3J5LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjgsNyAr MjgsNyBAQCBtb2R1bGUgc3RvcmFnZSB7CiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0 aW9uYWw9SU5ERVhFRF9EQVRBQkFTRQogICAgIF0gSURCRmFjdG9yeSB7Ci0gICAgICAgIFtDYWxs V2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0XSBJREJSZXF1ZXN0IG9wZW4oaW4gW0NvbnZlcnRO dWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcgbmFtZSkKKyAgICAgICAgW0NhbGxXaXRoPVNjcmlw dEV4ZWN1dGlvbkNvbnRleHRdIElEQlJlcXVlc3Qgb3BlbihpbiBbQ29udmVydFVuZGVmaW5lZE9y TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIG5hbWUpCiAgICAgICAgICAgICByYWlzZXMgKElE QkRhdGFiYXNlRXhjZXB0aW9uKTsKICAgICB9OwogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA4ODU1MykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDExLTA2LTEwICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmRleGVkREI6IGlu ZGV4ZWREQi5vcGVuKCkgbmFtZSBhcmd1bWVudCBpcyByZXF1aXJlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzOTgKKworICAgICAgICAqIHN0b3Jh Z2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVkLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtbmFtZS11bmRlZmluZWQuaHRt bDogQWRkZWQuCisKIDIwMTEtMDYtMTAgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IEdlbnRpbGNvcmUuCkluZGV4OiBMYXlv dXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1uYW1lLXVuZGVmaW5lZC1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJh c2UtbmFtZS11bmRlZmluZWQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2UtbmFtZS11bmRlZmluZWQtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIwIEBACitUZXN0IEluZGV4ZWREQiB1bmRlZmluZWQg YXMgcmVjb3JkIHZhbHVlCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitpbmRleGVk REIgPSB3aW5kb3cuaW5kZXhlZERCIHx8IHdpbmRvdy53ZWJraXRJbmRleGVkREIgfHwgd2luZG93 Lm1vekluZGV4ZWREQjsKK1BBU1MgaW5kZXhlZERCID09IG51bGwgaXMgZmFsc2UKK0lEQkRhdGFi YXNlRXhjZXB0aW9uID0gd2luZG93LklEQkRhdGFiYXNlRXhjZXB0aW9uIHx8IHdpbmRvdy53ZWJr aXRJREJEYXRhYmFzZUV4Y2VwdGlvbjsKK1BBU1MgSURCRGF0YWJhc2VFeGNlcHRpb24gPT0gbnVs bCBpcyBmYWxzZQorSURCQ3Vyc29yID0gd2luZG93LklEQkN1cnNvciB8fCB3aW5kb3cud2Via2l0 SURCQ3Vyc29yOworUEFTUyBJREJDdXJzb3IgPT0gbnVsbCBpcyBmYWxzZQorSURCS2V5UmFuZ2Ug PSB3aW5kb3cuSURCS2V5UmFuZ2UgfHwgd2luZG93LndlYmtpdElEQktleVJhbmdlOworUEFTUyBJ REJLZXlSYW5nZSA9PSBudWxsIGlzIGZhbHNlCitFeHBlY3RpbmcgZXhjZXB0aW9uIGZyb20gaW5k ZXhlZERCLm9wZW4oKTsKK1BBU1MgRXhjZXB0aW9uIHdhcyB0aHJvd24uCitQQVNTIGNvZGUgaXMg SURCRGF0YWJhc2VFeGNlcHRpb24uTk9OX1RSQU5TSUVOVF9FUlIKK1BBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9y YWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1uYW1lLXVuZGVmaW5lZC5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVkLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFz ZS1uYW1lLXVuZGVmaW5lZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM5IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9 Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3Jj PSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LWZ1bmN0aW9uLmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvc2hhcmVkLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUZXN0IEluZGV4ZWREQiB1bmRl ZmluZWQgYXMgcmVjb3JkIHZhbHVlIik7CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKworZnVuY3Rpb24g dGVzdCgpCit7CisgICAgaW5kZXhlZERCID0gZXZhbEFuZExvZygiaW5kZXhlZERCID0gd2luZG93 LmluZGV4ZWREQiB8fCB3aW5kb3cud2Via2l0SW5kZXhlZERCIHx8IHdpbmRvdy5tb3pJbmRleGVk REI7Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiaW5kZXhlZERCID09IG51bGwiKTsKKyAgICBJREJE YXRhYmFzZUV4Y2VwdGlvbiA9IGV2YWxBbmRMb2coIklEQkRhdGFiYXNlRXhjZXB0aW9uID0gd2lu ZG93LklEQkRhdGFiYXNlRXhjZXB0aW9uIHx8IHdpbmRvdy53ZWJraXRJREJEYXRhYmFzZUV4Y2Vw dGlvbjsiKTsKKyAgICBzaG91bGRCZUZhbHNlKCJJREJEYXRhYmFzZUV4Y2VwdGlvbiA9PSBudWxs Iik7CisgICAgSURCQ3Vyc29yID0gZXZhbEFuZExvZygiSURCQ3Vyc29yID0gd2luZG93LklEQkN1 cnNvciB8fCB3aW5kb3cud2Via2l0SURCQ3Vyc29yOyIpOworICAgIHNob3VsZEJlRmFsc2UoIklE QkN1cnNvciA9PSBudWxsIik7CisgICAgSURCS2V5UmFuZ2UgPSBldmFsQW5kTG9nKCJJREJLZXlS YW5nZSA9IHdpbmRvdy5JREJLZXlSYW5nZSB8fCB3aW5kb3cud2Via2l0SURCS2V5UmFuZ2U7Iik7 CisgICAgc2hvdWxkQmVGYWxzZSgiSURCS2V5UmFuZ2UgPT0gbnVsbCIpOworCisgICAgZXZhbEFu ZEV4cGVjdEV4Y2VwdGlvbigiaW5kZXhlZERCLm9wZW4oKTsiLCAiSURCRGF0YWJhc2VFeGNlcHRp b24uTk9OX1RSQU5TSUVOVF9FUlIiKTsKKyAgICBkb25lKCk7Cit9CisKK3ZhciBzdWNjZXNzZnVs bHlQYXJzZWQgPSB0cnVlOworCit0ZXN0KCk7CisKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo=