62396 2011-06-09 13:06:48 -0700 Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console 2011-06-24 01:26:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik webkit-unassigned abarth apavlov bweinstein fishd gavinp joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 418207 0 vsevik 2011-06-09 13:06:48 -0700 Successfully prefetched page shows up as an error in console. 418215 1 96623 vsevik 2011-06-09 13:12:27 -0700 Created attachment 96623 patch 418219 2 vsevik 2011-06-09 13:16:06 -0700 Downstream bug: crbug.com/82422 Here is a quick and naive attempt to implement this. I'd like to hear some feedback on using CANCELED to avoid getting console error. The chromium part of the patch is here: http://codereview.chromium.org/6995118 418250 3 96623 abarth 2011-06-09 13:52:24 -0700 Comment on attachment 96623 patch View in context: https://bugs.webkit.org/attachment.cgi?id=96623&action=review > Source/WebKit/chromium/src/WebURLError.cpp:67 > + resourceError.setIsCancellation(isCanceling); Why isn't this part of the constructor? 418251 4 96623 abarth 2011-06-09 13:52:40 -0700 Comment on attachment 96623 patch Needs ChangeLog and test. 418252 5 abarth 2011-06-09 13:52:59 -0700 +fishd for WebKit API review. 418294 6 vsevik 2011-06-09 14:22:26 -0700 This doesn't have tests and changelog intentionally. I just want to get some feedback on using CANCELED for that in general. And on setting isCancellation flag for all the re 418296 7 vsevik 2011-06-09 14:23:41 -0700 This doesn't have tests and changelog intentionally. I just want to get some feedback on using URLRequestStatus::CANCELED and setting isCancellation flag for all the requests having URLRequestStatus::CANCELED status in general. 418308 8 abarth 2011-06-09 14:32:20 -0700 +gavinp He's likely to give you the best quality feedback. 421317 9 gavinp 2011-06-15 08:30:08 -0700 This approach seems fine to me. The error in the debug console was really counterintuitive. See my comments in the corresponding chromium review at http://codereview.chromium.org/6995118 421372 10 96623 fishd 2011-06-15 09:30:46 -0700 Comment on attachment 96623 patch View in context: https://bugs.webkit.org/attachment.cgi?id=96623&action=review > Source/WebKit/chromium/public/WebURLError.h:54 > + bool isCanceling; This struct is supposed to correspond to WebCore::ResourceError. Unless you are plumbing this field all the way through ResourceError, I don't think it belongs here. 421376 11 96623 fishd 2011-06-15 09:37:12 -0700 Comment on attachment 96623 patch View in context: https://bugs.webkit.org/attachment.cgi?id=96623&action=review >> Source/WebKit/chromium/public/WebURLError.h:54 >> + bool isCanceling; > > This struct is supposed to correspond to WebCore::ResourceError. Unless you are plumbing this field all the way through ResourceError, I don't think it belongs here. OK, I missed the fact that ResourceError has an m_isCancellation field. Hmm... 421381 12 fishd 2011-06-15 09:43:07 -0700 It looks like ResourceError::m_isCancellation was added in http://trac.webkit.org/changeset/33559, and the layout test for that change is one that we skip for Chromium :-( It definitely seems like we need WebURLError to have its own isCancellation field, and we need to update both the WebURLError::operator=(const ResourceError&) and WebURLError::operator ResourceError(). 422124 13 97475 vsevik 2011-06-16 11:57:31 -0700 Created attachment 97475 patch 422126 14 vsevik 2011-06-16 12:03:42 -0700 I have added isCancellation field to WebURLError and updated WebURLError::operator=(const ResourceError&) and WebURLError::operator ResourceError() accordingly. I did not add a test for that. Unfortunately DumpRenderTree doesn't seem to put this error in console (looks like it treats prefetch differently overall), so it gives false positive on my test even without this change. 422129 15 97476 vsevik 2011-06-16 12:08:41 -0700 Created attachment 97476 patch (forgot to add a changelog) 423608 16 97782 vsevik 2011-06-20 05:17:16 -0700 Created attachment 97782 Patch with new field renamed 423928 17 97782 fishd 2011-06-20 13:52:02 -0700 Comment on attachment 97782 Patch with new field renamed View in context: https://bugs.webkit.org/attachment.cgi?id=97782&action=review > Source/WebKit/chromium/public/WebURLError.h:55 > + // A flag showing whether this error should be trated as a cancellation, "trated" -> "treated" > Source/WebKit/chromium/src/WebURLError.cpp:65 > + ResourceError resourceError = ResourceError(domain, reason, note: the old code aligned the parameters in a right-aligned column. you should probably indent the 2nd and 3rd params to preserve that style. 423956 18 97858 vsevik 2011-06-20 14:33:58 -0700 Created attachment 97858 Patch with fixes 426785 19 97858 webkit.review.bot 2011-06-24 01:26:02 -0700 Comment on attachment 97858 Patch with fixes Clearing flags on attachment: 97858 Committed r89658: <http://trac.webkit.org/changeset/89658> 426786 20 webkit.review.bot 2011-06-24 01:26:08 -0700 All reviewed patches have been landed. Closing bug. 96623 2011-06-09 13:12:27 -0700 2011-06-16 11:57:19 -0700 patch bug-62396-20110610001225.patch text/plain 1555 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogODg0NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlVSTEVycm9yLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJVUkxFcnJvci5oCmluZGV4IGRlODhlM2UwMWNlNjE4MTYyYWU4NjJiM2FmNDg2YzUzN2Rl M2IwOWQuLjNkZTAyYmNiNmY3MWM0MzRkZGU5YmU4ZTkyZTc0YTJlMjUyMzdhMTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMRXJyb3IuaApAQCAtNTEsMTEgKzUxLDEx IEBAIHN0cnVjdCBXZWJVUkxFcnJvciB7CiAgICAgLy8gdmFsdWVzIGFuZCBub3JtYWxseSBqdXN0 IGZvcndhcmRzIHRoaXMgZXJyb3IgaW5mb3JtYXRpb24gYmFjayB0byB0aGUKICAgICAvLyBlbWJl ZGRlciAoc2VlIGZvciBleGFtcGxlIFdlYkZyYW1lQ2xpZW50KS4KICAgICBpbnQgcmVhc29uOwot CisgICAgYm9vbCBpc0NhbmNlbGluZzsKICAgICAvLyBUaGUgdXJsIHRoYXQgZmFpbGVkIHRvIGxv YWQuCiAgICAgV2ViVVJMIHVucmVhY2hhYmxlVVJMOwogCi0gICAgV2ViVVJMRXJyb3IoKSA6IHJl YXNvbigwKSB7IH0KKyAgICBXZWJVUkxFcnJvcigpIDogcmVhc29uKDApLCBpc0NhbmNlbGluZyhm YWxzZSkgeyB9CiAKICNpZiBkZWZpbmVkKFdFQktJVF9JTVBMRU1FTlRBVElPTikKICAgICBXZWJV UkxFcnJvcihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJik7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxFcnJvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJVUkxFcnJvci5jcHAKaW5kZXggZWYzMmI1Yzc2MmM3ZTBkZDY2MmFlNDE4 MjA1Yzg2NjQyM2Q5NjEyMS4uNzFlNjAwZDYyMjZhNzJkNWJlOWQ4ZDlmYjg1YTY5ZTkzZWVjZDRj YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMRXJyb3IuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTEVycm9yLmNwcApAQCAtNjEs OSArNjEsMTEgQEAgV2ViVVJMRXJyb3I6Om9wZXJhdG9yIFJlc291cmNlRXJyb3IoKSBjb25zdAog ICAgIGlmICghcmVhc29uKQogICAgICAgICByZXR1cm4gUmVzb3VyY2VFcnJvcigpOwogICAgIENT dHJpbmcgc3BlYyA9IHVucmVhY2hhYmxlVVJMLnNwZWMoKTsKLSAgICByZXR1cm4gUmVzb3VyY2VF cnJvcihkb21haW4sIHJlYXNvbiwKKyAgICBSZXNvdXJjZUVycm9yIHJlc291cmNlRXJyb3IgPSBS ZXNvdXJjZUVycm9yKGRvbWFpbiwgcmVhc29uLAogICAgICAgICAgICAgICAgICAgICAgICAgIFN0 cmluZzo6ZnJvbVVURjgoc3BlYy5kYXRhKCksIHNwZWMubGVuZ3RoKCkpLAogICAgICAgICAgICAg ICAgICAgICAgICAgIFN0cmluZygpKTsKKyAgICByZXNvdXJjZUVycm9yLnNldElzQ2FuY2VsbGF0 aW9uKGlzQ2FuY2VsaW5nKTsKKyAgICByZXR1cm4gcmVzb3VyY2VFcnJvcjsKIH0KIAogfSAvLyBu YW1lc3BhY2UgV2ViS2l0Cg== 97475 2011-06-16 11:57:31 -0700 2011-06-16 12:08:29 -0700 patch bug-62396-20110616225728.patch text/plain 1918 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogODkwMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYlVSTEVycm9yLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJVUkxFcnJvci5oCmluZGV4IGRlODhlM2UwMWNlNjE4MTYyYWU4NjJiM2FmNDg2YzUzN2Rl M2IwOWQuLjkzMmVkN2NhNGVjNDU0NDM1MmFmNzc4MzljODcyOGQyMzFhNWFjYzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMRXJyb3IuaApAQCAtNTIsMTAgKzUyLDE0 IEBAIHN0cnVjdCBXZWJVUkxFcnJvciB7CiAgICAgLy8gZW1iZWRkZXIgKHNlZSBmb3IgZXhhbXBs ZSBXZWJGcmFtZUNsaWVudCkuCiAgICAgaW50IHJlYXNvbjsKIAorICAgIC8vIEEgZmxhZyBzaG93 aW5nIHdoZXRoZXIgdGhpcyBlcnJvciBzaG91bGQgYmUgdHJhdGVkIGFzIGEgY2FuY2VsbGF0aW9u LAorICAgIC8vIGUuZy4gd2UgZG8gbm90IHNob3cgY29uc29sZSBlcnJvcnMgZm9yIGNhbmNlbGxh dGlvbnMuCisgICAgYm9vbCBpc0NhbmNlbGluZzsKKwogICAgIC8vIFRoZSB1cmwgdGhhdCBmYWls ZWQgdG8gbG9hZC4KICAgICBXZWJVUkwgdW5yZWFjaGFibGVVUkw7CiAKLSAgICBXZWJVUkxFcnJv cigpIDogcmVhc29uKDApIHsgfQorICAgIFdlYlVSTEVycm9yKCkgOiByZWFzb24oMCksIGlzQ2Fu Y2VsaW5nKGZhbHNlKSB7IH0KIAogI2lmIGRlZmluZWQoV0VCS0lUX0lNUExFTUVOVEFUSU9OKQog ICAgIFdlYlVSTEVycm9yKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTEVycm9yLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTEVycm9yLmNwcAppbmRleCBlZjMyYjVjNzYyYzdlMGRk NjYyYWU0MTgyMDVjODY2NDIzZDk2MTIxLi4xYzFhNWZiYzUwZGViM2ExNzFhZTVjZjczYjUyMDU4 MWI0OWM4MmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxF cnJvci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMRXJyb3IuY3Bw CkBAIC01Miw2ICs1Miw3IEBAIFdlYlVSTEVycm9yJiBXZWJVUkxFcnJvcjo6b3BlcmF0b3I9KGNv bnN0IFJlc291cmNlRXJyb3ImIGVycm9yKQogICAgICAgICBkb21haW4gPSBlcnJvci5kb21haW4o KTsKICAgICAgICAgcmVhc29uID0gZXJyb3IuZXJyb3JDb2RlKCk7CiAgICAgICAgIHVucmVhY2hh YmxlVVJMID0gS1VSTChQYXJzZWRVUkxTdHJpbmcsIGVycm9yLmZhaWxpbmdVUkwoKSk7CisgICAg ICAgIGlzQ2FuY2VsaW5nID0gZXJyb3IuaXNDYW5jZWxsYXRpb24oKTsKICAgICB9CiAgICAgcmV0 dXJuICp0aGlzOwogfQpAQCAtNjEsOSArNjIsMTEgQEAgV2ViVVJMRXJyb3I6Om9wZXJhdG9yIFJl c291cmNlRXJyb3IoKSBjb25zdAogICAgIGlmICghcmVhc29uKQogICAgICAgICByZXR1cm4gUmVz b3VyY2VFcnJvcigpOwogICAgIENTdHJpbmcgc3BlYyA9IHVucmVhY2hhYmxlVVJMLnNwZWMoKTsK LSAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihkb21haW4sIHJlYXNvbiwKKyAgICBSZXNvdXJjZUVy cm9yIHJlc291cmNlRXJyb3IgPSBSZXNvdXJjZUVycm9yKGRvbWFpbiwgcmVhc29uLAogICAgICAg ICAgICAgICAgICAgICAgICAgIFN0cmluZzo6ZnJvbVVURjgoc3BlYy5kYXRhKCksIHNwZWMubGVu Z3RoKCkpLAogICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZygpKTsKKyAgICByZXNvdXJj ZUVycm9yLnNldElzQ2FuY2VsbGF0aW9uKGlzQ2FuY2VsaW5nKTsKKyAgICByZXR1cm4gcmVzb3Vy Y2VFcnJvcjsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg== 97476 2011-06-16 12:08:41 -0700 2011-06-20 05:17:04 -0700 patch (forgot to add a changelog) bug-62396-20110616230839.patch text/plain 2746 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogODkwNDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MDU5MWY3NTZjZDdiZGQ1NWQ4NTc5NjNkZmRmNjM2N2QzZWNmZDkyYi4uOGU4OGNlNGMwZTgxNDVj MmU1MWUyMWI1YjI0NThiMDdmYzUyZTNkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNi0xNiAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIFN1Y2Nlc3NmdWxseSBwcmVmZXRjaGVkIHBhZ2Ug c2hvd3MgdXAgYXMgYW4gZXJyb3IgaW4gY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzOTYKKworICAgICAgICAqIHB1YmxpYy9XZWJVUkxF cnJvci5oOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxFcnJvcjo6V2ViVVJMRXJyb3IpOgorICAg ICAgICAqIHNyYy9XZWJVUkxFcnJvci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTEVycm9y OjpvcGVyYXRvcj0pOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxFcnJvcjo6b3BlcmF0b3IgUmVz b3VyY2VFcnJvcik6CisKIDIwMTEtMDYtMTYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4OTAyNi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxFcnJvci5oCmluZGV4IGRlODhl M2UwMWNlNjE4MTYyYWU4NjJiM2FmNDg2YzUzN2RlM2IwOWQuLjkzMmVkN2NhNGVjNDU0NDM1MmFm Nzc4MzljODcyOGQyMzFhNWFjYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlVSTEVycm9yLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViVVJMRXJyb3IuaApAQCAtNTIsMTAgKzUyLDE0IEBAIHN0cnVjdCBXZWJVUkxFcnJvciB7CiAg ICAgLy8gZW1iZWRkZXIgKHNlZSBmb3IgZXhhbXBsZSBXZWJGcmFtZUNsaWVudCkuCiAgICAgaW50 IHJlYXNvbjsKIAorICAgIC8vIEEgZmxhZyBzaG93aW5nIHdoZXRoZXIgdGhpcyBlcnJvciBzaG91 bGQgYmUgdHJhdGVkIGFzIGEgY2FuY2VsbGF0aW9uLAorICAgIC8vIGUuZy4gd2UgZG8gbm90IHNo b3cgY29uc29sZSBlcnJvcnMgZm9yIGNhbmNlbGxhdGlvbnMuCisgICAgYm9vbCBpc0NhbmNlbGlu ZzsKKwogICAgIC8vIFRoZSB1cmwgdGhhdCBmYWlsZWQgdG8gbG9hZC4KICAgICBXZWJVUkwgdW5y ZWFjaGFibGVVUkw7CiAKLSAgICBXZWJVUkxFcnJvcigpIDogcmVhc29uKDApIHsgfQorICAgIFdl YlVSTEVycm9yKCkgOiByZWFzb24oMCksIGlzQ2FuY2VsaW5nKGZhbHNlKSB7IH0KIAogI2lmIGRl ZmluZWQoV0VCS0lUX0lNUExFTUVOVEFUSU9OKQogICAgIFdlYlVSTEVycm9yKGNvbnN0IFdlYkNv cmU6OlJlc291cmNlRXJyb3ImKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlVSTEVycm9yLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTEVy cm9yLmNwcAppbmRleCBlZjMyYjVjNzYyYzdlMGRkNjYyYWU0MTgyMDVjODY2NDIzZDk2MTIxLi4x YzFhNWZiYzUwZGViM2ExNzFhZTVjZjczYjUyMDU4MWI0OWM4MmY1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxFcnJvci5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVVJMRXJyb3IuY3BwCkBAIC01Miw2ICs1Miw3IEBAIFdlYlVSTEVy cm9yJiBXZWJVUkxFcnJvcjo6b3BlcmF0b3I9KGNvbnN0IFJlc291cmNlRXJyb3ImIGVycm9yKQog ICAgICAgICBkb21haW4gPSBlcnJvci5kb21haW4oKTsKICAgICAgICAgcmVhc29uID0gZXJyb3Iu ZXJyb3JDb2RlKCk7CiAgICAgICAgIHVucmVhY2hhYmxlVVJMID0gS1VSTChQYXJzZWRVUkxTdHJp bmcsIGVycm9yLmZhaWxpbmdVUkwoKSk7CisgICAgICAgIGlzQ2FuY2VsaW5nID0gZXJyb3IuaXND YW5jZWxsYXRpb24oKTsKICAgICB9CiAgICAgcmV0dXJuICp0aGlzOwogfQpAQCAtNjEsOSArNjIs MTEgQEAgV2ViVVJMRXJyb3I6Om9wZXJhdG9yIFJlc291cmNlRXJyb3IoKSBjb25zdAogICAgIGlm ICghcmVhc29uKQogICAgICAgICByZXR1cm4gUmVzb3VyY2VFcnJvcigpOwogICAgIENTdHJpbmcg c3BlYyA9IHVucmVhY2hhYmxlVVJMLnNwZWMoKTsKLSAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihk b21haW4sIHJlYXNvbiwKKyAgICBSZXNvdXJjZUVycm9yIHJlc291cmNlRXJyb3IgPSBSZXNvdXJj ZUVycm9yKGRvbWFpbiwgcmVhc29uLAogICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZzo6 ZnJvbVVURjgoc3BlYy5kYXRhKCksIHNwZWMubGVuZ3RoKCkpLAogICAgICAgICAgICAgICAgICAg ICAgICAgIFN0cmluZygpKTsKKyAgICByZXNvdXJjZUVycm9yLnNldElzQ2FuY2VsbGF0aW9uKGlz Q2FuY2VsaW5nKTsKKyAgICByZXR1cm4gcmVzb3VyY2VFcnJvcjsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViS2l0Cg== 97782 2011-06-20 05:17:16 -0700 2011-06-20 14:33:46 -0700 Patch with new field renamed bug-62396-20110620161714.patch text/plain 2729 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogODkyNDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg Njk5YTc2ZTA4ZTg2OGIzYjc5NzA3YmYwMmJmNjY5MGVmMmY1NzY5ZC4uMmI5MzE3OTE3NjkzMTRl MjQ4NDU5MzcxYzI2OTQwYjUzZmE1ZWFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNi0yMCAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIFN1Y2Nlc3NmdWxseSBwcmVmZXRjaGVkIHBhZ2Ug c2hvd3MgdXAgYXMgYW4gZXJyb3IgaW4gY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzOTYKKworICAgICAgICAqIHB1YmxpYy9XZWJVUkxF cnJvci5oOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxFcnJvcjo6V2ViVVJMRXJyb3IpOgorICAg ICAgICAqIHNyYy9XZWJVUkxFcnJvci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTEVycm9y OjpvcGVyYXRvcj0pOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxFcnJvcjo6b3BlcmF0b3IgUmVz b3VyY2VFcnJvcik6CisKIDIwMTEtMDYtMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUm9sbGVkIERFUFMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJVUkxFcnJvci5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViVVJMRXJyb3IuaAppbmRleCBkZTg4ZTNlMDFjZTYxODE2MmFlODYyYjNhZjQ4NmM1Mzdk ZTNiMDlkLi4wMzFmYjBmMGZmNmZjN2MyNDMyMWRkMjYyODVhYjExYmE4N2ZkZmIwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxFcnJvci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmgKQEAgLTUyLDEwICs1Miwx NCBAQCBzdHJ1Y3QgV2ViVVJMRXJyb3IgewogICAgIC8vIGVtYmVkZGVyIChzZWUgZm9yIGV4YW1w bGUgV2ViRnJhbWVDbGllbnQpLgogICAgIGludCByZWFzb247CiAKKyAgICAvLyBBIGZsYWcgc2hv d2luZyB3aGV0aGVyIHRoaXMgZXJyb3Igc2hvdWxkIGJlIHRyYXRlZCBhcyBhIGNhbmNlbGxhdGlv biwKKyAgICAvLyBlLmcuIHdlIGRvIG5vdCBzaG93IGNvbnNvbGUgZXJyb3JzIGZvciBjYW5jZWxs YXRpb25zLgorICAgIGJvb2wgaXNDYW5jZWxsYXRpb247CisKICAgICAvLyBUaGUgdXJsIHRoYXQg ZmFpbGVkIHRvIGxvYWQuCiAgICAgV2ViVVJMIHVucmVhY2hhYmxlVVJMOwogCi0gICAgV2ViVVJM RXJyb3IoKSA6IHJlYXNvbigwKSB7IH0KKyAgICBXZWJVUkxFcnJvcigpIDogcmVhc29uKDApLCBp c0NhbmNlbGxhdGlvbihmYWxzZSkgeyB9CiAKICNpZiBkZWZpbmVkKFdFQktJVF9JTVBMRU1FTlRB VElPTikKICAgICBXZWJVUkxFcnJvcihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxFcnJvci5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxFcnJvci5jcHAKaW5kZXggZWYzMmI1Yzc2 MmM3ZTBkZDY2MmFlNDE4MjA1Yzg2NjQyM2Q5NjEyMS4uODI2NDMzOWY0ZWFhZjUwN2I5OTc0ODcy ZmUyNjQxOTYwYzYxZTRmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVVJMRXJyb3IuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTEVy cm9yLmNwcApAQCAtNTIsNiArNTIsNyBAQCBXZWJVUkxFcnJvciYgV2ViVVJMRXJyb3I6Om9wZXJh dG9yPShjb25zdCBSZXNvdXJjZUVycm9yJiBlcnJvcikKICAgICAgICAgZG9tYWluID0gZXJyb3Iu ZG9tYWluKCk7CiAgICAgICAgIHJlYXNvbiA9IGVycm9yLmVycm9yQ29kZSgpOwogICAgICAgICB1 bnJlYWNoYWJsZVVSTCA9IEtVUkwoUGFyc2VkVVJMU3RyaW5nLCBlcnJvci5mYWlsaW5nVVJMKCkp OworICAgICAgICBpc0NhbmNlbGxhdGlvbiA9IGVycm9yLmlzQ2FuY2VsbGF0aW9uKCk7CiAgICAg fQogICAgIHJldHVybiAqdGhpczsKIH0KQEAgLTYxLDkgKzYyLDExIEBAIFdlYlVSTEVycm9yOjpv cGVyYXRvciBSZXNvdXJjZUVycm9yKCkgY29uc3QKICAgICBpZiAoIXJlYXNvbikKICAgICAgICAg cmV0dXJuIFJlc291cmNlRXJyb3IoKTsKICAgICBDU3RyaW5nIHNwZWMgPSB1bnJlYWNoYWJsZVVS TC5zcGVjKCk7Ci0gICAgcmV0dXJuIFJlc291cmNlRXJyb3IoZG9tYWluLCByZWFzb24sCisgICAg UmVzb3VyY2VFcnJvciByZXNvdXJjZUVycm9yID0gUmVzb3VyY2VFcnJvcihkb21haW4sIHJlYXNv biwKICAgICAgICAgICAgICAgICAgICAgICAgICBTdHJpbmc6OmZyb21VVEY4KHNwZWMuZGF0YSgp LCBzcGVjLmxlbmd0aCgpKSwKICAgICAgICAgICAgICAgICAgICAgICAgICBTdHJpbmcoKSk7Cisg ICAgcmVzb3VyY2VFcnJvci5zZXRJc0NhbmNlbGxhdGlvbihpc0NhbmNlbGxhdGlvbik7CisgICAg cmV0dXJuIHJlc291cmNlRXJyb3I7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 97858 2011-06-20 14:33:58 -0700 2011-06-24 01:26:02 -0700 Patch with fixes bug-62396-20110621013356.patch text/plain 2885 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogODkyNDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg Njk5YTc2ZTA4ZTg2OGIzYjc5NzA3YmYwMmJmNjY5MGVmMmY1NzY5ZC4uMmI5MzE3OTE3NjkzMTRl MjQ4NDU5MzcxYzI2OTQwYjUzZmE1ZWFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNi0yMCAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBbQ2hyb21pdW1dIFN1Y2Nlc3NmdWxseSBwcmVmZXRjaGVkIHBhZ2Ug c2hvd3MgdXAgYXMgYW4gZXJyb3IgaW4gY29uc29sZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzOTYKKworICAgICAgICAqIHB1YmxpYy9XZWJVUkxF cnJvci5oOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxFcnJvcjo6V2ViVVJMRXJyb3IpOgorICAg ICAgICAqIHNyYy9XZWJVUkxFcnJvci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTEVycm9y OjpvcGVyYXRvcj0pOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxFcnJvcjo6b3BlcmF0b3IgUmVz b3VyY2VFcnJvcik6CisKIDIwMTEtMDYtMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUm9sbGVkIERFUFMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJVUkxFcnJvci5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViVVJMRXJyb3IuaAppbmRleCBkZTg4ZTNlMDFjZTYxODE2MmFlODYyYjNhZjQ4NmM1Mzdk ZTNiMDlkLi4yZDEzZDYxZDRhMWZlZjJmNGU1ZjU5NDU3MGNkOTRmYjMzMTM3MTg5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxFcnJvci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTEVycm9yLmgKQEAgLTUyLDEwICs1Miwx NCBAQCBzdHJ1Y3QgV2ViVVJMRXJyb3IgewogICAgIC8vIGVtYmVkZGVyIChzZWUgZm9yIGV4YW1w bGUgV2ViRnJhbWVDbGllbnQpLgogICAgIGludCByZWFzb247CiAKKyAgICAvLyBBIGZsYWcgc2hv d2luZyB3aGV0aGVyIHRoaXMgZXJyb3Igc2hvdWxkIGJlIHRyZWF0ZWQgYXMgYSBjYW5jZWxsYXRp b24sCisgICAgLy8gZS5nLiB3ZSBkbyBub3Qgc2hvdyBjb25zb2xlIGVycm9ycyBmb3IgY2FuY2Vs bGF0aW9ucy4KKyAgICBib29sIGlzQ2FuY2VsbGF0aW9uOworCiAgICAgLy8gVGhlIHVybCB0aGF0 IGZhaWxlZCB0byBsb2FkLgogICAgIFdlYlVSTCB1bnJlYWNoYWJsZVVSTDsKIAotICAgIFdlYlVS TEVycm9yKCkgOiByZWFzb24oMCkgeyB9CisgICAgV2ViVVJMRXJyb3IoKSA6IHJlYXNvbigwKSwg aXNDYW5jZWxsYXRpb24oZmFsc2UpIHsgfQogCiAjaWYgZGVmaW5lZChXRUJLSVRfSU1QTEVNRU5U QVRJT04pCiAgICAgV2ViVVJMRXJyb3IoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMRXJyb3IuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMRXJyb3IuY3BwCmluZGV4IGVmMzJiNWM3 NjJjN2UwZGQ2NjJhZTQxODIwNWM4NjY0MjNkOTYxMjEuLmM0ZDk4NWY1OWMyYTg0ZDdlNmRhYjAx OWU3ZTk0OTQ5ZjViZmFjZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlVSTEVycm9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxF cnJvci5jcHAKQEAgLTUyLDYgKzUyLDcgQEAgV2ViVVJMRXJyb3ImIFdlYlVSTEVycm9yOjpvcGVy YXRvcj0oY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpCiAgICAgICAgIGRvbWFpbiA9IGVycm9y LmRvbWFpbigpOwogICAgICAgICByZWFzb24gPSBlcnJvci5lcnJvckNvZGUoKTsKICAgICAgICAg dW5yZWFjaGFibGVVUkwgPSBLVVJMKFBhcnNlZFVSTFN0cmluZywgZXJyb3IuZmFpbGluZ1VSTCgp KTsKKyAgICAgICAgaXNDYW5jZWxsYXRpb24gPSBlcnJvci5pc0NhbmNlbGxhdGlvbigpOwogICAg IH0KICAgICByZXR1cm4gKnRoaXM7CiB9CkBAIC02MSw5ICs2MiwxMSBAQCBXZWJVUkxFcnJvcjo6 b3BlcmF0b3IgUmVzb3VyY2VFcnJvcigpIGNvbnN0CiAgICAgaWYgKCFyZWFzb24pCiAgICAgICAg IHJldHVybiBSZXNvdXJjZUVycm9yKCk7CiAgICAgQ1N0cmluZyBzcGVjID0gdW5yZWFjaGFibGVV Ukwuc3BlYygpOwotICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGRvbWFpbiwgcmVhc29uLAotICAg ICAgICAgICAgICAgICAgICAgICAgIFN0cmluZzo6ZnJvbVVURjgoc3BlYy5kYXRhKCksIHNwZWMu bGVuZ3RoKCkpLAotICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZygpKTsKKyAgICBSZXNv dXJjZUVycm9yIHJlc291cmNlRXJyb3IgPSBSZXNvdXJjZUVycm9yKGRvbWFpbiwgcmVhc29uLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nOjpm cm9tVVRGOChzcGVjLmRhdGEoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHNwZWMubGVuZ3RoKCkpLCBTdHJpbmcoKSk7CisgICAgcmVzb3VyY2VFcnJv ci5zZXRJc0NhbmNlbGxhdGlvbihpc0NhbmNlbGxhdGlvbik7CisgICAgcmV0dXJuIHJlc291cmNl RXJyb3I7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=