62394 2011-06-09 13:05:05 -0700 [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without plugin support 2011-06-13 15:23:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandro leandro paroga webkit.review.bot oldest_to_newest 418205 0 leandro 2011-06-09 13:05:05 -0700 [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without plugin support 418222 1 96625 leandro 2011-06-09 13:22:48 -0700 Created attachment 96625 Patch 418237 2 96625 paroga 2011-06-09 13:36:49 -0700 Comment on attachment 96625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96625&action=review > Source/WebCore/CMakeLists.txt:-1507 > - LIST(APPEND WebCore_SOURCES > - plugins/PluginPackageNone.cpp > - plugins/PluginViewNone.cpp > - ) IMO you also need to add PluginPackageNone and PluginViewNone in the ELSE() at CMakeListsWinCE.txt. 418243 3 96631 leandro 2011-06-09 13:44:28 -0700 Created attachment 96631 Patch 419923 4 96631 eric 2011-06-13 15:06:45 -0700 Comment on attachment 96631 Patch OK. rs=me. 419957 5 96631 webkit.review.bot 2011-06-13 15:23:34 -0700 Comment on attachment 96631 Patch Clearing flags on attachment: 96631 Committed r88711: <http://trac.webkit.org/changeset/88711> 419958 6 webkit.review.bot 2011-06-13 15:23:38 -0700 All reviewed patches have been landed. Closing bug. 96625 2011-06-09 13:22:48 -0700 2011-06-09 13:44:22 -0700 Patch bug-62394-20110609172246.patch text/plain 2505 leandro SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NDc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMDkgIExlYW5kcm8g UGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0NNYWtlXSBBbGxvdyBidWlsZGluZyB3aXRoIEVO QUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIG9uIHBsYXRmb3JtcworICAgICAgICB3aXRob3V0IHBs dWdpbiBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MjM5NAorCisgICAgICAgIE5vIGJlaGF2aW91ciBjaGFuZ2VzLCBzbyBubyBuZXcgdGVz dHMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlIHJlZmVyZW5jZXMgdG8gUGx1 Z2lue1BhY2thZ2UsVmlld30uY3BwIGFuZAorICAgICAgICBQbHVnaW57UGFja2FnZSxWaWV3fU5v bmUuY3BwIGFuZCBtb3ZlIHRoZW0gdG8gQ01ha2VMaXN0V2luQ0UgYW5kCisgICAgICAgIENNYWtl TGlzdHNFZmwsIHJlc3BlY3RpdmVseS4KKyAgICAgICAgKiBDTWFrZUxpc3RzRWZsLnR4dDoKKyAg ICAgICAgKiBDTWFrZUxpc3RzV2luQ0UudHh0OgorCiAyMDExLTA2LTA5ICBKdWxpZW4gQ2hhZmZy YWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDg4NDczKQorKysgU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTE0OTYsMTUgKzE0 OTYsOCBAQCBJRiAoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgTElTVChBUFBFTkQg V2ViQ29yZV9TT1VSQ0VTCiAgICAgICAgIHBsdWdpbnMvUGx1Z2luRGVidWcuY3BwCiAgICAgICAg IHBsdWdpbnMvUGx1Z2luU3RyZWFtLmNwcAotICAgICAgICBwbHVnaW5zL1BsdWdpblBhY2thZ2Uu Y3BwCi0gICAgICAgIHBsdWdpbnMvUGx1Z2luVmlldy5jcHAKICAgICAgICAgcGx1Z2lucy9ucGFw aS5jcHAKICAgICApCi1FTFNFICgpCi0gICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0g ICAgICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCi0gICAgICAgIHBsdWdpbnMvUGx1 Z2luVmlld05vbmUuY3BwCi0gICAgKQogRU5ESUYgKCkKIAogSUYgKEVOQUJMRV9OT1RJRklDQVRJ T05TKQpJbmRleDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQJKHJldmlzaW9uIDg4NDczKQorKysg U291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTc0LDYg Kzc0LDggQEAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgIHBsYXRmb3JtL3Bvc2l4L0Zp bGVTeXN0ZW1QT1NJWC5jcHAKICAgcGxhdGZvcm0vdGV4dC9lZmwvVGV4dEJyZWFrSXRlcmF0b3JJ bnRlcm5hbElDVUVmbC5jcHAKICAgcGx1Z2lucy9QbHVnaW5EYXRhTm9uZS5jcHAKKyAgcGx1Z2lu cy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKKyAgcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKICkK IAogTElTVChBUFBFTkQgV2ViQ29yZV9VU0VSX0FHRU5UX1NUWUxFX1NIRUVUUwpJbmRleDogU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0c1dpbkNFLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DTWFrZUxpc3RzV2luQ0UudHh0CShyZXZpc2lvbiA4ODQ3MykKKysrIFNvdXJjZS9XZWJD b3JlL0NNYWtlTGlzdHNXaW5DRS50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEzNSw2ICsxMzUsOCBA QCBJRiAoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgICAgIHBsdWdpbnMvd2luL1Bs dWdpbk1lc3NhZ2VUaHJvdHRsZXJXaW4uY3BwCiAgICAgICAgIHBsdWdpbnMvd2luL1BsdWdpblBh Y2thZ2VXaW4uY3BwCiAgICAgICAgIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCisgICAg ICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKKyAgICAgICAgcGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAogICAgICkKIEVMU0UgKCkKICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMK 96631 2011-06-09 13:44:28 -0700 2011-06-13 15:23:34 -0700 Patch bug-62394-20110609174426.patch text/plain 2633 leandro SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NDc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMDkgIExlYW5kcm8g UGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0NNYWtlXSBBbGxvdyBidWlsZGluZyB3aXRoIEVO QUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIG9uIHBsYXRmb3JtcworICAgICAgICB3aXRob3V0IHBs dWdpbiBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MjM5NAorCisgICAgICAgIE5vIGJlaGF2aW91ciBjaGFuZ2VzLCBzbyBubyBuZXcgdGVz dHMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlIHJlZmVyZW5jZXMgdG8gUGx1 Z2lue1BhY2thZ2UsVmlld30uY3BwIGFuZAorICAgICAgICBQbHVnaW57UGFja2FnZSxWaWV3fU5v bmUuY3BwIGFuZCBtb3ZlIHRoZW0gdG8gQ01ha2VMaXN0V2luQ0UgYW5kCisgICAgICAgIENNYWtl TGlzdHNFZmwsIHJlc3BlY3RpdmVseS4KKyAgICAgICAgKiBDTWFrZUxpc3RzRWZsLnR4dDoKKyAg ICAgICAgKiBDTWFrZUxpc3RzV2luQ0UudHh0OgorCiAyMDExLTA2LTA5ICBKdWxpZW4gQ2hhZmZy YWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDg4NDczKQorKysgU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTE0OTYsMTUgKzE0 OTYsOCBAQCBJRiAoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgTElTVChBUFBFTkQg V2ViQ29yZV9TT1VSQ0VTCiAgICAgICAgIHBsdWdpbnMvUGx1Z2luRGVidWcuY3BwCiAgICAgICAg IHBsdWdpbnMvUGx1Z2luU3RyZWFtLmNwcAotICAgICAgICBwbHVnaW5zL1BsdWdpblBhY2thZ2Uu Y3BwCi0gICAgICAgIHBsdWdpbnMvUGx1Z2luVmlldy5jcHAKICAgICAgICAgcGx1Z2lucy9ucGFw aS5jcHAKICAgICApCi1FTFNFICgpCi0gICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0g ICAgICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCi0gICAgICAgIHBsdWdpbnMvUGx1 Z2luVmlld05vbmUuY3BwCi0gICAgKQogRU5ESUYgKCkKIAogSUYgKEVOQUJMRV9OT1RJRklDQVRJ T05TKQpJbmRleDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQJKHJldmlzaW9uIDg4NDczKQorKysg U291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTc0LDYg Kzc0LDggQEAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgIHBsYXRmb3JtL3Bvc2l4L0Zp bGVTeXN0ZW1QT1NJWC5jcHAKICAgcGxhdGZvcm0vdGV4dC9lZmwvVGV4dEJyZWFrSXRlcmF0b3JJ bnRlcm5hbElDVUVmbC5jcHAKICAgcGx1Z2lucy9QbHVnaW5EYXRhTm9uZS5jcHAKKyAgcGx1Z2lu cy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKKyAgcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKICkK IAogTElTVChBUFBFTkQgV2ViQ29yZV9VU0VSX0FHRU5UX1NUWUxFX1NIRUVUUwpJbmRleDogU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0c1dpbkNFLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DTWFrZUxpc3RzV2luQ0UudHh0CShyZXZpc2lvbiA4ODQ3MykKKysrIFNvdXJjZS9XZWJD b3JlL0NNYWtlTGlzdHNXaW5DRS50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEzNSw5ICsxMzUsMTMg QEAgSUYgKEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAgICAgICBwbHVnaW5zL3dpbi9Q bHVnaW5NZXNzYWdlVGhyb3R0bGVyV2luLmNwcAogICAgICAgICBwbHVnaW5zL3dpbi9QbHVnaW5Q YWNrYWdlV2luLmNwcAogICAgICAgICBwbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAorICAg ICAgICBwbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCisgICAgICAgIHBsdWdpbnMvUGx1Z2luVmll dy5jcHAKICAgICApCiBFTFNFICgpCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAg ICAgICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKKyAgICAgICAgcGx1Z2lucy9QbHVnaW5Q YWNrYWdlTm9uZS5jcHAKKyAgICAgICAgcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKICAgICAp CiBFTkRJRiAoKQo=