62383 2011-06-09 10:22:48 -0700 [Chromium] Overlay scrollbars leave glitches on web content 2011-06-16 14:18:54 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 0 sail webkit-unassigned eric jamesr mihaip thakis webkit.review.bot oldest_to_newest 418087 0 sail 2011-06-09 10:22:48 -0700 Scrolling a page with overlay scrollbars leaves trailing artifacts on web content. This needs to be fixed before overlay scrollbars are enabled. 420885 1 97201 sail 2011-06-14 17:30:07 -0700 Created attachment 97201 Patch 420886 2 sail 2011-06-14 17:30:57 -0700 This doesn't fix the root cause, any suggestions appreciated. 420929 3 97213 sail 2011-06-14 18:29:52 -0700 Created attachment 97213 Patch 420931 4 97213 thakis 2011-06-14 18:35:41 -0700 Comment on attachment 97213 Patch don't set r? on work-in-progress patches 420934 5 97213 jamesr 2011-06-14 18:38:36 -0700 Comment on attachment 97213 Patch How does the PLATFORM(MAC) port handle this in the non-composited case? Whatever the answer is here it does not belong in ScrollView.cpp 420969 6 sail 2011-06-14 20:02:30 -0700 (In reply to comment #5) > (From update of attachment 97213 [details]) > How does the PLATFORM(MAC) port handle this in the non-composited case? I think that on PLATFORM(MAC) this is handled by the native host scroll view. Our RenderWidget just blindly copies the scrollrect even for overlay scrollbars. > Whatever the answer is here it does not belong in ScrollView.cpp What do you think of fixing this in RenderWidget. This would be a little more complicated because I'd have to pipe more information about scrollbars to RenderWidget. 420974 7 thakis 2011-06-14 20:06:54 -0700 sail: What was the file where you removed the ?: earlier today? Did that help? 420984 8 sail 2011-06-14 20:27:05 -0700 (In reply to comment #7) > sail: What was the file where you removed the ?: earlier today? Did that help? That was in ScrollView.cpp ScrollView::rectToCopyOnScroll(). Changing it didn't help. 420990 9 jamesr 2011-06-14 20:44:17 -0700 The mac port doesn't use platform widgets for scrolling in WebKit2 420993 10 sail 2011-06-14 20:47:46 -0700 (In reply to comment #9) > The mac port doesn't use platform widgets for scrolling in WebKit2 Hm... how can I tell if I'm running Safar in composited or non-composited mode? Maybe they have this bug too. 421608 11 97369 sail 2011-06-15 15:13:25 -0700 Created attachment 97369 Patch 421610 12 sail 2011-06-15 15:14:39 -0700 (In reply to comment #9) > The mac port doesn't use platform widgets for scrolling in WebKit2 K, I think I got it. WebChromeClient::scroll() intersects the scroll rect with the clip rect. This excludes the scrollbars when overlay scrollbars are enabled. I'm running try bots now. 421650 13 sail 2011-06-15 17:25:49 -0700 Try bot results look good. http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/32264 http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/32445 http://build.chromium.org/p/tryserver.chromium/builders/win/builds/37228 421661 14 jamesr 2011-06-15 17:41:50 -0700 What about the layout tests trybots? (mac_layout, win_layout, linux_layout and the same with _rel for release). 421665 15 sail 2011-06-15 17:45:23 -0700 (In reply to comment #14) > What about the layout tests trybots? (mac_layout, win_layout, linux_layout and the same with _rel for release). Damn, forgot. Layout try bots pending. 421725 16 sail 2011-06-15 20:19:33 -0700 Hm.. a couple of webkit_gpu_tests failed. Not sure if it's my fault. I'm sending out a new layout try bot test with an empty change to check. http://build.chromium.org/p/tryserver.chromium/builders/mac_layout/builds/667 http://build.chromium.org/p/tryserver.chromium/builders/mac_layout_rel/builds/205 http://build.chromium.org/p/tryserver.chromium/builders/win_layout/builds/948 http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/289 http://build.chromium.org/p/tryserver.chromium/builders/linux_layout/builds/794 http://build.chromium.org/p/tryserver.chromium/builders/linux_layout_rel/builds/270 421767 17 sail 2011-06-15 22:08:22 -0700 Yay, an empty change has the same failures: http://build.chromium.org/p/tryserver.chromium/builders/mac_layout_rel/builds/207 422160 18 97369 mihaip 2011-06-16 13:24:09 -0700 Comment on attachment 97369 Patch Rubber-stamping since James is out. 422216 19 97369 webkit.review.bot 2011-06-16 14:18:49 -0700 Comment on attachment 97369 Patch Clearing flags on attachment: 97369 Committed r89065: <http://trac.webkit.org/changeset/89065> 422217 20 webkit.review.bot 2011-06-16 14:18:54 -0700 All reviewed patches have been landed. Closing bug. 97201 2011-06-14 17:30:07 -0700 2011-06-14 18:29:48 -0700 Patch bug-62383-20110614173006.patch text/plain 3629 sail U3VidmVyc2lvbiBSZXZpc2lvbjogODg2NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MzJmM2E0N2MzMWFmN2Q1 MDAyMGE4YjM1NTcwMDMxNmY2Mjk1NmY2Li42Y2FkZjY2NGFjMjc5YTgzYjYzZmU1ZmE5YTMwMzVk YjAxNjRkMjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTQgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gT3ZlcmxheSBzY3JvbGxiYXJzIGxl YXZlIGdsaXRjaGVzIG9uIHdlYiBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MjM4MworCisgICAgICAgIEZpeCBnbGl0Y2hlcyB3aGVuIHNj cm9sbGluZyB3aXRoIG92ZXJsYXkgc2Nyb2xsYmFycy4KKworICAgICAgICAqIHBsYXRmb3JtL1Nj cm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6c2Nyb2xsQ29udGVu dHMpOkludmFsaWRhdGUgc2Nyb2xsYmFyIHJlZ2lvbiB3aGVuIHNjcm9sbGluZyB3aXRoIG92ZXJs YXkgc2Nyb2xsYmFycy4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVy bGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW06RW5hYmxlIG92ZXJsYXkgc2Nyb2xsYmFycy4KKyAg ICAgICAgKHByZWZlcnJlZFNjcm9sbGVyU3R5bGUpOgorCiAyMDExLTA2LTEzICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDRmMzY2ZTU2NjA3NDRm ODQ3Nzg2MDg2NGUzZDQxNWExYjdmMDg3NTYuLjNhZjFkNDA0ZWZhZGQyN2U0NjZhZWRhNmEzYWEx NDQyOTM1MzE3ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC02 MjgsNiArNjI4LDIzIEBAIHZvaWQgU2Nyb2xsVmlldzo6c2Nyb2xsQ29udGVudHMoY29uc3QgSW50 U2l6ZSYgc2Nyb2xsRGVsdGEpCiAgICAgLy8gSW52YWxpZGF0ZSB0aGUgd2luZG93IChub3QgdGhl IGJhY2tpbmcgc3RvcmUpLgogICAgIGhvc3RXaW5kb3coKS0+aW52YWxpZGF0ZVdpbmRvdyh1cGRh dGVSZWN0LCBmYWxzZSAvKmltbWVkaWF0ZSovKTsKIAorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQor ICAgIC8vIEZJWE1FOiB0aGUgY2hyb21pdW0gcmVuZGVyIHdpZGdldCBpbmNvcnJlY3RseSBjb3Bp ZXMgdGhlIG92ZXJsYXkgc2Nyb2xsIGJhcnMgd2hlbiBzY3JvbGxpbmcuCisgICAgLy8gVG8gcHJl dmVudCB0aGlzIHdlIGhhdmUgdG8gbWFudWFsbHkgaW52YWxpZGF0ZSB0aGUgcmVnaW9uIHdpdGgg dGhlIHNjcm9sbGJhcnMuCisgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyMzgzCisgICAgaWYgKGhhc092ZXJsYXlTY3JvbGxiYXJzKCkpIHsKKyAgICAgIGlm IChzY3JvbGxEZWx0YS5oZWlnaHQoKSA+IDAgJiYgaG9yaXpvbnRhbFNjcm9sbGJhcigpKSB7Cisg ICAgICAgIEludFJlY3Qgc2Nyb2xsZXJSZWN0ID0gY29udmVydFRvQ29udGFpbmluZ1dpbmRvdyhJ bnRSZWN0KDAsIHZpc2libGVIZWlnaHQoKSAtIGhvcml6b250YWxTY3JvbGxiYXIoKS0+aGVpZ2h0 KCksIGhvcml6b250YWxTY3JvbGxiYXIoKS0+d2lkdGgoKSwgaG9yaXpvbnRhbFNjcm9sbGJhcigp LT5oZWlnaHQoKSkpOworICAgICAgICBob3N0V2luZG93KCktPmludmFsaWRhdGVDb250ZW50c0Fu ZFdpbmRvdyhzY3JvbGxlclJlY3QsIGZhbHNlIC8qaW1tZWRpYXRlKi8pOworICAgICAgfQorCisg ICAgICBpZiAoc2Nyb2xsRGVsdGEud2lkdGgoKSA+IDAgJiYgdmVydGljYWxTY3JvbGxiYXIoKSkg eworICAgICAgICBJbnRSZWN0IHNjcm9sbGVyUmVjdCA9IGNvbnZlcnRUb0NvbnRhaW5pbmdXaW5k b3coSW50UmVjdCh2aXNpYmxlV2lkdGgoKSAtIHZlcnRpY2FsU2Nyb2xsYmFyKCktPndpZHRoKCks IDAsIHZlcnRpY2FsU2Nyb2xsYmFyKCktPndpZHRoKCksIHZlcnRpY2FsU2Nyb2xsYmFyKCktPmhl aWdodCgpKSk7CisgICAgICAgIGhvc3RXaW5kb3coKS0+aW52YWxpZGF0ZUNvbnRlbnRzQW5kV2lu ZG93KHNjcm9sbGVyUmVjdCwgZmFsc2UgLyppbW1lZGlhdGUqLyk7CisgICAgICB9CisgICAgfQor I2VuZGlmCisKICAgICBpZiAobV9kcmF3UGFuU2Nyb2xsSWNvbikgewogICAgICAgICAvLyBGSVhN RTogdGhlIHBhbiBpY29uIGlzIGJyb2tlbiB3aGVuIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlz IG9uLCBzaW5jZSBpdCB3aWxsIGRyYXcgdW5kZXIgdGhlIGNvbXBvc2l0aW5nIGxheWVycy4KICAg ICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3ODM3CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVy bGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0KaW5kZXggODE2YWIz OWZiOGEwYjg4YWZmZDBkZjUwNWFhNTRjODllMWNkYjM5Ni4uODg5YmFiZGFkOTcxNGNkMjllZTQ2 MGY2NGJlYzZiZWVkYzI3Y2M3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFjLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXND aHJvbWl1bU1hYy5tbQpAQCAtMTI0LDExICsxMjQsNiBAQCBzdGF0aWMgTlNDb250cm9sU2l6ZSBz Y3JvbGxiYXJDb250cm9sU2l6ZVRvTlNDb250cm9sU2l6ZShpbnQgY29udHJvbFNpemUpCiAKIHN0 YXRpYyBOU1Njcm9sbGVyU3R5bGUgcHJlZmVycmVkU2Nyb2xsZXJTdHlsZSgpCiB7Ci0gICAgLy8g VE9ETyhzYWlsKTogRGlzYWJsZSBvdmVybGF5IHNjcm9sbGJhcnMgZm9yIG5vdyB1bnRpbCB0aGUg Zm9sbG93aW5nIGlzc3VlcyBhcmUgZml4ZWQ6Ci0gICAgLy8gIzE6IEludmFsaWRhdGlvbiBpc3N1 ZXMgY2F1c2VzIHRoZSBzY3JvbGxiYXIgdG8gbGVhdmUgdHJhaWxpbmcgYXJ0aWZhY3RzLgotICAg IC8vICMyOiBGaW5kIHRpY2sgbWFya3MgbmVlZCB0byBiZSBkcmF3biBvbiB0aGUgc2Nyb2xsYmFy IHRyYWNrLgotICAgIHJldHVybiBOU1Njcm9sbGVyU3R5bGVMZWdhY3k7Ci0KICAgICBpZiAoW05T U2Nyb2xsZXIgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihwcmVmZXJyZWRTY3JvbGxlclN0 eWxlKV0pCiAgICAgICAgIHJldHVybiBbTlNTY3JvbGxlciBwcmVmZXJyZWRTY3JvbGxlclN0eWxl XTsKICAgICByZXR1cm4gTlNTY3JvbGxlclN0eWxlTGVnYWN5Owo= 97213 2011-06-14 18:29:52 -0700 2011-06-15 15:13:21 -0700 Patch bug-62383-20110614182951.patch text/plain 5713 sail U3VidmVyc2lvbiBSZXZpc2lvbjogODg2NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MzJmM2E0N2MzMWFmN2Q1 MDAyMGE4YjM1NTcwMDMxNmY2Mjk1NmY2Li42Y2FkZjY2NGFjMjc5YTgzYjYzZmU1ZmE5YTMwMzVk YjAxNjRkMjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTQgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gT3ZlcmxheSBzY3JvbGxiYXJzIGxl YXZlIGdsaXRjaGVzIG9uIHdlYiBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MjM4MworCisgICAgICAgIEZpeCBnbGl0Y2hlcyB3aGVuIHNj cm9sbGluZyB3aXRoIG92ZXJsYXkgc2Nyb2xsYmFycy4KKworICAgICAgICAqIHBsYXRmb3JtL1Nj cm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6c2Nyb2xsQ29udGVu dHMpOkludmFsaWRhdGUgc2Nyb2xsYmFyIHJlZ2lvbiB3aGVuIHNjcm9sbGluZyB3aXRoIG92ZXJs YXkgc2Nyb2xsYmFycy4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVy bGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW06RW5hYmxlIG92ZXJsYXkgc2Nyb2xsYmFycy4KKyAg ICAgICAgKHByZWZlcnJlZFNjcm9sbGVyU3R5bGUpOgorCiAyMDExLTA2LTEzICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDRmMzY2ZTU2NjA3NDRm ODQ3Nzg2MDg2NGUzZDQxNWExYjdmMDg3NTYuLjc1OGQ0M2NlNTE0OTkxYTgxYTkwZjhiZWQwYWQx MDMwMDJkZWJlMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC02 MjgsNiArNjI4LDIzIEBAIHZvaWQgU2Nyb2xsVmlldzo6c2Nyb2xsQ29udGVudHMoY29uc3QgSW50 U2l6ZSYgc2Nyb2xsRGVsdGEpCiAgICAgLy8gSW52YWxpZGF0ZSB0aGUgd2luZG93IChub3QgdGhl IGJhY2tpbmcgc3RvcmUpLgogICAgIGhvc3RXaW5kb3coKS0+aW52YWxpZGF0ZVdpbmRvdyh1cGRh dGVSZWN0LCBmYWxzZSAvKmltbWVkaWF0ZSovKTsKIAorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQor ICAgIC8vIEZJWE1FOiB0aGUgY2hyb21pdW0gcmVuZGVyIHdpZGdldCBpbmNvcnJlY3RseSBjb3Bp ZXMgdGhlIG92ZXJsYXkgc2Nyb2xsIGJhcnMgd2hlbiBzY3JvbGxpbmcuCisgICAgLy8gVG8gcHJl dmVudCB0aGlzIHdlIGhhdmUgdG8gbWFudWFsbHkgaW52YWxpZGF0ZSB0aGUgcmVnaW9uIHdpdGgg dGhlIHNjcm9sbGJhcnMuCisgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyMzgzCisgICAgaWYgKGhhc092ZXJsYXlTY3JvbGxiYXJzKCkpIHsKKyAgICAgICAg aWYgKHNjcm9sbERlbHRhLmhlaWdodCgpID4gMCAmJiBob3Jpem9udGFsU2Nyb2xsYmFyKCkpIHsK KyAgICAgICAgICAgIEludFJlY3Qgc2Nyb2xsZXJSZWN0ID0gY29udmVydFRvQ29udGFpbmluZ1dp bmRvdyhJbnRSZWN0KDAsIHZpc2libGVIZWlnaHQoKSAtIGhvcml6b250YWxTY3JvbGxiYXIoKS0+ aGVpZ2h0KCksIGhvcml6b250YWxTY3JvbGxiYXIoKS0+d2lkdGgoKSwgaG9yaXpvbnRhbFNjcm9s bGJhcigpLT5oZWlnaHQoKSkpOworICAgICAgICAgICAgaG9zdFdpbmRvdygpLT5pbnZhbGlkYXRl Q29udGVudHNBbmRXaW5kb3coc2Nyb2xsZXJSZWN0LCBmYWxzZSAvKmltbWVkaWF0ZSovKTsKKyAg ICAgICAgfQorCisgICAgICAgIGlmIChzY3JvbGxEZWx0YS53aWR0aCgpID4gMCAmJiB2ZXJ0aWNh bFNjcm9sbGJhcigpKSB7CisgICAgICAgICAgICBJbnRSZWN0IHNjcm9sbGVyUmVjdCA9IGNvbnZl cnRUb0NvbnRhaW5pbmdXaW5kb3coSW50UmVjdCh2aXNpYmxlV2lkdGgoKSAtIHZlcnRpY2FsU2Ny b2xsYmFyKCktPndpZHRoKCksIDAsIHZlcnRpY2FsU2Nyb2xsYmFyKCktPndpZHRoKCksIHZlcnRp Y2FsU2Nyb2xsYmFyKCktPmhlaWdodCgpKSk7CisgICAgICAgICAgICBob3N0V2luZG93KCktPmlu dmFsaWRhdGVDb250ZW50c0FuZFdpbmRvdyhzY3JvbGxlclJlY3QsIGZhbHNlIC8qaW1tZWRpYXRl Ki8pOworICAgICAgICB9CisgICAgfQorI2VuZGlmCisKICAgICBpZiAobV9kcmF3UGFuU2Nyb2xs SWNvbikgewogICAgICAgICAvLyBGSVhNRTogdGhlIHBhbiBpY29uIGlzIGJyb2tlbiB3aGVuIGFj Y2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIG9uLCBzaW5jZSBpdCB3aWxsIGRyYXcgdW5kZXIgdGhl IGNvbXBvc2l0aW5nIGxheWVycy4KICAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ3ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hy b21pdW1NYWMubW0KaW5kZXggODE2YWIzOWZiOGEwYjg4YWZmZDBkZjUwNWFhNTRjODllMWNkYjM5 Ni4uODg5YmFiZGFkOTcxNGNkMjllZTQ2MGY2NGJlYzZiZWVkYzI3Y2M3MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0aWxpdGll c0Nocm9taXVtTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Nj cm9sbGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5tbQpAQCAtMTI0LDExICsxMjQsNiBA QCBzdGF0aWMgTlNDb250cm9sU2l6ZSBzY3JvbGxiYXJDb250cm9sU2l6ZVRvTlNDb250cm9sU2l6 ZShpbnQgY29udHJvbFNpemUpCiAKIHN0YXRpYyBOU1Njcm9sbGVyU3R5bGUgcHJlZmVycmVkU2Ny b2xsZXJTdHlsZSgpCiB7Ci0gICAgLy8gVE9ETyhzYWlsKTogRGlzYWJsZSBvdmVybGF5IHNjcm9s bGJhcnMgZm9yIG5vdyB1bnRpbCB0aGUgZm9sbG93aW5nIGlzc3VlcyBhcmUgZml4ZWQ6Ci0gICAg Ly8gIzE6IEludmFsaWRhdGlvbiBpc3N1ZXMgY2F1c2VzIHRoZSBzY3JvbGxiYXIgdG8gbGVhdmUg dHJhaWxpbmcgYXJ0aWZhY3RzLgotICAgIC8vICMyOiBGaW5kIHRpY2sgbWFya3MgbmVlZCB0byBi ZSBkcmF3biBvbiB0aGUgc2Nyb2xsYmFyIHRyYWNrLgotICAgIHJldHVybiBOU1Njcm9sbGVyU3R5 bGVMZWdhY3k7Ci0KICAgICBpZiAoW05TU2Nyb2xsZXIgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxl Y3RvcihwcmVmZXJyZWRTY3JvbGxlclN0eWxlKV0pCiAgICAgICAgIHJldHVybiBbTlNTY3JvbGxl ciBwcmVmZXJyZWRTY3JvbGxlclN0eWxlXTsKICAgICByZXR1cm4gTlNTY3JvbGxlclN0eWxlTGVn YWN5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xs YmFyVGhlbWVDaHJvbWl1bU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0KaW5kZXggMGZkODNkYjYzNmRlZWExNGFhZWI1 MDcxNzJhODQwMzlmOTZmOTA0OS4uMjc3Njg3ZmFjYTg4YzBiZjg2Y2YyNmE2NDQwMTQ5OWI4Mjli ZGE3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xs YmFyVGhlbWVDaHJvbWl1bU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCkBAIC05MSw3ICs5MSw3IEBAIHN0YXRp YyBTY3JvbGxiYXJQYWludGVyTWFwKiBzY3JvbGxiYXJNYXAoKQogKyAodm9pZClhcHBlYXJhbmNl UHJlZnNDaGFuZ2VkOihOU05vdGlmaWNhdGlvbiopdW51c2VkTm90aWZpY2F0aW9uCiB7CiAgICAg VU5VU0VEX1BBUkFNKHVudXNlZE5vdGlmaWNhdGlvbik7Ci0KK2ZwcmludGYoc3RkZXJyLCAiKioq KioqKioqKioqKioqKioqKioqKiAlc1xuIiwgX19mdW5jX18pOwogICAgIHN0YXRpY19jYXN0PFNj cm9sbGJhclRoZW1lQ2hyb21pdW1NYWMqPihTY3JvbGxiYXJUaGVtZTo6bmF0aXZlVGhlbWUoKSkt PnByZWZlcmVuY2VzQ2hhbmdlZCgpOwogICAgIGlmIChzY3JvbGxiYXJNYXAoKS0+aXNFbXB0eSgp KQogICAgICAgICByZXR1cm47CkBAIC0xMDUsMTIgKzEwNSwxMyBAQCBzdGF0aWMgU2Nyb2xsYmFy UGFpbnRlck1hcCogc2Nyb2xsYmFyTWFwKCkKICsgKHZvaWQpYmVoYXZpb3JQcmVmc0NoYW5nZWQ6 KE5TTm90aWZpY2F0aW9uKil1bnVzZWROb3RpZmljYXRpb24KIHsKICAgICBVTlVTRURfUEFSQU0o dW51c2VkTm90aWZpY2F0aW9uKTsKLQorZnByaW50ZihzdGRlcnIsICIqKioqKioqKioqKioqKioq KioqKioqICVzXG4iLCBfX2Z1bmNfXyk7CiAgICAgc3RhdGljX2Nhc3Q8U2Nyb2xsYmFyVGhlbWVD aHJvbWl1bU1hYyo+KFNjcm9sbGJhclRoZW1lOjpuYXRpdmVUaGVtZSgpKS0+cHJlZmVyZW5jZXND aGFuZ2VkKCk7CiB9CiAKICsgKHZvaWQpcmVnaXN0ZXJBc09ic2VydmVyCiB7CitmcHJpbnRmKHN0 ZGVyciwgIioqKioqKioqKioqKioqKioqKioqKiogJXNcbiIsIF9fZnVuY19fKTsKICAgICBbW05T RGlzdHJpYnV0ZWROb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6 c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoYXBwZWFyYW5jZVByZWZzQ2hhbmdlZDopIG5hbWU6QCJB cHBsZUFxdWFTY3JvbGxCYXJWYXJpYW50Q2hhbmdlZCIgb2JqZWN0Om5pbCBzdXNwZW5zaW9uQmVo YXZpb3I6TlNOb3RpZmljYXRpb25TdXNwZW5zaW9uQmVoYXZpb3JEZWxpdmVySW1tZWRpYXRlbHld OwogICAgIFtbTlNEaXN0cmlidXRlZE5vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBh ZGRPYnNlcnZlcjpzZWxmIHNlbGVjdG9yOkBzZWxlY3RvcihiZWhhdmlvclByZWZzQ2hhbmdlZDop IG5hbWU6QCJBcHBsZU5vUmVkaXNwbGF5QXBwZWFyYW5jZVByZWZlcmVuY2VDaGFuZ2VkIiBvYmpl Y3Q6bmlsIHN1c3BlbnNpb25CZWhhdmlvcjpOU05vdGlmaWNhdGlvblN1c3BlbnNpb25CZWhhdmlv ckNvYWxlc2NlXTsKIH0KQEAgLTE4Myw2ICsxODQsNyBAQCBXS1Njcm9sbGJhclBhaW50ZXJSZWYg U2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYzo6cGFpbnRlckZvclNjcm9sbGJhcihTY3JvbGxiYXIq CiBTY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjOjpTY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjKCkK IHsKICAgICBzdGF0aWMgYm9vbCBpbml0aWFsaXplZDsKK2ZwcmludGYoc3RkZXJyLCAiKioqKioq KioqKioqKioqKioqKioqKiAgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYzo6U2Nyb2xsYmFyVGhl bWVDaHJvbWl1bU1hY1xuIik7CiAgICAgaWYgKCFpbml0aWFsaXplZCkgewogICAgICAgICBpbml0 aWFsaXplZCA9IHRydWU7CiAgICAgICAgIFtTY3JvbGxiYXJQcmVmc09ic2VydmVyIHJlZ2lzdGVy QXNPYnNlcnZlcl07Cg== 97369 2011-06-15 15:13:25 -0700 2011-06-16 14:18:49 -0700 Patch bug-62383-20110615151323.patch text/plain 3377 sail U3VidmVyc2lvbiBSZXZpc2lvbjogODg2NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MzJmM2E0N2MzMWFmN2Q1 MDAyMGE4YjM1NTcwMDMxNmY2Mjk1NmY2Li5hZTYzOWEzY2NjZWMwMGQ3MGNjMTVkZDViNzQ4ZTNi ZDZkZDJmMjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMTUgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gT3ZlcmxheSBzY3JvbGxiYXJzIGxl YXZlIGdsaXRjaGVzIG9uIHdlYiBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MjM4MworCisgICAgICAgIEVuYWJsZSBvdmVybGF5IHNjcm9s bGJhcnMgb24gQ2hyb21pdW0gTWFjLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Ny b2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFjLm1tOgorICAgICAgICAocHJlZmVycmVk U2Nyb2xsZXJTdHlsZSk6CisKIDIwMTEtMDYtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXND aHJvbWl1bU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJh ck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5tbQppbmRleCA4MTZhYjM5ZmI4YTBiODhhZmZk MGRmNTA1YWE1NGM4OWUxY2RiMzk2Li44ODliYWJkYWQ5NzE0Y2QyOWVlNDYwZjY0YmVjNmJlZWRj MjdjYzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3Jv bGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFjLm1t CkBAIC0xMjQsMTEgKzEyNCw2IEBAIHN0YXRpYyBOU0NvbnRyb2xTaXplIHNjcm9sbGJhckNvbnRy b2xTaXplVG9OU0NvbnRyb2xTaXplKGludCBjb250cm9sU2l6ZSkKIAogc3RhdGljIE5TU2Nyb2xs ZXJTdHlsZSBwcmVmZXJyZWRTY3JvbGxlclN0eWxlKCkKIHsKLSAgICAvLyBUT0RPKHNhaWwpOiBE aXNhYmxlIG92ZXJsYXkgc2Nyb2xsYmFycyBmb3Igbm93IHVudGlsIHRoZSBmb2xsb3dpbmcgaXNz dWVzIGFyZSBmaXhlZDoKLSAgICAvLyAjMTogSW52YWxpZGF0aW9uIGlzc3VlcyBjYXVzZXMgdGhl IHNjcm9sbGJhciB0byBsZWF2ZSB0cmFpbGluZyBhcnRpZmFjdHMuCi0gICAgLy8gIzI6IEZpbmQg dGljayBtYXJrcyBuZWVkIHRvIGJlIGRyYXduIG9uIHRoZSBzY3JvbGxiYXIgdHJhY2suCi0gICAg cmV0dXJuIE5TU2Nyb2xsZXJTdHlsZUxlZ2FjeTsKLQogICAgIGlmIChbTlNTY3JvbGxlciByZXNw b25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHByZWZlcnJlZFNjcm9sbGVyU3R5bGUpXSkKICAgICAg ICAgcmV0dXJuIFtOU1Njcm9sbGVyIHByZWZlcnJlZFNjcm9sbGVyU3R5bGVdOwogICAgIHJldHVy biBOU1Njcm9sbGVyU3R5bGVMZWdhY3k7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDlm OWVhYzRiOGQzYjZjZGMxN2M5NjMwZWE4ODYwOGYxZTc0YzliZDYuLjQ3OTgzZmQzOTUyMGE3Zjhj NjE3ZDBjMTE5NWM3MTFkYzkwNjdmYTUgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDYtMTUgIFNhaWxlc2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtD aHJvbWl1bV0gT3ZlcmxheSBzY3JvbGxiYXJzIGxlYXZlIGdsaXRjaGVzIG9uIHdlYiBjb250ZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjM4Mwor CisgICAgICAgIEZpeCBnbGl0Y2hlcyB3aGVuIHNjcm9sbGluZyB3aXRoIG92ZXJsYXkgc2Nyb2xs YmFycy4gVGhlIHByb2JsZW0gd2FzIHRoYXQgdGhlIHJlbmRlciB3aWRnZXQgd2FzIGNvcHlpbmcg dGhlIHNjcm9sbGJhcnMgd2hlbiBzY3JvbGxpbmcuIEZpeCB3YXMgdG8gaW50ZXJzZWN0IHRoZSBj bGlwIHJlY3Qgd2l0aCB0aGUgc2Nyb2xsIHJlY3QuIFRoaXMgaXMgdGhlIHNhbWUgdGhpbmcgdGhh dCBTYWZhcmkgZG9lcyAoc2VlIFdlYkNocm9tZUNsaWVudDo6c2Nyb2xsKS4KKworICAgICAgICAq IHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50 SW1wbDo6c2Nyb2xsKToKKwogMjAxMS0wNi0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4IGY0ZTNh MDUxMzVmMWNkMTA0ZTFlOGE0ZjM3YWM4YmIxYjUzZTYzNDYuLmY3MTVjY2MwMDU0Y2JjNmM2Zjg4 N2UwYzcyYTQ3NzEwOGYyZGJhZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0Nocm9tZUNsaWVudEltcGwuY3BwCkBAIC01NTUsNyArNTU1LDcgQEAgdm9pZCBDaHJvbWVDbGll bnRJbXBsOjpzY3JvbGwoCiAgICAgICAgIGlmIChtX3dlYlZpZXctPmNsaWVudCgpKSB7CiAgICAg ICAgICAgICBpbnQgZHggPSBzY3JvbGxEZWx0YS53aWR0aCgpOwogICAgICAgICAgICAgaW50IGR5 ID0gc2Nyb2xsRGVsdGEuaGVpZ2h0KCk7Ci0gICAgICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgp LT5kaWRTY3JvbGxSZWN0KGR4LCBkeSwgY2xpcFJlY3QpOworICAgICAgICAgICAgbV93ZWJWaWV3 LT5jbGllbnQoKS0+ZGlkU2Nyb2xsUmVjdChkeCwgZHksIGludGVyc2VjdGlvbihzY3JvbGxSZWN0 LCBjbGlwUmVjdCkpOwogICAgICAgICB9CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5H KQogICAgIH0gZWxzZQo=