62373 2011-06-09 06:44:14 -0700 Build break in ScriptProfile.cpp and inspector disabled. 2011-06-09 08:52:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm steveblock webkit.review.bot yurys oldest_to_newest 417979 0 benm 2011-06-09 06:44:14 -0700 The build breaks due to missing ENABLE(INSPECTOR) guards when building ScriptProfile.cpp and the inspector disabled. Patch to follow. 417981 1 96581 benm 2011-06-09 06:46:54 -0700 Created attachment 96581 Patch. 417993 2 steveblock 2011-06-09 07:11:32 -0700 This looks reasonable, but I think Yury has a plan for handling this consistently - Bug 62118 - so I'll leave the review to him. 418041 3 96581 webkit.review.bot 2011-06-09 08:52:26 -0700 Comment on attachment 96581 Patch. Clearing flags on attachment: 96581 Committed r88454: <http://trac.webkit.org/changeset/88454> 418042 4 webkit.review.bot 2011-06-09 08:52:29 -0700 All reviewed patches have been landed. Closing bug. 96581 2011-06-09 06:46:54 -0700 2011-06-09 08:52:25 -0700 Patch. 62373.txt text/plain 2170 benm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NDQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDkgIEJlbiBNdXJk b2NoICA8YmVubUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJ1aWxkIGJyZWFrIGluIFNjcmlwdFByb2ZpbGUuY3BwIGFuZCBpbnNw ZWN0b3IgZGlzYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MjM3MworCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIGJ1aWxkIGZpeCBvbmx5Lgor CisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHA6IEFkZCBuZWNlc3Nhcnkg Z3VhcmRzLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuaDogZGl0dG8uCisK IDIwMTEtMDYtMDggIE1pa2/FgmFqIE1hxYJlY2tpICA8bS5tYWxlY2tpQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmNwcAkocmV2aXNpb24gODg0NDQpCisrKyBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjUsNiArNjUsNyBAQCBQYXNzUmVmUHRyPFNjcmlwdFByb2ZpbGVOb2RlPiBTY3JpcHRQ cm9mCiAgICAgcmV0dXJuIFNjcmlwdFByb2ZpbGVOb2RlOjpjcmVhdGUobV9wcm9maWxlLT5HZXRC b3R0b21VcFJvb3QoKSk7CiB9CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogc3RhdGljIFBhc3NS ZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBidWlsZEluc3BlY3Rvck9iamVjdEZvcihjb25zdCB2ODo6 Q3B1UHJvZmlsZU5vZGUqIG5vZGUpCiB7CiAgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3Bl OwpAQCAtOTcsNSArOTgsNiBAQCBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gU2NyaXB0UHJv ZmlsCiB7CiAgICAgcmV0dXJuIGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yKG1fcHJvZmlsZS0+R2V0 Qm90dG9tVXBSb290KCkpOwogfQorI2VuZGlmCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmgJKHJldmlzaW9u IDg4NDQ0KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5oCSh3 b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw5IEBAIGNsYXNzIENwdVByb2ZpbGU7CiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAorI2lmIEVOQUJMRShJTlNQRUNUT1IpCiBjbGFzcyBJbnNwZWN0b3JP YmplY3Q7CisjZW5kaWYKIAogY2xhc3MgU2NyaXB0UHJvZmlsZSA6IHB1YmxpYyBSZWZDb3VudGVk PFNjcmlwdFByb2ZpbGU+IHsKIHB1YmxpYzoKQEAgLTU1LDggKzU3LDEwIEBAIHB1YmxpYzoKICAg ICBQYXNzUmVmUHRyPFNjcmlwdFByb2ZpbGVOb2RlPiBoZWFkKCkgY29uc3Q7CiAgICAgUGFzc1Jl ZlB0cjxTY3JpcHRQcm9maWxlTm9kZT4gYm90dG9tVXBIZWFkKCkgY29uc3Q7CiAKKyNpZiBFTkFC TEUoSU5TUEVDVE9SKQogICAgIFBhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBidWlsZEluc3Bl Y3Rvck9iamVjdEZvckhlYWQoKSBjb25zdDsKICAgICBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVj dD4gYnVpbGRJbnNwZWN0b3JPYmplY3RGb3JCb3R0b21VcEhlYWQoKSBjb25zdDsKKyNlbmRpZgog CiBwcml2YXRlOgogICAgIFNjcmlwdFByb2ZpbGUoY29uc3Qgdjg6OkNwdVByb2ZpbGUqIHByb2Zp bGUpCg==