62365 2011-06-09 02:58:27 -0700 [EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp 2011-06-13 15:23:07 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned antognolli+webkit gyuyoung.kim gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 417928 0 g.czajkowski 2011-06-09 02:58:27 -0700 These functions do not exist in any public headers and they are not used internally. Moreover ewk_view has the same functionality added https://bugs.webkit.org/show_bug.cgi?id=60435. 417930 1 96566 g.czajkowski 2011-06-09 03:00:33 -0700 Created attachment 96566 patch 417958 2 96566 lucas.de.marchi 2011-06-09 05:38:36 -0700 Comment on attachment 96566 patch LGTM. 418401 3 gyuyoung.kim 2011-06-09 17:04:29 -0700 LGTM. 419930 4 96566 eric 2011-06-13 15:10:54 -0700 Comment on attachment 96566 patch OK. 419954 5 96566 webkit.review.bot 2011-06-13 15:23:02 -0700 Comment on attachment 96566 patch Clearing flags on attachment: 96566 Committed r88710: <http://trac.webkit.org/changeset/88710> 419955 6 webkit.review.bot 2011-06-13 15:23:07 -0700 All reviewed patches have been landed. Closing bug. 96566 2011-06-09 03:00:33 -0700 2011-06-13 15:23:02 -0700 patch remove_ewk_frame_select_functions.patch text/plain 3415 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwNzA4Y2FmLi45YzgwMjcwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDkgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGV3a19mcmFtZV9zZWxlY3RfKiBmdW5jdGlvbnMgZnJv bSBld2tfZnJhbWUuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MjM2NQorCisgICAgICAgIFRoZXNlIGZ1bmN0aW9ucyBkbyBub3QgZXhpc3QgaW4g YW55IHB1YmxpYyBoZWFkZXJzIGFuZAorICAgICAgICB0aGV5IGFyZSBub3QgdXNlZCBpbnRlcm5h bGx5LgorICAgICAgICBNb3Jlb3ZlciBld2tfdmlldyBoYXMgdGhlIHNhbWUgZnVuY3Rpb25hbGl0 eSBhZGRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjA0MzUKKworICAgICAgICAqIGV3ay9ld2tfZnJhbWUuY3BwOgorCiAyMDExLTA2LTA4ICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJh bWUuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKaW5kZXggMzg1M2Y4 Ni4uYmIwNDgzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKQEAgLTY1Nyw4MyAr NjU3LDYgQEAgY2hhciogZXdrX2ZyYW1lX3NlbGVjdGlvbl9nZXQoY29uc3QgRXZhc19PYmplY3Qq IG8pCiAgICAgcmV0dXJuIHN0cmR1cChzLmRhdGEoKSk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgRWlu YV9Cb29sIF9ld2tfZnJhbWVfZWRpdG9yX2NvbW1hbmQoRXdrX0ZyYW1lX1NtYXJ0X0RhdGEqIHNk LCBjb25zdCBjaGFyKiBjb21tYW5kKQotewotICAgIHJldHVybiBzZC0+ZnJhbWUtPmVkaXRvcigp LT5jb21tYW5kKFdURjo6U3RyaW5nOjpmcm9tVVRGOChjb21tYW5kKSkuZXhlY3V0ZSgpOwotfQot Ci0vKioKLSAqIFVuc2VsZWN0cyB3aGF0ZXZlciB3YXMgc2VsZWN0ZWQuCi0gKgotICogQHJldHVy biBAYyBFSU5BX1RSVUUgaWYgb3BlcmF0aW9uIHdhcyBleGVjdXRlZCwgQGMgRUlOQV9GQUxTRSBv dGhlcndpc2UuCi0gKi8KLUVpbmFfQm9vbCBld2tfZnJhbWVfc2VsZWN0X25vbmUoRXZhc19PYmpl Y3QqIG8pCi17Ci0gICAgRVdLX0ZSQU1FX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFM U0UpOwotICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChzZC0+ZnJhbWUsIEVJTkFf RkFMU0UpOwotICAgIHJldHVybiBfZXdrX2ZyYW1lX2VkaXRvcl9jb21tYW5kKHNkLCAiVW5zZWxl Y3QiKTsKLX0KLQotLyoqCi0gKiBTZWxlY3RzIGV2ZXJ5dGhpbmcuCi0gKgotICogQHJldHVybiBA YyBFSU5BX1RSVUUgaWYgb3BlcmF0aW9uIHdhcyBleGVjdXRlZCwgQGMgRUlOQV9GQUxTRSBvdGhl cndpc2UuCi0gKi8KLUVpbmFfQm9vbCBld2tfZnJhbWVfc2VsZWN0X2FsbChFdmFzX09iamVjdCog bykKLXsKLSAgICBFV0tfRlJBTUVfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7 Ci0gICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKHNkLT5mcmFtZSwgRUlOQV9GQUxT RSk7Ci0gICAgcmV0dXJuIF9ld2tfZnJhbWVfZWRpdG9yX2NvbW1hbmQoc2QsICJTZWxlY3RBbGwi KTsKLX0KLQotLyoqCi0gKiBTZWxlY3RzIHRoZSBjdXJyZW50IHBhcmFncmFoLgotICoKLSAqIEBy ZXR1cm4gQGMgRUlOQV9UUlVFIGlmIG9wZXJhdGlvbiB3YXMgZXhlY3V0ZWQsIEBjIEVJTkFfRkFM U0Ugb3RoZXJ3aXNlLgotICovCi1FaW5hX0Jvb2wgZXdrX2ZyYW1lX3NlbGVjdF9wYXJhZ3JhcGgo RXZhc19PYmplY3QqIG8pCi17Ci0gICAgRVdLX0ZSQU1FX1NEX0dFVF9PUl9SRVRVUk4obywgc2Qs IEVJTkFfRkFMU0UpOwotICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTChzZC0+ZnJh bWUsIEVJTkFfRkFMU0UpOwotICAgIHJldHVybiBfZXdrX2ZyYW1lX2VkaXRvcl9jb21tYW5kKHNk LCAiU2VsZWN0UGFyYWdyYXBoIik7Ci19Ci0KLS8qKgotICogU2VsZWN0cyB0aGUgY3VycmVudCBz ZW50ZW5jZS4KLSAqCi0gKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBpZiBvcGVyYXRpb24gd2FzIGV4 ZWN1dGVkLCBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZS4KLSAqLwotRWluYV9Cb29sIGV3a19mcmFt ZV9zZWxlY3Rfc2VudGVuY2UoRXZhc19PYmplY3QqIG8pCi17Ci0gICAgRVdLX0ZSQU1FX1NEX0dF VF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOwotICAgIEVJTkFfU0FGRVRZX09OX05VTExf UkVUVVJOX1ZBTChzZC0+ZnJhbWUsIEVJTkFfRkFMU0UpOwotICAgIHJldHVybiBfZXdrX2ZyYW1l X2VkaXRvcl9jb21tYW5kKHNkLCAiU2VsZWN0U2VudGVuY2UiKTsKLX0KLQotLyoqCi0gKiBTZWxl Y3RzIHRoZSBjdXJyZW50IGxpbmUuCi0gKgotICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgb3Bl cmF0aW9uIHdhcyBleGVjdXRlZCwgQGMgRUlOQV9GQUxTRSBvdGhlcndpc2UuCi0gKi8KLUVpbmFf Qm9vbCBld2tfZnJhbWVfc2VsZWN0X2xpbmUoRXZhc19PYmplY3QqIG8pCi17Ci0gICAgRVdLX0ZS QU1FX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFMU0UpOwotICAgIEVJTkFfU0FGRVRZ X09OX05VTExfUkVUVVJOX1ZBTChzZC0+ZnJhbWUsIEVJTkFfRkFMU0UpOwotICAgIHJldHVybiBf ZXdrX2ZyYW1lX2VkaXRvcl9jb21tYW5kKHNkLCAiU2VsZWN0TGluZSIpOwotfQotCi0vKioKLSAq IFNlbGVjdHMgdGhlIGN1cnJlbnQgd29yZC4KLSAqCi0gKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBp ZiBvcGVyYXRpb24gd2FzIGV4ZWN1dGVkLCBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZS4KLSAqLwot RWluYV9Cb29sIGV3a19mcmFtZV9zZWxlY3Rfd29yZChFdmFzX09iamVjdCogbykKLXsKLSAgICBF V0tfRlJBTUVfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxTRSk7Ci0gICAgRUlOQV9T QUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKHNkLT5mcmFtZSwgRUlOQV9GQUxTRSk7Ci0gICAgcmV0 dXJuIF9ld2tfZnJhbWVfZWRpdG9yX2NvbW1hbmQoc2QsICJTZWxlY3RXb3JkIik7Ci19Ci0KIC8q KgogICogU2VhcmNoIHRoZSBnaXZlbiB0ZXh0IHN0cmluZyBpbiBkb2N1bWVudC4KICAqCg==