62364 2011-06-09 02:46:27 -0700 [chromium-win] Register protocol handler tests are failing on build.webkit.org 2011-06-22 19:03:45 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned dglazkov jamesr koz tony oldest_to_newest 417924 0 rniwa 2011-06-09 02:46:27 -0700 It seems like the flags aren't enabled properly on build.webkit.org bots: http://build.webkit.org/results/Chromium%20Win%20Release%20(Tests)/r88434%20(15286)/results.html 418217 1 jamesr 2011-06-09 13:13:41 -0700 This is a bit strange - it seems that the ENABLE_REGISTER_... macro is not on for these bots, although when I regenerate the visual studio projects locally it's definitely set to true. The bots need a kick perhaps? 418293 2 tony 2011-06-09 14:21:52 -0700 I'll check on the bot. 418305 3 tony 2011-06-09 14:30:00 -0700 Oh, in the checked in code, I think it's disabled for all upstream builds since it's set to 0 in the top of features.gypi. In chromium checkouts, features_override.gypi enables it. The reason the variable in build/common.gypi doesn't override is because in features.gypi, the nesting puts the condition in a scope that doesn't see the value in build/common.gypi. This will be fixed by bug 62399. 418824 4 tony 2011-06-10 12:01:29 -0700 Seems green after landing the patch on bug 62399 and clobbering the build to pick up the compiler flag changes. 419098 5 rniwa 2011-06-10 18:10:58 -0700 fast/dom/navigator-detached-no-crash.html is failing on Mac: http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html 419221 6 dglazkov 2011-06-11 10:59:49 -0700 (In reply to comment #5) > fast/dom/navigator-detached-no-crash.html is failing on Mac: > > http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html I re-clobbered teh bot. Let's see what happens. 425869 7 rniwa 2011-06-22 19:03:45 -0700 It seems like the test has been passing, closing the bug.