62356 2011-06-08 22:05:30 -0700 Make CSSPrimitiveValue support cast to EVerticalAlign. 2011-06-08 23:55:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson dglazkov eric macpherson webkit.review.bot oldest_to_newest 417818 0 macpherson 2011-06-08 22:05:30 -0700 Make CSSPrimitiveValue support cast to EVerticalAlign. 417820 1 96547 macpherson 2011-06-08 22:07:05 -0700 Created attachment 96547 Patch 417844 2 96547 eric 2011-06-08 23:08:50 -0700 Comment on attachment 96547 Patch LGTM. 417867 3 96547 webkit.review.bot 2011-06-08 23:55:45 -0700 Comment on attachment 96547 Patch Clearing flags on attachment: 96547 Committed r88431: <http://trac.webkit.org/changeset/88431> 417868 4 webkit.review.bot 2011-06-08 23:55:49 -0700 All reviewed patches have been landed. Closing bug. 96547 2011-06-08 22:07:05 -0700 2011-06-08 23:55:45 -0700 Patch bug-62356-20110609150703.patch text/plain 5602 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4NDIwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMDggIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIENTU1ByaW1pdGl2ZVZhbHVlIHN1cHBv cnQgY2FzdCB0byBFVmVydGljYWxBbGlnbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYyMzU2CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC8gcmVmYWN0 b3Jpbmcgb25seS4KKworICAgICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmg6 CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUp OgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9yIEVWZXJ0aWNh bEFsaWduKToKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KToKKwogMjAxMS0wNi0wOCAg SGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg SGFqaW1lIE1vcml0YS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZU1hcHBpbmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlTWFwcGluZ3MuaAkocmV2aXNpb24gODg0MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xODQ5LDYgKzE4 NDksNzAgQEAgdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZQogICAgIH0K IH0KIAordGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZh bHVlKEVWZXJ0aWNhbEFsaWduIGEpCisgICAgOiBtX3R5cGUoQ1NTX0lERU5UKQorICAgICwgbV9o YXNDYWNoZWRDU1NUZXh0KGZhbHNlKQoreworICAgIHN3aXRjaCAoYSkgeworICAgIGNhc2UgVE9Q OgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVUb3A7CisgICAgICAgIGJyZWFrOwor ICAgIGNhc2UgQk9UVE9NOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVCb3R0b207 CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgTUlERExFOgorICAgICAgICBtX3ZhbHVlLmlkZW50 ID0gQ1NTVmFsdWVNaWRkbGU7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgQkFTRUxJTkU6Cisg ICAgICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZUJhc2VsaW5lOworICAgICAgICBicmVhazsK KyAgICBjYXNlIFRFWFRfQk9UVE9NOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVU ZXh0Qm90dG9tOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFRFWFRfVE9QOgorICAgICAgICBt X3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVUZXh0VG9wOworICAgICAgICBicmVhazsKKyAgICBjYXNl IFNVQjoKKyAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlU3ViOworICAgICAgICBicmVh azsKKyAgICBjYXNlIFNVUEVSOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFsdWVTdXBl cjsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBCQVNFTElORV9NSURETEU6CisgICAgICAgIG1f dmFsdWUuaWRlbnQgPSBDU1NWYWx1ZVdlYmtpdEJhc2VsaW5lTWlkZGxlOworICAgICAgICBicmVh azsKKyAgICBjYXNlIExFTkdUSDoKKyAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVlSW52 YWxpZDsKKyAgICB9Cit9CisKK3RlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpv cGVyYXRvciBFVmVydGljYWxBbGlnbigpIGNvbnN0Cit7CisgICAgc3dpdGNoIChtX3ZhbHVlLmlk ZW50KSB7CisgICAgY2FzZSBDU1NWYWx1ZVRvcDoKKyAgICAgICAgcmV0dXJuIFRPUDsKKyAgICBj YXNlIENTU1ZhbHVlQm90dG9tOgorICAgICAgICByZXR1cm4gQk9UVE9NOworICAgIGNhc2UgQ1NT VmFsdWVNaWRkbGU6CisgICAgICAgIHJldHVybiBNSURETEU7CisgICAgY2FzZSBDU1NWYWx1ZUJh c2VsaW5lOgorICAgICAgICByZXR1cm4gQkFTRUxJTkU7CisgICAgY2FzZSBDU1NWYWx1ZVRleHRC b3R0b206CisgICAgICAgIHJldHVybiBURVhUX0JPVFRPTTsKKyAgICBjYXNlIENTU1ZhbHVlVGV4 dFRvcDoKKyAgICAgICAgcmV0dXJuIFRFWFRfVE9QOworICAgIGNhc2UgQ1NTVmFsdWVTdWI6Cisg ICAgICAgIHJldHVybiBTVUI7CisgICAgY2FzZSBDU1NWYWx1ZVN1cGVyOgorICAgICAgICByZXR1 cm4gU1VQRVI7CisgICAgY2FzZSBDU1NWYWx1ZVdlYmtpdEJhc2VsaW5lTWlkZGxlOgorICAgICAg ICByZXR1cm4gQkFTRUxJTkVfTUlERExFOworICAgIGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gVE9QOworICAgIH0KK30KKwogdGVtcGxhdGU8 PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKEVWaXNpYmlsaXR5 IGUpCiAgICAgOiBtX3R5cGUoQ1NTX0lERU5UKQogICAgICwgbV9oYXNDYWNoZWRDU1NUZXh0KGZh bHNlKQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkocmV2aXNp b24gODg0MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM4NzIsNDkgKzM4NzIsMjcgQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9y OjphcHBseVByb3BlcnR5KGludAogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIGNhc2UgQ1NT UHJvcGVydHlWZXJ0aWNhbEFsaWduOgorICAgIHsKICAgICAgICAgSEFORExFX0lOSEVSSVRfQU5E X0lOSVRJQUwodmVydGljYWxBbGlnbiwgVmVydGljYWxBbGlnbikKICAgICAgICAgaWYgKCFwcmlt aXRpdmVWYWx1ZSkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgaWYgKHByaW1pdGl2ZVZh bHVlLT5nZXRJZGVudCgpKSB7Ci0gICAgICAgICAgRVZlcnRpY2FsQWxpZ24gYWxpZ247CiAKLSAg ICAgICAgICBzd2l0Y2ggKHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpKSB7Ci0gICAgICAgICAg ICAgICAgY2FzZSBDU1NWYWx1ZVRvcDoKLSAgICAgICAgICAgICAgICAgICAgYWxpZ24gPSBUT1A7 IGJyZWFrOwotICAgICAgICAgICAgICAgIGNhc2UgQ1NTVmFsdWVCb3R0b206Ci0gICAgICAgICAg ICAgICAgICAgIGFsaWduID0gQk9UVE9NOyBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlIENT U1ZhbHVlTWlkZGxlOgotICAgICAgICAgICAgICAgICAgICBhbGlnbiA9IE1JRERMRTsgYnJlYWs7 Ci0gICAgICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZUJhc2VsaW5lOgotICAgICAgICAgICAgICAg ICAgICBhbGlnbiA9IEJBU0VMSU5FOyBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlIENTU1Zh bHVlVGV4dEJvdHRvbToKLSAgICAgICAgICAgICAgICAgICAgYWxpZ24gPSBURVhUX0JPVFRPTTsg YnJlYWs7Ci0gICAgICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZVRleHRUb3A6Ci0gICAgICAgICAg ICAgICAgICAgIGFsaWduID0gVEVYVF9UT1A7IGJyZWFrOwotICAgICAgICAgICAgICAgIGNhc2Ug Q1NTVmFsdWVTdWI6Ci0gICAgICAgICAgICAgICAgICAgIGFsaWduID0gU1VCOyBicmVhazsKLSAg ICAgICAgICAgICAgICBjYXNlIENTU1ZhbHVlU3VwZXI6Ci0gICAgICAgICAgICAgICAgICAgIGFs aWduID0gU1VQRVI7IGJyZWFrOwotICAgICAgICAgICAgICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRC YXNlbGluZU1pZGRsZToKLSAgICAgICAgICAgICAgICAgICAgYWxpZ24gPSBCQVNFTElORV9NSURE TEU7IGJyZWFrOwotICAgICAgICAgICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICBtX3N0eWxlLT5zZXRWZXJ0aWNhbEFs aWduKGFsaWduKTsKKyAgICAgICAgaWYgKHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpKSB7Cisg ICAgICAgICAgbV9zdHlsZS0+c2V0VmVydGljYWxBbGlnbigqcHJpbWl0aXZlVmFsdWUpOwogICAg ICAgICAgIHJldHVybjsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICBpbnQgdHlwZSA9IHBy aW1pdGl2ZVZhbHVlLT5wcmltaXRpdmVUeXBlKCk7Ci0gICAgICAgICAgTGVuZ3RoIGw7Ci0gICAg ICAgICAgaWYgKENTU1ByaW1pdGl2ZVZhbHVlOjppc1VuaXRUeXBlTGVuZ3RoKHR5cGUpKQotICAg ICAgICAgICAgbCA9IExlbmd0aChwcmltaXRpdmVWYWx1ZS0+Y29tcHV0ZUxlbmd0aEludEZvckxl bmd0aChzdHlsZSgpLCBtX3Jvb3RFbGVtZW50U3R5bGUsIHpvb21GYWN0b3IpLCBGaXhlZCk7Ci0g ICAgICAgICAgZWxzZSBpZiAodHlwZSA9PSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BFUkNFTlRB R0UpCi0gICAgICAgICAgICBsID0gTGVuZ3RoKHByaW1pdGl2ZVZhbHVlLT5nZXREb3VibGVWYWx1 ZSgpLCBQZXJjZW50KTsKLQotICAgICAgICAgIG1fc3R5bGUtPnNldFZlcnRpY2FsQWxpZ24oTEVO R1RIKTsKLSAgICAgICAgICBtX3N0eWxlLT5zZXRWZXJ0aWNhbEFsaWduTGVuZ3RoKGwpOwogICAg ICAgICB9Ci0gICAgICAgIHJldHVybjsKIAorICAgICAgICBpbnQgdHlwZSA9IHByaW1pdGl2ZVZh bHVlLT5wcmltaXRpdmVUeXBlKCk7CisgICAgICAgIExlbmd0aCBsZW5ndGg7CisgICAgICAgIGlm IChDU1NQcmltaXRpdmVWYWx1ZTo6aXNVbml0VHlwZUxlbmd0aCh0eXBlKSkKKyAgICAgICAgICAg IGxlbmd0aCA9IExlbmd0aChwcmltaXRpdmVWYWx1ZS0+Y29tcHV0ZUxlbmd0aEludEZvckxlbmd0 aChzdHlsZSgpLCBtX3Jvb3RFbGVtZW50U3R5bGUsIHpvb21GYWN0b3IpLCBGaXhlZCk7CisgICAg ICAgIGVsc2UgaWYgKHR5cGUgPT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19QRVJDRU5UQUdFKQor ICAgICAgICAgICAgbGVuZ3RoID0gTGVuZ3RoKHByaW1pdGl2ZVZhbHVlLT5nZXREb3VibGVWYWx1 ZSgpLCBQZXJjZW50KTsKKworICAgICAgICBtX3N0eWxlLT5zZXRWZXJ0aWNhbEFsaWduKExFTkdU SCk7CisgICAgICAgIG1fc3R5bGUtPnNldFZlcnRpY2FsQWxpZ25MZW5ndGgobGVuZ3RoKTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KICAgICBjYXNlIENTU1Byb3BlcnR5Rm9udFNpemU6CiAgICAg ewogICAgICAgICBGb250RGVzY3JpcHRpb24gZm9udERlc2NyaXB0aW9uID0gbV9zdHlsZS0+Zm9u dERlc2NyaXB0aW9uKCk7Cg==