62352 2011-06-08 21:09:43 -0700 [Chromium] Support vertical sliders in Windows DRT 2011-06-08 21:47:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P1 Major --- 1 tkent tkent dglazkov morrita oldest_to_newest 417791 0 tkent 2011-06-08 21:09:43 -0700 http://trac.webkit.org/changeset/88415 exposed Chromium-win DRT doesn't support drawing vertical sliders. Yes, the test added by r88415 was the first test using a vertical slider. The test is causing a crash. 417793 1 96541 tkent 2011-06-08 21:13:54 -0700 Created attachment 96541 Patch 417804 2 96541 morrita 2011-06-08 21:45:49 -0700 Comment on attachment 96541 Patch rubber stamped by me. 417810 3 96541 tkent 2011-06-08 21:47:37 -0700 Comment on attachment 96541 Patch Clearing flags on attachment: 96541 Committed r88419: <http://trac.webkit.org/changeset/88419> 417811 4 tkent 2011-06-08 21:47:43 -0700 All reviewed patches have been landed. Closing bug. 96541 2011-06-08 21:13:54 -0700 2011-06-08 21:47:37 -0700 Patch bug-62352-20110609131352.patch text/plain 4638 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODg0MTYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYmQwOGYyZWZhYTZiY2Q3OGRjNGZjMWNmMDIzOTcyYWE0 NTBlNWI2Li5lMmQ3M2JmN2MyZjZjMGI4Mzg0MTY4MTdjMDQ1ODk2YWU5MGQzNDI2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDYtMDggIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gU3Vw cG9ydCB2ZXJ0aWNhbCBzbGlkZXJzIGluIFdpbmRvd3MgRFJUCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjM1MgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmNwcDoKKyAgICAgICAgKFdlYlRo ZW1lQ29udHJvbERSVFdpbjo6ZHJhdyk6CisgICAgICAgICAgUGFpbnQgVmVydGljYWxTbGlkZXJU aHVtYlR5cGUgYW5kIFZlcnRpY2FsU2xpZGVyVHJhY2tUeXBlLgorICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVFdpbi5oOgorICAgICAgICAgIEFkZCBW ZXJ0aWNhbFNsaWRlclRyYWNrVHlwZSBhbmQgVmVydGljYWxTbGlkZXJUaHVtYlR5cGUuCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRXaW4uY3BwOgor ICAgICAgICAoV2ViVGhlbWVFbmdpbmVEUlRXaW46OnBhaW50VHJhY2tiYXIpOgorICAgICAgICAg IENvbnZlcnQgV2luZG93cyBpZGVudGlmaWVycyB0byB0aGUgaW50ZXJuYWwgaWRlbnRpZmllcnMg Zm9yIHZlcnRpY2FsIHNsaWRlcnMuCisKIDIwMTEtMDYtMDggIE9qYW4gVmFmYWkgIDxvamFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmNw cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVFdpbi5j cHAKaW5kZXggYTJkZGExZDhjZjRmYjA1ODYwNGU2ZGMxOWEzYzY1OTY1ZGEwODI0ZC4uNDcyMjdl MGIxM2I5OWRkZWQ0NGE0NWYwZjJlOTlhODViODJmOGIzNiAxMDA3NTUKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUNvbnRyb2xEUlRXaW4uY3BwCkBAIC0z ODgsNiArMzg4LDcgQEAgdm9pZCBXZWJUaGVtZUNvbnRyb2xEUlRXaW46OmRyYXcoKQogICAgICAg ICBicmVhazsKIAogICAgIGNhc2UgSG9yaXpvbnRhbFNsaWRlclRodW1iVHlwZToKKyAgICBjYXNl IFZlcnRpY2FsU2xpZGVyVGh1bWJUeXBlOgogICAgICAgICAvLyBTbGlkZXIgdGh1bWJzIGFyZSBv dmFscy4KICAgICAgICAgb3ZhbChtX2JnQ29sb3IpOwogICAgICAgICBicmVhazsKQEAgLTQ1OSw2 ICs0NjAsMTcgQEAgdm9pZCBXZWJUaGVtZUNvbnRyb2xEUlRXaW46OmRyYXcoKQogICAgICAgICBi cmVhazsKICAgICB9CiAKKyAgICBjYXNlIFZlcnRpY2FsU2xpZGVyVHJhY2tUeXBlOiB7CisgICAg ICAgIC8vIERyYXcgYSBuYXJyb3cgcmVjdCBmb3IgdGhlIHRyYWNrIHBsdXMgYm94IGhhdGNoZXMg b24gdGhlIGVuZHMuCisgICAgICAgIFNrSVJlY3QgbGlyZWN0OworICAgICAgICBsaXJlY3QgPSBt X2lyZWN0OworICAgICAgICBsaXJlY3QuaW5zZXQoaGFsZldpZHRoIC0gc2xpZGVySW5kZXgsIG5v T2Zmc2V0KTsKKyAgICAgICAgYm94KGxpcmVjdCwgbV9iZ0NvbG9yKTsKKyAgICAgICAgbGluZSht X2xlZnQsIG1fdG9wLCBtX3JpZ2h0LCBtX3RvcCwgbV9lZGdlQ29sb3IpOworICAgICAgICBsaW5l KG1fbGVmdCwgbV9ib3R0b20sIG1fcmlnaHQsIG1fYm90dG9tLCBtX2VkZ2VDb2xvcik7CisgICAg ICAgIGJyZWFrOworICAgIH0KKwogICAgIGNhc2UgRHJvcERvd25CdXR0b25UeXBlOgogICAgICAg ICAvLyBEcmF3IGEgYm94IHdpdGggYSBiaWcgZG93biBhcnJvdyBvbiB0b3AuCiAgICAgICAgIGJv eChtX2lyZWN0LCBtX2JnQ29sb3IpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJUV2luLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJUaGVtZUNvbnRyb2xEUlRXaW4uaAppbmRleCAzOTdmYWYzYWM3MWY1ZmIwZDA1 ZWYwM2JiNzVmMzc2YzQ0MzJmYTdhLi5hN2U1ZTM2MDQ4MWFjMzBhMmU2YmQ2YzhhMmUxNGU0Njdk OWVkZDg0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVt ZUNvbnRyb2xEUlRXaW4uaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJU aGVtZUNvbnRyb2xEUlRXaW4uaApAQCAtMTE2LDYgKzExNiw4IEBAIHB1YmxpYzoKICAgICAgICAg RG93bkFycm93VHlwZSwKICAgICAgICAgSG9yaXpvbnRhbFNsaWRlclRyYWNrVHlwZSwKICAgICAg ICAgSG9yaXpvbnRhbFNsaWRlclRodW1iVHlwZSwKKyAgICAgICAgVmVydGljYWxTbGlkZXJUcmFj a1R5cGUsCisgICAgICAgIFZlcnRpY2FsU2xpZGVyVGh1bWJUeXBlLAogICAgICAgICBEcm9wRG93 bkJ1dHRvblR5cGUsCiAgICAgICAgIFByb2dyZXNzQmFyVHlwZQogICAgIH07CmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVFdpbi5jcHAg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVFdpbi5jcHAK aW5kZXggMWY4YTQyMmQ3OTMwZGNmNzU1YWFkNmMyM2I5ZjJmZTE5NTE5N2M1NS4uZWFlYzg5OGRi MGUzYjlhYjkyNGFhY2Q5YWNiZTY1M2ExMmIzZDg1OSAxMDA3NTUKLS0tIGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlRXaW4uY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJUV2luLmNwcApAQCAtNzI5LDEx ICs3MjksNDMgQEAgdm9pZCBXZWJUaGVtZUVuZ2luZURSVFdpbjo6cGFpbnRUcmFja2JhcihXZWJD YW52YXMqIGNhbnZhcywKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIH0KKyAgICB9IGVsc2UgaWYgKFRLUF9USFVNQlZFUlQgPT0g cGFydCkgeworICAgICAgICBjdHlwZSA9IFdlYlRoZW1lQ29udHJvbERSVFdpbjo6VmVydGljYWxT bGlkZXJUaHVtYlR5cGU7CisgICAgICAgIHN3aXRjaCAoc3RhdGUpIHsKKyAgICAgICAgY2FzZSBU VVNfTk9STUFMOgorICAgICAgICAgICAgQVNTRVJUKGNsYXNzaWNTdGF0ZSA9PSBkZmNzTm9ybWFs KTsKKyAgICAgICAgICAgIGNzdGF0ZSA9IFdlYlRoZW1lQ29udHJvbERSVFdpbjo6Tm9ybWFsU3Rh dGU7CisgICAgICAgICAgICBicmVhazsKKworICAgICAgICBjYXNlIFRVU19IT1Q6CisgICAgICAg ICAgICBBU1NFUlQoY2xhc3NpY1N0YXRlID09IERGQ1NfSE9UKTsKKyAgICAgICAgICAgIGNzdGF0 ZSA9IFdlYlRoZW1lQ29udHJvbERSVFdpbjo6SG90U3RhdGU7CisgICAgICAgICAgICBicmVhazsK KworICAgICAgICBjYXNlIFRVU19ESVNBQkxFRDoKKyAgICAgICAgICAgIEFTU0VSVChjbGFzc2lj U3RhdGUgPT0gREZDU19JTkFDVElWRSk7CisgICAgICAgICAgICBjc3RhdGUgPSBXZWJUaGVtZUNv bnRyb2xEUlRXaW46OkRpc2FibGVkU3RhdGU7CisgICAgICAgICAgICBicmVhazsKKworICAgICAg ICBjYXNlIFRVU19QUkVTU0VEOgorICAgICAgICAgICAgQVNTRVJUKGNsYXNzaWNTdGF0ZSA9PSBE RkNTX1BVU0hFRCk7CisgICAgICAgICAgICBjc3RhdGUgPSBXZWJUaGVtZUNvbnRyb2xEUlRXaW46 OlByZXNzZWRTdGF0ZTsKKyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIGRlZmF1bHQ6Cisg ICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIGJyZWFrOworICAg ICAgICB9CiAgICAgfSBlbHNlIGlmIChUS1BfVFJBQ0sgPT0gcGFydCkgewogICAgICAgICBjdHlw ZSA9IFdlYlRoZW1lQ29udHJvbERSVFdpbjo6SG9yaXpvbnRhbFNsaWRlclRyYWNrVHlwZTsKICAg ICAgICAgQVNTRVJUKHBhcnQgPT0gVFVTX05PUk1BTCk7CiAgICAgICAgIEFTU0VSVChjbGFzc2lj U3RhdGUgPT0gZGZjc05vcm1hbCk7CiAgICAgICAgIGNzdGF0ZSA9IFdlYlRoZW1lQ29udHJvbERS VFdpbjo6Tm9ybWFsU3RhdGU7CisgICAgfSBlbHNlIGlmIChUS1BfVFJBQ0tWRVJUID09IHBhcnQp IHsKKyAgICAgICAgY3R5cGUgPSBXZWJUaGVtZUNvbnRyb2xEUlRXaW46OlZlcnRpY2FsU2xpZGVy VHJhY2tUeXBlOworICAgICAgICBBU1NFUlQocGFydCA9PSBUVVNfTk9STUFMKTsKKyAgICAgICAg QVNTRVJUKGNsYXNzaWNTdGF0ZSA9PSBkZmNzTm9ybWFsKTsKKyAgICAgICAgY3N0YXRlID0gV2Vi VGhlbWVDb250cm9sRFJUV2luOjpOb3JtYWxTdGF0ZTsKICAgICB9IGVsc2UKICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CiAK