62347 2011-06-08 19:54:36 -0700 [EFL] Add load error handler to EWebLauncher 2011-06-13 15:30:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned gyuyoung.kim gyuyoung.kim kenneth lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 417761 0 ljaehun.lim 2011-06-08 19:54:36 -0700 Add a handler function of "load,error" to EWebLauncher. EWebLauncher can show a simple error page when load error. 417763 1 96530 ljaehun.lim 2011-06-08 20:02:39 -0700 Created attachment 96530 Proposed patch 417985 2 96530 leandro 2011-06-09 06:54:57 -0700 Comment on attachment 96530 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=96530&action=review Just some minor nitpicks. Otherwise, LGTM. > Tools/ChangeLog:9 > + Add a handler function of "load,error" to EWebLauncher. > + EWebLauncher can show a simple error page when load error. I think something along the lines of "EWebLauncher now displays a simple error page on load errors." would be better. > Tools/EWebLauncher/main.c:321 > + snprintf(message, 1024, "<html><body><div style=\"color:#ff0000\">ERROR !</div><br><div>Code : %d<br>Domain : %s<br>Description : %s<br>URL : %s</div></body</html>", No spaces before punctuation. Use "ERROR!", "Code:", etc. 418367 3 96657 ljaehun.lim 2011-06-09 15:54:35 -0700 Created attachment 96657 new patch 418368 4 ljaehun.lim 2011-06-09 15:57:04 -0700 (In reply to comment #2) > (From update of attachment 96530 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96530&action=review > > Just some minor nitpicks. Otherwise, LGTM. > > > Tools/ChangeLog:9 > > + Add a handler function of "load,error" to EWebLauncher. > > + EWebLauncher can show a simple error page when load error. > > I think something along the lines of "EWebLauncher now displays a simple error page on load errors." would be better. > > > Tools/EWebLauncher/main.c:321 > > + snprintf(message, 1024, "<html><body><div style=\"color:#ff0000\">ERROR !</div><br><div>Code : %d<br>Domain : %s<br>Description : %s<br>URL : %s</div></body</html>", > > No spaces before punctuation. Use "ERROR!", "Code:", etc. Thanks for your comments. I uploaded a new patch. 418391 5 gyuyoung.kim 2011-06-09 16:54:15 -0700 Internal r+ on my side. 419946 6 96657 eric 2011-06-13 15:19:41 -0700 Comment on attachment 96657 new patch rs=me. 419947 7 96657 eric 2011-06-13 15:20:56 -0700 Comment on attachment 96657 new patch View in context: https://bugs.webkit.org/attachment.cgi?id=96657&action=review > Tools/EWebLauncher/main.c:322 > + snprintf(message, 1024, "<html><body><div style=\"color:#ff0000\">ERROR!</div><br><div>Code: %d<br>Domain: %s<br>Description: %s<br>URL: %s</div></body</html>", > + err->code, err->domain, err->description, err->failing_url); Do we have any concerns about security of this HTML injection? I assume that the injected message can't be controleled by an attacker from a different domain? 419971 8 96657 webkit.review.bot 2011-06-13 15:30:16 -0700 Comment on attachment 96657 new patch Clearing flags on attachment: 96657 Committed r88714: <http://trac.webkit.org/changeset/88714> 419972 9 webkit.review.bot 2011-06-13 15:30:22 -0700 All reviewed patches have been landed. Closing bug. 96530 2011-06-08 20:02:39 -0700 2011-06-09 15:54:35 -0700 Proposed patch patch.diff text/plain 2248 ljaehun.lim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYmQw OGYyLi4zMzdmNDU0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIEphZWh1biBMaW0gIDxsamFlaHVu LmxpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbRUZMXSBBZGQgbG9hZCBlcnJvciBoYW5kbGVyIHRvIEVXZWJMYXVuY2hlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzNDcKKwor ICAgICAgICBBZGQgYSBoYW5kbGVyIGZ1bmN0aW9uIG9mICJsb2FkLGVycm9yIiB0byBFV2ViTGF1 bmNoZXIuCisgICAgICAgIEVXZWJMYXVuY2hlciBjYW4gc2hvdyBhIHNpbXBsZSBlcnJvciBwYWdl IHdoZW4gbG9hZCBlcnJvci4KKworICAgICAgICAqIEVXZWJMYXVuY2hlci9tYWluLmM6CisgICAg ICAgIChvbl9sb2FkX2Vycm9yKToKKyAgICAgICAgKGJyb3dzZXJDcmVhdGUpOgorCiAyMDExLTA2 LTA4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgVG9ueSBDaGFuZy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMgYi9U b29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmluZGV4IGFlNzc3Y2UuLjhmZWI1YWIgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKKysrIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21h aW4uYwpAQCAtMzE0LDYgKzMxNCwxNiBAQCBvbl9sb2FkX2ZpbmlzaGVkKHZvaWQgKnVzZXJfZGF0 YSwgRXZhc19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiB9CiAKIHN0YXRpYyB2 b2lkCitvbl9sb2FkX2Vycm9yKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKndlYnZpZXcs IHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgY29uc3QgRXdrX0ZyYW1lX0xvYWRfRXJyb3IgKmVy ciA9IChjb25zdCBFd2tfRnJhbWVfTG9hZF9FcnJvciAqKWV2ZW50X2luZm87CisgICAgY2hhciBt ZXNzYWdlWzEwMjRdOworICAgIHNucHJpbnRmKG1lc3NhZ2UsIDEwMjQsICI8aHRtbD48Ym9keT48 ZGl2IHN0eWxlPVwiY29sb3I6I2ZmMDAwMFwiPkVSUk9SICE8L2Rpdj48YnI+PGRpdj5Db2RlIDog JWQ8YnI+RG9tYWluIDogJXM8YnI+RGVzY3JpcHRpb24gOiAlczxicj5VUkwgOiAlczwvZGl2Pjwv Ym9keTwvaHRtbD4iLAorICAgICAgICAgICAgIGVyci0+Y29kZSwgZXJyLT5kb21haW4sIGVyci0+ ZGVzY3JpcHRpb24sIGVyci0+ZmFpbGluZ191cmwpOworICAgIGV3a19mcmFtZV9jb250ZW50c19z ZXQoZXJyLT5mcmFtZSwgbWVzc2FnZSwgMCwgInRleHQvaHRtbCIsICJVVEYtOCIsIGVyci0+ZmFp bGluZ191cmwpOworfQorCitzdGF0aWMgdm9pZAogb25fdG9vbGJhcnNfdmlzaWJsZV9zZXQodm9p ZCogdXNlcl9kYXRhLCBFdmFzX09iamVjdCogd2Vidmlldywgdm9pZCogZXZlbnRfaW5mbykKIHsK ICAgICBFaW5hX0Jvb2wgKnZpc2libGUgPSAoRWluYV9Cb29sICopZXZlbnRfaW5mbzsKQEAgLTcx MSw2ICs3MjEsNyBAQCBicm93c2VyQ3JlYXRlKGNvbnN0IGNoYXIgKnVybCwgY29uc3QgY2hhciAq dGhlbWUsIGNvbnN0IGNoYXIgKnVzZXJBZ2VudCwgRWluYV9SZQogICAgIGV2YXNfb2JqZWN0X3Nt YXJ0X2NhbGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsICJ0aXRsZSxjaGFuZ2VkIiwgb25fdGl0bGVf Y2hhbmdlZCwgYXBwKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwLT5i cm93c2VyLCAibG9hZCxwcm9ncmVzcyIsIG9uX3Byb2dyZXNzLCBhcHApOwogICAgIGV2YXNfb2Jq ZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsICJsb2FkLGZpbmlzaGVkIiwgb25f bG9hZF9maW5pc2hlZCwgYXBwKTsKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQo YXBwLT5icm93c2VyLCAibG9hZCxlcnJvciIsIG9uX2xvYWRfZXJyb3IsIGFwcCk7CiAgICAgZXZh c19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcC0+YnJvd3NlciwgInZpZXdwb3J0LGNoYW5n ZWQiLCBvbl92aWV3cG9ydF9jaGFuZ2VkLCBhcHApOwogCiAgICAgZXZhc19vYmplY3Rfc21hcnRf Y2FsbGJhY2tfYWRkKGFwcC0+YnJvd3NlciwgInRvb2xiYXJzLHZpc2libGUsc2V0Iiwgb25fdG9v bGJhcnNfdmlzaWJsZV9zZXQsIGFwcCk7Cg== 96657 2011-06-09 15:54:35 -0700 2011-06-13 15:30:16 -0700 new patch patch.diff text/plain 2246 ljaehun.lim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYmQw OGYyLi5jZGQyNTI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMDggIEphZWh1biBMaW0gIDxsamFlaHVu LmxpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbRUZMXSBBZGQgbG9hZCBlcnJvciBoYW5kbGVyIHRvIEVXZWJMYXVuY2hlcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzNDcKKwor ICAgICAgICBBZGQgYSBoYW5kbGVyIGZ1bmN0aW9uIG9mICJsb2FkLGVycm9yIiB0byBFV2ViTGF1 bmNoZXIuCisgICAgICAgIEVXZWJMYXVuY2hlciBub3cgZGlzcGxheXMgYSBzaW1wbGUgZXJyb3Ig cGFnZSBvbiBsb2FkIGVycm9ycy4KKworICAgICAgICAqIEVXZWJMYXVuY2hlci9tYWluLmM6Cisg ICAgICAgIChvbl9sb2FkX2Vycm9yKToKKyAgICAgICAgKGJyb3dzZXJDcmVhdGUpOgorCiAyMDEx LTA2LTA4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgVG9ueSBDaGFuZy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMg Yi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmluZGV4IGFlNzc3Y2UuLmQzYmI1YTEgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKKysrIGIvVG9vbHMvRVdlYkxhdW5jaGVy L21haW4uYwpAQCAtMzE0LDYgKzMxNCwxNiBAQCBvbl9sb2FkX2ZpbmlzaGVkKHZvaWQgKnVzZXJf ZGF0YSwgRXZhc19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiB9CiAKIHN0YXRp YyB2b2lkCitvbl9sb2FkX2Vycm9yKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKndlYnZp ZXcsIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgY29uc3QgRXdrX0ZyYW1lX0xvYWRfRXJyb3Ig KmVyciA9IChjb25zdCBFd2tfRnJhbWVfTG9hZF9FcnJvciAqKWV2ZW50X2luZm87CisgICAgY2hh ciBtZXNzYWdlWzEwMjRdOworICAgIHNucHJpbnRmKG1lc3NhZ2UsIDEwMjQsICI8aHRtbD48Ym9k eT48ZGl2IHN0eWxlPVwiY29sb3I6I2ZmMDAwMFwiPkVSUk9SITwvZGl2Pjxicj48ZGl2PkNvZGU6 ICVkPGJyPkRvbWFpbjogJXM8YnI+RGVzY3JpcHRpb246ICVzPGJyPlVSTDogJXM8L2Rpdj48L2Jv ZHk8L2h0bWw+IiwKKyAgICAgICAgICAgICBlcnItPmNvZGUsIGVyci0+ZG9tYWluLCBlcnItPmRl c2NyaXB0aW9uLCBlcnItPmZhaWxpbmdfdXJsKTsKKyAgICBld2tfZnJhbWVfY29udGVudHNfc2V0 KGVyci0+ZnJhbWUsIG1lc3NhZ2UsIDAsICJ0ZXh0L2h0bWwiLCAiVVRGLTgiLCBlcnItPmZhaWxp bmdfdXJsKTsKK30KKworc3RhdGljIHZvaWQKIG9uX3Rvb2xiYXJzX3Zpc2libGVfc2V0KHZvaWQq IHVzZXJfZGF0YSwgRXZhc19PYmplY3QqIHdlYnZpZXcsIHZvaWQqIGV2ZW50X2luZm8pCiB7CiAg ICAgRWluYV9Cb29sICp2aXNpYmxlID0gKEVpbmFfQm9vbCAqKWV2ZW50X2luZm87CkBAIC03MTEs NiArNzIxLDcgQEAgYnJvd3NlckNyZWF0ZShjb25zdCBjaGFyICp1cmwsIGNvbnN0IGNoYXIgKnRo ZW1lLCBjb25zdCBjaGFyICp1c2VyQWdlbnQsIEVpbmFfUmUKICAgICBldmFzX29iamVjdF9zbWFy dF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCAidGl0bGUsY2hhbmdlZCIsIG9uX3RpdGxlX2No YW5nZWQsIGFwcCk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcC0+YnJv d3NlciwgImxvYWQscHJvZ3Jlc3MiLCBvbl9wcm9ncmVzcywgYXBwKTsKICAgICBldmFzX29iamVj dF9zbWFydF9jYWxsYmFja19hZGQoYXBwLT5icm93c2VyLCAibG9hZCxmaW5pc2hlZCIsIG9uX2xv YWRfZmluaXNoZWQsIGFwcCk7CisgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFw cC0+YnJvd3NlciwgImxvYWQsZXJyb3IiLCBvbl9sb2FkX2Vycm9yLCBhcHApOwogICAgIGV2YXNf b2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsICJ2aWV3cG9ydCxjaGFuZ2Vk Iiwgb25fdmlld3BvcnRfY2hhbmdlZCwgYXBwKTsKIAogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2Nh bGxiYWNrX2FkZChhcHAtPmJyb3dzZXIsICJ0b29sYmFycyx2aXNpYmxlLHNldCIsIG9uX3Rvb2xi YXJzX3Zpc2libGVfc2V0LCBhcHApOwo=