62341 2011-06-08 16:47:15 -0700 [chromium] Make a few destructors private 2011-06-09 09:21:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis fishd webkit.review.bot oldest_to_newest 417688 0 thakis 2011-06-08 16:47:15 -0700 [chromium] Make VoidCallbackClient destructor private 417689 1 96507 thakis 2011-06-08 16:47:42 -0700 Created attachment 96507 Patch 417696 2 96507 thakis 2011-06-08 16:57:54 -0700 Comment on attachment 96507 Patch will add more to this 417698 3 96509 thakis 2011-06-08 17:04:36 -0700 Created attachment 96509 Patch 417701 4 thakis 2011-06-08 17:13:09 -0700 Requested by fishd in issue 62067 417813 5 96509 fishd 2011-06-08 21:57:16 -0700 Comment on attachment 96509 Patch Thanks! 418055 6 96509 webkit.review.bot 2011-06-09 09:20:58 -0700 Comment on attachment 96509 Patch Clearing flags on attachment: 96509 Committed r88457: <http://trac.webkit.org/changeset/88457> 418056 7 webkit.review.bot 2011-06-09 09:21:02 -0700 All reviewed patches have been landed. Closing bug. 96507 2011-06-08 16:47:42 -0700 2011-06-08 17:04:33 -0700 Patch bug-62341-20110608164741.patch text/plain 1426 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODgzMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ODRmYWIwNGU2MjMyNmUzZjVlM2FkMjZlYjczZTVjZWFjYzVkOTRkZi4uOTg0NDMxNGJiNDRlY2Qx ZTEyZDU5YjA5YTdiMjlhMTdlZjFiNmJjNyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNi0wOCAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIFZvaWRDYWxsYmFja0NsaWVudCBkZXN0cnVjdG9yIHByaXZhdGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyMzQxCisKKyAgICAg ICAgTm8gaW50ZW5kZWQgZnVuY3Rpb25hbGl0eSBjaGFuZ2UuCisKKyAgICAgICAgKiBzcmMvTm90 aWZpY2F0aW9uUHJlc2VudGVySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlZvaWRDYWxsYmFj a0NsaWVudDo6flZvaWRDYWxsYmFja0NsaWVudCk6CisKIDIwMTEtMDYtMDcgIEphbWVzIEtvemlh bnNraSAgPGtvekBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2Vk LiBEaXNhYmxlIFNlbGVjdEl0ZW1FdmVuRmlyZSB0aGF0IGZhaWxzIG9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuY3Bw CmluZGV4IDE3OWY3NDk2YTc3YmYzMDFhMTNkN2NiZjlhNjU3ZjdhMjM2NjUzODIuLjkxYjZiYTE2 ODI0YWI0M2IxYjAwMDhhYTZiOGYyNjY1NDgzMDlkM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuY3BwCkBAIC01 Niw4ICs1Niw2IEBAIHB1YmxpYzoKICAgICB7CiAgICAgfQogCi0gICAgdmlydHVhbCB+Vm9pZENh bGxiYWNrQ2xpZW50KCkgeyB9Ci0KICAgICB2aXJ0dWFsIHZvaWQgcGVybWlzc2lvblJlcXVlc3RD b21wbGV0ZSgpCiAgICAgewogICAgICAgICBpZiAobV9jYWxsYmFjaykKQEAgLTY2LDYgKzY0LDgg QEAgcHVibGljOgogICAgIH0KIAogcHJpdmF0ZToKKyAgICB2aXJ0dWFsIH5Wb2lkQ2FsbGJhY2tD bGllbnQoKSB7IH0KKwogICAgIFJlZlB0cjxWb2lkQ2FsbGJhY2s+IG1fY2FsbGJhY2s7CiB9Owog Cg== 96509 2011-06-08 17:04:36 -0700 2011-06-09 09:20:58 -0700 Patch bug-62341-20110608170435.patch text/plain 3660 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogODgzMjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ODRmYWIwNGU2MjMyNmUzZjVlM2FkMjZlYjczZTVjZWFjYzVkOTRkZi4uNGVjMzczYmRlZDBiNjJl MDcxMGQ2NGI1Y2ZhMzVlNTM5NDdkMTQ4OSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxMS0wNi0wOCAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIGEgZmV3IGRlc3RydWN0b3JzIHByaXZhdGUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjM0MQorCisgICAgICAgIE5vIGludGVu ZGVkIGZ1bmN0aW9uYWxpdHkgY2hhbmdlLgorCisgICAgICAgICogc3JjL05vdGlmaWNhdGlvblBy ZXNlbnRlckltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpWb2lkQ2FsbGJhY2tDbGllbnQ6On5W b2lkQ2FsbGJhY2tDbGllbnQpOgorICAgICAgICAqIHNyYy9XZWJUZXh0Q2hlY2tpbmdDb21wbGV0 aW9uSW1wbC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJUZXh0Q2hlY2tpbmdDb21wbGV0aW9uSW1w bDo6fldlYlRleHRDaGVja2luZ0NvbXBsZXRpb25JbXBsKToKKyAgICAgICAgKiBzcmMvV2ViVVJM UmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlVSTFJlcXVlc3RQcml2YXRlSW1wbDo6 fldlYlVSTFJlcXVlc3RQcml2YXRlSW1wbCk6CisgICAgICAgICogc3JjL1dlYlVSTFJlc3BvbnNl LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVVJMUmVzcG9uc2VQcml2YXRlSW1wbDo6fldlYlVS TFJlc3BvbnNlUHJpdmF0ZUltcGwpOgorCiAyMDExLTA2LTA3ICBKYW1lcyBLb3ppYW5za2kgIDxr b3pAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZC4gRGlzYWJs ZSBTZWxlY3RJdGVtRXZlbkZpcmUgdGhhdCBmYWlscyBvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmNwcAppbmRleCAx NzlmNzQ5NmE3N2JmMzAxYTEzZDdjYmY5YTY1N2Y3YTIzNjY1MzgyLi45MWI2YmExNjgyNGFiNDNi MWIwMDA4YWE2YjhmMjY2NTQ4MzA5ZDNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmNwcApAQCAtNTYsOCArNTYs NiBAQCBwdWJsaWM6CiAgICAgewogICAgIH0KIAotICAgIHZpcnR1YWwgflZvaWRDYWxsYmFja0Ns aWVudCgpIHsgfQotCiAgICAgdmlydHVhbCB2b2lkIHBlcm1pc3Npb25SZXF1ZXN0Q29tcGxldGUo KQogICAgIHsKICAgICAgICAgaWYgKG1fY2FsbGJhY2spCkBAIC02Niw2ICs2NCw4IEBAIHB1Ymxp YzoKICAgICB9CiAKIHByaXZhdGU6CisgICAgdmlydHVhbCB+Vm9pZENhbGxiYWNrQ2xpZW50KCkg eyB9CisKICAgICBSZWZQdHI8Vm9pZENhbGxiYWNrPiBtX2NhbGxiYWNrOwogfTsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVGV4dENoZWNraW5nQ29tcGxldGlv bkltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlRleHRDaGVja2luZ0NvbXBs ZXRpb25JbXBsLmgKaW5kZXggOTNiMjhlMzA5ZTRkYWVhMjc3NTBkZWJiMzZjYWJmZWY1ZGQxZjdh ZC4uZGVlMTE0YWRjMGRlMTI3OTU2ZmZjMGVkY2E0NTg4NWQ4MzIxZmFkNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVGV4dENoZWNraW5nQ29tcGxldGlvbkltcGwu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJUZXh0Q2hlY2tpbmdDb21wbGV0 aW9uSW1wbC5oCkBAIC00NiwxMSArNDYsMTEgQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKLSAg ICB2aXJ0dWFsIH5XZWJUZXh0Q2hlY2tpbmdDb21wbGV0aW9uSW1wbCgpIHsgfQotCiAgICAgdmly dHVhbCB2b2lkIGRpZEZpbmlzaENoZWNraW5nVGV4dChjb25zdCBXZWJWZWN0b3I8V2ViVGV4dENo ZWNraW5nUmVzdWx0PiYpOwogCiBwcml2YXRlOgorICAgIHZpcnR1YWwgfldlYlRleHRDaGVja2lu Z0NvbXBsZXRpb25JbXBsKCkgeyB9CisKICAgICBpbnQgbV9pZGVudGlmaWVyOwogICAgIFdlYkNv cmU6OlNwZWxsQ2hlY2tlciogbV9zcGVsbENoZWNrZXI7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJVUkxSZXF1ZXN0LmNwcAppbmRleCA2Mzg3M2U1YTY2YWQwMDllYmUyYmEx NzFmZmVlYjdlNjQzODA0NjhlLi42MDVmYjhjNDI1MjU3NGJmZmYxZjE0ZWU2YThkYjNjNjdlYjdj ODE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXF1ZXN0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXF1ZXN0LmNwcApA QCAtNzksMTAgKzc5LDExIEBAIHB1YmxpYzoKICAgICAgICAgbV9hbGxvd1N0b3JlZENyZWRlbnRp YWxzID0gcC0+bV9hbGxvd1N0b3JlZENyZWRlbnRpYWxzOwogICAgIH0KIAotICAgIHZpcnR1YWwg fldlYlVSTFJlcXVlc3RQcml2YXRlSW1wbCgpIHsgfQotCiAgICAgdmlydHVhbCB2b2lkIGRpc3Bv c2UoKSB7IGRlbGV0ZSB0aGlzOyB9CiAKK3ByaXZhdGU6CisgICAgdmlydHVhbCB+V2ViVVJMUmVx dWVzdFByaXZhdGVJbXBsKCkgeyB9CisKICAgICBSZXNvdXJjZVJlcXVlc3QgbV9yZXNvdXJjZVJl cXVlc3RBbGxvY2F0aW9uOwogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVVJMUmVzcG9uc2UuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi VVJMUmVzcG9uc2UuY3BwCmluZGV4IDQ5ZGU3YmI2NWI3ZWM4NzE1NWNiNGY1M2E3MTI0ODg0NzAw YTA1NTEuLjI0ODM2ZTYwNzQ4MjI2ZmIxODMzYzMyOGYwMjUxYjYxMGE0MmI2YjMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlVSTFJlc3BvbnNlLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJVUkxSZXNwb25zZS5jcHAKQEAgLTYyLDEwICs2 MiwxMSBAQCBwdWJsaWM6CiAgICAgICAgIG1fcmVzb3VyY2VSZXNwb25zZSA9ICZtX3Jlc291cmNl UmVzcG9uc2VBbGxvY2F0aW9uOwogICAgIH0KIAotICAgIHZpcnR1YWwgfldlYlVSTFJlc3BvbnNl UHJpdmF0ZUltcGwoKSB7IH0KLQogICAgIHZpcnR1YWwgdm9pZCBkaXNwb3NlKCkgeyBkZWxldGUg dGhpczsgfQogCitwcml2YXRlOgorICAgIHZpcnR1YWwgfldlYlVSTFJlc3BvbnNlUHJpdmF0ZUlt cGwoKSB7IH0KKwogICAgIFJlc291cmNlUmVzcG9uc2UgbV9yZXNvdXJjZVJlc3BvbnNlQWxsb2Nh dGlvbjsKIH07CiAK