62332 2011-06-08 15:15:23 -0700 [WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag 2011-06-08 16:04:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Major --- 1 sullivan sullivan oldest_to_newest 417586 0 sullivan 2011-06-08 15:15:23 -0700 [WKView _setDragImage:at:linkDrag:] contains a call to super that performs a drag. It's possible for this call to super to end up dealloc'ing self, and then WebKit will crash on the line of code that runs after the call to [super dragImage::::::]. This is in Radar as 9355199 417591 1 96492 sullivan 2011-06-08 15:22:01 -0700 Created attachment 96492 Patch to retain self during this method 417644 2 96492 darin 2011-06-08 15:57:08 -0700 Comment on attachment 96492 Patch to retain self during this method View in context: https://bugs.webkit.org/attachment.cgi?id=96492&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:2342 > + RetainPtr<WKView> protect(self); It’s better to use a noun for the name of the local variable. Say, protector, instead of protect. 417653 3 sullivan 2011-06-08 16:00:54 -0700 Will change to "protector". I used "protect" in mimicry of another function in this file. I'll change that one too while I'm in here. 417655 4 sullivan 2011-06-08 16:04:39 -0700 Fixed in <http://trac.webkit.org/changeset/88401>. 96492 2011-06-08 15:22:01 -0700 2011-06-08 15:57:08 -0700 Patch to retain self during this method 62332_patch.txt text/plain 1288 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4Mzk1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMDggIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MjMzMj4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzkzNTUxOTk+CisgICAgICAgIFtX S1ZpZXcgX3NldERyYWdJbWFnZTphdDpsaW5rRHJhZzpdIGNhbiBjcmFzaCBpZiBXS1ZpZXcgaXMg ZGVhbGxvYydlZCBkdXJpbmcgZHJhZworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tW aWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgX3NldERyYWdJbWFnZTphdDpsaW5rRHJhZzpdKToK KyAgICAgICAgQWRkZWQgYSBzZWxmLXByb3RlY3RpbmcgUmV0YWluUHRyLgorCiAyMDExLTA2LTA4 ICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA4ODMzOCkKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpA QCAtMjMzNyw2ICsyMzM3LDEwIEBAIC0gKHZvaWQpX3NldERyYWdJbWFnZTooTlNJbWFnZSAqKWlt YWdlIGEKICAgICAgICAgcmV0dXJuOwogICAgIAogICAgIF9kYXRhLT5fZHJhZ0hhc1N0YXJ0ZWQg PSBZRVM7CisgICAgCisgICAgLy8gVGhlIGNhbGwgdG8gc3VwZXIgY291bGQgcmVsZWFzZSB0aGlz IFdLVmlldy4KKyAgICBSZXRhaW5QdHI8V0tWaWV3PiBwcm90ZWN0KHNlbGYpOworICAgIAogICAg IFtzdXBlciBkcmFnSW1hZ2U6aW1hZ2UKICAgICAgICAgICAgICAgICAgIGF0OmNsaWVudFBvaW50 CiAgICAgICAgICAgICAgIG9mZnNldDpOU1plcm9TaXplCg==