62327 2011-06-08 14:17:56 -0700 Add faster lookup cache for multi character identifiers 2011-06-08 14:57:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver ggaren oldest_to_newest 417521 0 oliver 2011-06-08 14:17:56 -0700 Add faster lookup cache for multi character identifiers 417530 1 96481 oliver 2011-06-08 14:22:38 -0700 Created attachment 96481 Patch 417531 2 oliver 2011-06-08 14:23:25 -0700 This is a 1.7% parsing improvement by my measurements. 417540 3 96481 ggaren 2011-06-08 14:31:30 -0700 Comment on attachment 96481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96481&action=review r=me > Source/JavaScriptCore/parser/ParserArena.h:82 > + if (ident && ident->length() == (int)length && (!memcmp(characters, ident->characters(), length * sizeof(UChar)))) static_cast<int>, please. 417541 4 ggaren 2011-06-08 14:35:22 -0700 Just realized that Identifier::equal might be a better choice than memcmp. 417573 5 oliver 2011-06-08 14:57:34 -0700 Committed r88394: <http://trac.webkit.org/changeset/88394> 96481 2011-06-08 14:22:38 -0700 2011-06-08 14:31:30 -0700 Patch bug-62327-20110608142237.patch text/plain 3723 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODgyMTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDY0 NzA2MzcyN2I3OTQ2ZGQyNTBkMzM4ZjM3NjYzZDFjM2MyMTFhNjMuLmU1MGJlMzhiZDBlOTMxM2I4 ZjE4YmZhMGMwODM2YTI0OGIxZDMyMDcgMTAwNzU1Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDExLTA2LTA4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGZhc3Rl ciBsb29rdXAgY2FjaGUgZm9yIG11bHRpIGNoYXJhY3RlciBpZGVudGlmaWVycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIzMjcKKworICAgICAgICBB ZGQgYSBub24taGFzaCBsb29rdXAgZm9yIG11dGlwbGUgY2hhcmFjdGVyIGlkZW50aWZpZXJzLiAg VGhpcyBzYXZlcyB1cyBmcm9tCisgICAgICAgIGFkZGluZyByZXBlYXRlZCBpZGVudGlmaWVycyB0 byB0aGUgUGFyc2VyQXJlbmEncyBpZGVudGlmaWVyIGxpc3QgYXMgcGVvcGxlCisgICAgICAgIHRl bmQgdG8gbm90IHN0YXJ0IGFsbCB0aGVpciB2YXJpYWJsZXMgYW5kIHByb3BlcnRpZXMgd2l0aCB0 aGUgc2FtZSBjaGFyYWN0ZXIKKyAgICAgICAgYW5kIGhhcHBpbHkgaWRlbnRpZmllciBsb2NhbGl0 eSB3b3JrcyBpbiBvdXIgZmF2b3VyLgorCisgICAgICAgICogcGFyc2VyL1BhcnNlckFyZW5hLmg6 CisgICAgICAgIChKU0M6OklkZW50aWZpZXJBcmVuYTo6aXNFbXB0eSk6CisgICAgICAgIChKU0M6 OklkZW50aWZpZXJBcmVuYTo6Y2xlYXIpOgorICAgICAgICAoSlNDOjpJZGVudGlmaWVyQXJlbmE6 Om1ha2VJZGVudGlmaWVyKToKKwogMjAxMS0wNi0wNiAgSmFtZXMgU2ltb25zZW4gIDxzaW1vbmph bUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlckFyZW5hLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlckFyZW5hLmgKaW5kZXggMTU2M2U0OThm NDE2Y2VmMDBjM2NiOWZmZjNiNmE1MjQyNmJhMzc5NC4uMjJmZWFlYmExNTJjNjZhZDU2NDQ2NTVj M2IxODEwN2Y5ZGMyMmFlOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXJBcmVuYS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2Vy QXJlbmEuaApAQCAtNDUsMzEgKzQ1LDQ0IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBBTFdB WVNfSU5MSU5FIGNvbnN0IElkZW50aWZpZXImIG1ha2VJZGVudGlmaWVyKEpTR2xvYmFsRGF0YSos IGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoKTsKICAgICAgICAgY29uc3Qg SWRlbnRpZmllciYgbWFrZU51bWVyaWNJZGVudGlmaWVyKEpTR2xvYmFsRGF0YSosIGRvdWJsZSBu dW1iZXIpOwogCisgICAgICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuIG1faWRlbnRp ZmllcnMuaXNFbXB0eSgpOyB9CisKKyAgICBwdWJsaWM6CisgICAgICAgIHN0YXRpYyBjb25zdCBp bnQgTWF4aW11bUNhY2hhYmxlQ2hhcmFjdGVyID0gMTI4OworICAgICAgICB0eXBlZGVmIFNlZ21l bnRlZFZlY3RvcjxJZGVudGlmaWVyLCA2ND4gSWRlbnRpZmllclZlY3RvcjsKICAgICAgICAgdm9p ZCBjbGVhcigpCiAgICAgICAgIHsKICAgICAgICAgICAgIG1faWRlbnRpZmllcnMuY2xlYXIoKTsK LSAgICAgICAgICAgIGZvciAodW5zaWduZWQgIGkgPSAwOyBpIDwgMTI4OyBpKyspCisgICAgICAg ICAgICBmb3IgKGludCBpID0gMDsgaSA8IE1heGltdW1DYWNoYWJsZUNoYXJhY3RlcjsgaSsrKQog ICAgICAgICAgICAgICAgIG1fc2hvcnRJZGVudGlmaWVyc1tpXSA9IDA7CisgICAgICAgICAgICBm b3IgKGludCBpID0gMDsgaSA8IE1heGltdW1DYWNoYWJsZUNoYXJhY3RlcjsgaSsrKQorICAgICAg ICAgICAgICAgIG1fcmVjZW50SWRlbnRpZmllcnNbaV0gPSAwOwogICAgICAgICB9Ci0gICAgICAg IGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuIG1faWRlbnRpZmllcnMuaXNFbXB0eSgpOyB9 CiAKICAgICBwcml2YXRlOgotICAgICAgICBzdGF0aWMgY29uc3QgaW50IE1heGltdW1DYWNoYWJs ZUNoYXJhY3RlciA9IDEyODsKLSAgICAgICAgdHlwZWRlZiBTZWdtZW50ZWRWZWN0b3I8SWRlbnRp ZmllciwgNjQ+IElkZW50aWZpZXJWZWN0b3I7CiAgICAgICAgIElkZW50aWZpZXJWZWN0b3IgbV9p ZGVudGlmaWVyczsKICAgICAgICAgRml4ZWRBcnJheTxJZGVudGlmaWVyKiwgTWF4aW11bUNhY2hh YmxlQ2hhcmFjdGVyPiBtX3Nob3J0SWRlbnRpZmllcnM7CisgICAgICAgIEZpeGVkQXJyYXk8SWRl bnRpZmllciosIE1heGltdW1DYWNoYWJsZUNoYXJhY3Rlcj4gbV9yZWNlbnRJZGVudGlmaWVyczsK ICAgICB9OwogCiAgICAgQUxXQVlTX0lOTElORSBjb25zdCBJZGVudGlmaWVyJiBJZGVudGlmaWVy QXJlbmE6Om1ha2VJZGVudGlmaWVyKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgY29uc3QgVUNo YXIqIGNoYXJhY3RlcnMsIHNpemVfdCBsZW5ndGgpCiAgICAgewotICAgICAgICBpZiAobGVuZ3Ro ID09IDEgJiYgY2hhcmFjdGVyc1swXSA8IE1heGltdW1DYWNoYWJsZUNoYXJhY3RlcikgeworICAg ICAgICBpZiAoY2hhcmFjdGVyc1swXSA+PSBNYXhpbXVtQ2FjaGFibGVDaGFyYWN0ZXIpIHsKKyAg ICAgICAgICAgIG1faWRlbnRpZmllcnMuYXBwZW5kKElkZW50aWZpZXIoZ2xvYmFsRGF0YSwgY2hh cmFjdGVycywgbGVuZ3RoKSk7CisgICAgICAgICAgICByZXR1cm4gbV9pZGVudGlmaWVycy5sYXN0 KCk7CisgICAgICAgIH0KKyAgICAgICAgaWYgKGxlbmd0aCA9PSAxKSB7CiAgICAgICAgICAgICBp ZiAoSWRlbnRpZmllciogaWRlbnQgPSBtX3Nob3J0SWRlbnRpZmllcnNbY2hhcmFjdGVyc1swXV0p CiAgICAgICAgICAgICAgICAgcmV0dXJuICppZGVudDsKICAgICAgICAgICAgIG1faWRlbnRpZmll cnMuYXBwZW5kKElkZW50aWZpZXIoZ2xvYmFsRGF0YSwgY2hhcmFjdGVycywgbGVuZ3RoKSk7CiAg ICAgICAgICAgICBtX3Nob3J0SWRlbnRpZmllcnNbY2hhcmFjdGVyc1swXV0gPSAmbV9pZGVudGlm aWVycy5sYXN0KCk7CiAgICAgICAgICAgICByZXR1cm4gbV9pZGVudGlmaWVycy5sYXN0KCk7CiAg ICAgICAgIH0KKyAgICAgICAgSWRlbnRpZmllciogaWRlbnQgPSBtX3JlY2VudElkZW50aWZpZXJz W2NoYXJhY3RlcnNbMF1dOworICAgICAgICBpZiAoaWRlbnQgJiYgaWRlbnQtPmxlbmd0aCgpID09 IChpbnQpbGVuZ3RoICYmICghbWVtY21wKGNoYXJhY3RlcnMsIGlkZW50LT5jaGFyYWN0ZXJzKCks IGxlbmd0aCAqIHNpemVvZihVQ2hhcikpKSkKKyAgICAgICAgICAgIHJldHVybiAqaWRlbnQ7CiAg ICAgICAgIG1faWRlbnRpZmllcnMuYXBwZW5kKElkZW50aWZpZXIoZ2xvYmFsRGF0YSwgY2hhcmFj dGVycywgbGVuZ3RoKSk7CisgICAgICAgIG1fcmVjZW50SWRlbnRpZmllcnNbY2hhcmFjdGVyc1sw XV0gPSAmbV9pZGVudGlmaWVycy5sYXN0KCk7CiAgICAgICAgIHJldHVybiBtX2lkZW50aWZpZXJz Lmxhc3QoKTsKICAgICB9CiAK